PATCHES - Countdown for January 2nd

[James]

Hello,

Happy New Year to everyone!

Here is the current patch countdown list. The next countdown will be on
January 5th

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/



Push:


5021 web: fix HTML 4.01 validation - Graham Percival
https://sourceforge.net/p/testlilyissues/issues/5021
http://codereview.appspot.com/316060043


Countdown:


5023 converted font-size values from px and percentages to em values - 
Graham Percival

https://sourceforge.net/p/testlilyissues/issues/5023
http://codereview.appspot.com/315310043


5022 Allow fixed spacing of symbols in church rests - David Nalesnik
https://sourceforge.net/p/testlilyissues/issues/5022
http://codereview.appspot.com/319910043


Review:


5025 Let the distance of strings and frets in fret-diagrams be settable 
- Thomas Morley

https://sourceforge.net/p/testlilyissues/issues/5025
http://codereview.appspot.com/319030043


5024 Rework the Preinit framework into something simpler - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5024
http://codereview.appspot.com/318200043


4509 Enhancement: automatically engrave lyric extenders - Alexander Kobel
https://sourceforge.net/p/testlilyissues/issues/4509
http://codereview.appspot.com/313240043


New: No New patches at this time.


Regards

James


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 4983 Let crossStaff hide non-default-style flags (issue 315330043 by thomasmorle...@gmail.com)

[thomasmorley65]

Reviewers: ,

Message:
Please review

Description:
Issue 4983 Let crossStaff hide non-default-style flags

Return empty-stencil for all flags using the code provided in
flag-styles.scm, if the style property is 'no-flag as set by
the crossStaff-function.

Please review this at https://codereview.appspot.com/315330043/

Affected files (+18, -21 lines):
  M scm/flag-styles.scm


Index: scm/flag-styles.scm
diff --git a/scm/flag-styles.scm b/scm/flag-styles.scm
index  
a2ddf3a9dd0bd8d728b2352c5ea7d03dbcc2b324..b17b3fc2abd62d3ed45e0d6853a44f126916590c  
100644

--- a/scm/flag-styles.scm
+++ b/scm/flag-styles.scm
@@ -20,11 +20,6 @@
   styles.


-(define-public (no-flag grob)
-  "No flag: Simply return empty stencil."
-  empty-stencil)
-
-
 ;;
   Straight flags
 ;;
@@ -97,14 +92,16 @@ All lengths are scaled according to the font size of  
the note."

;; Log for 1/8 is 3, so we need to subtract 3
(flag-stencil (buildflag stencil (- log 3) stencil spacing))
(stroke-style (ly:grob-property grob 'stroke-style)))
-  (if (equal? stroke-style "grace")
-  (add-stroke-straight flag-stencil grob
-   dir log
-   stroke-style
-   flag-end flag-length
-   thickness
-   (* half-stem-thickness 2))
-  flag-stencil
+  (cond ((eq? (ly:grob-property grob 'style) 'no-flag)
+ empty-stencil)
+((equal? stroke-style "grace")
+ (add-stroke-straight flag-stencil grob
+  dir log
+  stroke-style
+  flag-end flag-length
+  thickness
+  (* half-stem-thickness 2)))
+(else flag-stencil)

 (define-public (modern-straight-flag grob)
   "Modern straight flag style (for composers like Stockhausen, Boulez,  
etc.).

@@ -174,10 +171,12 @@ flag stencil."
  (dir (if (eqv? (ly:grob-property stem-grob 'direction)  
UP) "u" "d"))

  (flag (retrieve-glyph-flag flag-style dir dir-modifier grob))
  (stroke-style (ly:grob-property grob 'stroke-style)))
-(if (null? stroke-style)
-flag
-(add-stroke-glyph flag grob dir stroke-style flag-style
-
+(cond ((eq? (ly:grob-property grob 'style) 'no-flag)
+   empty-stencil)
+  ((null? stroke-style)
+   flag)
+  (else
+   (add-stroke-glyph flag grob dir stroke-style flag-style)


 (define-public (mensural-flag grob)
@@ -205,7 +204,6 @@ a flag always touches a staff line."
 (create-glyph-flag "mensural" modifier grob)))


-
 (define ((glyph-flag flag-style) grob)
   "Simulatesthe default way of generating flags: Look up glyphs
 @code{flags.style[ud][1234]} from the feta font and use it for the flag
@@ -214,13 +212,11 @@ stencil."
 (export glyph-flag)


-
 (define-public (normal-flag grob)
   "Create a default flag."
   (create-glyph-flag "" "" grob))


-
 (define-public (default-flag grob)
   "Create a flag stencil for the stem.  Its style will be derived from the
 @code{'style} Flag property.  By default, @code{lilypond} uses a
@@ -242,5 +238,6 @@ at will.  The correct way to do this is:
 (cond
  ((equal? flag-style "") (normal-flag grob))
  ((equal? flag-style "mensural") (mensural-flag grob))
- ((equal? flag-style "no-flag") (no-flag grob))
+ ((equal? flag-style "no-flag") empty-stencil)
  (else ((glyph-flag flag-style) grob)
+



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Let the distance of strings and frets in fret-diagrams be settable (issue 319030043 by thomasmorle...@gmail.com)

[thomasmorley65]

Reviewers: ,

Message:
Please review

Description:
Let the distance of strings and frets in fret-diagrams be settable

- Two new sub-properties of fret-diagram-details are introduced:
  fret-distance and string-distance
- regtest fret-diagrams-size.ly is extended
- entry in changes.tely

Please review this at https://codereview.appspot.com/319030043/

Affected files (+116, -36 lines):
  M Documentation/changes.tely
  M input/regression/fret-diagrams-size.ly
  M scm/define-grob-properties.scm
  M scm/fret-diagrams.scm



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Free alternatives to Rietveld?

[Alexander Kobel]

Hi,

On 2017-01-02 11:50, Federico Bruni wrote:

Il giorno mer 28 dic 2016 alle 20:59, Graham Percival
 ha scritto:

On Wed, Dec 28, 2016 at 06:35:30PM +0100, Federico Bruni wrote:

 It would be possible to add a configuration option in git-cl so
 you can login in rietveld with a specific browser different from
 the default one?


Certainly!  In the source, I see:

-
If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

  --no_oauth2_webbrowser
-

IIRC that prints a URL string, which you can open with whatever
browser you want (on whichever computer you want).


Thanks! I'll try to remember when I need it.

There's a way to make it the default in my configuration? I see that
config values are saved in .git/config and there are some under
[rietveld]. I wonder if no_auth2_webbrowser=true may work...


Not sure about that; didn't spot anything from a (very) quick glance at 
the code. However, what you can do is to set up your own defaults:


alias git-cl-nooa="/path/to/git-cl --no_oauth2_webbrowser"
alias git-cl="BROWSER=/usr/bin/echo /path/to/git-cl"

Specifying the BROWSER environment variable instructs git-cl to use this 
application as browser - which I guess is what you actually wanted in 
the first place?



Cheers,
Alexander

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Free alternatives to Rietveld?

[Federico Bruni]

Il giorno mer 28 dic 2016 alle 20:59, Graham Percival 
 ha scritto:

On Wed, Dec 28, 2016 at 06:35:30PM +0100, Federico Bruni wrote:

 It would be possible to add a configuration option in git-cl so
 you can login in rietveld with a specific browser different from
 the default one?


Certainly!  In the source, I see:

-
If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

  --no_oauth2_webbrowser
-

IIRC that prints a URL string, which you can open with whatever
browser you want (on whichever computer you want).



Thanks! I'll try to remember when I need it.

There's a way to make it the default in my configuration? I see that 
config values are saved in .git/config and there are some under 
[rietveld]. I wonder if no_auth2_webbrowser=true may work...





___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

[Alexander Kobel]

A happy new one, everybody!

On 2017-01-01 16:39, Knut Petersen wrote:

Hi everybody!

Attached find a new version of the autoextender patch set.


Thanks Knut. Just uploaded to Rietveld.

(In fact, sorry for double-posting it; I deleted my first upload a 
minute ago after I recognized that I based the patch on a more recent 
master than I should have, with unrelated changes in some files.)



@Alexander:

I cannot think of anything easier to type than "", so it's still there ;-)


No worries, I'm fine with that.


LGTM!


Cheers,
Alexander

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel