Using eq? on numbers is undefined behavior (issue 314300043 by d...@gnu.org)

2017-01-23 Thread lemzwerg 

LGTM

https://codereview.appspot.com/314300043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-23 Thread thomasmorley65 

Two thoughts, otherwise

LGTM


https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522
Documentation/notation/changing-defaults.itely:2522: [-]\offset
@var{property} @var{offsets} @var{item}
Would it be even more clear to have instead of @var{offsets} something
like @var{offset-value} or @var{property-value}?
(Same below and in the docstring for the offset-command in
music-functions-init.ly)

Please keep in mind I'm not a native speaker, so I may be wrong here.

https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2539
Documentation/notation/changing-defaults.itely:2539: @code{\once} or
@code{\temporary} and reverted by using @code{\revert}
Does \undo work?
If so, please mention it as well.

https://codereview.appspot.com/319150043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik 

On 2017/01/23 19:00:43, david.nalesnik wrote:

No problem.



https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly

File ly/music-functions-init.ly (right):



https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107

ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item
'span-direction) START)
On 2017/01/23 18:24:29, dak wrote:
> This may be stupid, but as long as we are touching the code, we

might as well

> make it correct.  Numbers may not reliably be compared with eq? but

require

use
> of eqv? instead.



Done.


I get 18 instances with the following (misses variables storing numbers,
of course):

git grep
"(eq?\s\+\((.\+)\|[A-Za-z-]\+\)\s\+\(-\?[[:digit:]]\+\|X\|Y\|LEFT\|RIGHT\| 
UP\|DOWN\))"


Probably worth a patch.


https://codereview.appspot.com/319160043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GSoC project ideas

2017-01-23 Thread Simon Albrecht 

On 23.01.2017 22:47, Urs Liska wrote:

So while it's perfectly possible to put OLL projects on the list and to
apply for them (or others not listed there) in case of doubt projects
working on LilyPond itself might be the preference of the developer
community.

[…]

What I would see as a better project (and what I intend to suggest for
the list) is developing a system of automated testing and documentation
generation for openLilyLib, both the snippets repo and the other,
"new-style", packages. This would actually bring openLilyLib a huge step
forward to be usable on a broader base.


I think having openlilylib in a state where it’s reliable, easy to use 
and gets adopted more generally would be a huge step forward for all of 
LilyPond. I’m thinking (as I’m certain you are, too) of something 
comparable to the package system of the TeX universe, which offers a 
great possibility to provide facilities for very different use cases 
without blowing up the core program, while still having them readily 
available, documented and comfortable to maintain.

So don’t be too uneasy about bringing openLilyLib up here, I think.

Best, Simon

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GSoC project ideas

2017-01-23 Thread Urs Liska 


Am 23.01.2017 um 21:53 schrieb Jeffery Shivers:
> This might be selfish, but how about at least one of those ideas be an OLL
> (or even scholarLY) thing?

I'd like to have others comment on this, but technically this could be
very well possible.
I must admit that I felt somewhat uneasy last year for "occupying" a
LilyPond slot with an openLilyLib project, and I had even considered
appyling with OLL to become a mentoring organization of its own. But I
suspect this would be a totally futile effort.

So while it's perfectly possible to put OLL projects on the list and to
apply for them (or others not listed there) in case of doubt projects
working on LilyPond itself might be the preference of the developer
community.

> I can't guarantee what the exact status of scholarLY annotations and the
> LaTeX package will be by April - therefore I definitely don't suggest a
> direct extension of *that/those* projects. (Although I can say that I at
> least will get the ball rolling again in February when I am finally back in
> the States (if anxiously so) and have the current wave of work behind me.)
> But it would be nice to see another project emerge from our little corner
> of the pond again.

Technically it would be possible to continue on scholarLY with the next
GSoC program (as we had on the list with MusicXML export). But I think
this would have to be an extremely good proposal that also makes clear
why continuing on the same project isn't actually a disguised failure of
the previous one. I mean it would have to be very well worded.

What I would see as a better project (and what I intend to suggest for
the list) is developing a system of automated testing and documentation
generation for openLilyLib, both the snippets repo and the other,
"new-style", packages. This would actually bring openLilyLib a huge step
forward to be usable on a broader base.

Urs


>
> On Mon, Jan 23, 2017 at 8:06 PM, Urs Liska  wrote:
>
>> Hi all,
>>
>> GSoC has started and the timeline is proceeding quickly
>> (https://summerofcode.withgoogle.com/).
>>
>> GNU is going to apply until February 9, and by February 27 I expect them
>> to be accepted to the program, which will make LilyPond applicable as well.
>>
>> Students will apply between March 20 and April 3, but we expect them to
>> get in touch with us earlier. This and the fact that the project ideas
>> list might be relevant for GNU's application as well suggests that we
>> update our page ASAP, preferably by February 9. I'm quite positive that
>> having updated the ideas page had its part in having two projects last
>> year.
>>
>> So please everybody think about possible projects we can put on our
>> ideas list on http://lilypond.org/google-summer-of-code.html. Projects
>> should be possible to achieve for someone new to LilyPond within three
>> months of (full-time) work, and it is necessary to have someone ready to
>> mentor the project. If you make a suggestion it's not necessary to
>> volunteer for that project at the same time, although it would make
>> things easier ;-)
>>
>> Best
>> Urs
>>
>> PS:
>> I've also provided a patch containing a section with recommendations to
>> potential students. They draw from my own experience as a mentor last
>> year and suggestions discussed both on the mentors' mailing list and the
>> mentors' summit last year. Please consider these paragraphs too, as they
>> may need more refinement and discussion.
>>
>> --
>> u...@openlilylib.org
>> https://openlilylib.org
>> http://lilypondblog.org
>>
>>
>> ___
>> lilypond-devel mailing list
>> lilypond-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/lilypond-devel
>>
>
>

-- 
u...@openlilylib.org
https://openlilylib.org
http://lilypondblog.org


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR: Replace \set Staff.instrumentName (issue 313400043 by pkx1...@gmail.com)

2017-01-23 Thread pkx166h 

Hopefully this has simplified some of the examples.

I have made sure that the output after the change is identical (apart
from twp x-11 color markup definitions which I think was a better choice
- see comment below)


https://codereview.appspot.com/313400043/diff/1/Documentation/notation/editorial.itely
File Documentation/notation/editorial.itely (right):

https://codereview.appspot.com/313400043/diff/1/Documentation/notation/editorial.itely#newcode512
Documentation/notation/editorial.itely:512: \with-color #(x11-color
'red) "Clarinet"
Note that I also changed the 'x-11 color' here only because 'navy', I
thought, didn't really show up that well compared to the default (black)
in the doc.

https://codereview.appspot.com/313400043/diff/1/Documentation/notation/editorial.itely#newcode542
Documentation/notation/editorial.itely:542: \with-color #(x11-color
'red) "Clarinet"
Note that I also changed the 'x-11 color' here only because 'navy', I
thought, didn't really show up that well compared to the default (black)
in the doc.

https://codereview.appspot.com/313400043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GSoC project ideas

2017-01-23 Thread Jeffery Shivers 
This might be selfish, but how about at least one of those ideas be an OLL
(or even scholarLY) thing?

I can't guarantee what the exact status of scholarLY annotations and the
LaTeX package will be by April - therefore I definitely don't suggest a
direct extension of *that/those* projects. (Although I can say that I at
least will get the ball rolling again in February when I am finally back in
the States (if anxiously so) and have the current wave of work behind me.)
But it would be nice to see another project emerge from our little corner
of the pond again.

On Mon, Jan 23, 2017 at 8:06 PM, Urs Liska  wrote:

> Hi all,
>
> GSoC has started and the timeline is proceeding quickly
> (https://summerofcode.withgoogle.com/).
>
> GNU is going to apply until February 9, and by February 27 I expect them
> to be accepted to the program, which will make LilyPond applicable as well.
>
> Students will apply between March 20 and April 3, but we expect them to
> get in touch with us earlier. This and the fact that the project ideas
> list might be relevant for GNU's application as well suggests that we
> update our page ASAP, preferably by February 9. I'm quite positive that
> having updated the ideas page had its part in having two projects last
> year.
>
> So please everybody think about possible projects we can put on our
> ideas list on http://lilypond.org/google-summer-of-code.html. Projects
> should be possible to achieve for someone new to LilyPond within three
> months of (full-time) work, and it is necessary to have someone ready to
> mentor the project. If you make a suggestion it's not necessary to
> volunteer for that project at the same time, although it would make
> things easier ;-)
>
> Best
> Urs
>
> PS:
> I've also provided a patch containing a section with recommendations to
> potential students. They draw from my own experience as a mentor last
> year and suggestions discussed both on the mentors' mailing list and the
> mentors' summit last year. Please consider these paragraphs too, as they
> may need more refinement and discussion.
>
> --
> u...@openlilylib.org
> https://openlilylib.org
> http://lilypondblog.org
>
>
> ___
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
>



-- 

Jeffery Shivers
 jefferyshivers.com
 soundcloud.com/jefferyshivers
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GSoC project ideas

2017-01-23 Thread Urs Liska 



>
>PS:
>I've also provided a patch containing a section with recommendations to
>potential students. They draw from my own experience as a mentor last
>year and suggestions discussed both on the mentors' mailing list and
>the
>mentors' summit last year. Please consider these paragraphs too, as
>they
>may need more refinement and discussion.

I wanted to add the link to the patch:
https://codereview.appspot.com/315410043/diff/20001/Documentation/web/community.itexi

-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

GSoC project ideas

2017-01-23 Thread Urs Liska 
Hi all,

GSoC has started and the timeline is proceeding quickly
(https://summerofcode.withgoogle.com/).

GNU is going to apply until February 9, and by February 27 I expect them
to be accepted to the program, which will make LilyPond applicable as well.

Students will apply between March 20 and April 3, but we expect them to
get in touch with us earlier. This and the fact that the project ideas
list might be relevant for GNU's application as well suggests that we
update our page ASAP, preferably by February 9. I'm quite positive that
having updated the ideas page had its part in having two projects last year.

So please everybody think about possible projects we can put on our
ideas list on http://lilypond.org/google-summer-of-code.html. Projects
should be possible to achieve for someone new to LilyPond within three
months of (full-time) work, and it is necessary to have someone ready to
mentor the project. If you make a suggestion it's not necessary to
volunteer for that project at the same time, although it would make
things easier ;-)

Best
Urs

PS:
I've also provided a patch containing a section with recommendations to
potential students. They draw from my own experience as a mentor last
year and suggestions discussed both on the mentors' mailing list and the
mentors' summit last year. Please consider these paragraphs too, as they
may need more refinement and discussion.

-- 
u...@openlilylib.org
https://openlilylib.org
http://lilypondblog.org


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik 

No problem.


https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107
ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item
'span-direction) START)
On 2017/01/23 18:24:29, dak wrote:

This may be stupid, but as long as we are touching the code, we might

as well

make it correct.  Numbers may not reliably be compared with eq? but

require use

of eqv? instead.


Done.

https://codereview.appspot.com/319160043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik 

Reviewers: ,

Message:
Please review.  Thanks!

Description:
Let \alterBroken tweak ties again

When tweaking Tie grobs, the music function \alterBroken has
incorrectly rejected them since 2.17.6 as not being spanners.
The method of spanner recognition is at fault: 'span-direction
is not used by TieEvent.

Please review this at https://codereview.appspot.com/319160043/

Affected files (+2, -1 lines):
  M ly/music-functions-init.ly


Index: ly/music-functions-init.ly
diff --git a/ly/music-functions-init.ly b/ly/music-functions-init.ly
index  
1f94319bce743ca1e6994eebdff7daa672db0e12..901c7429129e5a2de4b5d27ac94a41da64a4a9a2  
100644

--- a/ly/music-functions-init.ly
+++ b/ly/music-functions-init.ly
@@ -104,7 +104,8 @@ a starting spanner event, or a symbol list in the form
 form of a spanner event, @var{property} may also have the form
 @samp{Grob.property} for specifying a directed tweak.")
   (if (ly:music? item)
-  (if (eq? (ly:music-property item 'span-direction) START)
+  (if (or (eq? (ly:music-property item 'span-direction) START)
+  (music-is-of-type? item 'tie-event))
   (tweak property (value-for-spanner-piece arg) item)
   (begin
 (ly:music-warning item (_ "not a spanner"))



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread dak 


https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107
ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item
'span-direction) START)
This may be stupid, but as long as we are touching the code, we might as
well make it correct.  Numbers may not reliably be compared with eq? but
require use of eqv? instead.

https://codereview.appspot.com/319160043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

LilyDev 5.1 released

2017-01-23 Thread Federico Bruni 

https://github.com/fedelibre/LilyDev/releases/tag/v5.1


Notable changes in this minor release:

- the setup script at first login is now working again (it was broken 
in v5.0)
- all applications now have an icon in the LxQT menu (so the "drag icon 
here" hint in the application bar makes more sense now)

- no proxy settings during the installation




___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-23 Thread simon . albrecht 

LGTM.

https://codereview.appspot.com/319150043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel