Re: Fix some programming errors "no interface for property" (issue 321730043 by thomasmorle...@gmail.com)
LGTM https://codereview.appspot.com/321730043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix regtest scheme-engraver.ly wrt to guile-2.2 (issue 322720043 by thomasmorle...@gmail.com)
thomasmorle...@gmail.com writes: > Reviewers: , > > Message: > Please review. > Instead of simply replacing 1 by (current-error-port) a variable for the > port could have been used probably. > Opinions? current-error-port is a built-in function. Calling it and referencing a variable are not likely recognizably different in their cost. So I wouldn't bother. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix regtest scheme-engraver.ly wrt to guile-2.2 (issue 322720043 by thomasmorle...@gmail.com)
Reviewers: ,
Message:
Please review.
Instead of simply replacing 1 by (current-error-port) a variable for the
port could have been used probably.
Opinions?
Description:
Fix regtest scheme-engraver.ly wrt to guile-2.2
Passing a number to format as the port is deprecated in guile-2.2
Thus using (current-error-port) instead
Please review this at https://codereview.appspot.com/322720043/
Affected files (+9, -9 lines):
M input/regression/scheme-engraver.ly
Index: input/regression/scheme-engraver.ly
diff --git a/input/regression/scheme-engraver.ly
b/input/regression/scheme-engraver.ly
index
0f31685f912d00d2bf828673a325ddff020a9caa..cd1b848c35826419ea561b6ddbf2f22fc36be3ae
100644
--- a/input/regression/scheme-engraver.ly
+++ b/input/regression/scheme-engraver.ly
@@ -14,31 +14,31 @@
engraver_demo =
#(make-engraver
((initialize translator)
-(format 1 "\n\n~16a: (initialize)\n" (t->m translator)))
+(format (current-error-port) "\n\n~16a: (initialize)\n" (t->m
translator)))
((start-translation-timestep translator)
-(format 1 "~16a: (start-translation-timestep)\n" (t->m translator)))
+(format (current-error-port) "~16a: (start-translation-timestep)\n"
(t->m translator)))
(listeners
((rest-event engraver event)
(let ((grob (ly:engraver-make-grob engraver 'TextScript event)))
(ly:grob-set-property! grob 'text "hi")
-(format 1 "~16a: detected this rest event: ~a\n~16a: created this
grob: ~a\n"
+(format (current-error-port) "~16a: detected this rest event:
~a\n~16a: created this grob: ~a\n"
(t->m engraver) event (t->m engraver) grob
(acknowledgers
((note-head-interface engraver grob source-engraver)
- (format 1 "~16a: saw ~a coming from ~a\n"
+ (format (current-error-port) "~16a: saw ~a coming from ~a\n"
(t->m engraver) grob source-engraver)))
(end-acknowledgers
((beam-interface engraver grob source-engraver)
- (format 1 "~16a: saw end of ~a coming from ~a\n"
+ (format (current-error-port) "~16a: saw end of ~a coming from ~a\n"
(t->m engraver) grob source-engraver)))
((process-music translator)
-(format 1 "~16a: (process-music)\n" (t->m translator)))
+(format (current-error-port) "~16a: (process-music)\n" (t->m
translator)))
((process-acknowledged translator)
-(format 1 "~16a: (process-acknowledged)\n" (t->m translator)))
+(format (current-error-port) "~16a: (process-acknowledged)\n" (t->m
translator)))
((stop-translation-timestep translator)
-(format 1 "~16a: (stop-translation-timestep)\n" (t->m translator)))
+(format (current-error-port) "~16a: (stop-translation-timestep)\n"
(t->m translator)))
((finalize translator)
-(format 1 "~16a: (finalize)\n" (t->m translator
+(format (current-error-port) "~16a: (finalize)\n" (t->m translator
\layout {
\context {
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [LilyIssues-auto] [testlilyissues:issues] #5097 Fix programming errors associated with texted HorizontalBracket grobs
Auto mailings of changes to Lily Issues writes: > Maybe the method in > http://codereview.appspot.com/321730043 > may partly help. > > At least with adding thickness and text to the properties in > horizontal-bracket.cc I got rid of one warning. We shouldn't add properties to grobs/interfaces that aren't even used in the grob. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fix some programming errors "no interface for property" (issue 321730043 by thomasmorle...@gmail.com)
Reviewers: , Message: Please review Description: Fix some programming errors "no interface for property" Adds glissando-skip to the properties in note-column.cc Adds line-thickness to the properties in semi-tie.cc Please review this at https://codereview.appspot.com/321730043/ Affected files (+2, -0 lines): M lily/note-column.cc M lily/semi-tie.cc Index: lily/note-column.cc diff --git a/lily/note-column.cc b/lily/note-column.cc index 1d79fee652c57a825400a5e9a3fca3abb9c483a2..b3f7e4aab9e350d22b64d3e536b69b50f8cd9f0b 100644 --- a/lily/note-column.cc +++ b/lily/note-column.cc @@ -251,4 +251,5 @@ ADD_INTERFACE (Note_column, "rest " "rest-collision " "stem " + "glissando-skip " ); Index: lily/semi-tie.cc diff --git a/lily/semi-tie.cc b/lily/semi-tie.cc index 0d31a2e07388b82e1ad0627b57f10d124e8bd5d9..2d0c1133a879f9e769900c014c8ba1c62c7e7bcc 100644 --- a/lily/semi-tie.cc +++ b/lily/semi-tie.cc @@ -49,6 +49,7 @@ ADD_INTERFACE (Semi_tie, "head-direction " "note-head " "thickness " + "line-thickness " ); MAKE_SCHEME_CALLBACK (Semi_tie, calc_control_points, 1) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Need some help - build doc fails for me
> Hello, > > I appear no longer to be able to make doc. > > I do not think it is for any particular checkin as I went back to > before 2.19.57 was released and still have problems. > > The 'only' thing I did prior to that was to install > texlive-lang-japanese to see if I could test Hosoda-san's recent > checkin and builld the Japanese Docs following his instructions in the > GNUmakefile. > > (note: I only needed to install that one package, the other > requirements were already met by whatever I had installed previously). > > I have also deleted by lilypong-git dir and re-fetched it but I still > get the same issue. It seems to be around the typography.ly demo > (where we typeset a lot of non-standard character sets) so it could be > something inadvertently pulled down while installing the japanese > package, but I removed it and it made no difference. > > If someone can just confirm that doc builds so I know if it is my > environment or something else I would appreciate it. > > I am at work now so will take some time to set up another build env > 'quickly' (i.e. before the end of the day), as there is no countdown > it is not so bad, but I cannot test any patches at the moment. > > > Thanks for your help. I cannot reproduce the error. Would you show me the error messages? For the following commit, I've succeed make and make doc. commit eca3d05456383fc0b451468ce1b21ed08229821f Issue 5083: Add making web.$(ISOLANG).pdf My environment is Cygwin64. TeX Live Japanese environment is installed. I use Japanese locale. $ locale LANG=ja_JP.UTF-8 LC_CTYPE="ja_JP.UTF-8" LC_NUMERIC="ja_JP.UTF-8" LC_TIME="ja_JP.UTF-8" LC_COLLATE="ja_JP.UTF-8" LC_MONETARY="ja_JP.UTF-8" LC_MESSAGES="ja_JP.UTF-8" LC_ALL= ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Need some help - build doc fails for me
James writes: > Hello, > > I appear no longer to be able to make doc. > > I do not think it is for any particular checkin as I went back to > before 2.19.57 was released and still have problems. > > The 'only' thing I did prior to that was to install > texlive-lang-japanese to see if I could test Hosoda-san's recent > checkin and builld the Japanese Docs following his instructions in the > GNUmakefile. > > (note: I only needed to install that one package, the other > requirements were already met by whatever I had installed previously). > > I have also deleted by lilypong-git dir and re-fetched it but I still > get the same issue. It seems to be around the typography.ly demo > (where we typeset a lot of non-standard character sets) so it could be > something inadvertently pulled down while installing the japanese > package, but I removed it and it made no difference. > > If someone can just confirm that doc builds so I know if it is my > environment or something else I would appreciate it. > > I am at work now so will take some time to set up another build env > 'quickly' (i.e. before the end of the day), as there is no countdown > it is not so bad, but I cannot test any patches at the moment. A Patchy-staging run went fine just now for me, for an i386 (32bit) build. I suspect your language environment to somehow interfere. What's the output of locale for you? -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Need some help - build doc fails for me
Hello, I appear no longer to be able to make doc. I do not think it is for any particular checkin as I went back to before 2.19.57 was released and still have problems. The 'only' thing I did prior to that was to install texlive-lang-japanese to see if I could test Hosoda-san's recent checkin and builld the Japanese Docs following his instructions in the GNUmakefile. (note: I only needed to install that one package, the other requirements were already met by whatever I had installed previously). I have also deleted by lilypong-git dir and re-fetched it but I still get the same issue. It seems to be around the typography.ly demo (where we typeset a lot of non-standard character sets) so it could be something inadvertently pulled down while installing the japanese package, but I removed it and it made no difference. If someone can just confirm that doc builds so I know if it is my environment or something else I would appreciate it. I am at work now so will take some time to set up another build env 'quickly' (i.e. before the end of the day), as there is no countdown it is not so bad, but I cannot test any patches at the moment. Thanks for your help. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
