Re: Fix typos in \offset documentation (issue 322040043 by david.nales...@gmail.com)

[Carl . D . Sorensen]

LGTM.  THanks for doing this.

https://codereview.appspot.com/322040043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: What is the point of \on-the-fly ?

[David Kastrup]

Thomas Morley  writes:

> 2017-06-11 15:08 GMT+02:00 David Kastrup :
>>
>> \on-the-fly gets as first argument a function that it calls on the
>> second argument as if the first argument was actually a markup command.
>>
>> Why not make the first argument actually a markup command?
>>
>> It would appear that we are mostly talking about a closed set here
>> anyway.  So why
>>
>> \markup \on-the-fly #(on-page 3) "blabla"
>>
>> instead of
>>
>> \markup \on-page #3 "blabla"
>>
>> ?  Where is the point in this particular obfuscation?
>>
>> --
>> David Kastrup
>
> on-the-fly is one (of two) markup-(list-)commands in
> define-markup-commands.scm which takes a procedure as argument (the
> other is map-markup-commands). This procedure needs to have three
> arguments: layout, props and the one which is actually worked on.
>
> I desperately tried to find such a procedure, being sufficiently
> different from markup-(list-)-commands. To no avail.
>
> So I'd vote for dropping on-the-fly entirely. (Unless somebody know a
> good use-case)

The use case is similar to that of lambda: creating a procedure on the
fly without giving it a name.  But most of the current uses of
\on-the-fly are on a procedure _with_ a name.

> Ofcourse several procedures in titling-init.ly would need to become
> markup-commands.

My guess is that this might have been an emergency measure because of
problems with the scopes/modules of markups (since the usual \on-the-fly
suspects are in the \paper module).  But I think that this may have been
solved in the mean time.

> map-markup-commands from define-markup-commands.scm needs to be
> changed as well.  And regtests and docs...

I don't think there's anything wrong with keeping \on-the-fly .  But
requiring its use does not seem like doing people a favor.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: What is the point of \on-the-fly ?

[Thomas Morley]

2017-06-11 15:08 GMT+02:00 David Kastrup :
>
> \on-the-fly gets as first argument a function that it calls on the
> second argument as if the first argument was actually a markup command.
>
> Why not make the first argument actually a markup command?
>
> It would appear that we are mostly talking about a closed set here
> anyway.  So why
>
> \markup \on-the-fly #(on-page 3) "blabla"
>
> instead of
>
> \markup \on-page #3 "blabla"
>
> ?  Where is the point in this particular obfuscation?
>
> --
> David Kastrup

on-the-fly is one (of two) markup-(list-)commands in
define-markup-commands.scm which takes a procedure as argument (the
other is map-markup-commands). This procedure needs to have three
arguments: layout, props and the one which is actually worked on.

I desperately tried to find such a procedure, being sufficiently
different from markup-(list-)-commands. To no avail.

So I'd vote for dropping on-the-fly entirely. (Unless somebody know a
good use-case)
Ofcourse several procedures in titling-init.ly would need to become
markup-commands.
map-markup-commands from define-markup-commands.scm needs to be changed as well.
And regtests and docs...


Cheers,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

What is the point of \on-the-fly ?

[David Kastrup]

\on-the-fly gets as first argument a function that it calls on the
second argument as if the first argument was actually a markup command.

Why not make the first argument actually a markup command?

It would appear that we are mostly talking about a closed set here
anyway.  So why

\markup \on-the-fly #(on-page 3) "blabla"

instead of

\markup \on-page #3 "blabla"

?  Where is the point in this particular obfuscation?

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES - Countdown for June 11th

[James]

Hello,

Here is the current patch countdown list. The next countdown will be on
June 14th.

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/



Push:


1388 Support OpenType font features - Jay Anderson
https://sourceforge.net/p/testlilyissues/issues/1388
http://codereview.appspot.com/323850043


Countdown:


5141 Fix typos in \offset documentation - David Nalesnik
https://sourceforge.net/p/testlilyissues/issues/5141
http://codereview.appspot.com/322040043


Review: No patches in Review at this time.


New:


5144 lilypond-manuals.css: edit color scheme and some spacing - Paul
Morris https://sourceforge.net/p/testlilyissues/issues/5144
http://codereview.appspot.com/322070043


James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel