Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On 2017/07/15 09:13:08, thomasmorley651 wrote: If you try \override BassFigure.X-offset = #ly:self-alignment-interface::centered-on-x-parent you'll see improvements in some cases (others are worse). Therefore I think ly:self-alignment-interface::centered-on-x-parent is not the correct tool, but something similiar could do the trick. https://sourceforge.net/p/testlilyissues/issues/5154/#ce35 May be a starting point/proof of concept. https://codereview.appspot.com/325070043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LilyDevOS, a LilyDev container + full VM image
On 07/14/2017 05:52 AM, Federico Bruni wrote: https://github.com/fedelibre/LilyDevOS/releases/tag/v0.1 Hi Federico, This looks great! I downloaded the one for linux (I'm on Ubuntu 16.04 LTS) and gave it a try. I ran into a few things but got it working and successfully built LilyPond in the container. Details below. One issue was that I had systemd installed, but not systemd-container, so I had to install that. So maybe we should add that to the dependencies in the instructions? $ sudo systemd-nspawn -bD lilydevos-0.1 sudo: unable to resolve host t440s sudo: systemd-nspawn: command not found $ systemd-nspawn --help The program 'systemd-nspawn' is currently not installed. You can install it by typing: sudo apt install systemd-container After that, things worked, although I saw some "Failed to..." messages, not sure if they are a problem or not: $ sudo systemd-nspawn -bD lilydevos-0.1 sudo: unable to resolve host t440s Spawning container lilydevos-0.1 on /home/paul/lilypond-world/LilyDevOS/lilydevos-0.1. Press ^] three times within 1s to kill container. Failed to create directory /home/paul/lilypond-world/LilyDevOS/lilydevos-0.1/sys/fs/selinux: Read-only file system Failed to create directory /home/paul/lilypond-world/LilyDevOS/lilydevos-0.1/sys/fs/selinux: Read-only file system systemd 233 running in system mode. (+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN default-hierarchy=hybrid) Detected virtualization systemd-nspawn. Detected architecture x86-64. Welcome to Fedora 26 (Twenty Six)! Set hostname to . Initializing machine ID from random generator. Failed to install release agent, ignoring: File exists [ OK ] Listening on /dev/initctl Compatibility Named Pipe. [ OK ] Listening on Journal Socket (/dev/log). [ OK ] Created slice User and Session Slice. [ OK ] Reached target Swap. [ OK ] Listening on Process Core Dump Socket. [ OK ] Created slice System Slice. [ OK ] Created slice system-getty.slice. Mounting Huge Pages File System... Mounting FUSE Control File System... [ OK ] Reached target Slices. Mounting POSIX Message Queue File System... [ OK ] Listening on Journal Socket. [ OK ] Reached target Local File Systems (Pre). [ OK ] Reached target Local File Systems. Starting Rebuild Journal Catalog... [ OK ] Started Forward Password Requests to Wall Directory Watch. Starting Rebuild Dynamic Linker Cache... [ OK ] Started Dispatch Password Requests to Console Directory Watch. [ OK ] Reached target Paths. [ OK ] Reached target Encrypted Volumes. Starting Create System Users... Starting Journal Service... [ OK ] Reached target Remote File Systems. [ OK ] Mounted FUSE Control File System. [ OK ] Mounted POSIX Message Queue File System. [ OK ] Mounted Huge Pages File System. [ OK ] Started Create System Users. [ OK ] Started Journal Service. Starting Flush Journal to Persistent Storage... [ OK ] Started Rebuild Journal Catalog. [ OK ] Started Flush Journal to Persistent Storage. Starting Create Volatile Files and Directories... [ OK ] Started Create Volatile Files and Directories. Starting Update UTMP about System Boot/Shutdown... [ OK ] Started Update UTMP about System Boot/Shutdown. [ OK ] Started Rebuild Dynamic Linker Cache. Starting Update is Completed... [ OK ] Started Update is Completed. [ OK ] Reached target System Initialization. [ OK ] Listening on D-Bus System Message Bus Socket. [ OK ] Reached target Sockets. [ OK ] Started Daily Cleanup of Temporary Directories. [ OK ] Started dnf makecache timer. [ OK ] Reached target Timers. [ OK ] Reached target Basic System. Starting Permit User Sessions... [ OK ] Started D-Bus System Message Bus. Starting Login Service... [ OK ] Started Permit User Sessions. [ OK ] Started Console Getty. [ OK ] Reached target Login Prompts. [ OK ] Started Login Service. [ OK ] Reached target Multi-User System. [ OK ] Reached target Graphical Interface. Starting Update UTMP about System Runlevel Changes... [ OK ] Started Update UTMP about System Runlevel Changes. Fedora 26 (Twenty Six) Kernel 4.4.0-83-generic on an x86_64 (console) lilydev login: Next I found that the uid for the dev user in the container was not the same as my host user uid, so I wasn't able to access the files from the host user account. But I was able to use the instructions in this blog post to change the dev user uid and that fixed it: https://muffinresearch.co.uk/linux-changing-uids-and-gids-for-user/ And I was able to successfully build lilypond in the container. (Look mom, no VM!) So this is really nice. I can edit files using my usual desktop environment and text editor, then just do git and git-cl via the command line in the container. One other
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On Sat, 2017-07-15 at 02:09 -0700, thomasmorle...@gmail.com wrote:
> On 2017/07/15 08:55:43, richard_rshann.plus.com wrote:
> > On Sat, 2017-07-15 at 08:51 +0100, Richard Shann wrote:
> > > On Sat, 2017-07-15 at 00:40 -0700, mailto:thomasmorle...@gmail.com
> wrote:
> > > > On 2017/07/15 07:25:37, http://richard_rshann.plus.com wrote:
> > > > > On Sat, 2017-07-15 at 00:09 -0700,
> mailto:thomasmorle...@gmail.com
> > > > wrote:
> > > > > > I'm afraid this patch does not fix the problem as wished.
> > > >
> > > > > You give an example of multiple bass figures on a note, I'm not
> > > sure
> > > > > what you would wish to see for that case,
> > > >
> > > > In
> > > > <<
> > > >\relative c' { c1 c1 }
> > > >\figures { <6+>2 <6+>2 <6+>1 }
> > > >
> > > > I would expect same aligning for first and second BassFigure
> related
> > > to
> > > > the note.
> > > (understood: first and second *group* of bass figures)
> > >
> > > That would be ok, although when you have multiple figures on a note
> > > allowing a bit more space for them can be good sometimes. You could
> > > always move the whole group along by inserting a short duration note
> > > with no figure in the bass figures if there was a particular case
> > > where
> > > this seemed obtrusive (hacky of course).
> > >
> > > So I think you could validly object that you didn't like them being
> > > treated differently.
> > Ha! I think I was being over-generous to your case here :)
> > consider
>
> > <<
> > \relative c' { c1 c2 }
> > \figures { <_+>2 <6+>2 <_+>4 <4>4}
>
> > >>
>
> > In the current LilyPond the two groups of figures are aligned
> > differently.
>
> As a debugging-helper I coded a visualization.tool:
>
> \layout {
>\context {
> \FiguredBass
> \override BassFigure.after-line-breaking =
>#(lambda (grob)
> (let ((line
> (ly:make-stencil
>(ly:stencil-expr (make-filled-box-stencil '(0 . 0) '(0
> . 10)))
>'(0 . 0)
>'(0 . 0
> (format #t "\nX-extent:\t~a"
>(interval-length (ly:grob-property grob 'X-extent)))
> (ly:grob-set-property! grob 'stencil
>(box-stencil
> (ly:stencil-combine-at-edge
>(ly:stencil-combine-at-edge
> line Y RIGHT (ly:text-interface::print grob) 0)
>X RIGHT line 0)
>0 0
>}
> }
>
> After applying it to your example I'm not sure what you mean. I don't
> see a significant difference.
Your visualization tool reveals the problem. They are aligned the same:
the left hand edge of the figure is aligned with the left hand edge of
the note. However, because the whole note is wider visual impression is
that the figure appears centered on the note for the shorter duration
notes but to the left for the whole note.
So the problem is perhaps that the choice of alignment point is
unfortunate.
Richard
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On 2017/07/15 09:03:30, richard_rshann.plus.com wrote:
On Sat, 2017-07-15 at 01:50 -0700, mailto:thomasmorle...@gmail.com
wrote:
> On 2017/07/15 08:06:41, http://richard_rshann.plus.com wrote:
>
> > So I think you could validly object that you didn't like them
being
> > treated differently.
>
> If you look at the following, namely the colored BassFigures
>
> cbf = \once \override BassFigure.color = #red
> <<
>\relative c' { c1 c8 d e f g f e d c1 c1 }
>\figures { <_!>2 <_!>2 \cbf <_!>1 <_!>2 <_!>2 \cbf <_!>1 }
>
>
> You'll see your patch improves the second colored BassFigure, but
the
> first one is turned worse.
Ah, yes I see. If you create a single figure of a duration to cover a
whole series of shorter duration notes you run into trouble. A better
approach to the problem would be needed to avoid you having to re-code
the bass figure duration to match the note it applies to.
Richard
If you try
\override BassFigure.X-offset =
#ly:self-alignment-interface::centered-on-x-parent
you'll see improvements in some cases (others are worse).
Therefore I think ly:self-alignment-interface::centered-on-x-parent is
not the correct tool, but something similiar could do the trick.
https://codereview.appspot.com/325070043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On 2017/07/15 08:55:43, richard_rshann.plus.com wrote:
On Sat, 2017-07-15 at 08:51 +0100, Richard Shann wrote:
> On Sat, 2017-07-15 at 00:40 -0700, mailto:thomasmorle...@gmail.com
wrote:
> > On 2017/07/15 07:25:37, http://richard_rshann.plus.com wrote:
> > > On Sat, 2017-07-15 at 00:09 -0700,
mailto:thomasmorle...@gmail.com
> > wrote:
> > > > I'm afraid this patch does not fix the problem as wished.
> >
> > > You give an example of multiple bass figures on a note, I'm not
> sure
> > > what you would wish to see for that case,
> >
> > In
> > <<
> >\relative c' { c1 c1 }
> >\figures { <6+>2 <6+>2 <6+>1 }
> >
> > I would expect same aligning for first and second BassFigure
related
> to
> > the note.
> (understood: first and second *group* of bass figures)
>
> That would be ok, although when you have multiple figures on a note
> allowing a bit more space for them can be good sometimes. You could
> always move the whole group along by inserting a short duration note
> with no figure in the bass figures if there was a particular case
> where
> this seemed obtrusive (hacky of course).
>
> So I think you could validly object that you didn't like them being
> treated differently.
Ha! I think I was being over-generous to your case here :)
consider
<<
\relative c' { c1 c2 }
\figures { <_+>2 <6+>2 <_+>4 <4>4}
>>
In the current LilyPond the two groups of figures are aligned
differently.
As a debugging-helper I coded a visualization.tool:
\layout {
\context {
\FiguredBass
\override BassFigure.after-line-breaking =
#(lambda (grob)
(let ((line
(ly:make-stencil
(ly:stencil-expr (make-filled-box-stencil '(0 . 0) '(0
. 10)))
'(0 . 0)
'(0 . 0
(format #t "\nX-extent:\t~a"
(interval-length (ly:grob-property grob 'X-extent)))
(ly:grob-set-property! grob 'stencil
(box-stencil
(ly:stencil-combine-at-edge
(ly:stencil-combine-at-edge
line Y RIGHT (ly:text-interface::print grob) 0)
X RIGHT line 0)
0 0
}
}
After applying it to your example I'm not sure what you mean. I don't
see a significant difference.
https://codereview.appspot.com/325070043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On Sat, 2017-07-15 at 01:50 -0700, thomasmorle...@gmail.com wrote:
> On 2017/07/15 08:06:41, richard_rshann.plus.com wrote:
>
> > So I think you could validly object that you didn't like them being
> > treated differently.
>
> If you look at the following, namely the colored BassFigures
>
> cbf = \once \override BassFigure.color = #red
> <<
>\relative c' { c1 c8 d e f g f e d c1 c1 }
>\figures { <_!>2 <_!>2 \cbf <_!>1 <_!>2 <_!>2 \cbf <_!>1 }
>
>
> You'll see your patch improves the second colored BassFigure, but the
> first one is turned worse.
Ah, yes I see. If you create a single figure of a duration to cover a
whole series of shorter duration notes you run into trouble. A better
approach to the problem would be needed to avoid you having to re-code
the bass figure duration to match the note it applies to.
Richard
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On Sat, 2017-07-15 at 08:51 +0100, Richard Shann wrote:
> On Sat, 2017-07-15 at 00:40 -0700, thomasmorle...@gmail.com wrote:
> > On 2017/07/15 07:25:37, richard_rshann.plus.com wrote:
> > > On Sat, 2017-07-15 at 00:09 -0700, mailto:thomasmorle...@gmail.com
> > wrote:
> > > > I'm afraid this patch does not fix the problem as wished.
> >
> > > You give an example of multiple bass figures on a note, I'm not
> sure
> > > what you would wish to see for that case,
> >
> > In
> > <<
> >\relative c' { c1 c1 }
> >\figures { <6+>2 <6+>2 <6+>1 }
> >
> > I would expect same aligning for first and second BassFigure related
> to
> > the note.
> (understood: first and second *group* of bass figures)
>
> That would be ok, although when you have multiple figures on a note
> allowing a bit more space for them can be good sometimes. You could
> always move the whole group along by inserting a short duration note
> with no figure in the bass figures if there was a particular case
> where
> this seemed obtrusive (hacky of course).
>
> So I think you could validly object that you didn't like them being
> treated differently.
Ha! I think I was being over-generous to your case here :)
consider
<<
\relative c' { c1 c2 }
\figures { <_+>2 <6+>2 <_+>4 <4>4}
>>
In the current LilyPond the two groups of figures are aligned
differently. So, my patch constitutes an improvement to the current
situation, even though it doesn't fix this case, (which, as I said, is
not really a worry - it's quite difficult to spot).
Richard
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On 2017/07/15 08:06:41, richard_rshann.plus.com wrote:
So I think you could validly object that you didn't like them being
treated differently.
If you look at the following, namely the colored BassFigures
cbf = \once \override BassFigure.color = #red
<<
\relative c' { c1 c8 d e f g f e d c1 c1 }
\figures { <_!>2 <_!>2 \cbf <_!>1 <_!>2 <_!>2 \cbf <_!>1 }
You'll see your patch improves the second colored BassFigure, but the
first one is turned worse.
But that wouldn't justify sticking with the
horrible effect you see when there is a single figure/lone accidental.
Indeed. Hence my suggestion to code a callback looking at the related
NoteColumn.
https://codereview.appspot.com/325070043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On Sat, 2017-07-15 at 00:40 -0700, thomasmorle...@gmail.com wrote:
> On 2017/07/15 07:25:37, richard_rshann.plus.com wrote:
> > On Sat, 2017-07-15 at 00:09 -0700, mailto:thomasmorle...@gmail.com
> wrote:
> > > I'm afraid this patch does not fix the problem as wished.
>
> > You give an example of multiple bass figures on a note, I'm not sure
> > what you would wish to see for that case,
>
> In
> <<
>\relative c' { c1 c1 }
>\figures { <6+>2 <6+>2 <6+>1 }
>
> I would expect same aligning for first and second BassFigure related to
> the note.
(understood: first and second *group* of bass figures)
That would be ok, although when you have multiple figures on a note
allowing a bit more space for them can be good sometimes. You could
always move the whole group along by inserting a short duration note
with no figure in the bass figures if there was a particular case where
this seemed obtrusive (hacky of course).
So I think you could validly object that you didn't like them being
treated differently. But that wouldn't justify sticking with the
horrible effect you see when there is a single figure/lone accidental.
Richard
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On 2017/07/15 07:51:11, thomasmorley651 wrote:
On 2017/07/15 07:40:01, thomasmorley651 wrote:
>
> In
> <<
> \relative c' { c1 c1 }
> \figures { <6+>2 <6+>2 <6+>1 }
> >>
> I would expect same aligning for first and second BassFigure related
to the
> note.
Aargh, should read:
I would expect same aligning for first and third BassFigure
I think it quite unusual to have a figure without a note. But the other
way round (note without figure) is very common and leads to the same
problem of the length of the figure being different from the length of
the note it purportedly aligns to.
https://codereview.appspot.com/325070043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On 2017/07/15 07:40:01, thomasmorley651 wrote:
On 2017/07/15 07:25:37, http://richard_rshann.plus.com wrote:
> On Sat, 2017-07-15 at 00:09 -0700, mailto:thomasmorle...@gmail.com
wrote:
> > I'm afraid this patch does not fix the problem as wished.
> You give an example of multiple bass figures on a note, I'm not sure
> what you would wish to see for that case,
In
<<
\relative c' { c1 c1 }
\figures { <6+>2 <6+>2 <6+>1 }
>>
I would expect same aligning for first and second BassFigure related
to the
note.
Aargh, should read:
I would expect same aligning for first and third BassFigure
https://codereview.appspot.com/325070043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On 2017/07/15 07:25:37, richard_rshann.plus.com wrote:
On Sat, 2017-07-15 at 00:09 -0700, mailto:thomasmorle...@gmail.com
wrote:
> I'm afraid this patch does not fix the problem as wished.
You give an example of multiple bass figures on a note, I'm not sure
what you would wish to see for that case,
In
<<
\relative c' { c1 c1 }
\figures { <6+>2 <6+>2 <6+>1 }
I would expect same aligning for first and second BassFigure related to
the note.
https://codereview.appspot.com/325070043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
On Sat, 2017-07-15 at 00:09 -0700, thomasmorle...@gmail.com wrote: > I'm afraid this patch does not fix the problem as wished. It solves the problem of single bass figures and isolated accidentals on notes of duration longer than whole note as the comment says. You give an example of multiple bass figures on a note, I'm not sure what you would wish to see for that case, but what LilyPond does in that case is quite readable - I can't suggest any improvement for that case. I wouldn't want to see the whole group of figures centered on the note centre since they would seem to start before the note - I'm not sure what the 19th c academic style might be... Richard ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Centering bass figures on whole notes and longer (issue 325070043 by pkx1...@gmail.com)
I'm afraid this patch does not fix the problem as wished. See my comment on the tracker: https://sourceforge.net/p/testlilyissues/issues/5154/#1933 https://codereview.appspot.com/325070043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
