Re: Installing URW++ fonts, issue 4998: why not add wget lines to lilydev-setup.sh?

2017-10-05 Thread Federico Bruni 



Il giorno gio 5 ott 2017 alle 3:10, Karlin High  
ha scritto:
On Wed, Oct 4, 2017 at 6:27 PM, Carl Sorensen  
wrote:

[...]



 somehow this patch needs to be coordinated with Federico,
 rather than using the standard LilyPond patch sequence.


That's what I gathered, too. I assumed Federico follows this list. The
discussion had
stopped with the question of how to instruct new developers to get 
the fonts,

and I debated whether to continue it here,
or on the Sourceforge or Rietveld issues.



Hi Karlin

In my opinion these fonts should be provided by linux distros.
I've just read that a new package urw-base35-fonts will replace the 
obsolete urw-fonts in Fedora 27 (which should be released in November):

https://bodhi.fedoraproject.org/updates/urw-base35-fonts-20170801-1.fc27

Upstream repository is:
https://github.com/ArtifexSoftware/urw-base35-fonts

I hope that Debian will do the same. I guess this is the package (at 
the moment only in experimental):

https://packages.debian.org/search?keywords=fonts-urw-base35




### about LilyDev ###

I've recently created a new LilyDev project, which I called LilyDevOS 
(based on latest stable Fedora):

https://github.com/fedelibre/LilyDevOS

This means that in a couple of months LilyDevOS may have this problem 
fixed.


It's not mentioned in LilyPond doc, as I thought I should wait for 
feedback from all LilyDev users.
It has a number of advantages over LilyDev and for me it's much easier 
to use, for a number of reasons which I've listed here:

http://lists.gnu.org/archive/html/lilypond-devel/2017-07/msg00014.html

Anyway, if we decide that the setup script in LilyDev should include 
your proposal, I'll be happy to see a pull request (if you have a 
github account) or I'll do the change for you. The problem in LilyDev 
is how to handle the guile1.8 problem: version 5 (master) is based on 
stretch and does not support guile1.8; version 4 is based on jessie and 
has guile1.8.





___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES - Countdown for October 5th

2017-10-05 Thread James 
Hello,

Here is the current patch countdown list. The next countdown will be on
October 8th.

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/




Push:

5206 Remove apostroph in backend-options of german running.itely - Thomas Morley
https://sourceforge.net/p/testlilyissues/issues/5206
http://codereview.appspot.com/326620043

5205 \chordmode { c:sus } should be , not - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5205
http://codereview.appspot.com/326610043

5204 Remove white-space from storePredefinedDiagram input-string - Thomas Morley
https://sourceforge.net/p/testlilyissues/issues/5204
http://codereview.appspot.com/330340043


Countdown:

5211 Merge_rests_engraver: fix vertical rest positions - maltem
https://sourceforge.net/p/testlilyissues/issues/5211
http://codereview.appspot.com/334740043

5210 LyricHyphen improvements: Accept hyphen markup, fuzzy-metrics - Knut 
Petersen
https://sourceforge.net/p/testlilyissues/issues/5210
http://codereview.appspot.com/330920043

5209 Pitches.itely - Typo - James Lowe
https://sourceforge.net/p/testlilyissues/issues/5209
http://codereview.appspot.com/324590043

5208 Changes.tely 2.20 - fix whitespace and semi colons - James Lowe
https://sourceforge.net/p/testlilyissues/issues/5208
http://codereview.appspot.com/327550043

5207 Parse strings and comments in #{ ... #} - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5207
http://codereview.appspot.com/323700043


Review:

5212 Allow quoted strings as Scheme arguments to markup commands - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5212
http://codereview.appspot.com/331820043


New: No new patches at this time.


Waiting:

4603 change all occurences of ‘partcombine’ to ‘partCombine’. - James Lowe
https://sourceforge.net/p/testlilyissues/issues/4603
http://codereview.appspot.com/323040043


Regards

James   Hello,
   Here is the current patch countdown list. The next countdown will be on
   October 2nd.
   A quick synopsis of all patches currently in the review process can be
   found here:
   http://philholmes.net/lilypond/allura/
   
   Push:
   5203 Don't let event-chord-reduce bomb on empty chords - David Kastrup
   https://sourceforge.net/p/testlilyissues/issues/5203
   http://codereview.appspot.com/327480043
   5202 Add regtest for issue 5181 - David Kastrup
   https://sourceforge.net/p/testlilyissues/issues/5202
   http://codereview.appspot.com/327470043
   5198 Add command for Thin Aiken noteheads - Karlin High
   https://sourceforge.net/p/testlilyissues/issues/5198
   http://codereview.appspot.com/326510043
   5190 NR: Update Clef styles Appendix - James Lowe
   https://sourceforge.net/p/testlilyissues/issues/5190
   http://codereview.appspot.com/324420043
   5176 2.20 - re-organize Changes.tely into Topics - James Lowe
   https://sourceforge.net/p/testlilyissues/issues/5176
   http://codereview.appspot.com/326400043

   Countdown:
   5200 display-lily-tests.ly: Remove unused lily-string->markup - David
   Kastrup
   https://sourceforge.net/p/testlilyissues/issues/5200
   http://codereview.appspot.com/324490043

   5201 Use -b together with -dgs-never-embed-fonts - Knut Petersen
   https://sourceforge.net/p/testlilyissues/issues/5201
   http://codereview.appspot.com/325630043

   Review:
   5205 \chordmode { c:sus } should be , not - David Kastrup
   https://sourceforge.net/p/testlilyissues/issues/5205
   http://codereview.appspot.com/326610043
   5204 Remove white-space from storePredefinedDiagram input-string -
   Thomas Morley
   https://sourceforge.net/p/testlilyissues/issues/5204
   http://codereview.appspot.com/330340043
   New:

   No new patches at this time.

   Waiting:
   4603 change all occurences of ‘partcombine’ to ‘partCombine’. - James
   Lowe
   https://sourceforge.net/p/testlilyissues/issues/4603
   http://codereview.appspot.com/323040043


   Regards

   James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Merge_rests_engraver: fix vertical rest positions (issue 334740043 by lilyp...@maltemeyn.de)

2017-10-05 Thread thomasmorley65 

Hi Malte,

your patch fixes the "magnifyStaff"-problem.

Though, this functionality needs testing, imho.
I'd extend the reg-test merge-rests-engraver.ly or add a new one.

Some other thoughts:


https://codereview.appspot.com/334740043/diff/1/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

https://codereview.appspot.com/334740043/diff/1/scm/scheme-engravers.scm#newcode140
scm/scheme-engravers.scm:140: (define (rest-eqv rest-len-prop)
While you're on it, I'd prefer rest-eqv? for a predicate returning a
boolean. Here and at several other instances.

https://codereview.appspot.com/334740043/diff/1/scm/scheme-engravers.scm#newcode214
scm/scheme-engravers.scm:214: (merge-rests rests (lambda (r) 0))
'merge-rests' as defined above expects a procedure as second argument,
so there is the need to put in a procedure here as well.
But wouldn't it be better to delete the 'position-function'-argument
from the definition and derive the local 'staff-pos'-variable from
(if (is-single-bar-rest? (car rests)) 2 0)
directly?
With the advantage one could then delete the entire 'mmrest-position',
at least after correcting the other code-parts expecting
position-function.
Then here only
(merge-rests rests)
remains.

https://codereview.appspot.com/334740043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel