Re: Multiple properties for \override \override-lines markup (issue 331860043 by d...@gnu.org)

2017-10-11 Thread dak 

On 2017/10/11 21:08:49, thomasmorley651 wrote:

On 2017/10/11 10:19:25, dak wrote:



>


https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm#newcode4026

> scm/define-markup-commands.scm:4026: \\override-lines

#'(multi-measure-rest .

> #t)
> On 2017/10/08 15:19:44, thomasmorley651 wrote:
> > Why override_-lines_ here. Don't understand.
>
> Because \override ... { x y z } is translated into
> { \override ... x \override ... y \override ... z }
> which is wasteful.
>
> Remember that everything that is called "-lines" in markup really is

talking

> about a markup _list_.  Whether it ends up in lines depends on the

usage.


Ah, ofcourse.


Also known as "this sucks".  At some point of time we might replace
-lines with -list like \markuplines was renamed to \markuplist .

But that's likely to be a large piece of work.

https://codereview.appspot.com/331860043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Multiple properties for \override \override-lines markup (issue 331860043 by d...@gnu.org)

2017-10-11 Thread thomasmorley65 

On 2017/10/11 10:19:25, dak wrote:


https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm#newcode4026

scm/define-markup-commands.scm:4026: \\override-lines

#'(multi-measure-rest .

#t)
On 2017/10/08 15:19:44, thomasmorley651 wrote:
> Why override_-lines_ here. Don't understand.



Because \override ... { x y z } is translated into
{ \override ... x \override ... y \override ... z }
which is wasteful.



Remember that everything that is called "-lines" in markup really is

talking

about a markup _list_.  Whether it ends up in lines depends on the

usage.

Ah, ofcourse. Thanks.

LGTM

https://codereview.appspot.com/331860043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Multiple properties for \override \override-lines markup (issue 331860043 by d...@gnu.org)

2017-10-11 Thread dak 


https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly
File Documentation/snippets/keyboard-headword.ly (right):

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly#newcode31
Documentation/snippets/keyboard-headword.ly:31: \override #'((direction
. 1) (baseline-skip . 2)) {
On 2017/10/11 10:19:25, dak wrote:

On 2017/10/08 15:19:44, thomasmorley651 wrote:
> One {}-bracket-pair could be deleted as well.



Two, actually (all except the innermost one).  I'll take a look.



The {} reduction was manually, so it may have been

incomplete/inconsistent.

Oh, this is rubbish.  It will get overwritten by the next LSR import
anyway and is not important enough to put in snippets/new.  I'll revert.

https://codereview.appspot.com/331860043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Multiple properties for \override \override-lines markup (issue 331860043 by d...@gnu.org)

2017-10-11 Thread dak 


https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly
File Documentation/snippets/keyboard-headword.ly (right):

https://codereview.appspot.com/331860043/diff/20001/Documentation/snippets/keyboard-headword.ly#newcode31
Documentation/snippets/keyboard-headword.ly:31: \override #'((direction
. 1) (baseline-skip . 2)) {
On 2017/10/08 15:19:44, thomasmorley651 wrote:

One {}-bracket-pair could be deleted as well.


Two, actually (all except the innermost one).  I'll take a look.

The {} reduction was manually, so it may have been
incomplete/inconsistent.

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm#newcode2530
scm/define-markup-commands.scm:2530: @lilypond[verbatim,quote]
On 2017/10/08 15:19:44, thomasmorley651 wrote:

How about demonstrating in the example. Suggestion:
\markup {
   \undertie "undertied"
   \override #'(offset . 15)
   \undertie "offset undertied"
   \override #'((offset . 15)(thickness . 3))
   \undertie "offset thick undertied"
}


Maybe. \markup { \line { ... } } is an abomination anyway.  Should be
just
\markup { ... }.  I'll take a look.

https://codereview.appspot.com/331860043/diff/20001/scm/define-markup-commands.scm#newcode4026
scm/define-markup-commands.scm:4026: \\override-lines
#'(multi-measure-rest . #t)
On 2017/10/08 15:19:44, thomasmorley651 wrote:

Why override_-lines_ here. Don't understand.


Because \override ... { x y z } is translated into
{ \override ... x \override ... y \override ... z }
which is wasteful.

Remember that everything that is called "-lines" in markup really is
talking about a markup _list_.  Whether it ends up in lines depends on
the usage.

https://codereview.appspot.com/331860043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES - Countdown for October 11th

2017-10-11 Thread James 
Hello,

Here is the current patch countdown list. The next countdown will be on
October 14th.

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/



Push:

5212 Allow quoted strings as Scheme arguments to markup commands - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5212
http://codereview.appspot.com/331820043


Countdown:


5214 Multiple properties for \override \override-lines markup - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5214
http://codereview.appspot.com/331860043

5213 Web: Remove links to gmane in footers for manuals - James Lowe
https://sourceforge.net/p/testlilyissues/issues/5213
http://codereview.appspot.com/330510043

5211 Merge_rests_engraver: fix vertical rest positions - Malte Meyn
https://sourceforge.net/p/testlilyissues/issues/5211
http://codereview.appspot.com/334740043

4996 Make easyHeads correctly heed the fontSize context property - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4996
http://codereview.appspot.com/330500043

4981 Web: Remove links to gmane throughout Website - James Lowe
https://sourceforge.net/p/testlilyissues/issues/4981
http://codereview.appspot.com/331850043

4905 Documentation - --include requires absolute paths - James Lowe
https://sourceforge.net/p/testlilyissues/issues/4905
http://codereview.appspot.com/326700043


Review:


5216 web/community: update link to German user forum - Malte Meyn
https://sourceforge.net/p/testlilyissues/issues/5216
http://codereview.appspot.com/335740043

5215 make metronomeMarkFormatter more flexible - Malte Meyn
https://sourceforge.net/p/testlilyissues/issues/5215
http://codereview.appspot.com/327620043


New: No new patches at this time.


Waiting:

4603 change all occurences of ‘partcombine’ to ‘partCombine’. - James Lowe
https://sourceforge.net/p/testlilyissues/issues/4603
http://codereview.appspot.com/323040043


Regards

James   Hello,
   Here is the current patch countdown list. The next countdown will be on
   October 2nd.
   A quick synopsis of all patches currently in the review process can be
   found here:
   http://philholmes.net/lilypond/allura/
   
   Push:
   5203 Don't let event-chord-reduce bomb on empty chords - David Kastrup
   https://sourceforge.net/p/testlilyissues/issues/5203
   http://codereview.appspot.com/327480043
   5202 Add regtest for issue 5181 - David Kastrup
   https://sourceforge.net/p/testlilyissues/issues/5202
   http://codereview.appspot.com/327470043
   5198 Add command for Thin Aiken noteheads - Karlin High
   https://sourceforge.net/p/testlilyissues/issues/5198
   http://codereview.appspot.com/326510043
   5190 NR: Update Clef styles Appendix - James Lowe
   https://sourceforge.net/p/testlilyissues/issues/5190
   http://codereview.appspot.com/324420043
   5176 2.20 - re-organize Changes.tely into Topics - James Lowe
   https://sourceforge.net/p/testlilyissues/issues/5176
   http://codereview.appspot.com/326400043

   Countdown:
   5200 display-lily-tests.ly: Remove unused lily-string->markup - David
   Kastrup
   https://sourceforge.net/p/testlilyissues/issues/5200
   http://codereview.appspot.com/324490043

   5201 Use -b together with -dgs-never-embed-fonts - Knut Petersen
   https://sourceforge.net/p/testlilyissues/issues/5201
   http://codereview.appspot.com/325630043

   Review:
   5205 \chordmode { c:sus } should be , not - David Kastrup
   https://sourceforge.net/p/testlilyissues/issues/5205
   http://codereview.appspot.com/326610043
   5204 Remove white-space from storePredefinedDiagram input-string -
   Thomas Morley
   https://sourceforge.net/p/testlilyissues/issues/5204
   http://codereview.appspot.com/330340043
   New:

   No new patches at this time.

   Waiting:
   4603 change all occurences of ‘partcombine’ to ‘partCombine’. - James
   Lowe
   https://sourceforge.net/p/testlilyissues/issues/4603
   http://codereview.appspot.com/323040043


   Regards

   James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: make metronomeMarkFormatter more flexible (issue 327620043 by lilyp...@maltemeyn.de)

2017-10-11 Thread David Kastrup 
Xavier Scheuer  writes:

> Hello,
>
> It is nice to see you working on adding new functionalities directly
> into LilyPond, thanks.
>
> Just FYI there are also all these Rhythm marks / play style indication
> shown in LSR #204 http://lsr.di.unimi.it/LSR/Item?id=204

Bit of a challenge to find good input syntax for it and something to map
it through.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: make metronomeMarkFormatter more flexible (issue 327620043 by lilyp...@maltemeyn.de)

2017-10-11 Thread Xavier Scheuer 
Hello,

It is nice to see you working on adding new functionalities directly
into LilyPond, thanks.

Just FYI there are also all these Rhythm marks / play style indication
shown in LSR #204 http://lsr.di.unimi.it/LSR/Item?id=204

Cheers,
Xavier


On 10 October 2017 at 20:47,  wrote:

> Reviewers: dak,
>
> Message:
> On 2017/10/10 16:29:05, dak wrote:
>
>> I think this approach is a rather bad tradeoff between additional
>>
> context
>
>> properties and actual flexibility: it still only allows for a very
>>
> limited
>
>> subset of metronome marks.
>>
>
> That’s true. BTW, I don’t even know why tempoHideNote and the properties
> of this snippet and patch are context properties and not properties of
> MetronomeMark.
>
> I think it would make sense to check all forms a \tempo mark currently
>>
> can take
>
>> and then see what principal forms those can assume.
>>
>
> Something like that?
>
> \tempo "Allegro" → Allegro
> \tempo 4 = 120   → 텟 = 120
> \tempo "Allegro" 4 = 120 → Allegro (텟 = 120)
> \tempo 4 = 120-132   → 텟 = 120 – 132
> \tempo "Allegro" 4 = 120-132 → Allegro (텟 = 120 – 132)
> \tempo "" 4 = 120→  (텟 = 120)   [misaligned]
> \tempo "" 4 = 120-132→  (텟 = 120 – 132) [misaligned]
>
> I’m not sure what you mean by “principal forms”. Could you explain? I
> made a list of limitations that the metronome mark formatter currently
> has:
>
> • font
>   – size
> ∘ everything can be scaled by grob property font-size
> ∘ text can then be scaled independently by markup commands
> ∘ note/numbers cannot be scaled independently
>   – series
> ∘ numbers can be made bold by grob property font-series
> ∘ text doesn’t respect the grob property, can be made medium by
> markup command
> • brackets
>   – type
> ∘ only round brackets
>   – presence
> ∘ present if text is set
> ∘ text but no brackets: impossible
> ∘ no text but brackets: possible but misaligned because of leading
> space
> • note
>   – stem
> ∘ only up
>   – duration
> ∘ only one note, no ties
> ∘ only simple durations, no tuplets
> • number
>   – type
> ∘ only integer (floating point is not nice to print as pointed out
> on the user list some time ago but rationals might be wanted)
>   – range
> ∘ dash is hardcoded (endash surrounded by thin spaces)
> • equation
>   – equation sign
> ∘ sign is hardcoded (= surrounded by spaces), so neither other signs
> like ≈ or ≥ nor text like “= approx.” are possible
>   – type
> ∘ only “note = number”/“note = range”, not “note = note”
> • miscellani
>   – swing feeling
> ∘ not really a tempo indication, but 8 8 = \tuplet 3/2 { 4 3 } and
> others would be nice (see equation→type and note→duration)
>
> Then, one needs to look how
>> many basically different format functions it makes sense to specify
>>
> for those
>
>> forms and pass those the _raw_ information in the \tempo mark, making
>>
> them
>
>> responsible for proper formatting.
>>
>
> So you don’t want grob and context properties for the fine tuning but
> different functions? That sound like an awful lot of functions to me
> (similar to the rehearsal mark formatters).
>
> That's for formatting: probably something needs to be there in
>>
> parallel for
>
>> calculating the moments-per-minute value.
>>
>
> Yes, that would be nice.
>
> Maybe we want something like
>>
>
> \tempo { \tuplet 2/3 { 4 8 } } = 45
>>
>
> to work as well?  That would require yet another hook.
>>
>
> What is this supposed to mean/look like? Does it mean \tempo 4 = 45 or
> \tempo 4*2/3 = 45? Should this output one quarter note or two notes?
>
> Description:
> make metronomeMarkFormatter more flexible
>
> This adds the context properties tempoEquationText, tempoBetweenText and
> tempoShowParentheses as shown in http://lsr.di.unimi.it/LSR/Item?id=1008
>
> It also allows to scale the size of the notes in a metronome mark
> independently from or rather relatively to the text and numbers.
> I added this possibility because http://lsr.di.unimi.it/LSR/Item?id=1008
> suggests smaller note sizes; so there seems to be a need for that.
>
> The default values are chosen so that the whole thing is backwards
> compatible; to achieve this, tempoShowParentheses accepts not only
> boolean values but also the symbol 'if-text.
>
> I chose the name tempoShowParentheses instead of tempoHideParentheses
> because this property also allows parenthesizing text-less
> MetronomeMarks.
>
> Contains regtests.
>
> Please review this at https://codereview.appspot.com/327620043/
>
> Affected files (+94, -16 lines):
>   A input/regression/metronome-mark-formatter-extended.ly
>   A input/regression/metronome-mark-note-size.ly
>   M lily/metronome-engraver.cc
>   M scm/define-context-properties.scm
>   M scm/translation-functions.scm
>
>
>
> ___
> lilypond-devel mailing list
> lilypond-devel@gnu.org
>