Re: Use convert -strip (issue 339350043 by bmwiedem...@gmail.com)
https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmakefile File Documentation/pictures/GNUmakefile (right): https://codereview.appspot.com/339350043/diff/1/Documentation/pictures/GNUmakefile#newcode29 Documentation/pictures/GNUmakefile:29: convert -strip -depth 8 -geometry 50x50% $< $@ It would be wise to add a brief comment before the dependency line explaining why -strip is important, otherwise someone might come along later, decide that it is pointless, and remove it. Are there any undesirable side effects of -strip, for example, removing a copyright notice? The man page says that -strip "strip[s the] image of all profiles and comments" but I'm not familiar enough with convert to know what that means. Are profiles also unimportant here? https://codereview.appspot.com/339350043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [testlilyissues:issues] Moderation action required
Hello On Sat, 12 May 2018 09:24:17 +0200, David Kastrup wrote: > "James Lowe" writes: > > > Dev team, > > > > Don tacked a patch on the end of an already-fixed issue. > > > > https://sourceforge.net/p/testlilyissues/issues/5243 > > > > I assume this needs a new issue? > > Basically yes, and definitely with an explanation of why the committed > fix is not considered sufficient. > > -- > David Kastrup I created https://sourceforge.net/p/testlilyissues/issues/5334/ Sorry this took so long to do. The patch has been attached to that issue and rebased. James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Use convert -strip (issue 339350043 by bmwiedem...@gmail.com)
On 2018/05/29 07:20:14, dulow kotic wrote: On 2018/05/29 07:20:04, dulow kotic wrote: Does this have a relevant 'Tracker issue'? I could not see one. This is probably why it has been ignored so far, let me know and we can create one for this Rietveld to get it in the Patch review process. Thanks James https://codereview.appspot.com/339350043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: musicxml2ly: handle hidden time signatures; support text+bpm \tempo marks. (issue 344000043 by a.mylt...@gmail.com)
On 2018/06/01 20:12:25, a.myltsev wrote: > What are the scripts these 'test' dirs? Those are actual tests for the added functionality, runnable with `pytest`. > Was this a mistake? No, I believe that these tests are individually useful, even though not yet integrated into the Lilypond testing system. If you prefer, though, I can leave them out. Yes if you wouldn't mind, that would be better I think. We should only be testing 'a patch' that has components that are 'push ready' (so to speak). If you want to add some more 'tests' then I suggest the best way would be to create a new tracker for them that you can start a discussion separate from the other work you have done. However, if these tests are integral to this work and you intend to eventually integrate them with the other work in this patch then that is fine too, but it wasn't clear to me. I'll wait to see what you want to do. Thanks for your understanding. https://codereview.appspot.com/34443/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
