Re: 2.20 plans.

2018-10-12 Thread Phil Holmes
- Original Message - 
From: "Thomas Morley" 

To: "Phil Holmes" 
Cc: "David Kastrup" ; "lilypond-devel" 
Sent: Friday, October 12, 2018 4:42 PM
Subject: Re: 2.20 plans.


On stable/2.20
I navigated to ~/lilypond-git/Documentation/pt/web
and did:
git blame manuals.itexi
And found

$ git log -p cf364e9995fcf22c15b753f12bf8389d1e0b3e18
commit cf364e9995fcf22c15b753f12bf8389d1e0b3e18
Author: Rafael Fontenelle 
Date:   Thu Aug 2 06:49:37 2018 -0300

   Docs-pt: Add Portuguese translation to website

diff --git a/Documentation/lilypond-texi2html-lang.init
b/Documentation/lilypond-texi2html-lang.init
index dc89070bc3..1e8a19bc78 100644
--- a/Documentation/lilypond-texi2html-lang.init
+++ b/Documentation/lilypond-texi2html-lang.init
@@ -4,7 +4,7 @@
use utf8;

my @langlist = (
-'ca', 'cs', 'de', 'es', 'fr', 'hu', 'it', 'ja', 'nl', 'po', 'zh'
+'ca', 'cs', 'de', 'es', 'fr', 'hu', 'it', 'ja', 'nl', 'po', 'pt', 
'zh'

);



Looks like this was pushed to stable/2.20 but never to master



Probably best to stash the changed files somewhere, to then revert this and 
to ask the contributor to submit a patch using the normal review process? 
It looks to me like it may have only done a partial job of trying to add a 
new translation.


--
Phil Holmes 



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


PATCHES - Countdown for Oct 12th

2018-10-12 Thread James Lowe

Hello,

Here is the current patch countdown list. The next countdown will be on 
15th October.


A quick synopsis of all patches currently in the review process can be 
found here:


http://philholmes.net/lilypond/allura/


Push:

5424 GUB: glib patch needed to compile with gcc >=6.x.y - Federico Bruni
https://sourceforge.net/p/testlilyissues/issues/5424
http://codereview.appspot.com/341500043

5423 First separator for subassignments must be '.' - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/5423
http://codereview.appspot.com/341490043

5396 GUB: lilypond-invoke-editor runs twice - Federico Bruni
https://sourceforge.net/p/testlilyissues/issues/5396
http://codereview.appspot.com/363790043

5384 Various fixes to GUB: - update broken download links - add missing 
dependencies - fix building of 'make' on glibc 2.27 systems - teach our 
ancient glibc that make 4.x exists - minor fixes - Knut Petersen

https://sourceforge.net/p/testlilyissues/issues/5384
http://codereview.appspot.com/369750043

Countdown: No patches on Countdown at this time.

Review: No patches in Review at this time.

New: No new patches at this time.



Regards

James


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: 2.20 plans.

2018-10-12 Thread Thomas Morley
Am Fr., 12. Okt. 2018 um 17:27 Uhr schrieb Thomas Morley
:
>
> Am Fr., 12. Okt. 2018 um 17:07 Uhr schrieb Phil Holmes :
> >
> > - Original Message -
> > From: "Thomas Morley" 
> > To: "Phil Holmes" 
> > Cc: "David Kastrup" ; "lilypond-devel" 
> > 
> > Sent: Friday, October 12, 2018 3:35 PM
> > Subject: Re: 2.20 plans.
> >
> >
> > > Am Fr., 12. Okt. 2018 um 16:13 Uhr schrieb Phil Holmes
> > > :
> > >>
> > >> - Original Message -
> > >> From: "David Kastrup" 
> > >> To: 
> > >> Sent: Monday, October 08, 2018 4:35 PM
> > >> Subject: 2.20 plans.
> > >>
> > >>
> > >> >
> > >> > Hi,
> > >> >
> > >> > I don't think there is much of a point in delaying more.  I've recently
> > >> > made another run through patches that should be in 2.20 and pushed to
> > >> > stable/2.20 branch.
> > >> >
> > >> > I think further integration work is as likely to destabilize as to
> > >> > stabilize stuff (if I not already did so), so the plan is to have
> > >> > a) let Phil release 2.19.83 as soon as he wants
> > >> > b) release 2.20.0 from that state (with a few cherry-picks on top)
> > >> > about
> > >> > a week after the last urgent "stop the presses" call.  Those would
> > >> > involve synching up documentation and bug fixes so obviously important
> > >> > that one would rather see them in than give them some time for testing.
> > >> >
> > >> > This will be followed (as soon as the state of download/web pages and
> > >> > Phil's resources permit) with releasing 2.21.0 to get an unstable
> > >> > version to refer to.
> > >> >
> > >> > --
> > >> > David Kastrup
> > >>
> > >>
> > >> I'm getting a bizarre problem with 2.20.  I did my updates to VERSION,
> > >> news,
> > >> etc. and ran a make to check all was OK.  It failed being unable to find
> > >> Documentation/pt/.  If I ls in a terminal, the directory is not shown.
> > >> If I
> > >> look with Nautilus it's there.  I know it's been deleted in master, but
> > >> not
> > >> in stable/2.20 and I really can't see why it should be there in the file
> > >> viewer but not via terminal.
> > >>
> > >> Anyone any idea??
> > >>
> > >> --
> > >> Phil Holmes
> > >
> > > I have no problems to see and to access it:
> > >
> > > hermann@kasten ~/lilypond-git (master)$ git checkout
> > > remotes/origin/stable/2.20
> > > Checking out files: 100% (886/886), done.
> > > Note: checking out 'remotes/origin/stable/2.20'.
> > >
> > > You are in 'detached HEAD' state. You can look around, make experimental
> > > changes and commit them, and you can discard any commits you make in this
> > > state without impacting any branches by performing another checkout.
> > >
> > > If you want to create a new branch to retain commits you create, you may
> > > do so (now or later) by using -b with the checkout command again. Example:
> > >
> > >  git checkout -b 
> > >
> > > HEAD is now at ab3d2f7a26 Bump version
> > > hermann@kasten ~/lilypond-git ((ab3d2f7a26...))$ cd Documentation/pt/
> > > hermann@kasten ~/lilypond-git/Documentation/pt ((ab3d2f7a26...))$ ls
> > > GNUmakefile  macros.itexi  search-box.ihtml  translations.itexi  web
> > > web.texi
> > >
> > >
> > > Sorry to be of not more help,
> > >  Harm
> >
> > It was of help.  It made me look harder and I found that it was actually
> > reporting that build/Documentation/pt/ was missing.  Which it is.  The
> > Documentation/pt/ directory is definitely missing from master but is present
> > in stable/2.20.  I guess that someone has deleted references to it and so
> > it's not getting copied into the build tree?  How do we find out which
> > commit deleted the directory in git?
> >
> > --
> > Phil Holmes
> >
>
> For reference I've looked into the branch
> stable/2.18
>
> ~/lilypond-git ((e7a7fe4faf...))$ cd Documentation/pt/
> bash: cd: Documentation/pt/: No such file or directory
>
> Searching via gitk is without result as well in both, stable/2.20 and master.
>
> Was Documentation/pt/ ever in master?
>
> Cheers,
>   Harm

On stable/2.20
I navigated to ~/lilypond-git/Documentation/pt/web
and did:
git blame manuals.itexi
And found

$ git log -p cf364e9995fcf22c15b753f12bf8389d1e0b3e18
commit cf364e9995fcf22c15b753f12bf8389d1e0b3e18
Author: Rafael Fontenelle 
Date:   Thu Aug 2 06:49:37 2018 -0300

Docs-pt: Add Portuguese translation to website

diff --git a/Documentation/lilypond-texi2html-lang.init
b/Documentation/lilypond-texi2html-lang.init
index dc89070bc3..1e8a19bc78 100644
--- a/Documentation/lilypond-texi2html-lang.init
+++ b/Documentation/lilypond-texi2html-lang.init
@@ -4,7 +4,7 @@
 use utf8;

 my @langlist = (
-'ca', 'cs', 'de', 'es', 'fr', 'hu', 'it', 'ja', 'nl', 'po', 'zh'
+'ca', 'cs', 'de', 'es', 'fr', 'hu', 'it', 'ja', 'nl', 'po', 'pt', 'zh'
 );



Looks like this was pushed to stable/2.20 but never to master


Cheers,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: 2.20 plans.

2018-10-12 Thread Thomas Morley
Am Fr., 12. Okt. 2018 um 17:07 Uhr schrieb Phil Holmes :
>
> - Original Message -
> From: "Thomas Morley" 
> To: "Phil Holmes" 
> Cc: "David Kastrup" ; "lilypond-devel" 
> Sent: Friday, October 12, 2018 3:35 PM
> Subject: Re: 2.20 plans.
>
>
> > Am Fr., 12. Okt. 2018 um 16:13 Uhr schrieb Phil Holmes
> > :
> >>
> >> - Original Message -
> >> From: "David Kastrup" 
> >> To: 
> >> Sent: Monday, October 08, 2018 4:35 PM
> >> Subject: 2.20 plans.
> >>
> >>
> >> >
> >> > Hi,
> >> >
> >> > I don't think there is much of a point in delaying more.  I've recently
> >> > made another run through patches that should be in 2.20 and pushed to
> >> > stable/2.20 branch.
> >> >
> >> > I think further integration work is as likely to destabilize as to
> >> > stabilize stuff (if I not already did so), so the plan is to have
> >> > a) let Phil release 2.19.83 as soon as he wants
> >> > b) release 2.20.0 from that state (with a few cherry-picks on top)
> >> > about
> >> > a week after the last urgent "stop the presses" call.  Those would
> >> > involve synching up documentation and bug fixes so obviously important
> >> > that one would rather see them in than give them some time for testing.
> >> >
> >> > This will be followed (as soon as the state of download/web pages and
> >> > Phil's resources permit) with releasing 2.21.0 to get an unstable
> >> > version to refer to.
> >> >
> >> > --
> >> > David Kastrup
> >>
> >>
> >> I'm getting a bizarre problem with 2.20.  I did my updates to VERSION,
> >> news,
> >> etc. and ran a make to check all was OK.  It failed being unable to find
> >> Documentation/pt/.  If I ls in a terminal, the directory is not shown.
> >> If I
> >> look with Nautilus it's there.  I know it's been deleted in master, but
> >> not
> >> in stable/2.20 and I really can't see why it should be there in the file
> >> viewer but not via terminal.
> >>
> >> Anyone any idea??
> >>
> >> --
> >> Phil Holmes
> >
> > I have no problems to see and to access it:
> >
> > hermann@kasten ~/lilypond-git (master)$ git checkout
> > remotes/origin/stable/2.20
> > Checking out files: 100% (886/886), done.
> > Note: checking out 'remotes/origin/stable/2.20'.
> >
> > You are in 'detached HEAD' state. You can look around, make experimental
> > changes and commit them, and you can discard any commits you make in this
> > state without impacting any branches by performing another checkout.
> >
> > If you want to create a new branch to retain commits you create, you may
> > do so (now or later) by using -b with the checkout command again. Example:
> >
> >  git checkout -b 
> >
> > HEAD is now at ab3d2f7a26 Bump version
> > hermann@kasten ~/lilypond-git ((ab3d2f7a26...))$ cd Documentation/pt/
> > hermann@kasten ~/lilypond-git/Documentation/pt ((ab3d2f7a26...))$ ls
> > GNUmakefile  macros.itexi  search-box.ihtml  translations.itexi  web
> > web.texi
> >
> >
> > Sorry to be of not more help,
> >  Harm
>
> It was of help.  It made me look harder and I found that it was actually
> reporting that build/Documentation/pt/ was missing.  Which it is.  The
> Documentation/pt/ directory is definitely missing from master but is present
> in stable/2.20.  I guess that someone has deleted references to it and so
> it's not getting copied into the build tree?  How do we find out which
> commit deleted the directory in git?
>
> --
> Phil Holmes
>

For reference I've looked into the branch
stable/2.18

~/lilypond-git ((e7a7fe4faf...))$ cd Documentation/pt/
bash: cd: Documentation/pt/: No such file or directory

Searching via gitk is without result as well in both, stable/2.20 and master.

Was Documentation/pt/ ever in master?

Cheers,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: 2.20 plans.

2018-10-12 Thread Jean-Julien Fleck
Hello,

>
> It was of help.  It made me look harder and I found that it was actually
> reporting that build/Documentation/pt/ was missing.  Which it is.  The
> Documentation/pt/ directory is definitely missing from master but is
> present
> in stable/2.20.  I guess that someone has deleted references to it and so
> it's not getting copied into the build tree?  How do we find out which
> commit deleted the directory in git?
>

I think that git bisect could help you if you know an old commit which have
for sure the given directory in it. See https://git-scm.com/docs/git-bisect

Cheers,

-- 
JJ Fleck
Physique et Informatique
PCSI1 Lycée Kléber
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: 2.20 plans.

2018-10-12 Thread Phil Holmes
- Original Message - 
From: "Thomas Morley" 

To: "Phil Holmes" 
Cc: "David Kastrup" ; "lilypond-devel" 
Sent: Friday, October 12, 2018 3:35 PM
Subject: Re: 2.20 plans.


Am Fr., 12. Okt. 2018 um 16:13 Uhr schrieb Phil Holmes 
:


- Original Message -
From: "David Kastrup" 
To: 
Sent: Monday, October 08, 2018 4:35 PM
Subject: 2.20 plans.


>
> Hi,
>
> I don't think there is much of a point in delaying more.  I've recently
> made another run through patches that should be in 2.20 and pushed to
> stable/2.20 branch.
>
> I think further integration work is as likely to destabilize as to
> stabilize stuff (if I not already did so), so the plan is to have
> a) let Phil release 2.19.83 as soon as he wants
> b) release 2.20.0 from that state (with a few cherry-picks on top) 
> about

> a week after the last urgent "stop the presses" call.  Those would
> involve synching up documentation and bug fixes so obviously important
> that one would rather see them in than give them some time for testing.
>
> This will be followed (as soon as the state of download/web pages and
> Phil's resources permit) with releasing 2.21.0 to get an unstable
> version to refer to.
>
> --
> David Kastrup


I'm getting a bizarre problem with 2.20.  I did my updates to VERSION, 
news,

etc. and ran a make to check all was OK.  It failed being unable to find
Documentation/pt/.  If I ls in a terminal, the directory is not shown. 
If I
look with Nautilus it's there.  I know it's been deleted in master, but 
not

in stable/2.20 and I really can't see why it should be there in the file
viewer but not via terminal.

Anyone any idea??

--
Phil Holmes


I have no problems to see and to access it:

hermann@kasten ~/lilypond-git (master)$ git checkout 
remotes/origin/stable/2.20

Checking out files: 100% (886/886), done.
Note: checking out 'remotes/origin/stable/2.20'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

 git checkout -b 

HEAD is now at ab3d2f7a26 Bump version
hermann@kasten ~/lilypond-git ((ab3d2f7a26...))$ cd Documentation/pt/
hermann@kasten ~/lilypond-git/Documentation/pt ((ab3d2f7a26...))$ ls
GNUmakefile  macros.itexi  search-box.ihtml  translations.itexi  web 
web.texi



Sorry to be of not more help,
 Harm


It was of help.  It made me look harder and I found that it was actually 
reporting that build/Documentation/pt/ was missing.  Which it is.  The 
Documentation/pt/ directory is definitely missing from master but is present 
in stable/2.20.  I guess that someone has deleted references to it and so 
it's not getting copied into the build tree?  How do we find out which 
commit deleted the directory in git?


--
Phil Holmes 



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: 2.20 plans.

2018-10-12 Thread Thomas Morley
Am Fr., 12. Okt. 2018 um 16:13 Uhr schrieb Phil Holmes :
>
> - Original Message -
> From: "David Kastrup" 
> To: 
> Sent: Monday, October 08, 2018 4:35 PM
> Subject: 2.20 plans.
>
>
> >
> > Hi,
> >
> > I don't think there is much of a point in delaying more.  I've recently
> > made another run through patches that should be in 2.20 and pushed to
> > stable/2.20 branch.
> >
> > I think further integration work is as likely to destabilize as to
> > stabilize stuff (if I not already did so), so the plan is to have
> > a) let Phil release 2.19.83 as soon as he wants
> > b) release 2.20.0 from that state (with a few cherry-picks on top) about
> > a week after the last urgent "stop the presses" call.  Those would
> > involve synching up documentation and bug fixes so obviously important
> > that one would rather see them in than give them some time for testing.
> >
> > This will be followed (as soon as the state of download/web pages and
> > Phil's resources permit) with releasing 2.21.0 to get an unstable
> > version to refer to.
> >
> > --
> > David Kastrup
>
>
> I'm getting a bizarre problem with 2.20.  I did my updates to VERSION, news,
> etc. and ran a make to check all was OK.  It failed being unable to find
> Documentation/pt/.  If I ls in a terminal, the directory is not shown.  If I
> look with Nautilus it's there.  I know it's been deleted in master, but not
> in stable/2.20 and I really can't see why it should be there in the file
> viewer but not via terminal.
>
> Anyone any idea??
>
> --
> Phil Holmes

I have no problems to see and to access it:

hermann@kasten ~/lilypond-git (master)$ git checkout remotes/origin/stable/2.20
Checking out files: 100% (886/886), done.
Note: checking out 'remotes/origin/stable/2.20'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b 

HEAD is now at ab3d2f7a26 Bump version
hermann@kasten ~/lilypond-git ((ab3d2f7a26...))$ cd Documentation/pt/
hermann@kasten ~/lilypond-git/Documentation/pt ((ab3d2f7a26...))$ ls
GNUmakefile  macros.itexi  search-box.ihtml  translations.itexi  web  web.texi


Sorry to be of not more help,
  Harm

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: 2.20 plans.

2018-10-12 Thread David Kastrup
"Phil Holmes"  writes:

>> Hi,
>>
>> I don't think there is much of a point in delaying more.  I've recently
>> made another run through patches that should be in 2.20 and pushed to
>> stable/2.20 branch.
>>
>> I think further integration work is as likely to destabilize as to
>> stabilize stuff (if I not already did so), so the plan is to have
>> a) let Phil release 2.19.83 as soon as he wants
>> b) release 2.20.0 from that state (with a few cherry-picks on top) about
>> a week after the last urgent "stop the presses" call.  Those would
>> involve synching up documentation and bug fixes so obviously important
>> that one would rather see them in than give them some time for testing.
>>
>> This will be followed (as soon as the state of download/web pages and
>> Phil's resources permit) with releasing 2.21.0 to get an unstable
>> version to refer to.
>
> I'm getting a bizarre problem with 2.20.  I did my updates to VERSION,
> news, etc. and ran a make to check all was OK.  It failed being unable
> to find Documentation/pt/.  If I ls in a terminal, the directory is
> not shown.  If I look with Nautilus it's there.

Nautilus may show files it knows that may be recovered from backup.

> I know it's been deleted in master,

Obviously I am not quite in the loop: why would we have done that?

> but not in stable/2.20 and I really can't see why it should be there
> in the file viewer but not via terminal.
>
> Anyone any idea??

I doubt we _have_ working Portuguese documentation for 2.20, so it is
likely that I cherrypicked too little or too much.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: 2.20 plans.

2018-10-12 Thread Phil Holmes
- Original Message - 
From: "David Kastrup" 

To: 
Sent: Monday, October 08, 2018 4:35 PM
Subject: 2.20 plans.




Hi,

I don't think there is much of a point in delaying more.  I've recently
made another run through patches that should be in 2.20 and pushed to
stable/2.20 branch.

I think further integration work is as likely to destabilize as to
stabilize stuff (if I not already did so), so the plan is to have
a) let Phil release 2.19.83 as soon as he wants
b) release 2.20.0 from that state (with a few cherry-picks on top) about
a week after the last urgent "stop the presses" call.  Those would
involve synching up documentation and bug fixes so obviously important
that one would rather see them in than give them some time for testing.

This will be followed (as soon as the state of download/web pages and
Phil's resources permit) with releasing 2.21.0 to get an unstable
version to refer to.

--
David Kastrup



I'm getting a bizarre problem with 2.20.  I did my updates to VERSION, news, 
etc. and ran a make to check all was OK.  It failed being unable to find 
Documentation/pt/.  If I ls in a terminal, the directory is not shown.  If I 
look with Nautilus it's there.  I know it's been deleted in master, but not 
in stable/2.20 and I really can't see why it should be there in the file 
viewer but not via terminal.


Anyone any idea??

--
Phil Holmes 



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Problem with guile-2.9.1-prerelease

2018-10-12 Thread David Kastrup
Thomas Morley  writes:

> Am Do., 11. Okt. 2018 um 21:25 Uhr schrieb Thomas Morley
> :
>
> 'make doc' (without rest-positioning.ly) now ended successfully (with
> guile-2.9.1)
>
> I then tried to apply your patch to my lilypond-git-guile-3.0 but I've got:
> $ git apply 0001-Use-different-values-implementation-of-Guilev2.patch
> error: patch failed: lily/lexer.ll:1107
> error: lily/lexer.ll: patch does not apply

A complete commit is applied using

git am

not git apply.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel