Re: add very short and Henze fermatas (issue 347080043 by lilyp...@maltemeyn.de)
Thanks for the review, I’ll use the correct indentation when pushing.
https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):
https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf#newcode122
mf/feta-scripts.mf:122: .. z6{up}
On 2019/03/04 05:05:02, lemzwerg wrote:
Indentation
Done.
https://codereview.appspot.com/347080043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)
The mf code looks fine, thanks! https://codereview.appspot.com/341560043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: add very short and Henze fermatas (issue 347080043 by lilyp...@maltemeyn.de)
LGTM, thanks!
https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf
File mf/feta-scripts.mf (right):
https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf#newcode122
mf/feta-scripts.mf:122: .. z6{up}
Indentation
https://codereview.appspot.com/347080043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: add fermata markup commands (issue 344160043 by lilyp...@maltemeyn.de)
Hm … Would this apply to the already existing script commands \shortfermata etc.? Then we would need a convert-ly rule. Good question. I see arguments for both directions, i.e., whether to stay with the commands, or to remove them. https://codereview.appspot.com/344160043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES - Countdown for March 3rd
Hello, Here is the current patch countdown list. The next countdown will be on March 6th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5477 Broken links in website pages - john-mandereau https://sourceforge.net/p/testlilyissues/issues/5477 http://codereview.appspot.com/361790043 Countdown: 5485 undefined operation (GCC warning) in page-turn-page-breaking.cc - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5485 http://codereview.appspot.com/351880043 5482 Do not build PDFs from the website Texinfo sources - john-mandereau https://sourceforge.net/p/testlilyissues/issues/5482 http://codereview.appspot.com/363930043 Review: 5490 Issue 5490: fix for wrong clefs.varC_change - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5490 http://codereview.appspot.com/361800043 5489 Issue 5489: improve prall glyphs - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5489 http://codereview.appspot.com/341560043 5487 add very short and Henze fermatas - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5487 http://codereview.appspot.com/347080043 New: No new patches at this time. Waiting: 5486 add fermata markup commands - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5486 http://codereview.appspot.com/344160043 *** Regards James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)
lilyp...@maltemeyn.de writes: > On 2019/03/03 12:20:41, dak wrote: >> More like >>str = re.sub (r'"scripts\.trilelement"', r'"scripts\.trillelement"', > str) > >> Sort of ironic to use raw strings here for the sake of easier >> backslash-quoting and then not even backslash-quote the necessary > parts. > > I don’t know anything about python and what the r before the strings > means. I just copied what I saw, that’s why I asked … I read "it is as easy" rather than the "is it as easy" you actually wrote. Sorry for that. Of course I also made a mistake since while the first dot needs quoting, the second doesn't. So it's more like str = re.sub (r'"scripts\.trilelement"', r'"scripts.trillelement"', str) -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)
On 2019/03/03 12:20:41, dak wrote: More like str = re.sub (r'"scripts\.trilelement"', r'"scripts\.trillelement"', str) Sort of ironic to use raw strings here for the sake of easier backslash-quoting and then not even backslash-quote the necessary parts. I don’t know anything about python and what the r before the strings means. I just copied what I saw, that’s why I asked … https://codereview.appspot.com/341560043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)
lilyp...@maltemeyn.de writes: > On 2019/03/03 09:37:01, thomasmorley651 wrote: >> Thanks for correcting the imho wrong spelling of "trilelement". >> Please add a conversion rule for it. Sometimes I used "trilelement" > and maybe >> I'm not the only one. > > Is it as easy as adding > > str = re.sub (r'"scripts.trilelement"', r'"scripts.trillelement"', > str) More like str = re.sub (r'"scripts\.trilelement"', r'"scripts\.trillelement"', str) Sort of ironic to use raw strings here for the sake of easier backslash-quoting and then not even backslash-quote the necessary parts. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)
On 2019/03/03 09:37:01, thomasmorley651 wrote:
Thanks for correcting the imho wrong spelling of "trilelement".
Please add a conversion rule for it. Sometimes I used "trilelement"
and maybe
I'm not the only one.
Is it as easy as adding
str = re.sub (r'"scripts.trilelement"', r'"scripts.trillelement"',
str)
directly after the powerChords rule (line 3979 of convertrules.py)? Or
are there more places where changes should be made?
I thought about adding \musicglyph to the rule above but then the
following wouldn’t be converted correctly:
$@(map (lambda (x) (markup #:musicglyph x))
'("scripts.trill"
"scripts.trillelement"))
https://codereview.appspot.com/341560043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 5490: fix for wrong clefs.varC_change (issue 361800043 by lilyp...@maltemeyn.de)
Reviewers: , Message: To see the difference between 2.19.82, master and the proposed fix, try \markup \box \musicglyph #"clefs.varC" \markup \box \musicglyph #"clefs.varC_change" Description: Issue 5490: fix for wrong clefs.varC_change For solving Issue 5278 I changed the bounding box of the varC clefs whithout noticing that the height of the vertical bars relies on the box height. This commit fixes that. Please review this at https://codereview.appspot.com/361800043/ Affected files (+2, -0 lines): M mf/feta-clefs.mf Index: mf/feta-clefs.mf diff --git a/mf/feta-clefs.mf b/mf/feta-clefs.mf index b04ff2407d0d06ba27cb042f1b0bb5cc772f8016..de1ec90594b622ec11a9fbd5d33149d83ca79b80 100644 --- a/mf/feta-clefs.mf +++ b/mf/feta-clefs.mf @@ -195,6 +195,8 @@ def draw_varc_clef (expr reduction) = % make unreduced glyph fit exactly into five staff lines if reduction = 1: h := d := 2 staff_space_rounded; + else: + h := d := 2 reduced_ss; fi; % assure that the gap between the left and right stem ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)
Thanks for correcting the imho wrong spelling of "trilelement". Please add a conversion rule for it. Sometimes I used "trilelement" and maybe I'm not the only one. https://codereview.appspot.com/341560043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)
Reviewers: ,
https://codereview.appspot.com/341560043/diff/1/mf/feta-trills.mf
File mf/feta-trills.mf (right):
https://codereview.appspot.com/341560043/diff/1/mf/feta-trills.mf#newcode265
mf/feta-trills.mf:265: .. tension 0.95
I’ll fix this indentation error before pushing, I don’t think this needs
another patchset.
Description:
Issue 5489: improve prall glyphs
• rename trilelement → trillelement
• fix erroneous shape of pralldown/prallup
• enlarge arc of downprall/pralldown
• move and shorten line of lineprall
Please review this at https://codereview.appspot.com/341560043/
Affected files (+27, -21 lines):
M mf/feta-trills.mf
Index: mf/feta-trills.mf
diff --git a/mf/feta-trills.mf b/mf/feta-trills.mf
index
93530fb8a2cd647d69305349a6eab319c5aaff75..d27ac292b536ade9a821ce761ef90755c416e0ec
100644
--- a/mf/feta-trills.mf
+++ b/mf/feta-trills.mf
@@ -39,7 +39,8 @@ trill_ne := unitvector ((2, 3));
% The trill element sticks out on both the left and right side
% of the normal bbox, so you can glue them together easily.
%
-% `ending' is either 0 for none, 1 for left, or 2 for right.
+% `ending' is either 0 for none, 1 for left, 2 for right,
+% or 3/4 for longer endings left/right.
%
def draw_trillelement (expr offset, ending) =
@@ -79,7 +80,12 @@ begingroup;
pat := pat shifted (offset, 0);
fill pat;
- z4 = z1 - trill_ne * trill_overlap;
+ if (ending = 3) or (ending = 4):
+ z4 = z1 - trill_ne * trill_overlap * 2;
+ else:
+ z4 = z1 - trill_ne * trill_overlap;
+ fi;
+
x4 := hround (x4 + 0.5 trill_thin) - 0.5 trill_thin;
pat := (z4 - nw_dist){-trill_ne}
@@ -90,9 +96,9 @@ begingroup;
-- (z1 - nw_dist){-trill_ne}
-- cycle;
- if ending = 1:
+ if (ending = 1) or (ending = 3):
fill pat shifted (offset, 0);
- elseif ending = 2:
+ elseif (ending = 2) or (ending = 4):
pat := pat scaled -1 shifted (-feta_eps, -feta_eps);
fill pat shifted (offset, 0);
fi;
@@ -100,7 +106,7 @@ endgroup;
enddef;
-fet_beginchar ("trilelement", "trilelement");
+fet_beginchar ("trillelement", "trillelement");
set_char_box (.5 trill_width#, .5 trill_width#,
trill_height#, trill_height#);
@@ -227,11 +233,11 @@ fet_beginchar ("upmordent", "upmordent");
fet_endchar;
-fet_beginchar ("pralldown", "pralldown");
+fet_beginchar ("prallup", "prallup");
set_char_box (1.5 trill_width#, 1.5 trill_width#,
trill_height#, trill_height#);
- currentpicture := remember_pic xscaled -1;
+ currentpicture := remember_pic rotated 180;
fet_endchar;
@@ -239,25 +245,25 @@ fet_beginchar ("downprall", "downprall");
set_char_box (1.5 trill_width#, 1.5 trill_width#,
trill_height#, trill_height#);
- draw_trillelement (-trill_width, 1);
- draw_trillelement (0, 0);
draw_trillelement (trill_width, 2);
+ draw_trillelement (0, 0);
+ draw_trillelement (-trill_width, 3);
z11 = z4 shifted (-trill_width, 0);
- z12 = z11 + (0, 2 trill_height);
+ z12 = z11 + (0, 2.25 trill_height);
- penpos11 (trill_thin, angle (trill_ne xscaled -1) - 90);
- penpos12 (trill_thin, angle (trill_ne) - 90);
+ penpos11 (trill_thin, angle (trill_ne xscaled -1) - 80);
+ penpos12 (trill_thin, angle (trill_ne) - 80);
penlabels (11, 12);
pickup pencircle scaled trill_stemwidth;
- fill z11l{trill_ne xscaled -1}
-.. z12l{trill_ne}
+ fill z11l{trill_ne xscaled -1 rotated 10}
+.. z12l{trill_ne rotated -10}
.. top z12
-.. rt z12
-.. z12r{-trill_ne}
-.. z11r{-trill_ne xscaled -1}
+.. z12r{-trill_ne rotated -10}
+.. tension 0.95
+.. z11r{-trill_ne xscaled -1 rotated 10}
-- cycle;
remember_pic := currentpicture;
@@ -285,19 +291,19 @@ fet_beginchar ("downmordent", "downmordent");
fet_endchar;
-fet_beginchar ("prallup", "prallup");
+fet_beginchar ("pralldown", "pralldown");
set_char_box (1.5 trill_width#, 1.5 trill_width#,
trill_height#, trill_height#);
- currentpicture := remember_pic xscaled -1;
+ currentpicture := remember_pic rotated 180;
fet_endchar;
fet_beginchar ("lineprall", "lineprall");
set_char_box (1.5 trill_width#, 1.5 trill_width#,
- trill_height#, 4 trill_height#);
+ trill_height#, 3.2 trill_height#);
- draw_trillelement (-trill_width, 1);
+ draw_trillelement (-trill_width, 3);
labels (1, 2, 3, 3', 4, 5, 5');
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
