Replace deprecated functions from string module (issue 566920044 by jonas.hahnf...@gmail.com)
For someone who doesn’t know python two questions come up:
1. Why do you sometimes use " " and sometimes ' '?
2. Is a space (" " or ' ') the default for the old string.join? Or
should you use an empty string ("".join()) instead in some places of the
new version?
https://codereview.appspot.com/566920044/diff/549120043/python/musicexp.py
File python/musicexp.py (right):
https://codereview.appspot.com/566920044/diff/549120043/python/musicexp.py#newcode694
python/musicexp.py:694: % " ".join (map (lambda x: x.lisp_expression(),
Here you use " " …
https://codereview.appspot.com/566920044/diff/549120043/python/musicexp.py#newcode1040
python/musicexp.py:1040: printer ('<%s>' % ' '.join (pitches))
… and here ' '.
https://codereview.appspot.com/566920044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES - Countdown for October 23rd
Hello, Here is the current patch countdown list. The next countdown will be on October 25th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5580 Replace deprecated functions from string module - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5580 http://codereview.appspot.com/566920044 5579 fix stem tremolo on rests crash - Malte Meyn https://sourceforge.net/p/testlilyissues/issues/5579 http://codereview.appspot.com/563170043 5578 Add a button to flip between old and new regtest images - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5578 http://codereview.appspot.com/566920043 5577 scripts/build: Remove unused scripts - Jonas Hahnfeld https://sourceforge.net/p/testlilyissues/issues/5577 http://codereview.appspot.com/551100044 Countdown: No patches on Countdown at this time. Review: 5581 Fix underline-markup to make multiple calls have nice output - Thomas Morley https://sourceforge.net/p/testlilyissues/issues/5581 http://codereview.appspot.com/559150043 5584 Rehabilitate regtest workflow - Dan Eble https://sourceforge.net/p/testlilyissues/issues/5584 http://codereview.appspot.com/571030043 New: No new patches at this time. *** Regards, James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Replace deprecated functions from string module (issue 566920044 by jonas.hahnf...@gmail.com)
On 2019/10/23 21:22:16, Malte Meyn wrote:
2. Is a space (" " or ' ') the default for the old string.join? Or
should you
use an empty string ("".join()) instead in some places of the new
version?
Ok, I found an answer to that question myself. The default is a space
indeed. Weird. https://docs.python.org/2/library/string.html
https://codereview.appspot.com/566920044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: make test-redo
On Oct 14, 2019, at 21:59, Dan Eble wrote: > > On Oct 14, 2019, at 18:27, Carl Sorensen wrote: >> >> What is the defect you are seeing? The last time I tried it, it worked as >> described in the CG. > > I wiped my build directory and ran these commands with master @ fa6c70e39a. > […] I think I've fixed the problems. https://sourceforge.net/p/testlilyissues/issues/5584/ — Dan ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5584: Rehabilitate regtest workflow (issue 571030043 by nine.fierce.ball...@gmail.com)
LGTM, thanks! https://codereview.appspot.com/571030043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)
> On Oct 23, 2019, at 12:36, David Kastrup wrote: > > "James Lowe" writes: > > Fixes should always be to staging rather than master but I guess that's > what you meant. It depends on just how old the problem is whether one > tries to hotfix it. Baselines created after this commit (a few back from the current tip of master) will create out-test-baseline/share as a symlink. 0d7744aad0 Issue 5572/1: Compile modified C++ files automatically before testing — Dan ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)
"James Lowe" writes: > Hello, > > On Wed, 23 Oct 2019 06:39:24 -0700, nine.fierce.ball...@gmail.com wrote: > >> Reviewers: , >> >> Description: >> https://sourceforge.net/p/testlilyissues/issues/5583/ >> >> I ran into a problem running "make ... doc" today, where www_post was >> trying unsuccessfully to mirror a symlink in an out-test-baseline >> subdirectory. > > OK good, it wasn't just me. I hit this today but as I am at work I > didn't get time to look and was planning this evening. > > I am not sure which commit this was but normally we should revert it > right? NOt just patch over it in master? Fixes should always be to staging rather than master but I guess that's what you meant. It depends on just how old the problem is whether one tries to hotfix it. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)
Dan Eble writes: >> On Oct 23, 2019, at 12:36, David Kastrup wrote: >> >> "James Lowe" writes: >> >> Fixes should always be to staging rather than master but I guess that's >> what you meant. It depends on just how old the problem is whether one >> tries to hotfix it. > > Baselines created after this commit (a few back from the current tip > of master) will create out-test-baseline/share as a symlink. > > 0d7744aad0 Issue 5572/1: Compile modified C++ files automatically before > testing > — > Dan I've no qualified opinion about this one. If you think it's messing up current testing, feel free to push the fix to staging without waiting for count-down etc (I doubt there will be much further feedback) if you are reasonably confident that this will address it. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)
Hello, On Wed, 23 Oct 2019 06:39:24 -0700, nine.fierce.ball...@gmail.com wrote: > Reviewers: , > > Description: > https://sourceforge.net/p/testlilyissues/issues/5583/ > > I ran into a problem running "make ... doc" today, where www_post was > trying unsuccessfully to mirror a symlink in an out-test-baseline > subdirectory. OK good, it wasn't just me. I hit this today but as I am at work I didn't get time to look and was planning this evening. I am not sure which commit this was but normally we should revert it right? NOt just patch over it in master? James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 5584: Rehabilitate regtest workflow (issue 571030043 by nine.fierce.ball...@gmail.com)
Reviewers: , Description: https://sourceforge.net/p/testlilyissues/issues/5584/ 0. fix repeated test runs for input/regression/midi this is issue 5582 but other changes in this review depend on it 1. fix multiple rules for target collated-files.list 2. don't create the output dir just to remove it 3. include count of added/removed regtests in summary 4. sort changed.txt and ensure a final newline 5. rehabilitate regtest workflow "make test-baseline" now incorporates "make test-clean" "make check" now works as make test-redo was supposed to: changed test cases are re-tested 6. Contributor's Guide updates Please review this at https://codereview.appspot.com/571030043/ Affected files (+82, -57 lines): M Documentation/contributor/programming-work.itexi M Documentation/contributor/regressions.itexi M GNUmakefile.in M input/regression/lilypond-book/GNUmakefile M input/regression/midi/GNUmakefile M make/lysdoc-rules.make M make/lysdoc-targets.make M make/lysdoc-vars.make M make/midi-rules.make M make/midi-vars.make M scripts/build/output-distance.py M stepmake/stepmake/generic-targets.make M stepmake/stepmake/texinfo-rules.make M stepmake/stepmake/toplevel-targets.make ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)
Reviewers: ,
Description:
https://sourceforge.net/p/testlilyissues/issues/5583/
I ran into a problem running "make ... doc" today, where www_post was
trying unsuccessfully to mirror a symlink in an out-test-baseline
subdirectory.
I looked around for information that would justify mirroring the
baseline and found none, so I've solved the problem by excluding it. If
you know better, please speak up.
Please review this at https://codereview.appspot.com/565170043/
Affected files (+2, -2 lines):
M scripts/build/www_post.py
Index: scripts/build/www_post.py
diff --git a/scripts/build/www_post.py b/scripts/build/www_post.py
index
3af2b64d8ed91a6aa9f37b28bc681b4736280ef6..24afd8ef99827aca516c68e92abb9ae61bf21e1c
100644
--- a/scripts/build/www_post.py
+++ b/scripts/build/www_post.py
@@ -46,7 +46,7 @@ dirs, symlinks, files = mirrortree.walk_tree (
tree_roots = doc_dirs,
process_dirs = outdir,
exclude_dirs = '(^|/)((' + \
-r'po|xref-maps|out|out-test|out-cov|.*?[.]t2d|\w*?-root)|
^Documentation/(' + \
+r'po|xref-maps|out|out-test(-baseline)?|out-cov|.*?[.]t2d|
\w*?-root)|^Documentation/(' + \
'|'.join ([l.code for l in langdefs.LANGUAGES]) + '))(/|$)',
find_files = r'.*?\.(?:midi|html|pdf|png|jpe?g|txt|i?ly|signature|css|
zip|js|..\.idx|php)$|VERSION',
exclude_files = r'lily-[0-9a-f]+.*\.(pdf|txt)')
@@ -54,7 +54,7 @@ dirs, symlinks, files = mirrortree.walk_tree (
extra_files = mirrortree.walk_tree (
tree_roots = ['input/regression/lilypond-book'],
process_dirs = outdir,
-exclude_dirs = r'(^|/)(out|out-test)(/|$)',
+exclude_dirs = r'(^|/)(out|out-test(-baseline)?)(/|$)',
find_files = r'.+\.(info|tex)$',
exclude_files = r'lily-[0-9a-f]+.*\.tex')[2]
files.extend(extra_files)
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
