Re: Issue 5578: add a button to flip between old and new regtest images (take 2) (issue 573160047 by nine.fierce.ball...@gmail.com)

2019-11-02 Thread Thaovy231011

https://codereview.appspot.com/573160047/



Re: git-cl upload and existing sf issues

2019-11-02 Thread Dan Eble
On Nov 2, 2019, at 12:35, Dan Eble  wrote:
> 
>> when uploading a first patch set, git-cl asks for a sourceforge issue 
>> number. If a new issue is created, everything is fine but when you choose an 
>> existing issue, there is some 404 error and the Rietveld link is not added 
>> to the sf issue—resulting in a missing Rietveld link on 
>> www.philholmes.net/lilypond/allura/ Does anybody know why that is happening?
> 
> I'll investigate.  Don't subscribe to this ticket unless you want to be 
> interrupted frequently. :)
> 
> https://sourceforge.net/p/testlilyissues/issues/5591/

Here's the fix.  I'll close the LilyPond ticket after it's pulled.

https://github.com/gperciva/git-cl/pull/5

During testing, I noticed that http://www.philholmes.net/lilypond/allura/ 
presents the link for the first review rather than the latter review. I don't 
think that's desirable, but it's a separate issue.
— 
Dan




Re: git-cl upload and existing sf issues

2019-11-02 Thread Dan Eble
On Sep 30, 2019, at 16:54, Malte Meyn  wrote:
> 
> when uploading a first patch set, git-cl asks for a sourceforge issue number. 
> If a new issue is created, everything is fine but when you choose an existing 
> issue, there is some 404 error and the Rietveld link is not added to the sf 
> issue—resulting in a missing Rietveld link on 
> www.philholmes.net/lilypond/allura/ Does anybody know why that is happening?

I'll investigate.  Don't subscribe to this ticket unless you want to be 
interrupted frequently. :)

https://sourceforge.net/p/testlilyissues/issues/5591/
— 
Dan




gub build succeeds

2019-11-02 Thread Werner LEMBERG


As the title says: A complete gub build succeeds again on my GNU/Linux
openSUSE platform if I apply

  https://github.com/gperciva/gub/pull/70

to gub's master branch.


Werner



PATCHES - Countdown for November 2nd

2019-11-02 Thread James Lowe
Hello,

Here is the current patch countdown list. The next countdown will be on
November 4th.


A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/


Push:

5590 Remove dead code from Dot_formatting_problem - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/5590
http://codereview.appspot.com/583100043

5589 Replace file() by open() - Jonas Hahnfeld
https://sourceforge.net/p/testlilyissues/issues/5589
http://codereview.appspot.com/554930043

5588 fix color-profile warning in output-distance - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/5588
http://codereview.appspot.com/545100043

5587 allow configure --enable-ubsan - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/5587
http://codereview.appspot.com/575180043

5585 doc: Update section on "commit access" - Jonas Hahnfeld
https://sourceforge.net/p/testlilyissues/issues/5585
http://codereview.appspot.com/566930043

5584 Rehabilitate regtest workflow - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/5584
http://codereview.appspot.com/571030043

5576 make output-distance less verbose by default - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/5576
http://codereview.appspot.com/581220043

Countdown: No patches on Countdown at this time.

Review: No patches on Review at this time.

New:

5578 Add a button to flip between old and new regtest images - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/5578
http://codereview.appspot.com/573160047



***

Regards,

James