Re: \epsfile

[Martin Tarenskeen]

On Fri, 15 Nov 2019, Martin Tarenskeen wrote:

Related issue: When using frescobaldi the syntax help and autocompletion 
balloon gives "\eps-file" instead of "\epsfile". A little bug?


Reported it on github.

https://github.com/frescobaldi/frescobaldi/issues/1213

An issue in musicxml2ly's LilyPond code generation

[Jacques Menu]

Hello folks,

At 
https://github.com/grame-cncm/libmusicxml/tree/lilypond/files/samples/musicxml/challenging,
 you’ll find a MusicXML version of Beethoven’s Ninth Symphony:

menu@macbookprojm: ~/libmusicxml-git/files/samples/musicxml > ll 
challenging/BeethovenNinthSymphony*
165888 -rw-r--r--@ 1 menu  staff  69542182 Oct 20 18:08:27 2019 
challenging/BeethovenNinthSymphony.xml
  7240 -rw-r--r--  1 menu  staff   3704645 Nov 16 00:42:13 2019 
challenging/BeethovenNinthSymphony_musicxml2.ly
 32776 -rw-r--r--  1 menu  staff  15775302 Nov 16 00:05:06 2019 
challenging/BeethovenNinthSymphony_xml2ly.ly

BeethovenNinthSymphony_musicxml2.ly is the result of translating 
BeethovenNinthSymphony.xml with musicxml2ly, as of 2.19.83.

It starts with:

\version "2.19.83"
% automatically converted by musicxml2ly from 
challenging/BeethovenNinthSymphony.xml
\pointAndClickOff

%% additional definitions required by the score:
p espress = #(make-dynamic-script "p espress")
pi f = #(make-dynamic-script "pi f")
sempre pi p = #(make-dynamic-script "sempre pi p")
sempre  = #(make-dynamic-script "sempre ")
p dolce = #(make-dynamic-script "p dolce")
un poco meno p = #(make-dynamic-script "un poco meno p")
sempre pp = #(make-dynamic-script "sempre pp")
espress. = #(make-dynamic-script "espress.")
sempre f = #(make-dynamic-script "sempre f")
sempre ff = #(make-dynamic-script "sempre ff")
p dolce  = #(make-dynamic-script "p dolce ")
sempre p = #(make-dynamic-script "sempre p")
mezza voce = #(make-dynamic-script "mezza voce")
pi p = #(make-dynamic-script "pi p")
sempre pi f = #(make-dynamic-script "sempre pi f")
pp sotto voce = #(make-dynamic-script "pp sotto voce")
sotto voce = #(make-dynamic-script "sotto voce")
poco f = #(make-dynamic-script "poco f")
p espress. = #(make-dynamic-script "p espress.")
… … … … … 

in which the macro names such as 'p espress’ contain spaces.

JM

Working on issue 665, how to proceed?

[lilypond]

In the last weeks I did write a start of a lilypond -> musicxml solution.

 

What I have written so far is creating musicxml files which contains all
partials time signatures, keys, notes, slurs, ties, staffs and staff
grouping, as well as support for most accidentals, barlines, lyrics, beams,
tupplets, forced linebreaks and pagebreaks.  There is partial support for
tempo (only =bps ). Also most header information  (title, composer
etc) is put in the xml document

What not is handled graceful is NullVoice (is just added to the staff).

 

Fermata, CueVoice, Figured bass, stems, repeat endings, special noteheads
are not handled at all (at this moment).

Also (apart from line end page breaks) no engraving information is added to
the musicxml

 

Anyone who is interested in the code can have a look at

https://github.com/de-wolff/lilypond/ in the branch musicxml

 

You only need musicxml.scm xml-library.scm and musicxml.ly.

Then you can include musicxml.ly in your music.ly, and put a line \musicxml
\mycomplexmusic in it The music can be the total expression as you put it
normally in a score, including staffs, staffgoups, lyrics etc.

 

As this is an (old) issue, there is need to put this in lilypond, but how?
What level of quality is needed? Who can help me to join the lilypond
developer group?

 

Jaap

 

 

 

Re: Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

[Carl . D . Sorensen]

I have not reviewed the code, but this looks like a worthwhile addition.
 Thanks for doing it!

I think the name should be changed from MeasureAttachedSpanner to
BarAttachedSpanner.  A measure is the interval between bar lines.  The
spanner is attached to the bar line.  While it requires some work, I
think it's worth making the change to be more clear in our terminology.

Thanks,

Carl


https://codereview.appspot.com/571180043/

Implement MeasureAttachedSpanner (issue 571180043 by david.nales...@gmail.com)

[lemzwerg--- via Discussions on LilyPond development]

LGTM from reading the code without testing.  Thanks!


https://codereview.appspot.com/571180043/diff/565230043/input/regression/measure-spanner.ly
File input/regression/measure-spanner.ly (right):

https://codereview.appspot.com/571180043/diff/565230043/input/regression/measure-spanner.ly#newcode5
input/regression/measure-spanner.ly:5: Measure attached spanners can
span single and multiple
Shouldn't this be rather

  Measure-attached spanners ...

?

https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc
File lily/measure-attached-spanner.cc (right):

https://codereview.appspot.com/571180043/diff/565230043/lily/measure-attached-spanner.cc#newcode96
lily/measure-attached-spanner.cc:96: }
The `}' is not aligned with `{'.  Maybe incorrect use of tabs?

https://codereview.appspot.com/571180043/diff/565230043/scm/define-music-types.scm
File scm/define-music-types.scm (right):

https://codereview.appspot.com/571180043/diff/565230043/scm/define-music-types.scm#newcode313
scm/define-music-types.scm:313:
In case this a hard line break between `measure-' and `attached', please
avoid it (and do the line break before `measure-').

https://codereview.appspot.com/571180043/diff/565230043/scm/scheme-engravers.scm
File scm/scheme-engravers.scm (right):

https://codereview.appspot.com/571180043/diff/565230043/scm/scheme-engravers.scm#newcode172
scm/scheme-engravers.scm:172: This engraver creates spanners bounded by
the columns which start and
s/which/that/

https://codereview.appspot.com/571180043/

git-cl patch: remove some redundant text from tracker fields

[Dan Eble]

Please review.  This handles a couple of details I'd rather not have to 
remember to do when submitting the patch or fix after the fact.  I've exercised 
these changes for the last few LilyPond patches I've uploaded.

https://github.com/gperciva/git-cl/pull/6

Thanks,
— 
Dan

Re: shepherd a patch?

[Kieren MacMillan]

Hi David,

> this is something that I've wanted and Kieren has clamored for...

Yes! I’m so excited to see this progress.

Thanks!
Kieren.

Re: shepherd a patch?

[David Nalesnik]

James and all,

On Fri, Nov 15, 2019 at 7:31 AM David Nalesnik  wrote:
>
> On Fri, Nov 15, 2019 at 4:31 AM James Lowe  wrote:
> >
> > David et al.

> > >
> > > Am 15.11.19 um 04:10 schrieb David Nalesnik:

> > > > Would someone be willing to shepherd the patch for me?

> >
> > What I would suggest (generally to anyone on this list that ever needs a 
> > patch shepherding) is to make sure a tracker exists - @David, as I know you 
> > have access to create tickets you can at least do this - and then attach 
> > your patch to that and set the tracker to 'started' so that at the very 
> > least if (for example) Urs forgets, goes on holiday, has some emergency, 
> > that I can at least pick it up/detect it on the countdown and put it up for 
> > review myself.
> >
> > I do this all the time for 'drive by' patches.
> >
> > James
> >
>
> Thanks for this explanation.  I discovered that my patch had gone to
> Rietveld, only no ticket was created.  So the error has to do with the
> issue tracker.  Here's hoping that it's possible to do what's left
> manually without too much trouble!
>
> Best,
> David

OK, I _think_ all is well.  I created this issue
https://sourceforge.net/p/testlilyissues/issues/5602/
and provided a link to the Rietveld issue.

Best,
David

Re: shepherd a patch?

[Urs Liska]

Am 15. November 2019 14:35:26 MEZ schrieb David Nalesnik 
:
>On Fri, Nov 15, 2019 at 12:33 AM Urs Liska 
>wrote:
>>
>> Hi David,
>>
>> I feel responsible for this because I know where this is coming from 
>;-)
>
>Hah! :)  (Seriously, though, this is something that I've wanted and
>Kieren has clamored for...)

Ah yes, you said so back then.

Coincidentally, you can see lots if examples in the project that was released 
this week.

Urs
>

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Re: shepherd a patch?

[David Nalesnik]

Federico,

On Fri, Nov 15, 2019 at 6:39 AM Federico Bruni  wrote:

>
> This is what's recommended in the README:
> https://github.com/fedelibre/LilyDev/tree/master/mkosi#running-graphical-applications-from-the-container
>

I saw this, but I'm running LilyDev from a Win10 host.

David

Re: shepherd a patch?

[David Nalesnik]

On Fri, Nov 15, 2019 at 12:33 AM Urs Liska  wrote:
>
> Hi David,
>
> I feel responsible for this because I know where this is coming from  ;-)

Hah! :)  (Seriously, though, this is something that I've wanted and
Kieren has clamored for...)

>
> You can send me the patch. However, it's a long time since I uploaded
> anything, so I'm not sure my set-up still works. But I'll try.
>
> Best
> Urs

I appreciate this very much!  Turns out, I may be able to do this
manually.  (A Rietveld issue is
created--https://codereview.appspot.com/571180043/  just no tracker
issue.)

I will let you know!

David

Re: shepherd a patch?

[David Nalesnik]

On Fri, Nov 15, 2019 at 4:31 AM James Lowe  wrote:
>
> David et al.
>
> On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska  wrote:
>
> > Hi David,
> >
> > I feel responsible for this because I know where this is coming from  ;-)
> >
> > You can send me the patch. However, it's a long time since I uploaded
> > anything, so I'm not sure my set-up still works. But I'll try.
> >
> > Best
> > Urs
> >
> > Am 15.11.19 um 04:10 schrieb David Nalesnik:
> > > Hi all,
> > >
> > > I have a patch which implements measure-attached spanners.  I am
> > > having a devil of a time getting the patch up for review.  I simply
> > > can't get git-cl to upload it.  (I suspect this has something to do
> > > with the number of files it touches--my system times out before
> > > everything can be uploaded.)
> > >
> > > Would someone be willing to shepherd the patch for me?
> > >
> > > Attached is a PNG which shows the output of one of the regtests.
> > >
> > > This would _really_ be appreciated.  Thanks!
> > >
> > > David
>
> What I would suggest (generally to anyone on this list that ever needs a 
> patch shepherding) is to make sure a tracker exists - @David, as I know you 
> have access to create tickets you can at least do this - and then attach your 
> patch to that and set the tracker to 'started' so that at the very least if 
> (for example) Urs forgets, goes on holiday, has some emergency, that I can at 
> least pick it up/detect it on the countdown and put it up for review myself.
>
> I do this all the time for 'drive by' patches.
>
> James
>

Thanks for this explanation.  I discovered that my patch had gone to
Rietveld, only no ticket was created.  So the error has to do with the
issue tracker.  Here's hoping that it's possible to do what's left
manually without too much trouble!

Best,
David

Re: shepherd a patch?

[David Nalesnik]

On Fri, Nov 15, 2019 at 2:19 AM Jonas Hahnfeld  wrote:
>
> Hi David,
>
> Am Donnerstag, den 14.11.2019, 21:10 -0600 schrieb David Nalesnik:
>
> Hi all,
>
>
> I have a patch which implements measure-attached spanners.  I am
>
> having a devil of a time getting the patch up for review.  I simply
>
> can't get git-cl to upload it.  (I suspect this has something to do
>
> with the number of files it touches--my system times out before
>
> everything can be uploaded.)
>
>
> based on your other messages, you're using LilyDev when running git-cl? If 
> you say it times out, I would guess that git-cl waiting for you to authorize 
> the tool. Usually, it opens a browser for that, but that's probably not going 
> to work under a headless VM / container?
> Did you try running git-cl from your host system?
>
> Jonas

Ugh.  My failing memory.  Several years ago I did need to upload the
patch from git-cl on an Ubuntu machine outside of LilyDev.  The output
I got on the Win10 machine that hosts LilyDev would give me output
similar to the following:

[dev@lilydev:lilypond-git]$ git-cl upload origin/master
 input/regression/measure-spanner-spacing-pair.ly |  33 +
 input/regression/measure-spanner.ly  |  30 +
 lily/bracket.cc  |  10 +-
 lily/enclosing-bracket.cc|   4 +-
 lily/include/bracket.hh  |   3 +-
 lily/include/measure-attached-spanner.hh |  34 +
 lily/measure-attached-spanner.cc | 151 +++
 ly/spanners-init.ly  |   4 +
 scm/define-event-classes.scm |   1 +
 scm/define-grobs.scm |  22 
 scm/define-music-types.scm   |   6 +
 scm/scheme-engravers.scm |  63 ++
 12 files changed, 353 insertions(+), 8 deletions(-)
Upload server: codereview.appspot.com (change with -s/--server)
Your browser has been opened to visit:

https://codereview.appspot.com/get-access-token?port=8001

If your browser is on a different machine then exit and re-run
upload.py with the command-line parameter

  --no_oauth2_webbrowser

Issue created. URL: http://codereview.appspot.com/566970043
Uploading base file for input/regression/measure-spanner-spacing-pair.ly
Uploading base file for scm/define-event-classes.scm
Uploading base file for scm/scheme-engravers.scm
Uploading base file for scm/define-grobs.scm
Traceback (most recent call last):
  File "/home/dev/git-cl/git-cl", line 628, in 
sys.exit(main(sys.argv))
  File "/home/dev/git-cl/git-cl", line 622, in main
return func(argv[2:])
  File "/home/dev/git-cl/git-cl", line 335, in CmdUpload
issue, patchset = upload.RealMain(['upload'] + upload_args + args)
  File "/home/dev/git-cl/upload.py", line 2693, in RealMain
vcs.UploadBaseFiles(issue, rpc_server, patches, patchset, options, files)
  File "/home/dev/git-cl/upload.py", line 1220, in UploadBaseFiles
print t.get(timeout=60)
  File "/usr/lib/python2.7/multiprocessing/pool.py", line 567, in get
raise self._value
urllib2.URLError: 
[dev@lilydev:lilypond-git]$

--

I see now that a Rietveld issue is created with all my changes present.
https://codereview.appspot.com/571180043/
However, no issue is created on the Allura tracker.

I presume that it is possible to do what remains in the issue tracker
without having to run git-cl successfully?

Thanks for your help!
David

Re: git-cl command not found

[Federico Bruni]

Il giorno gio 14 nov 2019 alle 20:56, David Nalesnik 
 ha scritto:

 It's not in your PATH ?


Ah yes.  Duh.  Didn't think to check b/c I figured this would just
work out of the box.


It should work out of the box, see:
https://github.com/fedelibre/LilyDev/blob/master/mkosi/debian/mkosi.postinst#L34

Which version of LilyDev are you running and how?

Re: shepherd a patch?

[Federico Bruni]

Il giorno ven 15 nov 2019 alle 09:19, Jonas Hahnfeld via Discussions on 
LilyPond development  ha scritto:

Hi David,

Am Donnerstag, den 14.11.2019, 21:10 -0600 schrieb David Nalesnik:

 Hi all,

 I have a patch which implements measure-attached spanners.  I am
 having a devil of a time getting the patch up for review.  I simply
 can't get git-cl to upload it.  (I suspect this has something to do
 with the number of files it touches--my system times out before
 everything can be uploaded.)


based on your other messages, you're using LilyDev when running 
git-cl?

If you say it times out, I would guess that git-cl waiting for you to
authorize the tool. Usually, it opens a browser for that, but that's
probably not going to work under a headless VM / container?
Did you try running git-cl from your host system?



This is what's recommended in the README:
https://github.com/fedelibre/LilyDev/tree/master/mkosi#running-graphical-applications-from-the-container

Re: shepherd a patch?

[James Lowe]

David et al.

On Fri, 15 Nov 2019 07:33:01 +0100, Urs Liska  wrote:

> Hi David,
> 
> I feel responsible for this because I know where this is coming from  ;-)
> 
> You can send me the patch. However, it's a long time since I uploaded 
> anything, so I'm not sure my set-up still works. But I'll try.
> 
> Best
> Urs
> 
> Am 15.11.19 um 04:10 schrieb David Nalesnik:
> > Hi all,
> >
> > I have a patch which implements measure-attached spanners.  I am
> > having a devil of a time getting the patch up for review.  I simply
> > can't get git-cl to upload it.  (I suspect this has something to do
> > with the number of files it touches--my system times out before
> > everything can be uploaded.)
> >
> > Would someone be willing to shepherd the patch for me?
> >
> > Attached is a PNG which shows the output of one of the regtests.
> >
> > This would _really_ be appreciated.  Thanks!
> >
> > David

What I would suggest (generally to anyone on this list that ever needs a patch 
shepherding) is to make sure a tracker exists - @David, as I know you have 
access to create tickets you can at least do this - and then attach your patch 
to that and set the tracker to 'started' so that at the very least if (for 
example) Urs forgets, goes on holiday, has some emergency, that I can at least 
pick it up/detect it on the countdown and put it up for review myself. 

I do this all the time for 'drive by' patches.

James

Re: shepherd a patch?

[Jonas Hahnfeld via Discussions on LilyPond development]

Hi David,

Am Donnerstag, den 14.11.2019, 21:10 -0600 schrieb David Nalesnik:
> Hi all,
> 
> I have a patch which implements measure-attached spanners.  I am
> having a devil of a time getting the patch up for review.  I simply
> can't get git-cl to upload it.  (I suspect this has something to do
> with the number of files it touches--my system times out before
> everything can be uploaded.)

based on your other messages, you're using LilyDev when running git-cl? 
If you say it times out, I would guess that git-cl waiting for you to
authorize the tool. Usually, it opens a browser for that, but that's
probably not going to work under a headless VM / container?
Did you try running git-cl from your host system?

Jonas


signature.asc
Description: This is a digitally signed message part