Re: Doc: Usage - Updated 'Running LilyPond' intros (issue 261240043 by pkx1...@gmail.com)
Minor nit, but otherwise LGTM https://codereview.appspot.com/261240043/diff/20001/Documentation/usage/lilypond-book.itely File Documentation/usage/lilypond-book.itely (right): https://codereview.appspot.com/261240043/diff/20001/Documentation/usage/lilypond-book.itely#newcode31 Documentation/usage/lilypond-book.itely:31: both Windows and MacOS users to be ble to use LilyPond on the "to be able" or perhaps "to enable LilyPond . . ."" https://codereview.appspot.com/261240043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Check for Note_column interface before using grob. (issue 141190043 by e...@ticalc.org)
Logged on issue tracker as Issue 4094: Note_column programming errors https://codereview.appspot.com/141190043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: minor revisions to Easier Editing (issue 118350043 by colinpkcampb...@gmail.com)
On 2014/07/27 08:22:47, uliska wrote: Apart from my comment LGTM Good feedback, Urs, and thanks. Changed patchset uploaded. https://codereview.appspot.com/118350043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
DOC: minor revisions to Easier Editing (issue 118350043 by colinpkcampb...@gmail.com)
Reviewers: ,
Message:
This is a bit of housekeeping, coming from research for a recent
presentation of LilyPond to a group of church musicians.
Description:
DOC: minor revisions to Easier Editing
Moved tunefl per comment 1 issue 2660
Moved LilyPondTool to "No longer developed" per Bertalan Fodor
Revised OS logos for Frescobaldi & Denemo
Added a bit of text to Frescobaldi
Please review this at https://codereview.appspot.com/118350043/
Affected files (+39, -44 lines):
M Documentation/web/introduction.itexi
Index: Documentation/web/introduction.itexi
diff --git a/Documentation/web/introduction.itexi
b/Documentation/web/introduction.itexi
index
512559a6b4dba7f3119b7ee5542f66fba19ef27c..035aa4c59a98531b800e0f03822f8cf62b0ef530
100644
--- a/Documentation/web/introduction.itexi
+++ b/Documentation/web/introduction.itexi
@@ -1205,59 +1205,21 @@ In particular, don't link to:
@end ignore
@divClass{column-center-top}
-@subheading Tunefl
-
-@sourceimage{logo-linux,,,}
-@sourceimage{logo-freebsd,,,}
-@sourceimage{logo-macosx,,,}
-@sourceimage{logo-windows,,,}
-
-@uref{http://www.tunefl.com}
-
-With tunefl you can typeset your scores directly online
-without needing to install LilyPond locally. It allows
-trying out all the program's features using a convenient
-web interface.
-
-@divEnd
-
-@divClass{column-center-top}
-@subheading LilyPondTool
-
-@imageClickable{lilypondtool-2.12-screenshot-400wide,png,
- (click to enlarge),lilypondtool-2.12-screenshot,png,right}
-
-@sourceimage{logo-linux,,,}
-@sourceimage{logo-freebsd,,,}
-@sourceimage{logo-macosx,,,}
-@sourceimage{logo-windows,,,}
-
-@uref{http://lilypondtool.organum.hu}
-
-Created as a plugin for the
-@uref{http://www.jedit.org,jEdit} text editor,
-LilyPondTool is one of the most feature-rich text-based tools for
-editing LilyPond scores. Its features include a Document Wizard
-with lyrics support to set up documents easier, and embedded PDF
-viewer with advanced point-and-click support.
-
-@divEnd
-
-@divClass{column-center-top}
@subheading Frescobaldi
@imageClickable{frescobaldi-lilypond-editor-small,png,
(click to enlarge),frescobaldi-lilypond-editor,png,right}
@sourceimage{logo-linux,,,}
-@sourceimage{logo-freebsd,,,}
+@sourceimage{logo-macosx,,,}
@sourceimage{logo-windows,,,}
@uref{http://www.frescobaldi.org}
-Frescobaldi is lightweight, yet powerful LilyPond music and text editor
-with a built-in PDF viewer. It is easy to use and will run on all major
-operating systems (GNU/Linux, Mac OS X and Windows).
+Frescobaldi is a lightweight, yet powerful, LilyPond music and text editor
+with a built-in PDF viewer. Developed from LilyKDE, it has had many
+features added and enhanced particularly for LilyPond. It is easy to use
+and will run on all major operating systems (GNU/Linux, Mac OS X and
Windows).
@divEnd
@@ -1268,6 +1230,7 @@ operating systems (GNU/Linux, Mac OS X and Windows).
(click to enlarge),screenshot-denemo,png,right}
@sourceimage{logo-linux,,,}
+@sourceimage{logo-macosx,,,}
@sourceimage{logo-windows,,,}
@uref{http://denemo.org}
@@ -1285,7 +1248,24 @@ the text view when printed from there.
@divEnd
@divClass{column-center-top}
-@subheading Text editors
+@subheading Tunefl
+@c do we need logos for web-based packages?
+@sourceimage{logo-linux,,,}
+@sourceimage{logo-freebsd,,,}
+@sourceimage{logo-macosx,,,}
+@sourceimage{logo-windows,,,}
+
+@uref{http://www.tunefl.com}
+
+With tunefl, you can typeset your mini-scores directly online
+without needing to install LilyPond locally. It allows
+trying out all the program's features using a convenient
+web interface.
+
+@divEnd
+
+@divClass{column-center-top}
+@subheading Elysium
@sourceimage{logo-linux,,,}
@sourceimage{logo-freebsd,,,}
@@ -1299,6 +1279,16 @@ view for source and score. It includes rapid visual
& auditive feedback
without having to switch contexts, and comes with many wizard-driven
templates.
+@divEnd
+
+@divClass{column-center-top}
+@subheading Text editors
+
+@sourceimage{logo-linux,,,}
+@sourceimage{logo-freebsd,,,}
+@sourceimage{logo-macosx,,,}
+@sourceimage{logo-windows,,,}
+
@uref{http://www.gnu.org/software/emacs/}
Emacs is a text editor with language-sensitive capabilities for
@@ -1428,6 +1418,11 @@ language.
@itemize
@item
+@uref{https://sourceforge.net/projects/lily4jedit,LilyPondTool} was
created as a
+plugin for the
+@uref{http://www.jedit.org,jEdit} text editor.
+
+@item
@uref{http://lilykde.googlecode.com/,LilyKDE} has been replaced by
@uref{http://www.frescobaldi.org/,Frescobaldi}, and exists as LilyKDE3
for KDE 3.5 and lilypond-KDE4 for KDE 4.1 only.
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 2366: THANKS needs updating or deleting (issue 6478050)
http://codereview.appspot.com/6478050/diff/1/THANKS File THANKS (right): http://codereview.appspot.com/6478050/diff/1/THANKS#newcode15 THANKS:15: Benkő Pál I believe that Pál is his given name and Benkő his surname. http://codereview.appspot.com/6478050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 2602: \unfoldRepeats and \repeat tremolo 7, 14, 15 produces weird output (issue 6300092)
I see the values of the c'' have changed between patch sets.
http://codereview.appspot.com/6300092/diff/6001/input/regression/display-lily-tests.ly
File input/regression/display-lily-tests.ly (right):
http://codereview.appspot.com/6300092/diff/6001/input/regression/display-lily-tests.ly#newcode193
input/regression/display-lily-tests.ly:193: \test ##[ \repeat tremolo 7
{ c''32 b' } #]
Should these two lines both be c''32 or c''16?
http://codereview.appspot.com/6300092/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows for framing comments in LilyPond backends. (issue 5450086)
On 2011/12/05 08:59:18, J_lowe wrote: http://codereview.appspot.com/5450086/diff/3001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/5450086/diff/3001/scm/define-grob-properties.scm#newcode310 scm/define-grob-properties.scm:310: stencilfied of a grob in a given backend.") Mike (anyone?) "...stencilfied grob in a given..." or "...stencilfication of a grob in a given..." but is there a better word than 'stencilfied'? I won't pretend to understand the things in this file anyway, but I did a quick look for the word elsewhere and there is none, so I assume this is not a 'standard' term in this literal context. Agreed completely, James: these neologisms are completely to be reprehended! A somewhat less painful alternative might be "stencilize" in its many permutations: viz. http://dictionary.reference.com/browse/stencilize althopugh to be quite frank, one hopes a more suitable word will come to light. Nevertheless, it should go to countdown for the added utility. http://codereview.appspot.com/5450086/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: musicxml2ly: title and subtitle (issue 1913), miscellaneous (issue 5096050)
Pushed as c4d028afdec2ee6e3cbbd661ed750ee9f5cf4c8f on behalf of Patrick/Janek http://codereview.appspot.com/5096050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: MIDI volume can exceed maximum value (fix 1938) (issue 5134047)
Pushed on behalf of James/Heikki as 2bbf0334903db23ad9cb3d3fcbf826cf41d45546 http://codereview.appspot.com/5134047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: Added note to CG about disable-optimizing (issue 5081048)
http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143
Documentation/contributor/regressions.itexi:143: be run with the
@code{--disable-optimising} option. Then you will need
On 2011/09/21 08:43:09, Trevor Daniels wrote:
I think I'd mention just running ./autogen, just in
case the reader is doing the build for the first time.
But if you leave the configure option in it should be
./configure.
I believe the ../configure is appropriate for an out of tree build: it
would be run from a /build directory, which we strongly recommend, no?
http://codereview.appspot.com/5081048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)
Pushed as 5f81429c8f8263eef85b4f7881d243cb9722e971 Details of how to push will be in a seperate patch. http://codereview.appspot.com/4898058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)
Regarding the addition of instructions on how to push, I'd like to do that in a separate patch, unless an experienced developer cares to send me a rough sketch, point form perhaps, which I could then repackage in documentation format. http://codereview.appspot.com/4898058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)
Reviewers: Graham Percival, phileholmes_googlemail.com, Reinhold,
reinhold_kainhofer.com, graham_percival-music.ca,
Message:
On 2011/08/19 03:11:15, graham_percival-music.ca wrote:
On Fri, Aug 19, 2011 at 03:21:03AM +0200, Reinhold Kainhofer wrote:
> Am Friday 19 August 2011, 02:29:22 schrieb
percival.music...@gmail.com:
> > On 2011/08/18 11:42:13, Reinhold wrote:
> > > Why did you change all dsa to rsa?
> It's not only savannah, it's basically everone who knows a little
bit about
> security...
Wait, I'm confused again, so I looked it up.
http://savannah.gnu.org/maintenance/SshAccess
says "we recommend using only RSA keys, not DSA".
Does that page give incorrect advice?
I know just enough about security to know that I don't know about
security. I've asked my brother for advice, but ultimately I
would recommend starting a discussion with the savannah people if
you think they are giving flaws encryption advice.
Cheers,
- Graham
A bit of Googling seems to suggest that while DSA and RSA are generally
equivalent in strength for the same key size, DSA is limited to 1024-bit
max, while RSA allows up to 4096. Keys of 2048 bits are probably secure
for the reasonable future, and are the RSA default. See, for example
http://en.wikipedia.org/wiki/Rsa#Security_and_practical_considerations
Description:
DOC: Revise CG 3.4 Commit Access
Please review this at http://codereview.appspot.com/4898058/
Affected files:
M Documentation/contributor/source-code.itexi
Index: Documentation/contributor/source-code.itexi
diff --git a/Documentation/contributor/source-code.itexi
b/Documentation/contributor/source-code.itexi
index
60c8ca2c123ced3a6816c8241ba92ef831866712..831dbc2f0e1fecd6102a6498d680ff46300635b4
100644
--- a/Documentation/contributor/source-code.itexi
+++ b/Documentation/contributor/source-code.itexi
@@ -1422,15 +1422,15 @@ Contributor of} on your @qq{My Group Membership}
page.
@item
-Generate an SSH @q{dsa} key pair. Enter the following at the
+Generate an SSH @q{rsa} key pair. Enter the following at the
command prompt:
@example
-ssh-keygen -t dsa
+ssh-keygen -t rsa
@end example
When prompted for a location to save the key, press to
-accept the default location (@file{~/.ssh/id_dsa}).
+accept the default location (@file{~/.ssh/id_rsa}).
Next you are asked to enter an optional passphrase. On most
systems, if you use a passphrase, you will likely be prompted for
@@ -1442,7 +1442,7 @@ though you may find it tedious to keep re-entering it.
You can change/enable/disable your passphrase at any time with:
@example
-ssh-keygen -f ~/.ssh/id_dsa -p
+ssh-keygen -f ~/.ssh/id_rsa -p
@end example
Note that the GNOME desktop has a feature which stores your
@@ -1457,14 +1457,14 @@ gconftool-2 --set -t bool \
@end example
After setting up your passphrase, your private key is saved as
-@file{~/.ssh/id_dsa} and your public key is saved as
-@file{~/.ssh/id_dsa.pub}.
+@file{~/.ssh/id_rsa} and your public key is saved as
+@file{~/.ssh/id_rsa.pub}.
@item
-Register your public SSH @q{dsa} key with Savannah. From the
+Register your public SSH @q{rsa} key with Savannah. From the
@qq{My Account Configuration} page, click on @qq{Edit SSH Keys},
-then paste the contents of your @file{~/.ssh/id_dsa.pub} file into
+then paste the contents of your @file{~/.ssh/id_rsa.pub} file into
one of the @qq{Authorized keys} text fields, and click
@qq{Update}.
@@ -1485,7 +1485,7 @@ git config remote.origin.url \
@end example
@noindent
-where @var{user} is your username on Savannah.
+replacing @var{user} with your Savannah username.
@item
@@ -1566,9 +1566,14 @@ git config push.default matching
@noindent
Then @code{git@tie{}push} should work as before. For more
details, consult the @code{git@tie{}push} man page.
-@end enumerate
+@item
+Repeat the steps from generating an RSA key through to testing
+your commit access, for each machine from which you will be
+making commits.
+@end enumerate
+
@subsubheading Technical details
@itemize
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: fix NR 1.6.3 Formatting Cue Notes (Issue 1762) (issue4808051)
Pushed by Graham as 2d30bf30c3af6e7c4f1d158ec095c67450adea79 http://codereview.appspot.com/4808051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: fix NR 1.6.3 Formatting Cue Notes (Issue 1762) (issue4808051)
Revised as requested. http://codereview.appspot.com/4808051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
DOC: fix NR 1.6.3 Formatting Cue Notes (Issue 1762) (issue4808051)
Reviewers: ,
Message:
Addresses Reinhold's comment re issue 1762
Description:
DOC: fix NR 1.6.3 Formatting Cue Notes
Moves comment about explicitly creating a Voice, to the proper example.
Please review this at http://codereview.appspot.com/4808051/
Affected files:
M Documentation/notation/staff.itely
Index: Documentation/notation/staff.itely
diff --git a/Documentation/notation/staff.itely
b/Documentation/notation/staff.itely
index
5344ab2b866ba8181d93084f9df01c385740487b..d0d6da753649a38d09665ce71da27ac036946984
100644
--- a/Documentation/notation/staff.itely
+++ b/Documentation/notation/staff.itely
@@ -1292,9 +1292,6 @@ oboeNotes = \relative c'' {
@end lilypond
@noindent
-In the above example, the @code{Voice} context had to be
-explicitly declared, or else the entire music expression would
-belong to the @code{CueVoice} context.
It is possible to adjust which aspects of the music are quoted with
@code{\cueDuring} by setting the @code{quotedCueEventTypes}
@@ -1319,6 +1316,10 @@ oboeNotes = \relative c'' {
}
@end lilypond
+In the above example, the @code{Voice} context had to be
+explicitly declared, or else the entire music expression would
+belong to the @code{CueVoice} context.
+
Markup can be used to show the name of the quoted instrument. Also,
if the cue notes require a change in clef, this can be done manually but
the original clef should also be restored manually at the end of the cue
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: an example of minimal example (issue4636082)
This has had its countdown; please push and close. http://codereview.appspot.com/4636082/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: correcting note about rerunning regtests (issue4675048)
This has had its countdown; please push and close. http://codereview.appspot.com/4675048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix Issue 770: Lyrics attached to a voice-derived context are off by 1 (issue4672041)
This has had a 48-hour countdown, and should be pushed and closed, please. Colin http://codereview.appspot.com/4672041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055)
This has had a 48-hour countdown, and can be pushed and closed, please. Colin http://codereview.appspot.com/4667055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sets spanner length as a spanner property. (issue4641085)
Addewd as issue 1729 http://codereview.appspot.com/4641085/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Implements multiple-line non-cross-staff glissandi (issue4527086)
Added issue 1728 to tracker http://codereview.appspot.com/4527086/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Adds glissando stems to Lilypond. (issue4661061)
Added issue 1727 for tracking http://codereview.appspot.com/4661061/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Clean up lilypond-book snippet formatting and file name hashing (issue183048)
I believe, since issue 867 is marked verified, that this could be closed, John. cheers, Colin Campbell Bug Squad http://codereview.appspot.com/183048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)
I gather this is connected to issue 684, so it should probably be marked closed, Jan. Thanks, Colin http://codereview.appspot.com/1579041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Experimental support for woff fonts in svg. (issue1428042)
Should this issue be closed, per the changes list announcing it in 2.14? http://codereview.appspot.com/1428042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Lilypond-book: Implement musicxml support in lilypond-book (issue1659041)
If this is still alive, Reinhold, I'd like to give it an entry on the issue tracker. I believe James or I could work with you on the documentation, as well. cheers, Colin http://codereview.appspot.com/1659041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
FiguredBass: Rewrite of the engraver to fix vertical position (issue224052)
Just tidying up a bit: has this been superceded by the fix to issue 1671? If so, the reitveld issue could be closed. cheers, Colin http://codereview.appspot.com/224052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows glissandi to be continuous at line breaks (issue4273098)
On 2011/03/23 00:37:07, MikeSol wrote: I'm using this is in a piece I'm working on and figured it may be useful in LilyPond. Let me know what you think! Mike, is this related to issue 663? If not, 'll open an issue to track it as an enhancement. http://codereview.appspot.com/4273098/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Allow other types of staves than only Staff inside a GrandStaff... (issue4275068)
Applied to 2.13.56 and shows a change in hara-kiri-tabstaff.ly Added issue #1577 on bug-lilypond to track this. http://codereview.appspot.com/4275068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Avoid repeats of 'staff-affinity' warning; change text. (issue4278058)
On 2011/03/18 11:22:11, Trevor Daniels wrote: LGTM I like this warning text. Much better. Trevor Applying the patch gave the following: /home/colin/lilypond-git/lily/page-layout-problem.cc: In member function 'void Page_layout_problem::solve_rod_spring_problem(bool)': /home/colin/lilypond-git/lily/page-layout-problem.cc:425: warning: conversion to 'Real' from 'vsize' may alter its value /home/colin/lilypond-git/lily/page-layout-problem.cc:427: warning: conversion to 'Real' from 'vsize' may alter its value /home/colin/lilypond-git/lily/page-layout-problem.cc: In static member function 'static scm_unused_struct* Page_layout_problem::get_spacing_spec(Grob*, Grob*, bool, int, int)': /home/colin/lilypond-git/lily/page-layout-problem.cc:861: error: expected ';' before '}' token make[1]: *** [out/page-layout-problem.o] Error 1 make[1]: Leaving directory `/home/colin/lilypond-git/build/lily' make: *** [all] Error 2 colin@Sherlock:~/lilypond-git/build$ http://codereview.appspot.com/4278058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
On 2011/03/07 19:48:23, J_lowe wrote: Layout wise - Looks fine. Colin, From: Colin Campbell [mailto:c...@shaw.ca] Sent: 10 March 2011 13:57 To: James Lowe Subject: Fwd: part combine doc patch Good morning, James Attached is a patch which needs pushing, if you would oblige --- Pushed as commit d0c8e3162e9d2c0c7195ce8d58e3dd63bf57aca4 In case you want to mention this on Reitveld? James http://codereview.appspot.com/4188056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Adds automatic numbering to footnotes. (issue4244064)
On 2011/03/09 19:13:20, mike_apollinemike.com wrote: Thanks for the helpful comments! Responses inlined below. Hi, Mike! Part-time patch helper Colin here. Mike, this patch has somehow poisoned the doc build and also the make test functionality, neither of which work since the patch was pushed. Also, I gather this patch is part of your work on issue, so I'll update the issue and set the status to "Patch needs work". http://codereview.appspot.com/4244064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
On 2011/03/06 12:13:15, Reinhold wrote: http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871 Documentation/notation/simultaneous.itely:871: previous part combining mechanism. Actually, it never returns to the previous mechanism, but rather to the default built-in mechanism (just like \revert always resets a grob property to the default an not to the value before the previous \override). Ah, I was thinking that \partcombineautomatic once would go automatic for one note, then return to whatever was in force before it was called. If you would confirm that, I'll reword the explanation to suit. http://codereview.appspot.com/4188056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
Patch revised to remove the doc-section.sh bits which were pushed separately. The remainder is just the partcombine explanation. Ordinarily, I suppose this needn't go on reitveld, but wotthehell archie, it started here so I'm putting the last bit up to close out the process. http://codereview.appspot.com/4188056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
Actually thinking about it more would it make more sense to have the auto function listed first then add the words "... May need some manual adjustment.' and then list the rest? James I like that very much, James, thanks! A question for Reinhold, though: do I gather correctly that \partcombine is applied to a Staff, and turns the combining mechanism on, while \partcombineAutomatic is applied to a single Voice? That being so, does it "turn off" a previous \partcombineApart, e.g.? http://codereview.appspot.com/4188056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
On 2011/02/22 12:15:31, Reinhold wrote: http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode852 Documentation/notation/simultaneous.itely:852: chord or unisono. On 2011/02/21 20:29:42, Colin Campbell wrote: > I believe "unisono" is a Dutch usage, so I've changed it to "unison", although > it is hardwired into the names of functions like \partCombineUnisono. Unisono is the usual Italian term, as opposed to "divisi". FWIW, "unisono" only appears in code, never in open text, per git grep 'unisono '; I feel that using the Italian term in this context would detract from the purpose of explaining the commands. http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode872 Documentation/notation/simultaneous.itely:872: Use the combination strategy automatically determined. On 2011/02/21 17:56:05, pkx166h wrote: > Can we be more descriptive on what the 'automatic' strategy is? Or we could > simply say > > "Let the software decide which is the best option". I want to not use the word > 'strategy'. Actually, it's not easy to describe the default (combine, if it is possible, but not for voice crossings or for different spanners or dynamics, or if the notes are further apart than an octave or so). Also, lilypond does not usually decide what's the best option, but rather the simplest. Perhaps I should add something like: decide, but the results may need adjustment in some cases."? http://codereview.appspot.com/4188056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
revised patch uploaded.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode846
Documentation/notation/simultaneous.itely:846: change the state
permanently.
On 2011/02/21 17:56:05, pkx166h wrote:
If I may make a suggestion for this whole paragraph?
--snip--
In professional scores, voices are often kept apart for long periods -
even if
one or two notes actually coincide and could easily be printed as
@emph{unisono}. Combining notes into a chord, or to print one voice
as solo is
therefore not ideal as the @code{\partcombine} function considers each
note
separately.
For this reason, the @code{\partcombine} function can be overriden
with the
following commands:
--snip--
I have moved that final sentence below the list
Done.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode852
Documentation/notation/simultaneous.itely:852: chord or unisono.
On 2011/02/21 17:56:05, pkx166h wrote:
Again do we @emph{} unisono? I assume this is a musical term and not
just a
mis-translation of foreign usage?
I believe "unisono" is a Dutch usage, so I've changed it to "unison",
although it is hardwired into the names of functions like
\partCombineUnisono.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode856
Documentation/notation/simultaneous.itely:856: Combine the notes to a
chord.
On 2011/02/21 17:56:05, pkx166h wrote:
There was much discussion on 'chord' vs 'not chord' unrelated to this,
but still
enough to worry some. So is 'chord' the correct term here? I have no
preference
but am just pre-empting discussion.
I think it's safe, given the names of the commands. Whether the
commands are correctly named may be another discussion!
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode860
Documentation/notation/simultaneous.itely:860: The two voices are
unisono.
On 2011/02/21 17:56:05, pkx166h wrote:
@emph{unisono}
As above.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode872
Documentation/notation/simultaneous.itely:872: Use the combination
strategy automatically determined.
On 2011/02/21 17:56:05, pkx166h wrote:
Can we be more descriptive on what the 'automatic' strategy is? Or we
could
simply say
"Let the software decide which is the best option". I want to not use
the word
'strategy'.
Done.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode874
Documentation/notation/simultaneous.itely:874: @end itemize
On 2011/02/21 17:56:05, pkx166h wrote:
Now add the final sentence from above:
All commands ending in @code{...Once} apply only to the following
note.
---
It is therefore implicit and unnecessary to state what the code that
doesn't end
in 'once' does. So I have removed that sentence.
Done.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode880
Documentation/notation/simultaneous.itely:880: \partcombineChords
e'^"chord" e |
On 2011/02/21 17:56:05, pkx166h wrote:
If we do change the word 'chord' above then we need to change it here
too.
Done.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode891
Documentation/notation/simultaneous.itely:891: c2 c
On 2011/02/21 17:56:05, pkx166h wrote:
If we're going to have bar checks then we need one on the last bar
Done.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode897
Documentation/notation/simultaneous.itely:897: \new Staff \partcombine
\instrumentOne \instrumentTwo
On 2011/02/21 17:56:05, pkx166h wrote:
If we do keep this @lilypond (see comment below) I'd like to see {}
after the
new Staff for clarity.
<<
\new Staff { \instrumentOne }
\new Staff { \instrumentTwo }
\new Staff { \partcombine \instrumentOne \instrumentTwo }
>>
Done.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode899
Documentation/notation/simultaneous.itely:899: @end lilypond
On 2011/02/21 17:56:05, pkx166h wrote:
Maybe I have missed something but this looks a tad complicated for an
@lilypond
and would be better served as a snippet instead. We don't often use
variables
like this in @lilypond except when explicitly discussing variables.
It may be more confusing to write it without variables; \partcombine is
certainly easier to do *with* than without, and I believe the example is
nearly unreadable without variables. Other tastes are of course
different!
http://codereview.appspot.com/4188056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mail
Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
On 2011/02/16 06:08:03, Keith wrote: Looks good as it is, better if you can add one markup that Reinhold missed in the example. http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely#newcode873 Documentation/notation/simultaneous.itely:873: from the left one of each pair of commands above. I had trouble understanding after the comma, but think the first part of the sentence says it all. AGree, Keith: I've trimmed it. http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely#newcode882 Documentation/notation/simultaneous.itely:882: \partcombineAutomatic c c | c^"auto" done, and thanks! http://codereview.appspot.com/4188056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)
Reviewers: ,
Message:
Add documentation of partcombine functions.
See issue 1518 on the bug tracker.
Description:
DOC: NR 1.5.2 Multiple voices - part combining
Adds explanations and examples of part combine functions to
NR 1.5.2 Multiple voices - Automatic part combining
Patch based on issue 4132045 by Reinhold
Please review this at http://codereview.appspot.com/4188056/
Affected files:
M Documentation/notation/simultaneous.itely
Index: Documentation/notation/simultaneous.itely
diff --git a/Documentation/notation/simultaneous.itely
b/Documentation/notation/simultaneous.itely
index
ededc3fc377b06e3a6bce7cb11590c0567feca51..5a041e408248972b4a513f92513542841b06db9b
100644
--- a/Documentation/notation/simultaneous.itely
+++ b/Documentation/notation/simultaneous.itely
@@ -836,6 +836,70 @@ A @code{\relative} section that is outside of
@code{\partcombine}
has no effect on the pitches of @code{@var{musicexpr1}} and
@code{@var{musicexpr2}}.
+Often the decision to combine notes into a chord or to print one voice
+as solo is not ideal, since the part-combiner considers each note
+separately. However, in professional scores voices are kept apart for
+longer periods, even if one or two notes actually coincide and could be
+printed as unisono. For this reason, the part-combiner's strategy can be
+overriden with any of the following commands. All commands ending in
+@code{...Once} apply only to the following note, while all other commands
+change the state permanently.
+
+@itemize
+@item
+@code{\partcombineApart}, @code{\partcombineApartOnce}:
+Keep the notes as two separate voices, even if they can be combined to a
+chord or unisono.
+
+@item
+@code{\partcombineChords}, @code{\partcombineChordsOnce}:
+Combine the notes to a chord.
+
+@item
+@code{\partcombineUnisono}, @code{\partcombineUnisonoOnce}:
+The two voices are unisono.
+
+@item
+@code{\partcombineSoloI}, @code{\partcombineSoloIOnce}:
+Show only voice one and mark it as solo.
+
+@item
+@code{\partcombineSoloII}, @code{\partcombineSoloIIOnce}:
+Show only voice two and mark it as solo.
+
+@item
+@code{\partcombineAutomatic}, @code{\partcombineAutomaticOnce}:
+Use the combination strategy automatically determined, or revert
+from the left one of each pair of commands above.
+
+@end itemize
+
+@lilypond[quote,verbatim]
+instrumentOne = \relative c' {
+ \partcombineApart c2^"apart" e |
+ \partcombineAutomatic e^"auto" e |
+ \partcombineChords e'^"chord" e |
+ \partcombineAutomatic c c |
+ \partcombineApart c^"apart" \partcombineChordsOnce e^"chord once" |
+ c c |
+}
+instrumentTwo = \relative c' {
+ c2 c |
+ e2 e |
+ a,2 c |
+ c2 c' |
+ c2 c |
+ c2 c
+}
+
+<<
+ \new Staff \instrumentOne
+ \new Staff \instrumentTwo
+ \new Staff \partcombine \instrumentOne \instrumentTwo
+>>
+@end lilypond
+
+
@snippets
@lilypondfile[verbatim,lilyquote,texidoc,doctitle]
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: DOC: add description of -dinclude-settings (issue4169053)
Revised to incorporate suggestions from Graham and James, for which my thanks, and some more commas,,,! http://codereview.appspot.com/4169053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
DOC: add description of -dinclude-settings (issue4169053)
Reviewers: ,
Message:
Revises and replaces Reinhold's patch in issue 4129053
Description:
DOC: add description of -dinclude-settings
Adds menu reverences and a description of using -dinclude-settings
on the comand line, to change among various global parameters
such as paper or font size.
Please review this at http://codereview.appspot.com/4169053/
Affected files:
M Documentation/notation/input.itely
Index: Documentation/notation/input.itely
diff --git a/Documentation/notation/input.itely
b/Documentation/notation/input.itely
index
1ef43544237ac75af708688016130c7cd0949494..122654c9f11144219f41d04508ee4994f30d3f11
100644
--- a/Documentation/notation/input.itely
+++ b/Documentation/notation/input.itely
@@ -1113,6 +1113,7 @@ structure while leaving the notation untouched.
@menu
* Using variables::
* Using tags::
+* Using global settings::
@end menu
@node Using variables
@@ -1331,6 +1332,33 @@ than one tagged section at the same place.
@end ignore
+@node Using global settings
+@unnumberedsubsubsec Using global settings
+
+@cindex include-settings
+
+Global settings can be kept in separate files, which are selected
+on the command line:
+
+@example
+lilypond -dinclude-settings=MY_SETTINGS.ly MY_SCORE.ly
+@end example
+
+Groups of settings such as page size, font or type face can be stored
+in separate files. This allows different editions from the same score
+as well as standard settings to be applied to many scores, simply by
+specifying the proper settings file.
+
+This technique also works well with the use of style sheets.
+See @rlearning{Style sheets}
+
+@seealso
+Learning Manual:
+@rlearning{Organizing pieces with variables}.
+
+Notation Reference:
+@ref{Including LilyPond files}.
+
@node Text encoding
@subsection Text encoding
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Add documentation for -dinclude-settings cmd line option (issue4129053)
My first attempt at this, and I hope it is what Reinhold is looking for. http://codereview.appspot.com/4129053/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4129053/diff/1/Documentation/notation/input.itely#newcode1341 Documentation/notation/input.itely:1341: in both A4 and letter format is desired, or when two versions shall only differ delete "shall" http://codereview.appspot.com/4129053/diff/1/Documentation/notation/input.itely#newcode1342 Documentation/notation/input.itely:1342: in font size. In these cases, one can create settings files, containing the "for these cases, simply create . . ." http://codereview.appspot.com/4129053/diff/1/Documentation/notation/input.itely#newcode1344 Documentation/notation/input.itely:1344: you can then use one of these settings files using the command-line option replace "you can then . . . files" with "select the desired settings file " http://codereview.appspot.com/4129053/diff/1/Documentation/notation/input.itely#newcode1347 Documentation/notation/input.itely:1347: With this approach, it is not necessary to modify the the source at all, if I would end this sentence after " at all". http://codereview.appspot.com/4129053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
