Re: Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2011-02-17 Thread FelipeG . Assis 


http://codereview.appspot.com/3789044/diff/29001/python/musicexp.py
File python/musicexp.py (right):

http://codereview.appspot.com/3789044/diff/29001/python/musicexp.py#newcode308
python/musicexp.py:308: return '(ly:make-pitch %d %d \'(%d . 0))' %
(self.octave,
On 2011/02/17 20:01:25, Carl wrote:

Why is the 0 for the second alteration hard-coded?


IIUC, this python code only deals with semitones.
By the way, the corresponding line in the current version
is a bug (I sent a mail to the frogs last week about that).

http://codereview.appspot.com/3789044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc -- Clarify instructions on autobeam settings (issue4160048)

2011-02-14 Thread FelipeG . Assis 


http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

http://codereview.appspot.com/4160048/diff/5001/Documentation/notation/rhythms.itely#newcode2207
Documentation/notation/rhythms.itely:2207: @code{Score} context.  This
means that a setting the time signature
Should it be "This means that setting the time signature [...]"?

http://codereview.appspot.com/4160048/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2010-12-29 Thread FelipeG . Assis 

Reviewers: ,

Message:
This patch is first and foremost a change in the internal Pitch
representation. I then suggest that we first discuss that, having it as
a reference.

Description:
Issue 1278: Arrow notation for quarter-tones.

We change the internal pitch representation so as to account for two
levels of alteration. Basically, instead of representing alterations
by a rational number, we represent them by a pair of integers.

The main changes are the addition of an Alteration struct, and
modifications in the Pitch and Scale classes.

The Pitch class was reimplemented. Its interface was mostly preserved.
No pitch normalisation policy is implemented, though.
(see lily/include/pitch.hh and lily/pitch.cc)

Class Scale was completely rewritten.
(see lily/include/scale.hh and lily/scale.hh)

Finally, new note names are defined, and the arrow style accidentals
are made available via the new arrow-alteration-glyph-name-alist.
(see scm/lily-library.scm, scm/define-note-names.scm and
scm/output-lib.scm)

Other changes are basically simple side-effects of these.

Please review this at http://codereview.appspot.com/3789044/

Affected files:
  M input/regression/scheme-book-scores.ly
  M lily/accidental-engraver.cc
  M lily/accidental-placement.cc
  A lily/alteration.cc
  M lily/ambitus-engraver.cc
  A lily/include/alteration.hh
  M lily/include/lily-guile.hh
  M lily/include/pitch.hh
  M lily/include/scale.hh
  M lily/key-engraver.cc
  M lily/key-performer.cc
  M lily/key-signature-interface.cc
  M lily/lily-guile.cc
  M lily/music-scheme.cc
  M lily/music.cc
  M lily/parser.yy
  M lily/pitch-scheme.cc
  M lily/pitch.cc
  M lily/pitched-trill-engraver.cc
  M lily/scale.cc
  M lily/slur-scoring.cc
  M ly/engraver-init.ly
  M ly/makam.ly
  M ly/scale-definitions-init.ly
  scm/chord-entry.scm
  scm/chord-generic-names.scm
  scm/chord-ignatzek-names.scm
  scm/chord-name.scm
  scm/define-grob-properties.scm
  scm/define-markup-commands.scm
  scm/define-music-display-methods.scm
  scm/define-music-properties.scm
  scm/define-note-names.scm
  scm/lily-library.scm
  scm/lily.scm
  scm/midi.scm
  scm/music-functions.scm
  scm/output-lib.scm
  scm/tablature.scm
  scm/translation-functions.scm



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel