Re: python: Fix compile for in-tree builds (issue 581910043 by jonas.hahnf...@gmail.com)

2020-04-17 Thread lilyfan
Thanks Jonas, it works like a charm.

If it doesn't break out-tree build, I think you might push directly.

https://codereview.appspot.com/581910043/



Re: texinfo-rules: generate log files in $(outdir)/ (issue 557480043 by hanw...@gmail.com)

2020-02-23 Thread lilyfan
Does this mean that, for example,

Documentation/fr/learning.*.log and
input/regression/collated-files.texilog.log would respectively land in
Documentation/fr/out/ and input/regression/out/ ?

https://codereview.appspot.com/557480043/



Re: Doc: Some miscellaneous suggestions from Peter Toye (issue 579280043 by michael.kaepp...@googlemail.com)

2020-02-11 Thread lilyfan
Have a look at Documentation/HOWTO.index


https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely#newcode880
Documentation/notation/input.itely:880: @cindex footers, page
Index them as singular

https://codereview.appspot.com/579280043/



Re: input/regression/multi-measure-rest-reminder: a demo of user-defined grobs (issue 557380044 by hanw...@gmail.com)

2020-02-11 Thread lilyfan
Are you a French forensics? (DNA is adn for us)


https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly
File input/regression/multi-measure-rest-reminder.ly (right):

https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly#newcode6
input/regression/multi-measure-rest-reminder.ly:6: This is a demo of
user-defined engravers, adn defining grobs using
adn -> and

https://codereview.appspot.com/557380044/



Web: GSoC: Add Style Sheets project (issue 340140043 by g...@ursliska.de)

2018-01-13 Thread lilyfan

LGTM


https://codereview.appspot.com/340140043/diff/1/Documentation/included/gsoc.itexi
File Documentation/included/gsoc.itexi (right):

https://codereview.appspot.com/340140043/diff/1/Documentation/included/gsoc.itexi#newcode172
Documentation/included/gsoc.itexi:172: (this would involve working on
Lilypond's C++ code) support for notation
Lilypond's -> LilyPond's

https://codereview.appspot.com/340140043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: typos and conistency (issue 332110043 by thomasmorle...@gmail.com)

2017-11-11 Thread lilyfan

On 2017/11/11 10:36:16, thomasmorley651 wrote:

On 2017/11/11 10:11:39, Jean-Charles wrote:
> Didn't you forget to amend the English version of changes.tely?…



I changed every changes.tely containing addLyrics in _master_
The english version is empty apart from defaults, because it was moved

to the

stable 2.18 branch.
I don't know how to change it there, see
http://lists.gnu.org/archive/html/lilypond-user/2017-11/msg00082.html


It should then be split in two patch-sets: one for LM/tweaks and
NR/vocal (applied in *master* – upcoming 2.21 — which would later be
cherry-picked in branch stable/2.20), and an other set for all
LL/changes.tely to be directly applied on stable/2.20.

A distinct pat-set should /empty/ the LL/changes.tely to reflect the
English version in master.

https://codereview.appspot.com/332110043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


typos and conistency (issue 332110043 by thomasmorle...@gmail.com)

2017-11-11 Thread lilyfan

Didn't you forget to amend the English version of changes.tely?…

https://codereview.appspot.com/332110043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Doc - NR: Add snippet for MM rests - space increment setting (issue 333970043 by pkx1...@gmail.com)

2017-11-04 Thread lilyfan

LGTM

https://codereview.appspot.com/333970043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: NR - rhythms.itely minor edits to Durations (issue 336030043 by pkx1...@gmail.com)

2017-11-04 Thread lilyfan

LGTM

https://codereview.appspot.com/336030043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: NR: Update Clef styles Appendix (issue 324420043 by pkx1...@gmail.com)

2017-09-24 Thread lilyfan

On 2017/09/24 14:20:08, pkx166h wrote:

Corrected the Note styles. Added more formatting changes.


Would you mind formatting the "Standard clefs" as well, which would then
"group" G, C and F-clefs and have a more pleasant layout?

https://codereview.appspot.com/324420043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Add how to change the notation fonts (issue 330040043 by truer...@gmail.com)

2017-08-26 Thread lilyfan

otherwise, LGTM


https://codereview.appspot.com/330040043/diff/40001/Documentation/notation/text.itely
File Documentation/notation/text.itely (right):

https://codereview.appspot.com/330040043/diff/40001/Documentation/notation/text.itely#newcode1624
Documentation/notation/text.itely:1624: @code{sans}, and
@code{typewriter} categoriles.
typo: categories

https://codereview.appspot.com/330040043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Web: Move older news to the attic page (issue 318630043 by paulwmor...@gmail.com)

2017-03-04 Thread lilyfan

On 2017/03/04 18:02:28, pkx166h wrote:

Fails make doc.



Seems to be a problem in the Catalan translations.



Processing web site: [ca]
*** Can't find web/news.itexi, skipping (in

/home/james/lilypond-git/Documentati

on/ca/web/community.itexi l. 1208)
Max error number exceeded


This line contains @include web/news.itexi that no longer exists.
It barfs because ca/ is the first alphabetically translations' subdir.

All LL/web/community.itexi should then be adapted.

No time to test this evening, must leave now.

https://codereview.appspot.com/318630043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Web: Move older news to the attic page (issue 318630043 by paulwmor...@gmail.com)

2017-03-04 Thread lilyfan

https://codereview.appspot.com/318630043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Ignore backslash when indexing (issue 300390043 by d...@gnu.org)

2016-06-15 Thread lilyfan

LGTM

That's where I put it yesterday for testing.

https://codereview.appspot.com/300390043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Issue 4557: Small typos in code base (issue 256470043 by d...@gnu.org)

2015-08-14 Thread lilyfan

On 2015/08/14 16:47:08, dak wrote:

On 2015/08/14 16:38:18, Jean-Charles wrote:
> Normally, you should not modify lilypond.pot as it is updated by

commit "PO:

> update template" during the releasing phase.
>
> For the *.po files, they are managed through the Free Translation

Project.


What does that imply for the issue/patch?


Only lily/change-iterator.cc python/convertrules.py and
scripts/lilypond-book.py should be part of it.
lilypond.pot and all .po files should be discarded from the patchset.

I was planning on sending lilypond.pot to the FTP on next release.

https://codereview.appspot.com/256470043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Issue 4557: Small typos in code base (issue 256470043 by d...@gnu.org)

2015-08-14 Thread lilyfan

Normally, you should not modify lilypond.pot as it is updated by commit
"PO: update template" during the releasing phase.

For the *.po files, they are managed through the Free Translation
Project.


https://codereview.appspot.com/256470043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Change comments like Voice "1" to Voice = "1" (issue 256860044 by d...@gnu.org)

2015-07-21 Thread lilyfan

LGTM


https://codereview.appspot.com/256860044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Doc Issue 4350: \compressFullBarRests needs a warning (issue 227470043 by tdanielsmu...@googlemail.com)

2015-04-24 Thread lilyfan

Otherwise, LGTM


https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):

https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely#newcode3193
Documentation/learning/fundamental.itely:3193: r4 f8 a | cis4 f | e4 d |
maybe add a "R2*2" to show the expansion?

https://codereview.appspot.com/227470043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Clarified how to use clip-systems option (issue 186640043 by pkx1...@gmail.com)

2015-01-11 Thread lilyfan

Sorry to come so late


https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely#newcode2543
Documentation/notation/input.itely:2543: (@code{5 1 2}) and
@emph{ending} after three, quarter notes in the
to avoid the comma and any ambiguity:
after the third quarter note…

https://codereview.appspot.com/186640043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Edit Kievan documentation (issue 193890043 by aleksandr.andr...@gmail.com)

2015-01-03 Thread lilyfan

LGTM for French


https://codereview.appspot.com/193890043/diff/1/Documentation/de/notation/ancient.itely
File Documentation/de/notation/ancient.itely (right):

https://codereview.appspot.com/193890043/diff/1/Documentation/de/notation/ancient.itely#newcode2670
Documentation/de/notation/ancient.itely:2670: \clef "kievan-do"
\kievanOn

https://codereview.appspot.com/193890043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Clarified how to use clip-systems option (issue 186640043 by pkx1...@gmail.com)

2015-01-02 Thread lilyfan

just one nitpick, otherwise LGTM.


https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2559
Documentation/notation/input.itely:2559: @ref{The layout block,,The
@code{@bs{}layout} block}.
No need for a third argument:
@ref{The layout block} references the @node but will be rendered like
the corresponding @sectioning argument (The @code{@bs{}layout} block)

https://codereview.appspot.com/186640043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Changes.tely updated - 2.19.x up to September 2014 (issue 147860043 by pkx1...@gmail.com)

2014-09-21 Thread lilyfan


https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode127
Documentation/changes.tely:127: the existing @code{\keepWithTag} and
@code{removeWithTag} commands.  For
@code{\keepWithTag} and @code{\removeWithTag}

https://codereview.appspot.com/147860043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread lilyfan

On 2014/08/25 10:13:52, Trevor Daniels wrote:

I think you're mistaken.  In the original file the unaltered English

notenames

were defined twice, and this patch alters just one of them, leaving

the other

unchanged.  So it does just add a variant.


Sorry, I did not expand enough!

https://codereview.appspot.com/133840043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread lilyfan

If I'm not mistaken, this patch *changes* every natural pitch in English
instead of just adding or including a variant for "natural".

Since this will modify what is in place since more than 15 years, it is
essential to document it, both in "changes" and over the documentation.

Too bad, I prefer English to French because "g" is much less typing than
"sol", and have always sung "mi" and "si" even when flattened or "fa"
even when sharpened...


https://codereview.appspot.com/133840043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-08-21 Thread lilyfan

On 2014/06/29 13:51:33, PhilEHolmes wrote:

Please review.


Sorry to step in like that.  I'm not able to comment on the code, but
have just one question, since I don't use incipits: does it happen that
the original score reproduced in an incipit happens to be on a four
lines staff? How would it then be verticaly positionned relatively to
the "modern" staff?

https://codereview.appspot.com/108270043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Changes from LSR doc run (issue 116040043 by philehol...@googlemail.com)

2014-07-20 Thread lilyfan

On 2014/07/20 16:49:33, mail_philholmes.net wrote:

- Original Message -
From: 


https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly

> File
>


Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly

> (right):
>


https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly#newcode136

>


Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly:136:

> %%% ATTENTION 
> Big block comments in French?
>
> In this form I'd lean towards removing the snippet from the import

list

> if that's feasible.
>



It is, but as a singer, I find that this is a valuable snippet.  I'll

tidy

it up in the LSR, so (as with the previous comment) I can't fix this

patch,

but will fix the snippet in a following patch.



Either ping Pierre to update this warning and word it in English
(X-translation to be adapted according to the key signature).

https://codereview.appspot.com/116040043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Changes from LSR doc run (issue 116040043 by philehol...@googlemail.com)

2014-07-20 Thread lilyfan

Good job! Thanks!


https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/editorial-headword.ly
File Documentation/snippets/editorial-headword.ly (right):

https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/editorial-headword.ly#newcode22
Documentation/snippets/editorial-headword.ly:22: %%
http://lsr.dsi.unimi.it/LSR/Snippet?id=627
should read lsr.di.unimi

https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/piano-template-simple.ly
File Documentation/snippets/piano-template-simple.ly (right):

https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/piano-template-simple.ly#newcode19
Documentation/snippets/piano-template-simple.ly:19: %%
http://lsr.dsi.unimi.it/LSR/Item?id=354
should read lsr.di.unimi

https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly
File
Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly
(right):

https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly#newcode29
Documentation/snippets/printing-a-repeat-sign-at-the-beginning-of-a-piece.ly:29:
% A |: bar line can be printed at the beginning of a piece,
by overriding the relevant property:
A @code{|:}

https://codereview.appspot.com/116040043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Changes from LSR doc run (issue 116040043 by philehol...@googlemail.com)

2014-07-20 Thread lilyfan

On 2014/07/20 15:45:14, email_philholmes.net wrote:

[...]


Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly:88:

> \once \once \hide NoteHead c'1 |
> Why this doubled "\once"?



Copy and paste error.  Unfortunately it's not trivial to correct

"properly"

within this patch.  I've corrected the file in the LSR and this will
therefore be corrected when I next run makelsr from the tarball.  That

will

need to be a new patch, because I've also done work on snippets/new in

the

interim.  I think we can live with a duplicate \once in the docs for a



couple of days.



As I cannot do any serious work because of a stormy weather (already 3
power breakages),
I'm reviewing each file, and let you know if I find something else...

Cheers.


https://codereview.appspot.com/116040043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Changes from LSR doc run (issue 116040043 by philehol...@googlemail.com)

2014-07-20 Thread lilyfan

I just picked one file, but there might be some other occurrences of
such "things".


https://codereview.appspot.com/116040043/diff/20001/Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly
File
Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly
(right):

https://codereview.appspot.com/116040043/diff/20001/Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly#newcode88
Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly:88:
\once \once \hide NoteHead c'1 |
Why this doubled "\once"?

https://codereview.appspot.com/116040043/diff/20001/Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly#newcode124
Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly:124:
\once \once \hide NoteHead g1 |
idem

https://codereview.appspot.com/116040043/diff/20001/Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly#newcode160
Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly:160:
\once \once \hide NoteHead e'1 |
idem

https://codereview.appspot.com/116040043/diff/20001/Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly#newcode192
Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly:192:
\once \once \hide NoteHead e1 |
idem

https://codereview.appspot.com/116040043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: NR: 1.4.1 Replaced deprecated snippet w\ @lilypond (issue 60840048)

2014-02-09 Thread lilyfan

On 2014/02/08 21:55:15, dak wrote:

Is there any way in which one can actually delete this snippet file

without

getting it carried back in via LSR?


According to CG 7.4:
"Snippets used in the documentation are in
'$LILYPOND_GIT/Documentation/snippets'.
This directory contains a complete set of the snippets in the LSR which
are tagged with 'docs'."

So, you would just need to remove the "docs" tag?

My 2 cents?

Jean-Charles

https://codereview.appspot.com/60840048/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Web:Reworded UNIX Download page more strongly not to use distro-based packages (issue 60180043)

2014-02-05 Thread lilyfan

LGTM

https://codereview.appspot.com/60180043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Issue 3720: Built-in templates for SATB vocal scores (issue 41990043)

2013-12-14 Thread lilyfan

LGTM, except one typo.


https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely
File Documentation/learning/templates.itely (right):

https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely#newcode53
Documentation/learning/templates.itely:53: Any of the staves my be
omitted.  Here, for example, is how the input
mAy be omitted

https://codereview.appspot.com/41990043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Track move of grammar to CG (issue 3015) in German translation (issue 14160044)

2013-10-01 Thread lilyfan

On 2013/10/01 11:52:35, dak wrote:

Use @rcontribnamed for translated link names


LGTM

https://codereview.appspot.com/14160044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: ERROR: Please install required programs: International New Century Schoolbook fonts

2013-09-13 Thread Lilyfan
> Message du 13/09/13 00:55
> De : "Julien Rioux" 
> On 12/09/2013 6:09 PM, Federico Bruni wrote:
> > 2013/8/3 Federico Bruni >
> >
> > I'm getting this error if I run ./autogen.sh in git master:
> >
> > ERROR: Please install required programs: International New Century
> > Schoolbook fonts International New Century Schoolbook fonts
> >
> > I can't find the missing package, I have all the ones listes in the CG.
> > What I'm missing?
> >
> >
> > In the same directory, now it works if I checkout master branch and I
> > still get this error if I checkout translation branch.
> > Probably issue 3526 fixed by Julien?
> >
> 
> Yes. Given multiple sets of installed Century fonts, ./configure now 
> tries to find one that does have the Cyrillic characters. Previously, it 
> would just take the first font location it could find, check that it had 
> Cyrillic characters, and bomb out when it didn't, without checking the 
> alternative locations for the font. I presume this fix hasn't made it 
> into the translation branch yet.
> 


I've planned a merge for tomorrow.

Cheers,
Jean-Charles

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Corrections to LM (Issue 3407) (issue 11455046)

2013-07-23 Thread lilyfan

Except one nitpick, LGTM


https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):

https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely#newcode2387
Documentation/learning/tweaks.itely:2387: by the trick of setting the
leftmost extent to infinity and
the trick of setting foo by setting blah
Either one might need a synonym?

https://codereview.appspot.com/11455046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Updates to NR chapter 2 (issue 10543044)

2013-06-25 Thread lilyfan

fro the rest, LGTM


https://codereview.appspot.com/10543044/diff/1/Documentation/notation/chords.itely
File Documentation/notation/chords.itely (right):

https://codereview.appspot.com/10543044/diff/1/Documentation/notation/chords.itely#newcode442
Documentation/notation/chords.itely:442: chordmusic = \relative c'{
space before opening bracket

https://codereview.appspot.com/10543044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Use @dots{} instead of ... in manuals (issue 10296043)

2013-06-15 Thread lilyfan

Reviewers: dak, Trevor Daniels, Graham Percival,

Message:
Follow up of issue 3392


Description:
Use @dots{} instead of ... in manuals

 Web: intro and helpus
 Doc: usage, extenting and learning

Please review this at https://codereview.appspot.com/10296043/

Affected files:
  M Documentation/extending/programming-interface.itely
  M Documentation/extending/scheme-tutorial.itely
  M Documentation/included/compile.itexi
  M Documentation/included/helpus.itexi
  M Documentation/learning/common-notation.itely
  M Documentation/learning/tweaks.itely
  M Documentation/usage/lilypond-book.itely
  M Documentation/usage/running.itely
  M Documentation/usage/suggestions.itely
  M Documentation/usage/updating.itely
  M Documentation/web/introduction.itexi



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Use @dots{} instead of ... in notation manual where appropriate (issue 9964043)

2013-06-04 Thread lilyfan

On 2013/06/04 18:33:41, dak wrote:

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/simultaneous.itely#newcode49

Documentation/notation/simultaneous.itely:49: @funindex <...>
On 2013/06/04 18:17:21, Jean-Charles wrote:
> @funindex <@dots{}>



No, the index is something that one looks literally for in Info files.

 So it

should not contain Texinfo sequences.


OK, sorry.

https://codereview.appspot.com/9964043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Use @dots{} instead of ... in notation manual where appropriate (issue 9964043)

2013-06-04 Thread lilyfan

There is also

notation/rhythms.itely:2320:If a manual beam is specified with
@code{[..]} set the beam

For the rest, LGTM


https://codereview.appspot.com/9964043/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/changing-defaults.itely#newcode678
Documentation/notation/changing-defaults.itely:678: @emph{..music..}
@emph{@dots{}music@dots{}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode101
Documentation/notation/input.itely:101: delimited by @code{%@{ .. %@}}
may be placed anywhere within an
delimited by @code{%@{@dots{}%@}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode136
Documentation/notation/input.itely:136: @var{..music..}
@var{@dots{}music@dots{}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode144
Documentation/notation/input.itely:144: @var{..text..}
@var{@dots{}text@dots{}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode155
Documentation/notation/input.itely:155: @var{..}
@var{@dots{}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode158
Documentation/notation/input.itely:158: @var{..}
@var{@dots{}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode161
Documentation/notation/input.itely:161: @var{..}
@var{@dots{}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode185
Documentation/notation/input.itely:185: ..text of second verse..
@dots{}text of second verse@dots{}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode188
Documentation/notation/input.itely:188: ..text of third verse..
@dots{}text of third verse@dots{}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode484
Documentation/notation/input.itely:484: A multi-line comment delimited
by @code{%@{ .. %@}}.
delimited by @code{%@{ @dots{} %@}}.

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode2964
Documentation/notation/input.itely:2964: @var{..music..}
@var{@dots{}music@dots{}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode2965
Documentation/notation/input.itely:2965: \layout @{ .. @}
\layout @{ @dots{} @}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode2968
Documentation/notation/input.itely:2968: \unfoldRepeats @var{..music..}
\unfoldRepeats @var{@dots{}music@dots{}}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/input.itely#newcode2969
Documentation/notation/input.itely:2969: \midi @{ .. @}
\midi @{ @dots{} @}

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/simultaneous.itely#newcode49
Documentation/notation/simultaneous.itely:49: @funindex <...>
@funindex <@dots{}>

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/simultaneous.itely#newcode382
Documentation/notation/simultaneous.itely:382: @funindex \voiceOne ...
\voiceFour
@funindex \voiceOne @dots{} \voiceFour

https://codereview.appspot.com/9964043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: elaborate explanation of accidentals within cadenzas (3078) (issue 8866043)

2013-04-25 Thread lilyfan

LGTM

Jean-Charles

https://codereview.appspot.com/8866043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: elaborate the placement of \paper blocks (2902) (issue 8599045)

2013-04-25 Thread lilyfan

LGTM

Jean-Charles

https://codereview.appspot.com/8599045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Remove space before the tie symbol (3133) (issue 8758047)

2013-04-25 Thread lilyfan

On 2013/04/25 15:20:07, dak wrote:

On 2013/04/25 15:10:35, Graham Percival wrote:
> I'm not wild about having ties without a space in front of them, but

I can't

> think of any rational reason for my reaction, so I guess LGTM.



Oh, there is a perfectly rational reason: ties are placed

symmetrically between

notes, so placing them symmetrically in the source code reflects this

symmetry.


However, the implementation and the resulting behavior does _not_ have

a similar

symmetry.  Which is not really all that new: we don't have comparable

input

symmetry with slurs either (though it would be interesting to try).


Might be because of "one bar per line":

a4 a a b~
b4 c c c

?
Otherwise, LGTM
Jean-Charles

https://codereview.appspot.com/8758047/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Document \absolute in Changes and Notation Reference (issue 8933043)

2013-04-25 Thread lilyfan

LGTM

Jean-Charles

https://codereview.appspot.com/8933043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Document the use of \temporary (2938) (issue 8859044)

2013-04-25 Thread lilyfan

LGTM

Jean-Charles

https://codereview.appspot.com/8859044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Augment section about titles (3103) (issue 8895044)

2013-04-22 Thread lilyfan

LGTM

Cheers,
Jean-Charles

https://codereview.appspot.com/8895044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: expand explanation of negative measurePosition (3080) (issue 8538050)

2013-04-21 Thread lilyfan


https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#newcode1422
Documentation/notation/rhythms.itely:1422: is usually positive and
indicates how much of the measure has passed
On 2013/04/21 12:15:24, Trevor Daniels wrote:

On 2013/04/21 09:25:49, Jean-Charles wrote:
> Sorry, but "minus 1/8" seems to me to be a negative value?



It is indeed!  But measurePosition is _usually_ positive.
It is only negative when manually set so by \partial.  Is
the following sentence not clear enough?


My bad! "usually" got mixed with the minus from the example.

https://codereview.appspot.com/8538050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Augment description of how to customise staff line positions (3175) (issue 8540046)

2013-04-21 Thread lilyfan

LGTM

https://codereview.appspot.com/8540046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: expand explanation of negative measurePosition (3080) (issue 8538050)

2013-04-21 Thread lilyfan


https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):

https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#newcode1422
Documentation/notation/rhythms.itely:1422: is usually positive and
indicates how much of the measure has passed
Sorry, but "minus 1/8" seems to me to be a negative value?

https://codereview.appspot.com/8538050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Replace transposition example (3159) (issue 8622047)

2013-04-21 Thread lilyfan

LGTM

https://codereview.appspot.com/8622047/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Error message: unexpected \new (3285) (issue 8581044)

2013-04-10 Thread lilyfan

LGTM,
amended with Ian's comment about _double_ angle brackets.

https://codereview.appspot.com/8581044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: doc: explain how to add lyrics to polyphonic sections (issue 3236) (issue 8384043)

2013-04-04 Thread lilyfan

Typo


https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):

https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely#newcode1637
Documentation/notation/vocal.itely:1637: contexts} which will result in
@emph{no lyrcis} being set for
@emph{no lyrics}

https://codereview.appspot.com/8384043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Add Czech translations (issue 7307088)

2013-02-10 Thread lilyfan

On 2013/02/10 16:51:30, PhilEHolmes wrote:

The Czech strings resemble what I deduced from reading what is in
Documentation/cs

LGTM

https://codereview.appspot.com/7307088/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Make documentation reflect presence of \tuplet (issue 7220052)

2013-01-29 Thread lilyfan

On 2013/01/29 17:25:19, Keith wrote:

I tried to write simpler texts, below.  If you are dissatisfied you >

can use them as inspiration.


I like this evident wording.

https://codereview.appspot.com/7220052/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES (issue 7029043)

2012-12-29 Thread lilyfan

Reviewers: dak, phileholmes_googlemail.com, Graham Percival,

Message:
Please review

Description:
PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES

Introduced with version 1.0.1 :
  in stepmake/stepmake/C.make
ALL_C_SOURCES = h, c, y and l files
  in stepmake/stepmake/Targets.make
ALL_PO_SOURCES = $(ALL_C_SOURCES) $(wildcard $(outdir)/*.hh)
$(wildcard $(outdir)/*.cc)

hh and cc files having since then been registered through
ALL_CC_SOURCES,
there is no need to double their entry,
Even worse, an "out of tree build" results in a doubled location of
parser.yy and lexer.ll (one with a full path).

Please review this at https://codereview.appspot.com/7029043/

Affected files:
  M stepmake/stepmake/po-targets.make


Index: stepmake/stepmake/po-targets.make
diff --git a/stepmake/stepmake/po-targets.make  
b/stepmake/stepmake/po-targets.make
index  
c971e513c034b8dcc6e45ef4ae05db00ea33370c..8919dab8239e69f0378a0d6071fc1d249f8bbff0  
100644

--- a/stepmake/stepmake/po-targets.make
+++ b/stepmake/stepmake/po-targets.make
@@ -29,7 +29,7 @@ local-po:
 else
 po: local-po
$(LOOP)
-ALL_PO_SOURCES = $(ALL_C_SOURCES) $(ALL_CC_SOURCES) $(PYTHON_SCRIPTS_IN)  
$(PY_MODULES_IN) $(SCM_FILES) $(wildcard $(outdir)/*.hh) $(wildcard  
$(outdir)/*.cc)
+ALL_PO_SOURCES = $(ALL_C_SOURCES) $(ALL_CC_SOURCES) $(PYTHON_SCRIPTS_IN)  
$(PY_MODULES_IN) $(SCM_FILES)

 local-po:
 ifneq ($(strip $(ALL_PO_SOURCES)),)
@echo $(ALL_PO_SOURCES)



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Using MSH Paris Nord server

2012-07-24 Thread Lilyfan

> Message du 25/07/12 00:08
> De : "Trevor Daniels" 
> A : "Graham Percival" , "John Mandereau" 
> Copie à : "lilypond-devel" 
> Objet : Re: Using MSH Paris Nord server
> 
> 
> Graham Percival wrote Tuesday, July 24, 2012 10:55 PM
> 
> > grenouille.lilynet.net.
> 
> I like it. Definitely better than crapaud which has an unfortunate
> connotation to English-speakers.
> 
> Trevor

When I was a child, I would have loved to be the "crapaud" being kissed by the 
princess.
A crapaud is also a size for grand piano.

Cheers,
Jean-Charles

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Documentation for cross staff stems (issue 6432063)

2012-07-23 Thread lilyfan

Just to be sure I understand correctly!


http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely
File Documentation/notation/keyboards.itely (right):

http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely#newcode426
Documentation/notation/keyboards.itely:426: automatic beams do not beam
the notes on one staff when it’s not
Once I've seen the snippet's code, I understand what you mean: "beware:
autobeam should be switched off somewhere!"

http://codereview.appspot.com/6432063/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: web: Linux => GNU/Linux. English only. (issue 6374060)

2012-07-12 Thread lilyfan

On 2012/07/12 12:47:46, janek wrote:

Also, i didn't touch translations (btw, is there a complete list of
Translation Meisters somewhere? didn't find in CG...).



The change will appear with a "check-translation" when master will be
merged in translation, or a special "view" on Documentation/ in gitk.


http://codereview.appspot.com/6374060/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: NR clarified \footnote command as a TextScript (issue 6137050)

2012-05-13 Thread lilyfan

Nitpicks, but I had to read twice and carefully the first paragraph and
I'm not sure to understand.


http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely#newcode1037
Documentation/notation/input.itely:1037: customize footnote indicators
to suit.
More digestible (?):
Footnotes can be crated for all grobs, TL markup or chord, either with
automatically incrementing numbers or customized footnote indicators.

http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely#newcode1140
Documentation/notation/input.itely:1140: command comes after the note or
rest associated with the item being
one "command" is enough!

http://codereview.appspot.com/6137050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: CG: add updating of lilypond.pot in the release process (issue 6195060)

2012-05-10 Thread lilyfan

Uploading new version


http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi
File Documentation/contributor/release-work.itexi (right):

http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi#newcode87
Documentation/contributor/release-work.itexi:87: make po-replace
On 2012/05/10 13:26:29, Graham Percival wrote:

Thanks, this is exactly the kind of thing I wanted you to do!



However, a few note: the po-replace must happen before the vi command,

otherwise

the "make po-replace" text will be sent to the vi command when I

copy&paste the

entire block.



Also, how about moving po-replace above the vi, then adding the git

commit ...

po/lilypond.pot above the vi command as well?  That'll make the

copy&paste

process easier.


Done.

http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi#newcode373
Documentation/contributor/release-work.itexi:373:
coordinator@@translationproject.org, mentioning lilypond-VERSION.pot
On 2012/05/10 13:26:29, Graham Percival wrote:

I think you already know this, but just to confirm: you know that this

isn't

part of the regular release process?


Yes, but it is not bad to give the correct contact...

http://codereview.appspot.com/6195060/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


CG: add updating of lilypond.pot in the release process (issue 6195060)

2012-05-08 Thread lilyfan

Reviewers: Graham Percival,

Message:
Both when releasing a stable or unstable version.

Description:
CG: add updating of lilypond.pot in the release process

Please review this at http://codereview.appspot.com/6195060/

Affected files:
  M Documentation/contributor/release-work.itexi


Index: Documentation/contributor/release-work.itexi
diff --git a/Documentation/contributor/release-work.itexi  
b/Documentation/contributor/release-work.itexi
index  
baa68a85e468768c8defbf0d24412aaba1570134..d86d6343434ab02ecaa0e72c4ae06938a892ee97  
100644

--- a/Documentation/contributor/release-work.itexi
+++ b/Documentation/contributor/release-work.itexi
@@ -84,6 +84,7 @@ git fetch
 git checkout origin/release/unstable
 git merge origin
 vi Documentation/web/news-front.itexi Documentation/web/news.itexi
+make po-replace
 @end example

 @item
@@ -91,6 +92,7 @@ Commit, push, switch back to master (or wherever else):

 @example
 git commit -m "Release: update news." Documentation/web/
+git commit -m "PO: update template." po/lilypond.pot
 git push origin HEAD:release/unstable
 git checkout master
 @end example
@@ -298,6 +300,13 @@ various websites, so be brief.
 Run convert-ly on all files, bump parser minimum version.

 @item
+Update lilypond.pot:
+
+@example
+make po-replace
+@end example
+
+@item
 Make directories on lilypond.org:

 @example
@@ -360,8 +369,8 @@ Disallow: /doc/v2.CURRENT-DEVELOPMENT/

 @itemize
 @item
-submit pots for translation: send url of tarball to
-translation@@iro.umontreal.ca, mentioning lilypond-VERSION.pot
+submit po template for translation: send url of tarball to
+coordinator@@translationproject.org, mentioning lilypond-VERSION.pot

 @item
 update links to distros providing lilypond packages?  link in:



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


PO: modifying po-replace before integrating it to the release process (issue 6188051)

2012-05-07 Thread lilyfan

Reviewers: Graham Percival,

Message:
Before integrating po-replace in the release process,
let build a well-formed lilypond.pot in one run.


Description:
PO: modifying po-replace before integrating it to the release process

Until now, updating the translation template file is disconnected from
the releasing process, which means that a dev or translator must

1- run 'po-replace',
2- embed lilypond.pot headers,
3- eliminate all po files that have been moved upwards from po/out to
po/
4- commit the new lilypond.pot
5- run 'make dist' to have a tarball,
6- notify the Free Translation Project where to pick up that tarbal.

The first three steps may already be reduced to one single step by
embedding lilypond.pot directly (with specific options and some 'sed'
when creating) and moving it only in po/, what does this patch.

A second step would be to have a call to po-replace when the Release
Meister enters the dance, which would "group" steps 4 and 5.

We then will have the same unique tarball to refer to, directly from
linuxaudio.

Please review this at http://codereview.appspot.com/6188051/

Affected files:
  M po/README
  M stepmake/stepmake/po-targets.make
  M stepmake/stepmake/podir-targets.make


Index: po/README
diff --git a/po/README b/po/README
index  
7b9c400308ecaa035ebd4846846d77c472d25ae9..f691dbb6b8714a6a72a0dc7e522fe55363e6c5f6  
100644

--- a/po/README
+++ b/po/README
@@ -28,12 +28,13 @@ automatically notified to lilypond-devel@gnu.org list  
by the FTP

 robot; you can also see LilyPond page on FTP.


-2) updating lilypond.pot: run 'make po-replace' at toplevel, clean up
-lilypond.pot header to make it look like its previous state, commit
-only lilypond.pot to Git and reset all .po files, roll a tarball with
-'make dist', upload it somewhere on the web (or wait for the release),
-and send a notification to FTP coordinator with a link to the tarball.
-
+2) updating lilypond.pot: run 'make po-replace' at toplevel, commit
+lilypond.pot to Git, roll a tarball with 'make dist', upload it
+somewhere on the web (or wait for the release), and send a notification
+to FTP coordinator with a link to the tarball.
+Running 'po-update' at top-level and opening either po/out/fr.po or
+po/out/es.po gives you an idea of the changes that have affected
+the sources (number of fuzzy and untranslated stings).

 Rationale
 =
Index: stepmake/stepmake/po-targets.make
diff --git a/stepmake/stepmake/po-targets.make  
b/stepmake/stepmake/po-targets.make
index  
05088ee1700a49164a67681a3e5f84d75ded7c06..bb6215cf3025161afd1a5b7452f9e2abdfb011b9  
100644

--- a/stepmake/stepmake/po-targets.make
+++ b/stepmake/stepmake/po-targets.make
@@ -1,5 +1,14 @@
-
-
+XGETTEXT_OPTIONS = \
+   --default-domain=$(package) \
+   --from-code=UTF-8 \
+   --join \
+   --add-comments \
+	 
--msgid-bugs-address="http://post.gmane.org/post.php?group=gmane.comp.gnu.lilypond.bugs";  
\

+   --package-name=$(package) \
+   --package-version=$(VERSION)
+
+sed-header = \# Translation of LilyPond\n\# Copyright \(C\) 1998--2012  
Han-Wen Nienhuys, Jan Nieuwenhuizen.\n\# This file is distributed under the  
same license as the LilyPond package.

+sed-content = "Content-Type: text\/plain; charset=UTF-8\\n"

 
  UGH!
@@ -21,12 +30,14 @@ ALL_PO_SOURCES = $(ALL_C_SOURCES) $(ALL_CC_SOURCES)  
$(PYTHON_SCRIPTS_IN) $(PY_MO

 local-po:
 ifneq ($(strip $(ALL_PO_SOURCES)),)
@echo $(ALL_PO_SOURCES)
-   xgettext --default-domain=$(package) --join \
---output-dir=$(po-dir)/$(outdir) --add-comments \
+   xgettext $(XGETTEXT_OPTIONS) --output-dir=$(po-dir)/$(outdir) \
 --keyword=_ --keyword=_f --keyword=_i \
 $(XGETTEXT_FLAGS) $(ALL_PO_SOURCES)
 endif
 endif
+   sed -i '1,2d' $(po-dir)/$(outdir)/$(package).po
+	sed -i -e 's/^\# This file is distributed.*/$(sed-header)/'  
$(po-dir)/$(outdir)/$(package).po
+	sed -i -e 's/^\"Content-Type: text\/plain.*/$(sed-content)/'  
$(po-dir)/$(outdir)/$(package).po



 po-update: po
Index: stepmake/stepmake/podir-targets.make
diff --git a/stepmake/stepmake/podir-targets.make  
b/stepmake/stepmake/podir-targets.make
index  
0b831c5c797b622a230d2d80ea0be2a3c80bd99a..fdfa5ef33f472194b1701629b34edc85a8dd1f8f  
100644

--- a/stepmake/stepmake/podir-targets.make
+++ b/stepmake/stepmake/podir-targets.make
@@ -29,4 +29,3 @@ po-changes:

 po-replace: po-update
mv $(outdir)/$(package).po $(package).pot
-   mv $(outdir)/*.po .



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: [PATCH 1/2] Fix spelling definiton -> definition

2012-01-20 Thread Lilyfan

> Message du 20/01/12 09:15
> De : "James"
> A : "Lilyfan"
> Copie à : "StefanWeil" , lilypond-devel@gnu.org
> Objet : Re: [PATCH 1/2] Fix spelling definiton -> definition
>
> Jean-Charles,
>
> On 20 January 2012 08:02, Lilyfan wrote:
> >
> >> Message du 20/01/12 03:42
> >> De : "Stefan Weil"
> >> A : lilypond-devel@gnu.org
> >> Copie à : "Stefan Weil"
> >> Objet : [PATCH 1/2] Fix spelling definiton -> definition
> >>
> >> Signed-off-by: Stefan Weil ---
> >> po/cs.po
> ...
>
> >
> > Please *never* patch the po directory: all translations transit
> > on the Free Translation Project. The master file, lilypond.pot,
> > is generated by a dedicated script I will run when 2.16-RC1 comes out.
> >
> > The po files are to the responsability of a due translator who willl send
> > his updated native po file to the FTP.
>
> Should we mention this in the Contributor Guide somewhere -
> Documentation Translation didn't seem the appropriate place?
>

I think it should be worth it. In fact, it doesn't belong to translations
but rather directly to the source code (everything that will be "gettextified").

Ooops, my chief...
further read after office-time

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


re: [PATCH 1/2] Fix spelling definiton -> definition

2012-01-20 Thread Lilyfan

> Message du 20/01/12 03:42
> De : "Stefan Weil"
> A : lilypond-devel@gnu.org
> Copie à : "Stefan Weil"
> Objet : [PATCH 1/2] Fix spelling definiton -> definition
>
> Signed-off-by: Stefan Weil ---
> po/cs.po
> po/de.po
> po/el.po
> po/es.po
> po/fr.po
> po/it.po
> po/ja.po
> po/lilypond.pot
> po/nl.po
> po/vi.po

Please *never* patch the po directory: all translations transit
on the Free Translation Project. The master file, lilypond.pot,
is generated by a dedicated script I will run when 2.16-RC1 comes out.

The po files are to the responsability of a due translator who willl send
his updated native po file to the FTP.

Cheers,
Jean-Charles

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


re: can't release 2.15.17 due to translators

2011-11-10 Thread Lilyfan
> Message du 09/11/11 21:00
> De : "Graham Percival"
> A : lilypond-devel@gnu.org
> Copie à :
> Objet : can't release 2.15.17 due to translators
>
> can somebody fix this? and depending on dak, either push directly
> to master (which means he has to play yet more games with
> dev/staging), or push to dev/staging and then wait for James to do
> his stuff and then I'll try making 2.15.17 again then.
>
>
> file from VC not distributed:
> lilypond-2.15.17/Documentation/fr/texidocs/alternative-breve-note.texidocs


My deepest apologies, I cannot correct it until this evening (worktime 
08:00-18:00).

file name should not have any trailing *S*

Documentation/fr/texidocs/alternative-breve-note.texidoc

Cheers,
Jean-Charles

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel