Patchy email
Begin LilyPond compile, commit: 05efb98f2e3ff68f4bb8221db640b0174bfcde93 Merged staging, now at: b445e1b4207996eee2362187fa3e8b8af8ff05ba Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make clean -j3 CPU_COUNT=3 Success:nice make -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make test -j3 CPU_COUNT=3 Previous good commit: 05efb98f2e3ff68f4bb8221db640b0174bfcde93 Current broken commit: b445e1b4207996eee2362187fa3e8b8af8ff05ba ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 8019ff784cd3aa6cc43b8eb8f29a621bc5800f5c Merged staging, now at: f1b7a60cdb4c2f1d41329a1b3a6a01f4306f6467 Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make clean -j3 CPU_COUNT=3 Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 8019ff784cd3aa6cc43b8eb8f29a621bc5800f5c Current broken commit: f1b7a60cdb4c2f1d41329a1b3a6a01f4306f6467 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 11cf086eaba246f043d553a8bafcdbf1b47b9117 Merged staging, now at: b667b7fe1bf651b7373014204edbe0e68f17326e Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make clean -j3 CPU_COUNT=3 Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 11cf086eaba246f043d553a8bafcdbf1b47b9117 Current broken commit: b667b7fe1bf651b7373014204edbe0e68f17326e ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: ee12a32549ed3802251669b9ad511141fda7b9a0 Merged staging, now at: b70e6aaf640755d503add64bec847126761bc8c0 Success:./autogen.sh --noconfigure Success:../configure --disable-optimising *** FAILED BUILD *** nice make -j3 CPU_COUNT=3 Previous good commit: ee12a32549ed3802251669b9ad511141fda7b9a0 Current broken commit: b70e6aaf640755d503add64bec847126761bc8c0 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 42984d05239a3c3be1ea859ba5214ce140448afc Merged staging, now at: 42984d05239a3c3be1ea859ba5214ce140448afc Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 820c7ff5d380e8ca52057717ab3176b5e40107fd Current broken commit: 42984d05239a3c3be1ea859ba5214ce140448afc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 76801e173f3815c1347e5685195059a01676cd75 Merged staging, now at: cf023c3d5b03b333cb5e5c3c50ab8d6635efdc60 Success:./autogen.sh --noconfigure Success:../configure --disable-optimising *** FAILED BUILD *** nice make -j3 CPU_COUNT=3 Previous good commit: 820c7ff5d380e8ca52057717ab3176b5e40107fd Current broken commit: cf023c3d5b03b333cb5e5c3c50ab8d6635efdc60 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 76801e173f3815c1347e5685195059a01676cd75 Merged staging, now at: 9b10eba64e43dcb9488366db7ae7723a6df123d6 Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 76801e173f3815c1347e5685195059a01676cd75 Current broken commit: 9b10eba64e43dcb9488366db7ae7723a6df123d6 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 76801e173f3815c1347e5685195059a01676cd75 Merged staging, now at: a13c09c267ce9abfd1fe063019aefc16a49322d7 Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 76801e173f3815c1347e5685195059a01676cd75 Current broken commit: a13c09c267ce9abfd1fe063019aefc16a49322d7 Begin LilyPond compile, commit: 76801e173f3815c1347e5685195059a01676cd75 Merged staging, now at: 9b10eba64e43dcb9488366db7ae7723a6df123d6 Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 76801e173f3815c1347e5685195059a01676cd75 Current broken commit: 9b10eba64e43dcb9488366db7ae7723a6df123d6 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 2f25894efd8ad242b233d5a1d07afcfa087ebab2 Merged staging, now at: c1a1f9684b6cfab2e4b4d813db6058c7d22b9b0a Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 2fd5a378f5d883536b1aac57583d261ce60a4043 Current broken commit: c1a1f9684b6cfab2e4b4d813db6058c7d22b9b0a ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 2f25894efd8ad242b233d5a1d07afcfa087ebab2 Merged staging, now at: a14c8e86aa0a5e438d6b7a296617bb18ac08b5fb Success:./autogen.sh --noconfigure Success:../configure --disable-optimising *** FAILED BUILD *** nice make -j3 CPU_COUNT=3 Previous good commit: 99ff3c45ac880bc5ba46859ef8206d95a3c6521b Current broken commit: a14c8e86aa0a5e438d6b7a296617bb18ac08b5fb ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 2f25894efd8ad242b233d5a1d07afcfa087ebab2 *** FAILED STEP *** merge from staging maybe somebody pushed a commit directly to master? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 2f25894efd8ad242b233d5a1d07afcfa087ebab2 Merged staging, now at: cf90f405d8036dc736449f51fca6b5eff3e61d4e Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: dcbe4a2d00afb92b422ca782fa3582247359d029 Current broken commit: cf90f405d8036dc736449f51fca6b5eff3e61d4e ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: eb1eabe03dd1b822b5536e4bdeba8f69c43754cb Merged staging, now at: eb1eabe03dd1b822b5536e4bdeba8f69c43754cb Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 3c46876d446ca034e2b109302941586061865a01 Current broken commit: eb1eabe03dd1b822b5536e4bdeba8f69c43754cb ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: eb1eabe03dd1b822b5536e4bdeba8f69c43754cb Merged staging, now at: eb1eabe03dd1b822b5536e4bdeba8f69c43754cb Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: 3c46876d446ca034e2b109302941586061865a01 Current broken commit: eb1eabe03dd1b822b5536e4bdeba8f69c43754cb ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 008e88de999af6027fdd9d10df23e99414e57958 *** FAILED STEP *** merge from staging maybe somebody pushed a commit directly to master? Begin LilyPond compile, commit: 008e88de999af6027fdd9d10df23e99414e57958 *** FAILED STEP *** merge from staging maybe somebody pushed a commit directly to master? Begin LilyPond compile, commit: 008e88de999af6027fdd9d10df23e99414e57958 Merged staging, now at: 008e88de999af6027fdd9d10df23e99414e57958 Success:./autogen.sh --noconfigure Success:../configure --disable-optimising *** FAILED BUILD *** nice make -j3 CPU_COUNT=3 Previous good commit: 3c46876d446ca034e2b109302941586061865a01 Current broken commit: 008e88de999af6027fdd9d10df23e99414e57958 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 1665810dee903c597ecafdbf64461899141165f4 Merged staging, now at: 008e88de999af6027fdd9d10df23e99414e57958 Success:./autogen.sh --noconfigure Success:../configure --disable-optimising *** FAILED BUILD *** nice make -j3 CPU_COUNT=3 Previous good commit: 3c46876d446ca034e2b109302941586061865a01 Current broken commit: 008e88de999af6027fdd9d10df23e99414e57958 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: 1665810dee903c597ecafdbf64461899141165f4 *** FAILED STEP *** merge from staging maybe somebody pushed a commit directly to master? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: aeda0cc2675a13ade10f3f97630ffa7dadd111aa Success:No new commits in staging Begin LilyPond compile, commit: aeda0cc2675a13ade10f3f97630ffa7dadd111aa Success:No new commits in staging Begin LilyPond compile, commit: aeda0cc2675a13ade10f3f97630ffa7dadd111aa Success:No new commits in staging Begin LilyPond compile, commit: aeda0cc2675a13ade10f3f97630ffa7dadd111aa *** FAILED STEP *** merge from staging maybe somebody pushed a commit directly to master? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patchy email
Begin LilyPond compile, commit: f8e03b152b436d6034dd17e71335fc6221497571 Merged staging, now at: 438084fc487d6e575500a4e2866ef750476ce6cf Success:./autogen.sh --noconfigure Success:../configure --disable-optimising Success:nice make -j3 CPU_COUNT=3 Success:nice make test -j3 CPU_COUNT=3 *** FAILED BUILD *** nice make doc -j3 CPU_COUNT=3 Previous good commit: f8e03b152b436d6034dd17e71335fc6221497571 Current broken commit: 438084fc487d6e575500a4e2866ef750476ce6cf ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: CG: add instructions for staging branch (issue 5440080)
Reviewers: Graham Percival, Keith, c_sorensen_byu.edu, mail_philholmes.net, J_lowe, Message: sorry, I uploaded this with the wrong account. The patch continues here: http://codereview.appspot.com/5467051/ Description: Doc: CG: add instructions for staging branch Please review this at http://codereview.appspot.com/5440080/ Affected files: M Documentation/contributor/issues.itexi M Documentation/contributor/source-code.itexi Index: Documentation/contributor/issues.itexi diff --git a/Documentation/contributor/issues.itexi b/Documentation/contributor/issues.itexi index b72831ed2e59de4650b4eecb0fb3deff9deff8ab..fa8755c1ff025a10bcc5c7f80d20ee09169e67aa 100644 --- a/Documentation/contributor/issues.itexi +++ b/Documentation/contributor/issues.itexi @@ -769,6 +769,15 @@ email should contain a link to the issue you just added. @warning{This is not a Bug Squad responsibility; we have a separate person handling this task.} +For contributors/developers: follow the steps in +@ref{Commits and patches}, and @ref{Pushing to staging}. + +For people doing maintenance tasks: git-cl is adding issues, James +is testing them, Colin is selecting them for countdowns, and +Patchy is merging from staging to master. In the coming weeks, +these tasks will be more and more automated. + +@ignore There is a single Patch Meister, and a number of Patch Helpers (rename this?). The list of known patches awaiting review is: @@ -806,6 +815,7 @@ message) on the webgit page: @uref{http://git.savannah.gnu.org/gitweb/?p=lilypond.git} @end example @end ignore +@ignore @item If the patch is clearly in response to an existing issue, then @@ -883,7 +893,7 @@ weeks. @end itemize - +@end ignore @node Summary of project status Index: Documentation/contributor/source-code.itexi diff --git a/Documentation/contributor/source-code.itexi b/Documentation/contributor/source-code.itexi index 27d8236b64e0850783b7b5df12098ffbe6b73a5f..3f5fbd73dc606e36cc0ffb9b460f5793bef42806 100644 --- a/Documentation/contributor/source-code.itexi +++ b/Documentation/contributor/source-code.itexi @@ -1076,6 +1076,23 @@ running: git cl issue 0 @end example +@subsubheading Wait for a countdown + +Your patch will be available for reviews for the next few hours or +days. Three times a week, patches with no known problems are +gathered into a @qq{patch countdown} and their status changed to +@code{patch-countdown}. The countdown is a 48-hour waiting period +in which any final reviews or complaints should be made. + +During the countdown, your patch may be set to +@code{patch-needs_work}, indicating that you should fix something +(or at least discuss why the patch needs no modification). If no +problems are found, the patch will be set to @code{patch-push}. + +Once a patch has @code{patch-push}, it should be sent to your +mentor for uploading. If you have git push ability, look at +@ref{Pushing to staging}. + @node Advanced Git procedures @section Advanced Git procedures @@ -1104,6 +1121,7 @@ several Git branches of LilyPond source code is presented. * Sending and receiving patches via email:: * Cleaning up multiple patches:: * Commit access:: +* Pushing to staging:: @end menu @@ -1390,7 +1408,6 @@ remove those commits.} @node Commit access @subsection Commit access - Most contributors are not able to commit patches directly to the main repository---only members of the LilyPond development team have @emph{commit access}. If you are a contributor and are @@ -1567,6 +1584,9 @@ Git properly in the previous step. @item Test your commit access with a dry run: +@warning{Do not push directly to master; instead, push to staging. +See @ref{Pushing to staging}.} + @example git push --dry-run --verbose @end example @@ -1658,6 +1678,29 @@ broadband may use a slightly smaller MTU for efficient transmission over ATM. If this problem is encountered a possible work-around is to set the MTU in the local router to 1500. +@node Pushing to staging +@subsection Pushing to staging + +Do not push directly to the git @code{master} branch. Instead, +push to @code{staging}. Assuming that your patch is in a file +called @file{0001-my-patch.patch}, and you are currently on git +master, do: + +@example +git checkout staging +git pull +git am 0001-my-patch.patch +git push origin staging +git checkout master +@end example + +You will not see your patch on @code{master} until some automatic +tests have been run. These tests are run every couple of hours; +please wait at least 12 hours before wondering if your patch has +been lost. Note that you can check the commits on @code{staging} +by looking at the git web interface on savannah. + + @node Git on Windows @section Git on Windows ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel