Re: Issue 5217: Fix sorting order without outside-staff-priority (issue 554960043 by jonas.hahnf...@gmail.com)
Interestingly (or not) I did 3 patch runs on this patch and 2 out of 3 times I still got the reg test showing. I have some time today so I'll see if I can spot anything and update accordingly. Jams https://codereview.appspot.com/554960043/
Re: NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (issue 560790043 by pkxgnugi...@runbox.com)
~~~ NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly staging author Hassan Elfatihi Sun, 30 Jun 2019 10:49:45 +0100 (10:49 +0100) committer James Lowe Sun, 14 Jul 2019 13:22:41 +0100 (13:22 +0100) commit c24f83991b772a65c15b6290cf70d725def117bd ~~~ Hassan did comment on the example used, but I will deal with that in a separate patch. Closing this one. https://codereview.appspot.com/560790043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: New function css-color (issue 580780043 by g...@ursliska.de)
This was stuck as 'please push' for weeks. I have retested the patch today and am pushing it on Ur's behalf - seems a shame to waste the work otherwise. ~~~ Enhancement - New function css-color staging author Urs Liska Sun, 14 Jul 2019 13:16:17 +0100 (13:16 +0100) committer James Lowe Sun, 14 Jul 2019 13:19:19 +0100 (13:19 +0100) commit a5e0b01b0c8251cf0244e05467938b813fc8fa0a ~~~ https://codereview.appspot.com/580780043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Use new syntax throughout the doc and examples (issue 572640043 by v.villen...@gmail.com)
This was stuck as 'please push' for weeks. I have retested the patch today and am pushing it on VV's behalf - seems a shame to waste the work otherwise. Doc: Use new syntax throughout all doc and examples staging author Valentin Villenave Sun, 14 Jul 2019 13:02:02 +0100 (13:02 +0100) committer James Lowe Sun, 14 Jul 2019 13:07:17 +0100 (13:07 +0100) commit 47f74e11cfdf3f7dfa54ca0b1d009da770d6aef5 https://codereview.appspot.com/572640043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
Lukas-Fabian, see the comments about reverting a previous commit within this patch. I didn't see any reply so am leaving this patch on 'Review' until the next countdown cycle on the 11th https://codereview.appspot.com/570830043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Use new syntax throughout the doc and examples (issue 572640043 by v.villen...@gmail.com)
On 2019/04/25 21:27:39, Valentin Villenave wrote: spaces not tabs… Patch counted down - please push https://codereview.appspot.com/572640043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: New function css-color (issue 580780043 by g...@ursliska.de)
On 2019/06/05 14:57:11, git wrote: This is a follow-up patch to https://codereview.appspot.com/570690043/ For some reason it was uploaded as a new patch, and Issue https://sourceforge.net/p/testlilyissues/issues/5524/ wasn't updated. This new patch attempts a cleaner separation of color definitions between X11 and CSS colors, avoiding duplication. As with the original patch, I'll document it when there's basic agreement. Patch counted down - please push https://codereview.appspot.com/580780043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
stem.cc - issue 5303 - misplaced notehead (issue 570830043 by pkxgnugi...@runbox.com)
Reviewers: ,
Message:
Passes make, make check and a full make doc.
Description:
stem.cc - issue 5303 - misplaced notehead
In loop calculating the attachments
of chord node heads to stem,
calculate last used position by
_rounding_ to int rather than by
truncating to int.
This fixes issue 5303 (misplaced note head bug).
Also add regression test.
Please review this at https://codereview.appspot.com/570830043/
Affected files (+15, -1 lines):
A input/regression/misplaced-note-head-bug.ly
M lily/stem.cc
Index: input/regression/misplaced-note-head-bug.ly
diff --git a/input/regression/misplaced-note-head-bug.ly
b/input/regression/misplaced-note-head-bug.ly
new file mode 100644
index
..1e5918631c27039e7f75dbf44c6f215363aaa970
--- /dev/null
+++ b/input/regression/misplaced-note-head-bug.ly
@@ -0,0 +1,14 @@
+\version "2.19.16"
+
+\header {
+
+ texidoc = "Misplaced note head bug (issue 5303) should be fixed."
+
+}
+
+\layout {
+ #(layout-set-staff-size 19)
+}
+
+
+{ 2 \clef bass }
Index: lily/stem.cc
diff --git a/lily/stem.cc b/lily/stem.cc
index
37aa40c250934eb08d1bc6f16bd7598671099193..34bf557fca9c538f22c5fe9c3ff85895ab0f2bca
100644
--- a/lily/stem.cc
+++ b/lily/stem.cc
@@ -626,7 +626,7 @@ Stem::calc_positioning_done (SCM smob)
else
parity = true;
- lastpos = int (p);
+ lastpos = int (round (p));
}
return SCM_BOOL_T;
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly (issue 560790043 by pkxgnugi...@runbox.com)
Reviewers: lemzwerg, anthoneyhughes88,
Message:
Thanks Werner
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode185
Documentation/notation/world.itely:185: The @code{hel-arabic.ly} file
allows English note names to be used.
On 2019/07/01 02:54:33, lemzwerg wrote:
Please use `@file' for file names.
Done.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode257
Documentation/notation/world.itely:257: are defined in either
@code{hel-arabic} or @file{arabic.ly} files and
On 2019/07/01 02:54:33, lemzwerg wrote:
@file{hel-arabic.ly} ?
Done.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode262
Documentation/notation/world.itely:262: music. Arabic maqams only allow
for limited modulations, due to the
On 2019/07/01 02:54:33, lemzwerg wrote:
Please use two spaces after a full stop that ends a sentence.
Done.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode266
Documentation/notation/world.itely:266: of music;
On 2019/07/01 02:54:33, lemzwerg wrote:
Instead of a semicolon I think it's better to use either a full stop
or a colon.
Done.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode281
Documentation/notation/world.itely:281: below (e.g. @notation{bayati},
@notation{hussaini}, @notation{saba}, and
On 2019/07/01 02:54:33, lemzwerg wrote:
e.g.,
Done.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode282
Documentation/notation/world.itely:282: @notation{ushaq} can be
indicated in the same way. These are all
On 2019/07/01 02:54:33, lemzwerg wrote:
@notation{ushaq})
Done.
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely#newcode290
Documentation/notation/world.itely:290: parenthesis for those that are
modulations of their base maqam.
On 2019/07/01 02:54:33, lemzwerg wrote:
parentheses
Done.
Description:
NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly
Using information provided
by Hassan Elfatihi this
section now includes
references to the
significantly updated
hel-arabic.ly file.
Other fixes include making
sure we follow CG policy with
@seealso ordering as well
as line length and some
@notation{} syntax additions.
Please review this at https://codereview.appspot.com/560790043/
Affected files (+82, -50 lines):
M Documentation/notation/world.itely
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: New function css-color (issue 580780043 by g...@ursliska.de)
Patch counted down - please push https://codereview.appspot.com/580780043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Use new syntax throughout the doc and examples (issue 572640043 by v.villen...@gmail.com)
Patch counted down - please push https://codereview.appspot.com/572640043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 568820043 by pkxgnugi...@runbox.com)
https://codereview.appspot.com/568820043/diff/582790043/config.make.in
File config.make.in (right):
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode23
config.make.in:23: CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS)
$(GUILE_CFLAGS)
On 2019/06/17 07:59:41, knupero wrote:
This breaks building.
If you break lines, you need to use ' \'
Ah yes, of course!. Sorry ("it's not just white space James!").
Done.
Although it didn't break the patch test - which would have done a new
'make' after it had been applied (after a make test-baseline had been
done). So I am guessing that the normal Patch Test Workflow does not
work for these files?
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode25
config.make.in:25: CONFIG_CXXFLAGS = @CXXFLAGS@ $(GUILE_CFLAGS)
$(FREETYPE2_CFLAGS)
On 2019/06/17 07:59:41, knupero wrote:
see above
Done.
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode36
config.make.in:36: CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GLIB_LIBS)
$(GUILE_LIBS)
On 2019/06/17 07:59:41, knupero wrote:
see above
Done.
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode37
config.make.in:37: $(PANGO_FT2_LIBS) $(FONTCONFIG_LIBS)
On 2019/06/17 07:59:41, knupero wrote:
see above
Done.
https://codereview.appspot.com/568820043/diff/582790043/configure.ac
File configure.ac (right):
https://codereview.appspot.com/568820043/diff/582790043/configure.ac#newcode301
configure.ac:301: STEPMAKE_GLIB(glib-2.0, REQUIRED, 2.44)
On 2019/06/17 07:59:41, knupero wrote:
A gub build revealed that we use glib 2.38 for freebsd cross builds.
'2.44' must
be changed to '2.38'
Done.
https://codereview.appspot.com/568820043/diff/582790043/configure.ac#newcode302
configure.ac:302: STEPMAKE_GOBJECT(gobject-2.0, REQUIRED, 2.44)
On 2019/06/17 07:59:41, knupero wrote:
Same as above, change '2.44' to '2.38'
Done.
https://codereview.appspot.com/568820043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 568820043 by pkxgnugi...@runbox.com)
Reviewers: lemzwerg, https://codereview.appspot.com/568820043/diff/550830043/config.make.in File config.make.in (right): https://codereview.appspot.com/568820043/diff/550830043/config.make.in#newcode34 config.make.in:34: CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GLIB_LIBS) $(GUILE_LIBS) $(PANGO_FT2_LIBS) $(FONTCONFIG_LIBS) $(FREETYPE2_LIBS) On 2019/06/16 19:38:50, lemzwerg wrote: Not really important, but I would prefer if we don't intentionally introduce overlong lines... Done. Description: Add glib-2.0 and gobject-2.0 library dependency For a long time we relied on pango/pangoft2 to pull in the glib and gobject libraries. That worked as long as every distribution used a pangoft2.pc file that included both libs in the 'Required:' line. According to the pkg-config documentation that was definitely wrong, and the problem was corrected on opensuse tumbleweed recently. As a consequence building lilypond failed with a linker error as we use symbols from both libs directly in our c++ source code. Signed-off-by: Knut Petersen Please review this at https://codereview.appspot.com/568820043/ Affected files (+44, -2 lines): M aclocal.m4 M config.make.in M configure.ac Index: aclocal.m4 diff --git a/aclocal.m4 b/aclocal.m4 index aec7813fc01b2067191f32adfc2e6f06d74f0ae8..dc088ea3f988c2285782093979835b450fdf317f 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -1337,6 +1337,44 @@ AC_DEFUN(PKG_CHECK_MODULES, [ fi ]) +AC_DEFUN(STEPMAKE_GLIB, [ +PKG_CHECK_MODULES(GLIB, $1 >= $3, have_glib=yes, true) +if test "$have_glib" = yes; then + AC_DEFINE(HAVE_GLIB) +save_CPPFLAGS="$CPPFLAGS" +save_LIBS="$LIBS" + CPPFLAGS="$GLIB_CFLAGS $CPPFLAGS" + LIBS="$GLIB_LIBS $LIBS" + AC_SUBST(GLIB_CFLAGS) + AC_SUBST(GLIB_LIBS) + CPPFLAGS="$save_CPPFLAGS" + LIBS="$save_LIBS" +else + r="libglib-dev or glib?-devel" + ver="`pkg-config --modversion $1`" + STEPMAKE_ADD_ENTRY($2, ["$r >= $3 (installed: $ver)"]) +fi +]) + +AC_DEFUN(STEPMAKE_GOBJECT, [ +PKG_CHECK_MODULES(GOBJECT, $1 >= $3, have_gobject=yes, true) +if test "$have_gobject" = yes; then + AC_DEFINE(HAVE_GOBJECT) +save_CPPFLAGS="$CPPFLAGS" +save_LIBS="$LIBS" + CPPFLAGS="$GOBJECT_CFLAGS $CPPFLAGS" + LIBS="$GOBJECT_LIBS $LIBS" + AC_SUBST(GOBJECT_CFLAGS) + AC_SUBST(GOBJECT_LIBS) + CPPFLAGS="$save_CPPFLAGS" + LIBS="$save_LIBS" +else + r="libgobject-dev or gobject?-devel" + ver="`pkg-config --modversion $1`" + STEPMAKE_ADD_ENTRY($2, ["$r >= $3 (installed: $ver)"]) +fi +]) + AC_DEFUN(STEPMAKE_FREETYPE2, [ PKG_CHECK_MODULES(FREETYPE2, $1 >= $3, have_freetype2=yes, true) Index: config.make.in diff --git a/config.make.in b/config.make.in index 420600ae8e5327a676be2940362e457ba6b6c3ce..97cf5634cb16c216913287437314e4deefc58a4b 100644 --- a/config.make.in +++ b/config.make.in @@ -15,11 +15,12 @@ FREETYPE2_CFLAGS = @FREETYPE2_CFLAGS@ GUILE_CFLAGS = @GUILE_CFLAGS@ PANGO_FT2_CFLAGS = @PANGO_FT2_CFLAGS@ PYTHON_CFLAGS = @PYTHON_CFLAGS@ +GLIB_CLFAGS = @GLIB_CFLAGS@ @GOBJECT_CFLAGS@ CONFIG_CPPFLAGS = @CPPFLAGS@ CONFIG_DEFINES = @DEFINES@ -CONFIG_CFLAGS = @CFLAGS@ $(GUILE_CFLAGS) $(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS) +CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS) $(GUILE_CFLAGS) $(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS) CONFIG_CXXFLAGS = @CXXFLAGS@ $(GUILE_CFLAGS) $(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS) FONTCONFIG_LIBS = @FONTCONFIG_LIBS@ @@ -28,8 +29,9 @@ FREETYPE2_LIBS = @FREETYPE2_LIBS@ PANGO_FT2_LIBS = @PANGO_FT2_LIBS@ PYTHON_LIBS = @PYTHON_LDFLAGS@ CXXABI_LIBS = @CXXABI_LIBS@ +GLIB_LIBS = @GLIB_LIBS@ @GOBJECT_LIBS@ -CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GUILE_LIBS) $(PANGO_FT2_LIBS) $(FONTCONFIG_LIBS) $(FREETYPE2_LIBS) +CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GLIB_LIBS) $(GUILE_LIBS) $(PANGO_FT2_LIBS) $(FONTCONFIG_LIBS) $(FREETYPE2_LIBS) CONFIG_LDFLAGS = @LDFLAGS@ PACKAGE = @PACKAGE@ Index: configure.ac diff --git a/configure.ac b/configure.ac index f4121f43824dbbfcbcb01d64aafef23212ce74ca..ed796bb5126c5f41195237397edcb08e31703eca 100644 --- a/configure.ac +++ b/configure.ac @@ -298,6 +298,8 @@ if test "$have_pangoft2_with_otf_feature" != yes ; then fi STEPMAKE_FONTCONFIG(fontconfig, REQUIRED, 2.4.0) STEPMAKE_FREETYPE2(freetype2, REQUIRED, 2.1.10) +STEPMAKE_GLIB(glib-2.0, REQUIRED, 2.44) +STEPMAKE_GOBJECT(gobject-2.0, REQUIRED, 2.44) STEPMAKE_WINDOWS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by pkxgnugi...@runbox.com)
This has moved to http://codereview.appspot.com/568820043 I am closing this one. https://codereview.appspot.com/552770043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by pkxgnugi...@runbox.com)
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode77 aclocal.m4:77: STEPMAKE_ADD_ENTRY($3, $2) On 2019/06/07 06:47:17, lemzwerg wrote: This looks strange, at least here in appspot. It appears as if one level of indentation got lost. Done. https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode96 aclocal.m4:96: true On 2019/06/07 06:47:17, lemzwerg wrote: Ditto, and many other lines in this file, too. Yes, I guess find/replace didn't work. I'll fix these manually. https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode399 aclocal.m4:399: fi Cannot see corresponding 'if' line for this 'fi'. Again I maybe missing something obvious. https://codereview.appspot.com/552770043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR - 2.10 World Music Turkish Classical additions (issue 550780043 by pkxgnugi...@runbox.com)
https://codereview.appspot.com/550780043/diff/570700043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
https://codereview.appspot.com/550780043/diff/570700043/Documentation/notation/world.itely#newcode562
Documentation/notation/world.itely:562: The correct accidentals koma
flat (@var{b1}), and koma sharp
On 2019/06/05 10:52:09, lemzwerg wrote:
→ The correct accidentals, koma flat (@var{b1}) and koma sharp
(@code{f4}, both
in relation to the tonic @var{g}), ...
Done.
https://codereview.appspot.com/550780043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR - 2.10 World Music Turkish Classical additions (issue 550780043 by pkxgnugi...@runbox.com)
Reviewers: lemzwerg,
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode74
Documentation/notation/world.itely:74: Western staff notes are still
used, but with special accidentals unique
On 2019/05/31 07:05:12, lemzwerg wrote:
unique → uniquely
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode78
Documentation/notation/world.itely:78: Other, related, init files are
also available; @file{hel-arabic.ly} and
On 2019/05/31 07:05:12, lemzwerg wrote:
Other, related, init files → Other, related init files
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode438
Documentation/notation/world.itely:438: @q{group} of maqams than
individual key signatures for each maqam
On 2019/05/31 07:05:12, lemzwerg wrote:
than → instead of
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode439
Documentation/notation/world.itely:439: seperately.
On 2019/05/31 07:05:12, lemzwerg wrote:
seperately → separately
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode505
Documentation/notation/world.itely:505: of a tone, from which are
constructed the melodic forms known as
On 2019/05/31 07:05:12, lemzwerg wrote:
from which the melodic forms ... are constructed.
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode521
Documentation/notation/world.itely:521: the basis of pitch on 1/9-tone
divisions means makamlar employ a
On 2019/05/31 07:05:12, lemzwerg wrote:
means → means that
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode522
Documentation/notation/world.itely:522: completely different set of
intervals from Western scales and modes:
On 2019/05/31 07:05:12, lemzwerg wrote:
from → compared to
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode560
Documentation/notation/world.itely:560: The correct accidentals koma
flat (@var{b1}) and koma sharp (@code{f4}),
On 2019/05/31 07:05:12, lemzwerg wrote:
accidentals, ... (...), ...
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode591
Documentation/notation/world.itely:591: contains information in English
regarding Turkish makam including 2 CDs.
On 2019/05/31 07:05:12, lemzwerg wrote:
2 → two
Done.
https://codereview.appspot.com/550780043/diff/560710043/Documentation/snippets/new/turkish-makam-example.ly
File Documentation/snippets/new/turkish-makam-example.ly (right):
https://codereview.appspot.com/550780043/diff/560710043/Documentation/snippets/new/turkish-makam-example.ly#newcode7
Documentation/snippets/new/turkish-makam-example.ly:7: Here is a
template that also uses the start of a well known Turkish
On 2019/05/31 07:05:12, lemzwerg wrote:
Here is a template that also uses... → This template uses...
well known → well-known
Done.
Description:
Doc: NR - 2.10 World Music Turkish Classical additions
Additions to Turkish Classical Music
From suggestions made by Adam Good
also references to Adam's recent
Turkish Makam additions.
Removed @lilypond example and
made it a snippet.
Formatted changed sections so
they follow more closely to the
CG Guidelines.
Removed the table listing some
of the modes and referenced the
Turkish Makam ly file instead as
it has significantly more additions.
Please review this at https://codereview.appspot.com/550780043/
Affected files (+164, -125 lines):
M Documentation/notation/world.itely
A Documentation/snippets/new/turkish-makam-example.ly
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add glib-2.0 and gobject-2.0 library dependency (issue 552770043 by pkxgnugi...@runbox.com)
Reviewers: lemzwerg, https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4#newcode1291 aclocal.m4:1291: save_CPPFLAGS="$CPPFLAGS" On 2019/06/04 05:40:35, lemzwerg wrote: we probably should replace tabs with spaces ... Done. https://codereview.appspot.com/552770043/diff/574790043/config.make.in File config.make.in (right): https://codereview.appspot.com/552770043/diff/574790043/config.make.in#newcode23 config.make.in:23: CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS)$(GUILE_CFLAGS) $(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS) On 2019/06/04 05:40:35, lemzwerg wrote: A space is missing here. Done. Description: Add glib-2.0 and gobject-2.0 library dependency For a long time we relied on pango/pangoft2 to pull in the glib and gobject libraries. That worked as long as every distribution used a pangoft2.pc file that included both libs in the 'Required:' line. According to the pkg-config documentation that was definitely wrong, and the problem was corrected on opensuse tumbleweed recently. As a consequence building lilypond failed with a linker error as we use symbols from both libs directly in our c++ source code. Signed-off-by: Knut Petersen Please review this at https://codereview.appspot.com/552770043/ Affected files (+44, -2 lines): M aclocal.m4 M config.make.in M configure.ac Index: aclocal.m4 diff --git a/aclocal.m4 b/aclocal.m4 index cf558c81e91ce044dd7a642038e92bbc40836d77..cb4fa83414af72d6d8b3d23611cab4269845121a 100644 --- a/aclocal.m4 +++ b/aclocal.m4 @@ -1284,6 +1284,44 @@ AC_DEFUN(PKG_CHECK_MODULES, [ fi ]) +AC_DEFUN(STEPMAKE_GLIB, [ +PKG_CHECK_MODULES(GLIB, $1 >= $3, have_glib=yes, true) +if test "$have_glib" = yes; then + AC_DEFINE(HAVE_GLIB) +save_CPPFLAGS="$CPPFLAGS" +save_LIBS="$LIBS" + CPPFLAGS="$GLIB_CFLAGS $CPPFLAGS" + LIBS="$GLIB_LIBS $LIBS" + AC_SUBST(GLIB_CFLAGS) + AC_SUBST(GLIB_LIBS) + CPPFLAGS="$save_CPPFLAGS" + LIBS="$save_LIBS" +else + r="libglib-dev or glib?-devel" + ver="`pkg-config --modversion $1`" + STEPMAKE_ADD_ENTRY($2, ["$r >= $3 (installed: $ver)"]) +fi +]) + +AC_DEFUN(STEPMAKE_GOBJECT, [ +PKG_CHECK_MODULES(GOBJECT, $1 >= $3, have_gobject=yes, true) +if test "$have_gobject" = yes; then + AC_DEFINE(HAVE_GOBJECT) +save_CPPFLAGS="$CPPFLAGS" +save_LIBS="$LIBS" + CPPFLAGS="$GOBJECT_CFLAGS $CPPFLAGS" + LIBS="$GOBJECT_LIBS $LIBS" + AC_SUBST(GOBJECT_CFLAGS) + AC_SUBST(GOBJECT_LIBS) + CPPFLAGS="$save_CPPFLAGS" + LIBS="$save_LIBS" +else + r="libgobject-dev or gobject?-devel" + ver="`pkg-config --modversion $1`" + STEPMAKE_ADD_ENTRY($2, ["$r >= $3 (installed: $ver)"]) +fi +]) + AC_DEFUN(STEPMAKE_FREETYPE2, [ PKG_CHECK_MODULES(FREETYPE2, $1 >= $3, have_freetype2=yes, true) if test "$have_freetype2" = yes; then Index: config.make.in diff --git a/config.make.in b/config.make.in index 420600ae8e5327a676be2940362e457ba6b6c3ce..c9e1d992daae26ab7823b66169c7b7fb35c882b2 100644 --- a/config.make.in +++ b/config.make.in @@ -15,11 +15,12 @@ FREETYPE2_CFLAGS = @FREETYPE2_CFLAGS@ GUILE_CFLAGS = @GUILE_CFLAGS@ PANGO_FT2_CFLAGS = @PANGO_FT2_CFLAGS@ PYTHON_CFLAGS = @PYTHON_CFLAGS@ +GLIB_CLFAGS = @GLIB_CFLAGS@ @GOBJECT_CFLAGS@ CONFIG_CPPFLAGS = @CPPFLAGS@ CONFIG_DEFINES = @DEFINES@ -CONFIG_CFLAGS = @CFLAGS@ $(GUILE_CFLAGS) $(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS) +CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS)$(GUILE_CFLAGS) $(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS) CONFIG_CXXFLAGS = @CXXFLAGS@ $(GUILE_CFLAGS) $(FREETYPE2_CFLAGS) $(PANGO_FT2_CFLAGS) FONTCONFIG_LIBS = @FONTCONFIG_LIBS@ @@ -28,8 +29,9 @@ FREETYPE2_LIBS = @FREETYPE2_LIBS@ PANGO_FT2_LIBS = @PANGO_FT2_LIBS@ PYTHON_LIBS = @PYTHON_LDFLAGS@ CXXABI_LIBS = @CXXABI_LIBS@ +GLIB_LIBS = @GLIB_LIBS@ @GOBJECT_LIBS@ -CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GUILE_LIBS) $(PANGO_FT2_LIBS) $(FONTCONFIG_LIBS) $(FREETYPE2_LIBS) +CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GLIB_LIBS) $(GUILE_LIBS) $(PANGO_FT2_LIBS) $(FONTCONFIG_LIBS) $(FREETYPE2_LIBS) CONFIG_LDFLAGS = @LDFLAGS@ PACKAGE = @PACKAGE@ Index: configure.ac diff --git a/configure.ac b/configure.ac index e53bfcc4d6d7f3c3d1bc374f27dea876c3410739..bd1db31bddd4f375c29b01e8a374fca4d54b0e1a 100644 --- a/configure.ac +++ b/configure.ac @@ -283,6 +283,8 @@ if test "$have_pangoft2_with_otf_feature" != yes ; then fi STEPMAKE_FONTCONFIG(fontconfig, REQUIRED, 2.4.0) STEPMAKE_FREETYPE2(freetype2, REQUIRED, 2.1.10) +STEPMAKE_GLIB(glib-2.0, REQUIRED,2.44) +STEPMAKE_GOBJECT(gobject-2.0, REQUIRED,2.44) STEPMAKE_WINDOWS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Charles Winston's chord-semantics GSOC work (issue 568650043 by carl.d.soren...@gmail.com)
Are we sure all the reg tests are OK (see tracker for download link)? For example regression/chord-name-major7.ly This looks completely broken with this patch https://codereview.appspot.com/568650043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Axis_group_engraver + Scheme engraver for staff combining (issue 576540043 by pkxgnugi...@runbox.com)
Reviewers: , Message: Passes make, make check and a full make doc. Description: Axis_group_engraver + Scheme engraver for staff combining It provides an intuitive user interface to control whether shared or separate staves are printed, and should work for combinations of 4 or more parts. Currently, Axis_group_engraver reads keepAliveInterfaces into an internal variable during process-music, then uses the stored value during acknowledge-grob. In this patched it waits to read keepAliveInterfaces during acknowledge-grob. Please review this at https://codereview.appspot.com/576540043/ Affected files (+128, -12 lines): M lily/axis-group-engraver.cc A ly/divisi_engraver.ly ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR 4.2.2 - remove deprecated @knownissue (issue 550530043 by pkxgnugi...@runbox.com)
On 2019/03/09 11:13:18, Malte Meyn wrote: Could this be done for all other languages (de, es, fr, it, ja) too or should that be left to the translators? Done. https://codereview.appspot.com/550530043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: ly: Updates to predefined Ukulele fretboards (issue 367880043 by pkxgnugi...@runbox.com)
This has now been pushed ly: Updates to predefined Ukulele fretboards master staging author Davide Bonetti Fri, 18 Jan 2019 11:34:37 + (11:34 +) committer James Lowe Fri, 18 Jan 2019 11:36:47 + (11:36 +) commit 17c0c74440f5a9b26617b274d927e8e4db1a1d4e -- Thank you Davide. https://codereview.appspot.com/367880043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: ly: Updates to predefined Ukulele fretboards (issue 367880043 by pkxgnugi...@runbox.com)
Patch on countdown for January 17th https://codereview.appspot.com/367880043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: ly: Updates to predefined Ukulele fretboards (issue 367880043 by pkxgnugi...@runbox.com)
Passes make, make check and a full make doc. Please review https://codereview.appspot.com/367880043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: ly: updates to hel-arabic.ly (issue 349810043 by pkxgnugi...@runbox.com)
author Hassan Elfathi Wed, 12 Dec 2018 08:19:18 + (08:19 +) committer James Lowe Mon, 24 Dec 2018 10:40:01 + (10:40 +) commit bb5af856e09b4008f3a6e5ff8c13c34b239ae6b9 https://codereview.appspot.com/349810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: ly: updates to hel-arabic.ly (issue 349810043 by pkxgnugi...@runbox.com)
On 2018/12/18 03:44:19, goodadamgood_gmail.com wrote: Hassan, I'm having a little bit of difficulty following the thread because I can't seem to find the hel-arabic.ly file you're working on. Could you please point me to the file so I can play with it? Thank you in advance Adam Good Adam, The diffs for the file are on this very Rietveld issue. ? I am shepherding this patch on behalf of Hassan. So all the correspondence has been via email between him and myself - although I have cut and pasted all Hassans responses to all the comments/questions the diffs in this Rietveld generated - see the questions by Malt above that were answered by Hassan. I have also attached a git formatted patch to the original Source Forge issue tracker if you want that. This is all available via either https://sourceforge.net/p/testlilyissues/issues/5446 or (here) http://codereview.appspot.com/349810043 regards James https://codereview.appspot.com/349810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and conver… (issue 323040043 by chazwi...@gmail.com)
On 2017/05/30 17:50:02, Trevor Daniels wrote: Looks OK as far as it goes, but the Docs have been missed. Trevor This has now been superceded by http://codereview.appspot.com/369930043 https://codereview.appspot.com/323040043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: ly: updates to hel-arabic.ly (issue 349810043 by pkxgnugi...@runbox.com)
On 2018/12/13 17:28:50, haberg-1_telia.com wrote: > On 12 Dec 2018, at 09:55, mailto:lilyp...@maltemeyn.de wrote: > > I don’t know anything about arabic music but there are some changes that > look strange to me. FYI, Adam Good expressed interest updating the Arabic and Persian files for LilyPond [1]. I have sent him a file with maqam from the site [2]. 1. https://lists.gnu.org/archive/html/lilypond-devel/2018-11/msg00105.html 2. https://www.maqamworld.com/en/ Turkish/Persian Maqams and are very different to Arabic Maqams so cannot - according to Hassan - be compared. James https://codereview.appspot.com/349810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: ly: updates to hel-arabic.ly (issue 349810043 by pkxgnugi...@runbox.com)
Thanks for the review Malte https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly File ly/hel-arabic.ly (left): https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode73 ly/hel-arabic.ly:73: %% Sajakar: c' d' edb' f' g' ab' b' c'' c'' bb' a' g' f' edb' d' c' On 2018/12/12 08:55:01, Malte Meyn wrote: Is this “never used” in the same way as locrian mode, i. e. only in theory? From Hassan: rast : c d edb f g a bdb c sajkar : c dd edb f g a bdb c rast = #`( (0 . ,NATURAL) (1 . ,NATURAL) (2 . ,SEMI-FLAT) (3 . ,NATURAL) (4 . ,NATURAL) (5 . ,NATURAL) (6 . ,SEMI-FLAT) ) This is rast with the altered note in dd (dis). That's why musicians arabic use rast by altering the note d in dd (dis) %% Sajakar: c dd edb f g a bdb (good) sajkar = #`( (0 . ,NATURAL) (1 . ,SHARP) (2 . ,SEMI-FLAT) (3 . ,NATURAL) (4 . ,NATURAL) (5 . ,NATURAL) (6 . ,SEMI-FLAT) ) it replaces ( an error here in hel-arabic.ly ) (bad ) sajkar = #`( (0 . ,NATURAL) (1 . ,NATURAL) (2 . ,SEMI-FLAT) (3 . ,NATURAL) (4 . ,NATURAL) (5 . ,FLAT) (6 . ,NATURAL) ) https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode248 ly/hel-arabic.ly:248: %% Irak: bdb c d edb f g a bdb bb a g f edb d c bdb On 2018/12/12 08:55:01, Malte Meyn wrote: Are these identical to “rast” in the same way ionian is to major? Then I wouldn’t delete them. Maybe simply #(define iraq rast) or iraq = \rast From Hassan: No they arent' identical to rast in the same way ionian to major . in fact rast : c d edb f g a bdb c ( it also includes the note bb (bes) ) irak : bdb c d edb f g a bdb rahatalarouah : bdb c d edb fd g a bdb alboustankar : bdb c d edb f gb a bdb As you see iraq, rahatalarouah and alboustankar contain edb and bdb notes. But the rast key includes edb and bdb. So Arab musicians use the key of rast to write irak, rahatalarouah and alboustankar https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode334 ly/hel-arabic.ly:334: major = #`( On 2018/12/12 08:55:01, Malte Meyn wrote: Does hel-arabic.ly *replace* scale-definitions-init.ly? If not, these definitions are redundant. From Hassan: hel-arabic.ly don't need scale-definitions-init.ly. in other words it replaces scale-definitions-init.ly (minor, major,... are defined in hel-arabic.ly). There is no interaction between hel-arabic.ly and scale-definitions-init.ly In addition, it uses bb (b flat) instead of bes and dd (d sharp) instead of dis for example. We write music independently. There is of course edb (e semi-flat), fdd (f semi-sharp ). Major and minor makams exist in Arabic music. They have different names : ajam (for major) and nahawand (for minor) In conclusion I think it's better to delete them. Also Reminder: - hel-arabic.ly uses define-note-names.scm and lily-library.scm define-note-names.scm and lily-library.scm are not modified https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly File ly/hel-arabic.ly (right): https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#newcode158 ly/hel-arabic.ly:158: (4 . FLAT) On 2018/12/12 08:55:01, Malte Meyn wrote: Should be ,FLAT (with comma). Or ,SHARP == 1/2? Yes this should have a comma. https://codereview.appspot.com/349810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: ly: updates to hel-arabic.ly (issue 349810043 by pkxgnugi...@runbox.com)
Reviewers: Malte Meyn, Message: On 2018/12/12 15:44:15, hassan.elfatihi_free.fr wrote: Hello I am hassan el fatihi author of hel-arabic.ly. I corrected some minimal errors. 20 makams are working properly. I can give you examples if you wish. I use the hel-arabic.ly file since 2009. Makam sajkar is from the rast family, with slight modifications The makam irak notes can be written with the key of rast: \ key c \ rast (same thing for rahatalarouah and alboustankar). If you need more information, I am at your disposal. Thank you Hassan can you answer the specific questions from Malte please? I cannot answer them. You can reply directly to Malte in his entry above. I can them make any adjustments as necessary. Regards James Description: ly: updates to hel-arabic.ly Changes suggested by Hassan Elfatihi Minor Typos fixed irak, rahatalarouah and alboustankar are all redundant as they are all the same mode as 'rast'. Sajkar mode is never used so this has been removed. Please review this at https://codereview.appspot.com/349810043/ Affected files (+3, -53 lines): M ly/hel-arabic.ly Index: ly/hel-arabic.ly diff --git a/ly/hel-arabic.ly b/ly/hel-arabic.ly index 890ae908b18345ab7216c6197a50e6212b9e4b57..dc6141334f876c00da9a64d066fba02f8f6938cf 100644 --- a/ly/hel-arabic.ly +++ b/ly/hel-arabic.ly @@ -66,18 +66,6 @@ souznak = #`( (3 . ,NATURAL) (4 . ,NATURAL) (5 . ,FLAT) - %(6 . ,SEMI-FLAT) - (6 . ,NATURAL) -) - -%% Sajakar: c' d' edb' f' g' ab' b' c'' c'' bb' a' g' f' edb' d' c' -sajkar = #`( - (0 . ,NATURAL) - (1 . ,NATURAL) - (2 . ,SEMI-FLAT) - (3 . ,NATURAL) - (4 . ,NATURAL) - (5 . ,FLAT) (6 . ,NATURAL) ) @@ -132,7 +120,7 @@ nakriz = #`( (2 . ,FLAT) (3 . ,SHARP) (4 . ,NATURAL) - (5 . ,FLAT) + (5 . ,NATURAL) (6 . ,FLAT) ) @@ -167,7 +155,7 @@ karjkhar = #`( (1 . ,SEMI-FLAT) (2 . ,FLAT) (3 . ,NATURAL) - (4 . 1/2) + (4 . FLAT) (5 . ,NATURAL) (6 . ,FLAT) ) @@ -217,7 +205,7 @@ huzam = #`( (1 . ,SEMI-FLAT) (2 . ,SEMI-FLAT) (3 . ,SEMI-FLAT) - (4 . ,SEMI-FLAT) + (4 . ,SEMI-SHARP) (5 . ,SEMI-FLAT) (6 . ,SEMI-FLAT) ) @@ -245,44 +233,6 @@ yakah = #`( (6 . ,SEMI-FLAT) ) -%% Irak: bdb c d edb f g a bdb bb a g f edb d c bdb -%% Irak: en do: c ddb edb f gdb adb c cdb bdb adb gdb f edb ddb c -iraq = #`( - (0 . ,NATURAL) - (1 . ,SEMI-FLAT) - (2 . ,SEMI-FLAT) - (3 . ,NATURAL) - (4 . ,SEMI-FLAT) - (5 . ,SEMI-FLAT) - (6 . ,SEMI-FLAT) -) - -%% Rahatalarouah: bdb c'd' eb' fd' g' a' bdb' bdb' a' g' fd' eb' d' c' bdb' -%% Rahatalarouah: en do : c' ddb' edb' fdd' gdd' adb' bdb' c'' c'' bdb' adb' gdd' -%% fdd' edb' ddb' c' -rahatalarouah = #`( - (0 . ,NATURAL) - (1 . ,SEMI-FLAT) - (2 . ,SEMI-FLAT) - (3 . ,SEMI-FLAT) - (4 . ,SEMI-SHARP) - (5 . ,SEMI-FLAT) - (6 . ,SEMI-FLAT) -) - -%% Alboustankar: bdb c d edb f gb a bb bb a gb f edb d c bdb -%% Alboustankar: c ddb edb f gdb a bdb cdb cdb bdb a gdb f edb ddb c -alboustankar = #`( - (0 . ,NATURAL) - (1 . ,SEMI-FLAT) - (2 . ,SEMI-FLAT) - (3 . ,SEMI-FLAT) - (4 . ,SEMI-SHARP) - (5 . ,SEMI-FLAT) - (6 . ,SEMI-FLAT) -) - - %% Hizaz Avec sib et mib: d' eb' fd' g' a' bdb' c'' d'' d'' c''bb' a' g' fd' eb' d' %% Hizaz: en do: c db e f g adb bb c c bb ab g f e db c hizaz = #`( ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Web: update Productions list (issue 348040043 by fedel...@gmail.com)
nits - hope this isn't 'bike-shedding' too much https://codereview.appspot.com/348040043/diff/20001/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (right): https://codereview.appspot.com/348040043/diff/20001/Documentation/web/introduction.itexi#newcode741 Documentation/web/introduction.itexi:741: with over 2000 pieces of classical sheet music for free download, is '... it is ...' https://codereview.appspot.com/348040043/diff/20001/Documentation/web/introduction.itexi#newcode748 Documentation/web/introduction.itexi:748: collects over 800 scores of baroque music. The archive includes scores, "... started in 2005 and with over 800 scores of baroque music, the archive ..." https://codereview.appspot.com/348040043/diff/20001/Documentation/web/introduction.itexi#newcode773 Documentation/web/introduction.itexi:773: repository of LilyPond source files of all pieces in Mutopia library. Needs an (in)definite article: 'a repository ...' or 'the repository ...' https://codereview.appspot.com/348040043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: document grob metadata in SVG output in Notation Reference (issue 357720044 by paulwmor...@gmail.com)
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely#newcode2780 Documentation/notation/input.itely:2780: @node SVG Output I think you will need to add this 'node' to the @menu section after line #2665. https://codereview.appspot.com/357720044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: musicxml2ly: handle hidden time signatures; support text+bpm \tempo marks. (issue 344000043 by a.mylt...@gmail.com)
On 2018/06/13 14:38:23, lilypond-pkx wrote: On 2018/06/04 10:51:25, a.myltsev wrote: > Removed the 'test' commits, leaving only changes to Python files. Patch counted down - please push. Alex if you do not have commit access can you attach a git-formatted patch (re-based against current master) and I can push it for you - attach it to the tracker, I will see it - https://sourceforge.net/p/testlilyissues/issues/5333/ author Alexander Myltsev Wed, 27 Apr 2016 16:04:43 +0100 (18:04 +0300) committer James Lowe Sat, 16 Jun 2018 10:58:59 +0100 (10:58 +0100) commit d751f5fd70d1c4de9878dceb81bda42e9a500fb7 author Alexander Myltsev Thu, 2 Jun 2016 09:19:07 +0100 (11:19 +0300) committer James Lowe Sat, 16 Jun 2018 10:59:08 +0100 (10:59 +0100) commit 7b07440da921d979ab492fd284b6198152a8020c Many thanks Alexander. https://codereview.appspot.com/34443/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: musicxml2ly: handle hidden time signatures; support text+bpm \tempo marks. (issue 344000043 by a.mylt...@gmail.com)
On 2018/06/04 10:51:25, a.myltsev wrote: Removed the 'test' commits, leaving only changes to Python files. Patch counted down - please push. Alex if you do not have commit access can you attach a git-formatted patch (re-based against current master) and I can push it for you - attach it to the tracker, I will see it - https://sourceforge.net/p/testlilyissues/issues/5333/ https://codereview.appspot.com/34443/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: sort input files (issue 347770043 by bmwiedem...@gmail.com)
On 2018/05/26 13:04:12, Dan Eble wrote: On 2018/05/23 12:22:09, bmwiedemann wrote: > sorting .o files instead of .cc This is not quite what I meant. If it works for you, fine, but I think it is more likely to break eventually than if you found the commands that are being invoked and sorted their arguments. For example, $(CXX) -o $@ $(sort $(O_FILES)) blah blah blah This puts the sort where it really matters and leaves no room for modifying O_FILES after the sort. It would still be a good idea to include a short comment on the reason for the sort, because It isn't obvious. Dan et al. I am not seeing any feedback from Bernhard here on or on the tracker. I don't want to waste good work, but it seems to me that this patch is still not ready for pushing yet. I'll set the issue back down to 'review' for one more countdown before I will set it to 'needs_work', but if you or someone else reading this (preferably Bernhard) can help me understand if this can be pushed or not, then I'd rather not have to make the unilateral decision myself to take it off the countdown (even though I am Patch Meister). James https://codereview.appspot.com/347770043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Use convert -strip (issue 339350043 by bmwiedem...@gmail.com)
On 2018/05/29 07:20:14, dulow kotic wrote: On 2018/05/29 07:20:04, dulow kotic wrote: Does this have a relevant 'Tracker issue'? I could not see one. This is probably why it has been ignored so far, let me know and we can create one for this Rietveld to get it in the Patch review process. Thanks James https://codereview.appspot.com/339350043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: musicxml2ly: handle hidden time signatures; support text+bpm \tempo marks. (issue 344000043 by a.mylt...@gmail.com)
On 2018/06/01 20:12:25, a.myltsev wrote: > What are the scripts these 'test' dirs? Those are actual tests for the added functionality, runnable with `pytest`. > Was this a mistake? No, I believe that these tests are individually useful, even though not yet integrated into the Lilypond testing system. If you prefer, though, I can leave them out. Yes if you wouldn't mind, that would be better I think. We should only be testing 'a patch' that has components that are 'push ready' (so to speak). If you want to add some more 'tests' then I suggest the best way would be to create a new tracker for them that you can start a discussion separate from the other work you have done. However, if these tests are integral to this work and you intend to eventually integrate them with the other work in this patch then that is fine too, but it wasn't clear to me. I'll wait to see what you want to do. Thanks for your understanding. https://codereview.appspot.com/34443/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: musicxml2ly: handle hidden time signatures; support text+bpm \tempo marks. (issue 344000043 by a.mylt...@gmail.com)
On 2018/06/01 11:50:31, a.myltsev wrote: musicxml2ly: hidden timesigs and tempo marks with text. What are the scripts these 'test' dirs? Was this a mistake? If so can you re-submit the patch please? thanks James https://codereview.appspot.com/34443/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
