Re: [PATCH] Fix for broken examples in section about explicit vertical positioning

2008-11-23 Thread Maximilian Albert
2008/11/21 Neil Puttock [EMAIL PROTECTED]:

 Thanks for the patch; it's a definite improvement. :)

 Unfortunately, that's just the start of what's wrong with these
 examples;
 [...]
 Therefore, I've applied your patch together with the following changes:
 [...]

Awesome, thanks a lot for improving the examples!

Max


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


[PATCH] Fix for broken examples in section about explicit vertical positioning

2008-11-21 Thread Maximilian Albert
Hi,

in the Documentation section about explicit vertical positioning, the
four examples have too many measures per line. This makes the lines
break in a funny way and garbles the examples quite a lot (see
http://tinyurl.com/expl-vert-spacing). Although I thought I knew a bit
about vertical spacing, it took me quite a while to connect the
pictures to the text while reading this section (actually, I had to
look at the code before it made sense). I suggest reducing the number
of measures from 6 to 5 per line so that there are no unintended line
breaks. Corresponding patches against master are attached (for the
English and Spanish version separately, in case the latter is somehow
automatically generated from the former).

Cheers,
Max
From 9cc0cbef69c4227127371f6d8e65946ed6a8889f Mon Sep 17 00:00:00 2001
From: Maximilian Albert [EMAIL PROTECTED]
Date: Fri, 21 Nov 2008 10:43:05 +0100
Subject: [PATCH] Examples for vertical spacing: Reduce number of measures per line so that they don't break due to the short line length

---
 Documentation/user/spacing.itely |   42 +++---
 1 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/Documentation/user/spacing.itely b/Documentation/user/spacing.itely
index baabf80..349eabd 100644
--- a/Documentation/user/spacing.itely
+++ b/Documentation/user/spacing.itely
@@ -1507,14 +1507,14 @@ by looking at an example that includes no overrides at all.
 \new Score 
   \new Staff 
 \new Voice {
-  s1 * 6 \break
-  s1 * 6 \break
-  s1 * 6 \break
+  s1 * 5 \break
+  s1 * 5 \break
+  s1 * 5 \break
 }
-\new Voice { \repeat unfold 18 { c'4 c'4 c'4 c'4 } }
+\new Voice { \repeat unfold 15 { c'4 c'4 c'4 c'4 } }
   
   \new Staff {
-\repeat unfold 18 { d'4 d'4 d'4 d'4 }
+\repeat unfold 15 { d'4 d'4 d'4 d'4 }
   }
 
 @end lilypond
@@ -1536,18 +1536,18 @@ attribute of the @code{NonMusicalPaperColumn} grob:
 \new Voice {
   \overrideProperty #Score.NonMusicalPaperColumn
 #'line-break-system-details #'((Y-offset . 0))
-  s1 * 6 \break
+  s1 * 5 \break
   \overrideProperty #Score.NonMusicalPaperColumn
 #'line-break-system-details #'((Y-offset . 40))
-  s1 * 6 \break
+  s1 * 5 \break
   \overrideProperty #Score.NonMusicalPaperColumn
 #'line-break-system-details #'((Y-offset . 80))
-  s1 * 6 \break
+  s1 * 5 \break
 }
-\new Voice { \repeat unfold 18 { c'4 c'4 c'4 c'4 } }
+\new Voice { \repeat unfold 15 { c'4 c'4 c'4 c'4 } }
   
   \new Staff {
-\repeat unfold 18 { d'4 d'4 d'4 d'4 }
+\repeat unfold 15 { d'4 d'4 d'4 d'4 }
   }
 
 @end lilypond
@@ -1569,20 +1569,20 @@ subproperty of @code{line-break-system-details}.
   \overrideProperty #Score.NonMusicalPaperColumn
 #'line-break-system-details #'((Y-offset . 20)
   (alignment-offsets . (0 -15)))
-  s1 * 6 \break
+  s1 * 5 \break
   \overrideProperty #Score.NonMusicalPaperColumn
 #'line-break-system-details #'((Y-offset . 60)
   (alignment-offsets . (0 -15)))
-  s1 * 6 \break
+  s1 * 5 \break
   \overrideProperty #Score.NonMusicalPaperColumn
 #'line-break-system-details #'((Y-offset . 100)
   (alignment-offsets . (0 -15)))
-  s1 * 6 \break
+  s1 * 5 \break
 }
-\new Voice { \repeat unfold 18 { c'4 c'4 c'4 c'4 } }
+\new Voice { \repeat unfold 15 { c'4 c'4 c'4 c'4 } }
   
   \new Staff {
-\repeat unfold 18 { d'4 d'4 d'4 d'4 }
+\repeat unfold 15 { d'4 d'4 d'4 d'4 }
   }
 
 @end lilypond
@@ -1604,24 +1604,24 @@ specifies the vertical positioning of staves but not of staff groups.
   \overrideProperty #Score.NonMusicalPaperColumn
   #'line-break-system-details #'((Y-offset . 0)
 (alignment-offsets . (0 -30 -40)))
-  s1 * 6 \break
+  s1 * 5 \break
   \overrideProperty #Score.NonMusicalPaperColumn
   #'line-break-system-details #'((Y-offset . 60)
 (alignment-offsets . (0 -10 -20)))
-  s1 * 6 \break
+  s1 * 5 \break
   \overrideProperty #Score.NonMusicalPaperColumn
   #'line-break-system-details #'((Y-offset . 100)
 (alignment-offsets . (0 -10, -40)))
-  s1 * 6 \break
+  s1 * 5 \break
 }
-\new Voice { \repeat unfold 18 { c'4 c'4 c'4 c'4 } }
+\new Voice { \repeat unfold 15 { c'4 c'4 c'4 c'4 } }
   
   \new StaffGroup 
 \new Staff {
-  \repeat unfold 18 { d'4 d'4 d'4 d'4 }
+  \repeat unfold 15 { d'4 d'4 d'4 d'4 }
 }
 \new Staff {
-  \repeat unfold 18 { e'4 e'4 e'4 e'4 }
+  \repeat unfold 15 { e'4 e'4 e'4 e'4 }
 }
   
 
-- 
1.5.4.3

From e4cc73ed87b31b0039540e1887acb41fe3bb353b Mon Sep 17 00:00:00 2001
From: Maximilian Albert [EMAIL PROTECTED]
Date: Fri, 21 Nov 2008 10:49:47 +0100
Subject: [PATCH] Also reduce number of measures in spacing examples in Spanish version

---
 Documentation/es/user/spacing.itely |   42 +-
 1 files changed, 21 

Re: [PATCH] Fix for broken examples in section about explicit vertical positioning

2008-11-21 Thread Neil Puttock
Hi Max,

2008/11/21 Maximilian Albert [EMAIL PROTECTED]:
 Hi,

 in the Documentation section about explicit vertical positioning, the
 four examples have too many measures per line. This makes the lines
 break in a funny way and garbles the examples quite a lot (see
 http://tinyurl.com/expl-vert-spacing). Although I thought I knew a bit
 about vertical spacing, it took me quite a while to connect the
 pictures to the text while reading this section (actually, I had to
 look at the code before it made sense). I suggest reducing the number
 of measures from 6 to 5 per line so that there are no unintended line
 breaks. Corresponding patches against master are attached (for the
 English and Spanish version separately, in case the latter is somehow
 automatically generated from the former).

Thanks for the patch; it's a definite improvement. :)

Unfortunately, that's just the start of what's wrong with these
examples; they're designed to show explicit spacing in a page, but
you've probably noticed that they show almost identical spacing
between systems.  The only way around this is to enclose each example
in \book { }.  Therefore, I've applied your patch together with the
following changes:

1. use \book { } to maintain the correct spacing in each example;
2. remove ragged-right from fragment options;
3. remove tagline: this tidies up the empty space below the last
system when using \book (though not in the pdf, regrettably);
4. change left-margin to zero so that the examples don't appear too
far to the right in pdf.

Attached is the third snippet using the new settings, demonstrating
the correct spacing.

Cheers,
Neil
attachment: lily-5e516a13.png___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel