Re: [PATCH] Re: Centered Poet rolling of the paper 2.12.2 and 2.13.1

2010-01-21 Thread Patrick McCarty
On 2010-01-11, Alexander Kobel wrote:
 
 The attached patch for fill-line (scm/define-markup-commands.scm)
 should do the expected thing.
 fill-line currently only considers the extents of the stencils, not
 their position relative to the X-origin; with the patch, they are
 shifted according to the first stencil argument.
 
 Sorry in advance for non-proper indentation, a probably non-proper
 patch format, and not having in on Rietveld or something like this,
 but to be honest, I don't want to take the time to bother with git's
 functionality and a coding account setup right now.

Thanks.  Looks great!

I cleaned up the indentation and pushed your patch.

-Patrick


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


[PATCH] Re: Centered Poet rolling of the paper 2.12.2 and 2.13.1

2010-01-11 Thread Alexander Kobel

Alexander Kobel wrote:

Wilbert Berendsen wrote:

Hi,

this code:

\header {
  poet = \markup \center-column {
\line { poet with Long Name }
\small (1800-1900)
  }
  composer = \markup \center-column {
\line { composer with Long Name }
\small (1800-1900)
  }
}

{ c' }

results in falling the poet off the paper. It looks like the column is 
centered on the margin.


Confirmed.  Looks like a strange artifact of the \fill-line markup 
(containing both poet and composer) w.r.t. a negative first X-extent 
entry of a \center-column, IIUC.


The attached patch for fill-line (scm/define-markup-commands.scm) should 
do the expected thing.
fill-line currently only considers the extents of the stencils, not 
their position relative to the X-origin; with the patch, they are 
shifted according to the first stencil argument.


Sorry in advance for non-proper indentation, a probably non-proper patch 
format, and not having in on Rietveld or something like this, but to be 
honest, I don't want to take the time to bother with git's functionality 
and a coding account setup right now.



Cheers,
Alexander
--- scm/define-markup-commands.scm.new	2010-01-11 16:47:46.0 +0100
+++ scm/define-markup-commands.scm	2010-01-11 16:43:31.0 +0100
@@ -850,11 +850,8 @@
 
 (if (null? (remove ly:stencil-empty? orig-stencils))
 	empty-stencil
-  (ly:stencil-translate-axis
-  	 (stack-stencils-padding-list X
-  RIGHT fill-space-normal line-stencils)
- (- (car (ly:stencil-extent (car stencils) X)))
- X
+	(stack-stencils-padding-list X
+ RIGHT fill-space-normal line-stencils
 
 (define-markup-command (line layout props args)
   (markup-list?)
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: [PATCH] Re: Centered Poet rolling of the paper 2.12.2 and 2.13.1

2010-01-11 Thread David Kastrup
Alexander Kobel n...@a-kobel.de writes:

 Sorry in advance for non-proper indentation, a probably non-proper
 patch format, and not having in on Rietveld or something like this,
 but to be honest, I don't want to take the time to bother with git's
 functionality and a coding account setup right now.

Uh, but a reverse patch?  It's not actually tragic since most patch
commands I know will ask whether they should do it in reverse.

I trust that someone with commit access (which does not include me) will
pick this up and push.

-- 
David Kastrup



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel