Re: Add predefined mandolin fretboards to lilypond. (issue4384055)

2011-04-19 Thread Marc Hohl 

Am 11.04.2011 10:34, schrieb Marc Hohl:

[...]

So please have a look at

http://codereview.appspot.com/4370054/


LGTM, anyone? ;-)

Marc

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add predefined mandolin fretboards to lilypond. (issue4384055)

2011-04-11 Thread Marc Hohl 

Am 11.04.2011 06:43, schrieb carl.d.soren...@gmail.com:

Reviewers: ,

Message:
Marc Hohl has prepared a patch for mandolin predefined fretboards.

The patch looks good to me.

Please review.

Thanks,

Carl



http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itely 


File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itely#newcode1905 


Documentation/notation/fretted-strings.itely:1905:
@file{scm/string-tunings-init.scm} contains predefined banjo tunings.
Thanks for the catch!

Description:
Add predefined mandolin fretboards to lilypond.

Please review this at http://codereview.appspot.com/4384055/
Oops, I just uploaded it myself and corrected the version numbers and 
the path for inclusion
(it was \include "./predefined-..." instead of just \include 
"predefined-..." )


So please have a look at

http://codereview.appspot.com/4370054/

@Carl: sorry for messing all up...

Regards,

Marc


Affected files:
  A Documentation/included/display-predefined-mandolin-fretboards.ly
  M Documentation/notation/fretted-strings.itely
  M Documentation/notation/notation-appendices.itely
  A ly/predefined-mandolin-fretboards.ly



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel




___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Add predefined mandolin fretboards to lilypond. (issue4384055)

2011-04-10 Thread Carl . D . Sorensen 

Reviewers: ,

Message:
Marc Hohl has prepared a patch for mandolin predefined fretboards.

The patch looks good to me.

Please review.

Thanks,

Carl



http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):

http://codereview.appspot.com/4384055/diff/1/Documentation/notation/fretted-strings.itely#newcode1905
Documentation/notation/fretted-strings.itely:1905:
@file{scm/string-tunings-init.scm} contains predefined banjo tunings.
Thanks for the catch!

Description:
Add predefined mandolin fretboards to lilypond.

Please review this at http://codereview.appspot.com/4384055/

Affected files:
  A Documentation/included/display-predefined-mandolin-fretboards.ly
  M Documentation/notation/fretted-strings.itely
  M Documentation/notation/notation-appendices.itely
  A ly/predefined-mandolin-fretboards.ly



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel