Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-19 Thread bordage . bertrand 

Pushed as f9251331576c94fa6aa4b85776917d3774b13b63

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-16 Thread pkx166h 

Passes make and reg tests. I did get the 'NOT A BUG' test show up again,
I see that I had had this before...so this looks ok.

See: http://code.google.com/p/lilypond/issues/detail?id=1854#c1

James

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-15 Thread bordage . bertrand 

Great. I removed the dynamics.

Is someone opposed to this patch to be pushed?
I suggest we put this issue in the next countdown.

Thanks,
Bertrand

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-15 Thread n . puttock 

LGTM.

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-12 Thread janek . lilypond 

On 2011/09/06 16:42:34, Bertrand Bordage wrote:

Ok, DynamicText and DynamicLineSpanner should be removed.
But what about the others?


I think they should be added.

cheers,
Janek

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-06 Thread bordage . bertrand 

Ok, DynamicText and DynamicLineSpanner should be removed.
But what about the others?

* Simple trill is directed (as a Script), so TrillSpanner logically has
to be directed.

* Slurs, Ties and TupletBrackets are also directed, so I don't see any
reason for LigatureBrackets to behave differently.

* AccidentalSuggestion in polyphony leads to mistakes if it isn't
directed.

Bertrand

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-01 Thread tdanielsmusic 

I don't think we have sufficient support for applying this patch.  Both
Neil and I have spoken against it, and presented our arguments.  No one
has given a counter view.

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-08-30 Thread pkx166h 

Passes make but get two reg tests show up that look ok but that need a
second opinion.

Attached on

http://code.google.com/p/lilypond/issues/detail?id=1854#c1


http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-08-29 Thread bordage . bertrand 

Updated.

Bertrand

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add some polyphonically directed grobs (issue 4387046)

2011-08-28 Thread pkx166h 

Patch fails on tree as of 28 August.

patching file scm/music-functions.scm
Hunk #2 FAILED at 415.
1 out of 2 hunks FAILED -- saving rejects to file
scm/music-functions.scm.rej
jlowe@jlowe-lilybuntu2:~/lilypond-git$

http://codereview.appspot.com/4387046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel