Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-19 Thread trueroad

Thank you for your advice.



https://codereview.appspot.com/314130043/diff/20001/configure.ac
File configure.ac (right):

https://codereview.appspot.com/314130043/diff/20001/configure.ac#newcode305
configure.ac:305: [" documentation and the final PDF files.)"])
On 2016/11/19 14:06:07, pkx166h wrote:

All I would say is that "... and the final PDF files." is redundant

*if* this

change ONLY affects the PDF files and the rest of the 'documentation

files' are

unaffected then simply say:



"...significantly reduce the disk space needed for the PDF files when

building

the documentation".


It also affects the size of intermediate PDF files not only the final
PDF files.


Also, would it be better to state 'Ghostscript' rather than 'gs' in

the message?

Done.

https://codereview.appspot.com/314130043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-19 Thread pkx166h

Domou Hosoda-Sama.


https://codereview.appspot.com/314130043/diff/20001/configure.ac
File configure.ac (right):

https://codereview.appspot.com/314130043/diff/20001/configure.ac#newcode305
configure.ac:305: [" documentation and the final PDF files.)"])
All I would say is that "... and the final PDF files." is redundant *if*
this change ONLY affects the PDF files and the rest of the
'documentation files' are unaffected then simply say:

"...significantly reduce the disk space needed for the PDF files when
building the documentation".

Also, would it be better to state 'Ghostscript' rather than 'gs' in the
message?

https://codereview.appspot.com/314130043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-19 Thread trueroad

On 2016/11/19 06:11:09, lemzwerg wrote:

Ah, bad wording, sorry.  I don't care about the actual length of the

message but

the line length in the source code, so please just wrap the message to

stay

within 80 columns or so if possible.



Here's another version of the message which you might consider.



   Optionally using gs >= 9.20 together with extractpdfmark can
   significantly reduce the disk space required for building the
   documentation and the final PDF files.



Maybe native English speakers find something even better :-)


Thank you for your suggestion.
I've uploaded Patch Set 2.


https://codereview.appspot.com/314130043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-18 Thread lemzwerg

Ah, bad wording, sorry.  I don't care about the actual length of the
message but the line length in the source code, so please just wrap the
message to stay within 80 columns or so if possible.

Here's another version of the message which you might consider.

  Optionally using gs >= 9.20 together with extractpdfmark can
  significantly reduce the disk space required for building the
  documentation and the final PDF files.

Maybe native English speakers find something even better :-)


https://codereview.appspot.com/314130043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-18 Thread trueroad

Reviewers: lemzwerg,

Message:
Thank you for your reviewing.


https://codereview.appspot.com/314130043/diff/1/configure.ac
File configure.ac (right):

https://codereview.appspot.com/314130043/diff/1/configure.ac#newcode300
configure.ac:300: STEPMAKE_ADD_ENTRY(OPTIONAL,"(gs >= 9.20 and
extractpdfmark can reduce the disk space required for document building.
They also can reduce the size of generated PDF document files. Even if
they are missing, you can build documents.)")
On 2016/11/18 18:04:55, lemzwerg wrote:

Is it necessary to have such a long line?


How about the following messages?

1.
(gs >= 9.20 and extractpdfmark can reduce the size of generated PDF
document files and the disk space required for document building. Even
if they are missing, you can build documents.)

2.
(gs >= 9.20 and extractpdfmark can reduce the disk space required for
document building. Even if they are missing, you can build documents.)

3.
(gs >= 9.20 and extractpdfmark can reduce the size of generated PDF
document files and the disk space required for document building.)

4.
(gs >= 9.20 and extractpdfmark can reduce the disk space required for
document building.)

Description:
Add using Extract PDFmark for document building

Issue 5000/5: Add using Extract PDFmark for DocBook

  This commit adds using Extract PDFmark for Doc Book documents.

Issue 5000/4: Add using Extract PDFmark for LaTeX

  This commit adds using Extract PDFmark for LaTeX documents.

Issue 5000/3: Add using Extract PDFmark for Texinfo

  This commit adds using Extract PDFmark for Texinfo PDF documents.

Issue 5000/2: Add font-export and never-embed options for document
building

  This commit adds `-dfont-export-dir=[dir]` option
  and `-dgs-never-embed-fonts` option for document building.

Issue 5000/1: Add checking Ghostscript 9.20+ and Extract PDFmark

  This commit adds checking Ghostscript 9.20+ and Extract PDFmark.
  They can reduce the disk space required for document building.
  They also can reduce the size of generated PDF document files.

  Even if they are missing, you can build documents.

  Ghostscript 9.20+:
  It is necessary for string named destinations.
  Ghostscript 9.19 and prior cannot handle them.
  http://bugs.ghostscript.com/show_bug.cgi?id=696974

  Extract PDFmark:
  It is necessary for preserving named destinations and page mode.
  https://github.com/trueroad/extractpdfmark
  http://www.ctan.org/pkg/extractpdfmark

Please review this at https://codereview.appspot.com/314130043/

Affected files (+51, -0 lines):
  M config.make.in
  M configure.ac
  M make/lilypond-book-rules.make
  M make/lilypond-vars.make
  M make/lysdoc-targets.make
  M stepmake/stepmake/texinfo-rules.make


Index: config.make.in
diff --git a/config.make.in b/config.make.in
index  
d376a59f481c18a385d8b9703617d94ab8aa4662..3bf17671a029f0b3123277d98e0afb322fe415d9  
100644

--- a/config.make.in
+++ b/config.make.in
@@ -38,6 +38,8 @@ PACKAGE_NAME = @PACKAGE_NAME@

 HOST_ARCH=@HOST_ARCH@

+USE_EXTRACTPDFMARK=@USE_EXTRACTPDFMARK@
+
 
 ## FILESYSTEM
 
@@ -110,12 +112,14 @@ DBLATEX = @DBLATEX@
 DEFINES = @DEFS@ @DEFINES@
 DEFS = @DEFS@
 DOCUMENTATION = @DOCUMENTATION@
+EXTRACTPDFMARK = @EXTRACTPDFMARK@
 FIND = @FIND@
 FCLIST = @FCLIST@
 FLEX = @FLEX@
 FLEXLEXER_FILE = @FLEXLEXER_FILE@
 FONTFORGE = @FONTFORGE@
 GROFF = @GROFF@
+GS920 = @GS920@
 GUILE = @GUILE@
 GUILE_CFLAGS = @GUILE_CFLAGS@
 GUILE_CONFIG = @GUILE_CONFIG@
Index: configure.ac
diff --git a/configure.ac b/configure.ac
index  
19ffd18bf31663cda5177993589e8f7d6edcb405..7a24208d3ad50486591ea13f9391a368b30b70d0  
100644

--- a/configure.ac
+++ b/configure.ac
@@ -281,6 +281,25 @@ fi

 STEPMAKE_PATH_PROG(GHOSTSCRIPT, gs, $DOCUMENTATION_REQUIRED, 8.60)

+AC_SUBST(GS920)
+AC_SUBST(EXTRACTPDFMARK)
+AC_SUBST(USE_EXTRACTPDFMARK)
+STEPMAKE_PROGS(GS920, gs, OPTIONAL, 9.20)
+STEPMAKE_PROGS(EXTRACTPDFMARK, extractpdfmark, OPTIONAL)
+req=`STEPMAKE_NUMERIC_VERSION(9.20)`
+USE_EXTRACTPDFMARK=yes
+if test "$GS920_VERSION" -lt "$req"; then
+GS920=
+USE_EXTRACTPDFMARK=no
+fi
+if test "$EXTRACTPDFMARK" != "extractpdfmark"; then
+EXTRACTPDFMARK=
+USE_EXTRACTPDFMARK=no
+fi
+if test "$USE_EXTRACTPDFMARK" != "yes"; then
+STEPMAKE_ADD_ENTRY(OPTIONAL,"(gs >= 9.20 and extractpdfmark can reduce  
the disk space required for document building. They also can reduce the  
size of generated PDF document files. Even if they are missing, you can  
build documents.)")

+fi
+
 STEPMAKE_PROGS(MAKEINFO, makeinfo, REQUIRED, 4.11)
 STEPMAKE_PROGS(TEXI2HTML, texi2html, $DOCUMENTATION_REQUIRED, 1.82)
 STEPMAKE_PROGS(DBLATEX, dblatex, $DOCUMENTATION_REQUIRED, 0.1.4)
Index: make/lilypond-book-rules.make
diff --git a/make/lilypond-book-rules.make b/make/lilypond-book-rules.make
index  
3dda429003e092aa813c3ab319b7036c257b68d7..e0c0756bc403af37cb02b5a4f339c72d6ee5ed4a  
100644

--- a/make/lilypond-book-r

Add using Extract PDFmark for document building (issue 314130043 by truer...@gmail.com)

2016-11-18 Thread lemzwerg

Very nice, LGTM!


https://codereview.appspot.com/314130043/diff/1/configure.ac
File configure.ac (right):

https://codereview.appspot.com/314130043/diff/1/configure.ac#newcode300
configure.ac:300: STEPMAKE_ADD_ENTRY(OPTIONAL,"(gs >= 9.20 and
extractpdfmark can reduce the disk space required for document building.
They also can reduce the size of generated PDF document files. Even if
they are missing, you can build documents.)")
Is it necessary to have such a long line?

https://codereview.appspot.com/314130043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel