Re: CG: clarify git-cl and contributor quick start (issue 5240054)

2011-10-11 Thread percival . music . ca


http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi#newcode953
Documentation/contributor/source-code.itexi:953: Note that a google
account need not be a gmail account; you can
On 2011/10/11 17:34:43, Bertrand Bordage wrote:

"doesn't need to be a gmail account"?


My version was not incorrect by the rules of formal English grammar, but
it could certainly sound weird to non-native speakers.  I've made the
change you suggested, thanks!

http://codereview.appspot.com/5240054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: CG: clarify git-cl and contributor quick start (issue 5240054)

2011-10-11 Thread bordage . bertrand

LGTM


http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi#newcode953
Documentation/contributor/source-code.itexi:953: Note that a google
account need not be a gmail account; you can
"doesn't need to be a gmail account"?

http://codereview.appspot.com/5240054/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


CG: clarify git-cl and contributor quick start (issue 5240054)

2011-10-11 Thread percival . music . ca

Reviewers: ,

Message:
Patchy the autobot will ok this in an hour or so, but please take a
quick look.  Not because I think there's any problems, but because it
could bring you up to speed on the new git-cl if you're feeling
confused.

Description:
CG: clarify git-cl and contributor quick start

Please review this at http://codereview.appspot.com/5240054/

Affected files:
  M Documentation/contributor/quick-start.itexi
  M Documentation/contributor/source-code.itexi


Index: Documentation/contributor/quick-start.itexi
diff --git a/Documentation/contributor/quick-start.itexi  
b/Documentation/contributor/quick-start.itexi
index  
d12ff3578d649c0606e0d74cca5764098a483e1b..90706569fb4511a5fc0791f61b61fbc7c31c9934  
100644

--- a/Documentation/contributor/quick-start.itexi
+++ b/Documentation/contributor/quick-start.itexi
@@ -263,7 +263,7 @@ Click on the @qq{Get source} button.

 This will create a directory called @file{lilypond-git/} within
 your home directory, and will download the source code into that
-directory (around 55Mb).  When the process is finished, the
+directory (around 121Mb).  When the process is finished, the
 @qq{Command output} window will display @qq{Done}, and the button
 label will change to say @qq{Update source}.

@@ -284,13 +284,6 @@ You should now progress to @ref{Compiling with  
lilydev}.

 input should be entered from @file{~/lilypond-git/}.  This is
 referred to as the @emph{top source directory}.}

-@advanced{the @qq{Get source} button does not fetch the entire
-history of the git repository, so utilities like @command{gitk}
-will only be able to display the most recent additions.  As you
-continue to work with @command{lily-git.tcl}, the @qq{Update
-source} button will take any new additions and add it to whatever
-is currently in your repository's history.}
-

 @node Daily use of lily-git.tcl
 @unnumberedsubsec Daily use of @command{lily-git.tcl}
Index: Documentation/contributor/source-code.itexi
diff --git a/Documentation/contributor/source-code.itexi  
b/Documentation/contributor/source-code.itexi
index  
bac6bed2d6a3f50405d5059caa86b92801b4b9d7..e660490aa0358445c86aa6481a8f1ecc0a685997  
100644

--- a/Documentation/contributor/source-code.itexi
+++ b/Documentation/contributor/source-code.itexi
@@ -947,9 +947,12 @@ LilyDev users should perform these @q{configuration}  
instructions.


 @enumerate
 @item
-You must have a gmail account; please create one if you do not
+You must have a google account; please create one if you do not
 have one already.

+Note that a google account need not be a gmail account; you can
+use any email address for your google account when you sign up.
+
 @item
 Move into the top source directory and then configure @command{git
 cl} with the following commands.  If you do not understand any
@@ -990,6 +993,13 @@ If you have git push ability, make sure that you  
@emph{remove}

 your patch (with @command{git rebase} or @command{git reset})
 before pushing other stuff.

+@c don't make this one an @example; we don't want to make it easy
+@c for people to use this accidently
+Notifications of patches are automatically added to our issue
+tracker to reduce the chance of patches getting lost.  To suppress
+this (not recommended), add the @code{-n / --no-code-issue}
+option.
+
 @item
 @strong{Separate branch}: (complicated option)

@@ -1024,9 +1034,9 @@ patch set will be posted to Rietveld, and you will be  
given a URL

 for your patch.

 @warning{Some installations of git-cl fail when uploading a patch
-set that includes a .scm file.  When this happens, it can
-generally be fixed by editing the file @file{/etc/mime.types}.
-Add a line to this file containing @code{text/x-script.scheme scm}.}
+with certain filename extensions.  If this happens, it can
+generally be fixed by editing the list of exceptions at top of
+@file{git-cl.py}.}

 @subsubheading Announcing your patch set




___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel