Re: Doc: Added @knownissue to NR for fingering (issue4248081)

2011-03-15 Thread pkx166h

Pushed as f93bc90b3ee5e5de96b59c8e81b4ea354d5b1927

Only @knownissue added.

Solving issue.

http://codereview.appspot.com/4248081/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Added @knownissue to NR for fingering (issue4248081)

2011-03-12 Thread pkx166h

Reviewers: Neil Puttock, Trevor Daniels, Graham Percival,

Message:
On 2011/03/11 23:21:48, Graham Percival wrote:

LGTM, go ahead and push after fixing Neil's thing.


Made Neil's edit and uploaded but not yet pushed. I'll give it a bit
more time to see if David can come up with a patch for support  9



Description:
Doc: Added @knownissue to NR for fingering

By default double-digit fingering (i.e. 9) is not possible using
normal fingering markups. There is an LSR that has been posted for
approval
at the time of this patch, and will be included in the snippet link in
the
@seealso already in this section.

Tidied up some grammar and minor punctuation changes.

Please review this at http://codereview.appspot.com/4248081/

Affected files:
  M Documentation/notation/editorial.itely


Index: Documentation/notation/editorial.itely
diff --git a/Documentation/notation/editorial.itely  
b/Documentation/notation/editorial.itely
index  
c83383359c698b30c5fdbc64a49967a88208340e..9c3f70386f01a4519aba37ae677651cd9fe0f430  
100644

--- a/Documentation/notation/editorial.itely
+++ b/Documentation/notation/editorial.itely
@@ -166,7 +166,7 @@ c4-1 d-2 f-4 c^\markup { \finger 2 - 3 }
 @funindex \thumb
 @funindex thumb

-A thumb-script can be added (e.g., in cello music) to indicate
+A thumb-script can be added (e.g. cello music) to indicate
 that a note should be played with the thumb.

 @lilypond[verbatim,quote,relative=2]
@@ -177,8 +177,8 @@ that a note should be played with the thumb.
 @cindex fingering instructions for chords
 @cindex chords, fingering

-Fingerings for chords can also be added to individual notes of the
-chord by adding them after the pitches.
+Fingerings for chords can also be added to individual notes by
+adding them after the pitches.

 @lilypond[verbatim,quote,relative=2]
 c-1 e-2 g-3 b-52 d-1 f-2 a-3 c-5
@@ -201,7 +201,7 @@ staff, see @ref{Direction and placement}.

 @seealso
 Notation Reference:
-@ref{Direction and placement}
+@ref{Direction and placement}.

 Snippets:
 @rlsr{Editorial annotations}.
@@ -213,6 +213,10 @@ Internals Reference:
 @rinternals{New_fingering_engraver},
 @rinternals{Fingering}.

+@knownissues
+By default, numbers greater than 9 are not supported using
+@samp{@var{note}-@var{digit}}.
+

 @node Hidden notes
 @unnumberedsubsubsec Hidden notes



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Added @knownissue to NR for fingering (issue4248081)

2011-03-11 Thread percival . music . ca

LGTM, go ahead and push after fixing Neil's thing.

http://codereview.appspot.com/4248081/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Doc: Added @knownissue to NR for fingering (issue4248081)

2011-03-10 Thread n . puttock

LGTM.


http://codereview.appspot.com/4248081/diff/1/Documentation/notation/editorial.itely
File Documentation/notation/editorial.itely (right):

http://codereview.appspot.com/4248081/diff/1/Documentation/notation/editorial.itely#newcode217
Documentation/notation/editorial.itely:217: By default, numbers greater
than 9 are not possible using
not supported

http://codereview.appspot.com/4248081/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel