Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-12 Thread n . puttock 

LGTM.

http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-11 Thread pkx166h 

New patch uploaded with corrected snippet edit

http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-11 Thread percival . music . ca 

LGTM, not tested compile but I trust James.

http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-11 Thread janek . lilypond 

LGTM

http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-10 Thread Peekay Ex 
Francisco,

On Sat, Sep 10, 2011 at 12:36 AM, Francisco Vila paconet@gmail.com wrote:
 Hello all,

 2011/9/6 Peekay Ex pkx1...@gmail.com:
 I need to make a new patch. It's because of a combination of things; I was
 (and am still) waiting on Francisco to know if I can remove the old compound
 meter examples in the snippet refs in the various translation tely files (I
 have asked him for a review a couple of times and emailed directly but had
 no response) and then I was away for a couple of weeks and the patched files
 are now out of sync.

 Hello. I've found this in my recycle bin:

 Re: Doc: Added \compoundMeter function to NR (issue 4837050)
 http://lists.gnu.org/archive/html/lilypond-devel/2011-08/msg01029.html

 Message headers include [Reply_to:] to 9 addresses, [To:] to 6
 addresses, [Cc:] to 2 more addresses and none of them all is my own
 address.  So, I am very sorry to say, it seems you forgot to cc me.  I
 read and delete many messages based on the subject line and whether
 the message is for me and this didn't, despite of including the word
 Francisco in the body.  Sorry for that!

 This has been a Very Bad Year (TM) for me and I hope things will
 improve slowly from now on.  Thanks for your interest.

...

I figured this was what happened Francisco (I am still getting used to
gmail's interface and keep forgetting to reply-all).

The problem now is that my code is too old for the current tree and
fails when I try to patch. I have been trying to re-do the patch
manually but am having a hard time now getting to compile - so I'll
keep working on this today (so I am back doing 'doc' again Graham! ;)
)

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-09 Thread Francisco Vila 
Hello all,

2011/9/6 Peekay Ex pkx1...@gmail.com:
 I need to make a new patch. It's because of a combination of things; I was
 (and am still) waiting on Francisco to know if I can remove the old compound
 meter examples in the snippet refs in the various translation tely files (I
 have asked him for a review a couple of times and emailed directly but had
 no response) and then I was away for a couple of weeks and the patched files
 are now out of sync.

Hello. I've found this in my recycle bin:

Re: Doc: Added \compoundMeter function to NR (issue 4837050)
http://lists.gnu.org/archive/html/lilypond-devel/2011-08/msg01029.html

Message headers include [Reply_to:] to 9 addresses, [To:] to 6
addresses, [Cc:] to 2 more addresses and none of them all is my own
address.  So, I am very sorry to say, it seems you forgot to cc me.  I
read and delete many messages based on the subject line and whether
the message is for me and this didn't, despite of including the word
Francisco in the body.  Sorry for that!

This has been a Very Bad Year (TM) for me and I hope things will
improve slowly from now on.  Thanks for your interest.

As for Rietveld 4837050, I can not oppose to removing references to a
non-existant snippet from translated docs. Thanks for this useful
work.

-- 
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-06 Thread Peekay Ex 
Janek

On Mon, Sep 5, 2011 at 9:54 PM, janek.lilyp...@gmail.com wrote:

 James,
 i see this patch is quite orphaned despite being very nice and
 ready-to-go.  Shall i push it for you?

 cheers,
 Janek

 http://codereview.appspot.com/**4837050/http://codereview.appspot.com/4837050/


Thanks for the offer, that's nice of you, however the patch no longer
applies to current master.

:/

I need to make a new patch. It's because of a combination of things; I was
(and am still) waiting on Francisco to know if I can remove the old compound
meter examples in the snippet refs in the various translation tely files (I
have asked him for a review a couple of times and emailed directly but had
no response) and then I was away for a couple of weeks and the patched files
are now out of sync.

I'll try to get a new patch set uploaded asap. It's not forgotten (I also
let Colin know off list because he had said I could push it too), don't
worry.

-- 
--

James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-05 Thread janek . lilypond 

James,
i see this patch is quite orphaned despite being very nice and
ready-to-go.  Shall i push it for you?

cheers,
Janek

http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-24 Thread pkx166h 

On 2011/08/08 22:09:09, Trevor Daniels wrote:

LGTM
Although I'm not sure about editing the other language files.  Best

wait for

Francisco to comment.


Francisco, can you tell me if this patch is ok to go as I have touched
some of the translated docs to remove this snippet.

Thanks



http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-24 Thread pkx166h 

On 2011/08/08 22:09:09, Trevor Daniels wrote:

LGTM
Although I'm not sure about editing the other language files.  Best

wait for

Francisco to comment.


Francisco, can you tell me if this patch is ok to go as I have touched
some of
the translated docs to remove this snippet.

Thank

http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-22 Thread janek . lilypond 

Just to make things clear,
LGTM
(and sorry for my long absence)
Thanks for your work and your patience, James!

Janek

http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-08-19 Thread n . puttock 

LGTM.

http://codereview.appspot.com/4837050/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel