Re: Doc: NR Moved Appendix C to CG (issue 6948070)
LGTM https://codereview.appspot.com/6948070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR Moved Appendix C to CG (issue 6948070)
https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.texi File Documentation/contributor.texi (right): https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.texi#newcode70 Documentation/contributor.texi:70: On 2012/12/25 08:05:45, Trevor Daniels wrote: Drop the blank line Done. https://codereview.appspot.com/6948070/diff/3001/Documentation/notation.tely File Documentation/notation.tely (left): https://codereview.appspot.com/6948070/diff/3001/Documentation/notation.tely#oldcode88 Documentation/notation.tely:88: @node LilyPond grammar On 2012/12/25 08:05:45, Trevor Daniels wrote: You'll need to find and drop the menu item corresponding to this node, else the docs won't build. Done. https://codereview.appspot.com/6948070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR Moved Appendix C to CG (issue 6948070)
LGTM, apart from a couple of nitpicks which
I missed earlier. No need to post a new
patch-set.
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (left):
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely#oldcode1545
Documentation/notation/notation-appendices.itely:1545: (BNF) in
@ref{LilyPond grammar}. This file is used to build the
Our standard is two spaces after full stops in
mono-spaced text.
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely#newcode1534
Documentation/notation/notation-appendices.itely:1534: @cindex grammar,
for LilyPond
I think the comma is wrong here. grammar for Lilypond
is perfectly sensible.
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely#newcode1547
Documentation/notation/notation-appendices.itely:1547: parser during the
program build by the parser generator, Bison. It is
Same here.
https://codereview.appspot.com/6948070/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR Moved Appendix C to CG (issue 6948070)
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (left):
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely#oldcode1545
Documentation/notation/notation-appendices.itely:1545: (BNF) in
@ref{LilyPond grammar}. This file is used to build the
On 2012/12/26 10:09:45, Trevor Daniels wrote:
Our standard is two spaces after full stops in
mono-spaced text.
Done.
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely#newcode1534
Documentation/notation/notation-appendices.itely:1534: @cindex grammar,
for LilyPond
On 2012/12/26 10:09:45, Trevor Daniels wrote:
I think the comma is wrong here. grammar for Lilypond
is perfectly sensible.
Done.
https://codereview.appspot.com/6948070/diff/6001/Documentation/notation/notation-appendices.itely#newcode1547
Documentation/notation/notation-appendices.itely:1547: parser during the
program build by the parser generator, Bison. It is
On 2012/12/26 10:09:45, Trevor Daniels wrote:
Same here.
Done.
https://codereview.appspot.com/6948070/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR Moved Appendix C to CG (issue 6948070)
Once the docs build this will be ready to go. https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.texi File Documentation/contributor.texi (right): https://codereview.appspot.com/6948070/diff/3001/Documentation/contributor.texi#newcode70 Documentation/contributor.texi:70: Drop the blank line https://codereview.appspot.com/6948070/diff/3001/Documentation/notation.tely File Documentation/notation.tely (left): https://codereview.appspot.com/6948070/diff/3001/Documentation/notation.tely#oldcode88 Documentation/notation.tely:88: @node LilyPond grammar You'll need to find and drop the menu item corresponding to this node, else the docs won't build. https://codereview.appspot.com/6948070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc: NR Moved Appendix C to CG (issue 6948070)
Reviewers: Trevor Daniels,
https://codereview.appspot.com/6948070/diff/1/Documentation/contributor.texi
File Documentation/contributor.texi (right):
https://codereview.appspot.com/6948070/diff/1/Documentation/contributor.texi#newcode74
Documentation/contributor.texi:74: @verbatiminclude ly-grammar.txt
On 2012/12/17 23:43:58, Trevor Daniels wrote:
The text needs to go just before the
@include fdl.itexi
near the end of this file.
Just the * LilyPond grammar:: line should
appear in the menu block.
You'll also need to prefix the text with
@node LilyPond grammar
@appendix LilyPond grammar
Done.
https://codereview.appspot.com/6948070/diff/1/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (left):
https://codereview.appspot.com/6948070/diff/1/Documentation/notation/notation-appendices.itely#oldcode1545
Documentation/notation/notation-appendices.itely:1545: (BNF) in
@ref{LilyPond grammar}. This file is used to build the
On 2012/12/17 23:43:58, Trevor Daniels wrote:
How about leaving this paragraph in, simply
changing the @ref{} to @rcontrib{}? It is in a
Technical glossary, so I don't mind the technicalities
being mentioned here. What do you think?
Done.
Description:
Doc: NR Moved Appendix C to CG
Issue 3015
Please review this at https://codereview.appspot.com/6948070/
Affected files:
M Documentation/contributor.texi
M Documentation/notation.tely
M Documentation/notation/notation-appendices.itely
Index: Documentation/contributor.texi
diff --git a/Documentation/contributor.texi b/Documentation/contributor.texi
index
74d03bd1b7e8fb9a05ba3fbaeee96dcfa49733cd..a71b124ce60e9517849a6b8fcb46bdfa9bcf4794
100644
--- a/Documentation/contributor.texi
+++ b/Documentation/contributor.texi
@@ -66,6 +66,8 @@ Copyright @copyright{} 2007--2012 by the authors.
Appendices
+* LilyPond grammar::
+
* GNU Free Documentation License:: License of this document.
@end menu
@@ -91,7 +93,14 @@ Appendices
@include contributor/feta-font.itexi
@include contributor/administration.itexi
+@node LilyPond grammar
+@appendix LilyPond grammar
+
+This appendix contains a description of the LilyPond grammar, as
+output from the parser.
+
+@verbatiminclude ly-grammar.txt
+
@include fdl.itexi
@bye
-
Index: Documentation/notation.tely
diff --git a/Documentation/notation.tely b/Documentation/notation.tely
index
098d4f3593a3cb1aea7d783e310761a788987fc8..0e269c2076a6e7933ad0a5c8b9d4785814e33848
100644
--- a/Documentation/notation.tely
+++ b/Documentation/notation.tely
@@ -84,16 +84,6 @@ Appendices
@include notation/cheatsheet.itely
-
-@node LilyPond grammar
-@appendix LilyPond grammar
-
-This appendix contains a description of the LilyPond grammar, as
-output from the parser.
-
-@verbatiminclude ly-grammar.txt
-
-
@include fdl.itexi
Index: Documentation/notation/notation-appendices.itely
diff --git a/Documentation/notation/notation-appendices.itely
b/Documentation/notation/notation-appendices.itely
index
e74dae6184639caa4a96455ece846bfe9dca6557..8926646de7c12ac9f8b6c860b130fcadff5482c8
100644
--- a/Documentation/notation/notation-appendices.itely
+++ b/Documentation/notation/notation-appendices.itely
@@ -1530,7 +1530,8 @@ created for midi, layout and paper blocks.
@cindex parser
@cindex Bison
-@cindex grammar for LilyPond
+@cindex LilyPond grammar
+@cindex grammar, for LilyPond
@cindex BNF
A @strong{parser} analyzes the sequence of tokens produced by a
@@ -1542,10 +1543,10 @@ cannot be achieved the file is invalid and an
appropriate error
message is produced. The syntactic groupings and the rules for
constructing the groupings from their parts for the LilyPond syntax
are defined in @file{lily/parser.yy} and shown in Backus Normal Form
-(BNF) in @ref{LilyPond grammar}. This file is used to build the
-parser during the program build by the parser generator, Bison. It
-is part of the source code and is not included in the LilyPond
-binary installation.
+(BNF) in @rcontrib{LilyPond grammar}. This file is used to build the
+parser during the program build by the parser generator, Bison. It is
+part of the source code and is not included in the LilyPond binary
+installation.
@node parser variable
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Doc: NR Moved Appendix C to CG (issue 6948070)
Hi James
Thanks for tackling this - it would be hard for
me to do as compiling the full docs takes ages
on my laptop. That means I haven't actually
tested the suggestions I've made. Hope they
work!
Trevor
https://codereview.appspot.com/6948070/diff/1/Documentation/contributor.texi
File Documentation/contributor.texi (right):
https://codereview.appspot.com/6948070/diff/1/Documentation/contributor.texi#newcode74
Documentation/contributor.texi:74: @verbatiminclude ly-grammar.txt
The text needs to go just before the
@include fdl.itexi
near the end of this file.
Just the * LilyPond grammar:: line should
appear in the menu block.
You'll also need to prefix the text with
@node LilyPond grammar
@appendix LilyPond grammar
https://codereview.appspot.com/6948070/diff/1/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (left):
https://codereview.appspot.com/6948070/diff/1/Documentation/notation/notation-appendices.itely#oldcode1545
Documentation/notation/notation-appendices.itely:1545: (BNF) in
@ref{LilyPond grammar}. This file is used to build the
How about leaving this paragraph in, simply
changing the @ref{} to @rcontrib{}? It is in a
Technical glossary, so I don't mind the technicalities
being mentioned here. What do you think?
https://codereview.appspot.com/6948070/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
