Re: Fix 1805: AmbitusAccidental needs avoid-slur, needed when the notes in the ambitus have a slur (issue 4904049)

2011-09-07 Thread tdanielsmusic 

LGTM, but the regession test needs work


http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly
File input/regression/ambitus-slur.ly (right):

http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly#newcode3
input/regression/ambitus-slur.ly:3: texidoc = "Ambitus also works with
slurs.
plus "so no misleading warnings are issued."

http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly#newcode10
input/regression/ambitus-slur.ly:10: c'4( e')
On 2011/09/05 15:55:30, Neil Puttock wrote:

need an accidentalled note here

It's not necessary to produce the unwanted error

http://codereview.appspot.com/4904049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1805: AmbitusAccidental needs avoid-slur, needed when the notes in the ambitus have a slur (issue 4904049)

2011-09-05 Thread n . puttock 

LGTM.


http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly
File input/regression/ambitus-slur.ly (right):

http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly#newcode3
input/regression/ambitus-slur.ly:3: texidoc = "Ambitus also works with
slurs.
prefer

ambitus accidentals are ignored for slur avoidance

http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly#newcode8
input/regression/ambitus-slur.ly:8: \new Score {
remove

http://codereview.appspot.com/4904049/diff/3001/input/regression/ambitus-slur.ly#newcode10
input/regression/ambitus-slur.ly:10: c'4( e')
need an accidentalled note here

http://codereview.appspot.com/4904049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1805: AmbitusAccidental needs avoid-slur, needed when the notes in the ambitus have a slur (issue 4904049)

2011-09-03 Thread pkx166h 

passes Make and reg tests

http://codereview.appspot.com/4904049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix 1805: AmbitusAccidental needs avoid-slur, needed when the notes in the ambitus have a slur (issue 4904049)

2011-08-17 Thread n . puttock 


http://codereview.appspot.com/4904049/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4904049/diff/1/scm/define-grobs.scm#newcode125
scm/define-grobs.scm:125: (avoid-slur . inside)
I think it would make more sense for the engravers to ignore an
AmbitusAccidental by changing the acknowledger to use
inline-accidental-interface.

http://codereview.appspot.com/4904049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel