Re: Fix regtests about Footnote (issue 549320043 by thomasmorle...@gmail.com)

2019-12-15 Thread thomasmorley65

patch-description is changed.
Fixing footnote-auto-numbering-vertical-order.ly will take more work
than simply correct context-settings

https://codereview.appspot.com/549320043/



Fix regtests about Footnote (issue 549320043 by thomasmorle...@gmail.com)

2019-12-14 Thread thomasmorley65

Reviewers: ,

Description:
Fix regtests about Footnote

Several regtest about FootnoteItem/Spanner contained overrides
without specifying the context.
Footnote_engraver lives in Score-context, though.  Thus the
Score-context is added to the overrides in:
input/regression/footnote-auto-numbering-vertical-order.ly
input/regression/footnote-auto-numbering.ly
input/regression/footnote-spanner.ly
input/regression/in-note.ly
Regtest-diffs are expected.

Please review this at https://codereview.appspot.com/549320043/

Affected files (+17, -17 lines):
  M input/regression/footnote-auto-numbering.ly
  M input/regression/footnote-auto-numbering-vertical-order.ly
  M input/regression/footnote-spanner.ly
  M input/regression/in-note.ly


Index: input/regression/footnote-auto-numbering-vertical-order.ly
diff --git a/input/regression/footnote-auto-numbering-vertical-order.ly  
b/input/regression/footnote-auto-numbering-vertical-order.ly
index  
a7c86686eafeb6330b3e2588b8bb06eb5d38805f..780d8f2c3c22d8c2220577f3c047861ffad02436  
100644

--- a/input/regression/footnote-auto-numbering-vertical-order.ly
+++ b/input/regression/footnote-auto-numbering-vertical-order.ly
@@ -30,28 +30,28 @@ in the correct vertical order.
 <<
   \new Staff \relative {
 d'4 e
-\once \override FootnoteItem.numbering-assertion-function =
+\once \override Score.FootnoteItem.numbering-assertion-function =
   #(lambda (grob) (make-footnote-numbering-assertion-function 0))
 < f \footnote #'(1 . -1) \markup { n } a c >
-\once \override FootnoteSpanner.numbering-assertion-function =
+\once \override Score.FootnoteSpanner.numbering-assertion-function  
=

   #(simultaneous-footnote-numbering-assertion-function 2 4)
 a8-\footnote #'(1 . 1) \markup { p } \<
-\footnote #'(1 . 1) \markup { o } [ b c d ] a4 b c\f |
 d a b c |\break
 d,4 e
-\once \override FootnoteItem.numbering-assertion-function =
+\once \override Score.FootnoteItem.numbering-assertion-function =
   #(lambda (grob) (make-footnote-numbering-assertion-function 6))
 < f \footnote #'(1 . -1) \markup { n } a c >
-\once \override FootnoteSpanner.numbering-assertion-function =
+\once \override Score.FootnoteSpanner.numbering-assertion-function  
=

   #(simultaneous-footnote-numbering-assertion-function 8 10)
 a8-\footnote #'(1 . 1) \markup { p } \<
-\footnote #'(1 . 1) \markup { o } [ b c d ] a4 b c |
 d a b c\f |\pageBreak
 d,4 e
-\once \override FootnoteItem.numbering-assertion-function =
+\once \override Score.FootnoteItem.numbering-assertion-function =
   #(lambda (grob) (make-footnote-numbering-assertion-function 12))
 < f  \footnote #'(1 . -1) \markup { n } a c >
-\once \override FootnoteSpanner.numbering-assertion-function =
+\once \override Score.FootnoteSpanner.numbering-assertion-function  
=

   #(simultaneous-footnote-numbering-assertion-function 14 16)
 a8-\footnote #'(1 . 1) \markup { p } \<
-\single\footnote #'(1 . 1) \markup { o } Beam [ b c d ] a4 b c |
@@ -59,28 +59,28 @@ in the correct vertical order.
   }
   \new Staff \relative {
 d'4 e
-\once \override FootnoteItem.numbering-assertion-function =
+\once \override Score.FootnoteItem.numbering-assertion-function =
   #(lambda (grob) (make-footnote-numbering-assertion-function 1))
 < f \footnote #'(1 . -1) \markup { n } a c >
-\once \override FootnoteSpanner.numbering-assertion-function =
+\once \override Score.FootnoteSpanner.numbering-assertion-function  
=

   #(simultaneous-footnote-numbering-assertion-function 3 5)
 a8-\single\footnote #'(1 . 1) \markup { p } Hairpin \<
-\footnote #'(1 . 1) \markup { o } [ b c d ] a4 b c\f |
 d a b c |\break
 d,4 e
-\once \override FootnoteItem.numbering-assertion-function =
+\once \override Score.FootnoteItem.numbering-assertion-function =
   #(lambda (grob) (make-footnote-numbering-assertion-function 7))
 < f \footnote #'(1 . -1) \markup { n } a c >
-\once \override FootnoteSpanner.numbering-assertion-function =
+\once \override Score.FootnoteSpanner.numbering-assertion-function  
=

   #(simultaneous-footnote-numbering-assertion-function 9 11)
 a8-\footnote #'(1 . 1) \markup { p } \<
-\footnote #'(1 . 1) \markup { o } [ b c d ] a4 b c |
 d a b c\f |\pageBreak
 d,4 e
-\once \override FootnoteItem.numbering-assertion-function =
+\once \override Score.FootnoteItem.numbering-assertion-function =
   #(lambda (grob) (make-footnote-numbering-assertion-function 13))
 < f \footnote #'(1 . -1) \markup { n } a c >
-\once \override FootnoteSpanner.numbering-assertion-function =
+\once \override