Re: Fixed space after time- key-signatures (issue 4964059)

2011-09-03 Thread Keith OHara 

On Sat, 03 Sep 2011 00:13:56 -0700, Trevor Daniels  
wrote:


although the grace
note in lyric-hyphen-grace.ly seems closer to the
time signature than normal notes.  Any idea why this
is, Keith?


That is how grace notes were spaced in the last two stable versions.

Grace notes get 80% the space that a note would get to the prefatory item,
but that 80% space is measured from /left/ edge of the prefatory item, so
for wide items that results in grace notes being placed as close to the
right edge of wide prefatory item as the non-collision condition allows.

Now the space-alist mechanism is more sophisticated, specifying space to
either the left- or right- edge as appropriate for each prefatory item.
I'll try computing the desired grace note position based on this more
sophisticated specification, and propose the change if it looks good.

The proposed fix for issue 724 will add 0.8 staff-space between time-
signature and grace note anyway, by adjusting the non-collision condition.


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixed space after time- key-signatures (issue 4964059)

2011-09-03 Thread tdanielsmusic 

LGTM, thanks Keith.

Trevor

http://codereview.appspot.com/4964059/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixed space after time- key-signatures (issue 4964059)

2011-09-03 Thread Trevor Daniels 


passes Make but I get a lot of (probably expected) reg test 
differences.

Attached the most significant shifts here


These changes are all expected consequences of the
patch.  All are improvements, although the grace
note in lyric-hyphen-grace.ly seems closer to the
time signature than normal notes.  Any idea why this
is, Keith?

Trevor



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fixed space after time- key-signatures (issue 4964059)

2011-09-02 Thread pkx166h 

passes Make but I get a lot of (probably expected) reg test differences.
Attached the most significant shifts here

http://code.google.com/p/lilypond/issues/detail?id=1856#c9

(as a zip containing about 30 pngs)

james

http://codereview.appspot.com/4964059/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel