Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

2011-10-10 Thread percival . music . ca 

yes, fine, LGTM, push it.

http://codereview.appspot.com/5155045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

2011-10-08 Thread pkx166h 

Had problems uploading new patch to Rietveld after I ran makelsr.py -
there are 60+ files changed (all the comittishes for the translations) -
patch applies but my internet connection seems to be flakey and/or
Rietveld is unforgiving it seems. I want to check that this is ok (with
all those files changed).

Patch attached here.

http://code.google.com/p/lilypond/issues/detail?id=1931#c11

http://codereview.appspot.com/5155045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

2011-10-07 Thread percival . music . ca 

LGTM

http://codereview.appspot.com/5155045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

2011-10-06 Thread pkx166h 

Reviewers: Trevor Daniels, Graham Percival,

Message:
Nitpicks done. I'm still not sure of the process here

Do I need to delete the file in ../snippets/.. and then re-rerun
makelsr.py, or what?

Also I guess we need to get phil to remove this deprecated snippet from
the LSR itself so it doesn't clobber this in git or doesn't it work like
that?

Thanks

James


http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly
File Documentation/snippets/new/positioning-multi-measure-rests.ly
(right):

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode57
Documentation/snippets/new/positioning-multi-measure-rests.ly:57: %
Multi-Measure Rest by default are set under the fourth line
On 2011/10/01 21:19:50, Trevor Daniels wrote:

% Multi-measure rests ...


Done.

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode77
Documentation/snippets/new/positioning-multi-measure-rests.ly:77: % Both
voices with a Multi Measure Rest
On 2011/10/01 21:19:50, Trevor Daniels wrote:

% Multi-measure rests in both voices remain separate


Done.

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode80
Documentation/snippets/new/positioning-multi-measure-rests.ly:80: % More
that two voices with a Multi Measure Rest require an override
On 2011/10/01 21:19:50, Trevor Daniels wrote:

% Separating multi-measure rests in more than two voices requires an

override

Done.

Description:
LSR: Updated snippet for MMR Positions (1931)

Removed statement that default MMR position was #0 (it is actually #2)

Added some examples of the overrides and clarified some comments
including adding new example of more than two voices

Please review this at http://codereview.appspot.com/5155045/

Affected files:
  A Documentation/snippets/new/positioning-multi-measure-rests.ly


Index: Documentation/snippets/new/positioning-multi-measure-rests.ly
diff --git a/Documentation/snippets/new/positioning-multi-measure-rests.ly  
b/Documentation/snippets/new/positioning-multi-measure-rests.ly

new file mode 100644
index  
..ca752462a02400f098aa1f755ac33f624fa05f61

--- /dev/null
+++ b/Documentation/snippets/new/positioning-multi-measure-rests.ly
@@ -0,0 +1,59 @@
+\version 2.15.14
+
+\header {
+  lsrtags = rhythms, tweaks-and-overrides
+
+  texidoc = 
+Unlike ordinary rests, there is no predefined command to change the
+staff position of a multi-measure rest symbol of either form by
+attaching it to a note.  However, in polyphonic music multi-measure
+rests in odd-numbered and even-numbered voices are vertically
+separated. The positioning of multi-measure rests can be controlled as
+follows:
+
+
+  doctitle = Positioning multi-measure rests
+} % begin verbatim
+
+\relative c'' {
+  % Multi-measure rests by default are set under the fourth line
+  R1
+  % They can be moved using an override
+  \override MultiMeasureRest #'staff-position = #-2
+  R1
+  \override MultiMeasureRest #'staff-position = #0
+  R1
+  \override MultiMeasureRest #'staff-position = #2
+  R1
+  \override MultiMeasureRest #'staff-position = #3
+  R1
+  \override MultiMeasureRest #'staff-position = #6
+  R1
+  \revert MultiMeasureRest #'staff-position
+  \break
+
+  % In two Voices, odd-numbered voices are under the top line
+   { R1 } \\ { a1 } 
+  % Even-numbered voices are under the bottom line
+   { a1 } \\ { R1 } 
+  % Multi-measure rests in both voices remain separate
+   { R1 } \\ { R1 } 
+
+  % Separating multi-measure rests in more than two voices
+  % requires an override
+   { R1 } \\ { R1 } \\
+ \once \override MultiMeasureRest #'staff-position = #0
+ { R1 }
+  
+
+  % Using compressed bars in multiple voices requires another override
+  % in all voices to avoid multiple instances being printed
+  \compressFullBarRests
+  
+   \revert MultiMeasureRest #'staff-position
+{ R1*3 }
+\\
+   \revert MultiMeasureRest #'staff-position
+{ R1*3 }
+  
+}



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

2011-10-06 Thread Trevor Daniels 


James, you wrote Thursday, October 06, 2011 8:55 PM


Do I need to delete the file in ../snippets/.. and then re-rerun
makelsr.py, or what?


There's no need to delete it as the snippet
in /new takes precedence.

Also I guess we need to get phil to remove this deprecated snippet 
from
the LSR itself so it doesn't clobber this in git or doesn't it 
work like

that?


I'd leave it there.  The LSR runs 2.12, and the snippet
is correct for 2.12.  It won't affect the new snippet in
/new.

(I'm sure Graham or Neil will correct this if what
I've said is wrong.)

Trevor


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

2011-10-02 Thread percival . music . ca 


http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly
File Documentation/snippets/new/positioning-multi-measure-rests.ly
(right):

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode1
Documentation/snippets/new/positioning-multi-measure-rests.ly:1:
\version 2.14.0
On 2011/10/01 21:19:50, Trevor Daniels wrote:

2.15.14


I didn't read the history, but is this a clarification of old program
behavior, or something new since 2.15.13 ?  I took a quick glance at the
git changelog and I didn't see anything about multi-measure rests since
2.15.13, so I don't think the version string needs to be 2.15.14.  I'm
not certain it needs to change at all, actually.

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode8
Documentation/snippets/new/positioning-multi-measure-rests.ly:8:
texidoces = 
Do we normally have translations in here?  I thought they normally went
in places like es/texidocs/

http://codereview.appspot.com/5155045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

2011-10-02 Thread percival . music . ca 

wait a moment, why are you adding a snippet to git at all?  Just fix it
in LSR.  Talk to Phil if you don't know how.

Patch rejected, sorry.


(wow, what a disaster the whole LSR thing is!)

http://codereview.appspot.com/5155045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

2011-10-01 Thread tdanielsmusic 

A couple of nitpicks, otherwise LGTM (but untested).

(I'll abandon my patch - yours is better :)

Trevor


http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly
File Documentation/snippets/new/positioning-multi-measure-rests.ly
(right):

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode1
Documentation/snippets/new/positioning-multi-measure-rests.ly:1:
\version 2.14.0
2.15.14

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode57
Documentation/snippets/new/positioning-multi-measure-rests.ly:57: %
Multi-Measure Rest by default are set under the fourth line
% Multi-measure rests ...

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode77
Documentation/snippets/new/positioning-multi-measure-rests.ly:77: % Both
voices with a Multi Measure Rest
% Multi-measure rests in both voices remain separate

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly#newcode80
Documentation/snippets/new/positioning-multi-measure-rests.ly:80: % More
that two voices with a Multi Measure Rest require an override
% Separating multi-measure rests in more than two voices requires an
override

http://codereview.appspot.com/5155045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel