Re: Multimeasure rest print function

2011-01-30 Thread Graham Percival
On Sat, Jan 29, 2011 at 09:07:27PM +, Keith OHara wrote:
 Mike Solomon MikeSol at ufl.edu writes:
 
  
  It seems that the variable `measures' is unused in this function - can this 
  be 
 deleted?
 
 Who are you asking?   git blame (git credit would have been a nicer name) 

Aye, but nobody ever looks at code history to see who wrote some
*good* code.  ;)

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Multimeasure rest print function

2011-01-29 Thread Keith OHara
Mike Solomon MikeSol at ufl.edu writes:

 
 It seems that the variable `measures' is unused in this function - can this 
 be 
deleted?
 

Who are you asking?   git blame (git credit would have been a nicer name) 
shows these lines have not been touched in several years, so it is not likely 
to be in anyone's memory.

It really does look like a left-over piece of code, since the complete version 
appears in  symbol_stencil().  The names of functions called imply they have no 
side-effects, but I'd still do regression test.



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Multimeasure rest print function

2011-01-27 Thread Mike Solomon
Hey all,

I noticed the following lines of code in Multi_measure_rest::print (SCM smob):

snip
  int measures = 0;
  SCM m (me-get_property (measure-count));
  if (scm_is_number (m))
measures = scm_to_int (m);  
/snip

It seems that the variable `measures' is unused in this function - can this be 
deleted?

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel