Re: New alist to replace special characters. (issue 4553056)

2011-09-24 Thread bordage . bertrand 

Pushed as 688f5f1711d8ca07338385a2ae0191b1a8aae315.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-21 Thread bordage . bertrand 

New patch set.
I hope this is ready for to be pushed, now.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-21 Thread n . puttock 


http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly
File Documentation/included/special-characters.ly (right):

http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly#newcode1
Documentation/included/special-characters.ly:1: \version 2.15.12
2.15.13

http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly#newcode8
Documentation/included/special-characters.ly:8:
#(define-markup-list-command (show-special-characters layout props) ()
fix indentation (nearly every line)

http://codereview.appspot.com/4553056/diff/106003/Documentation/included/special-characters.ly#newcode13
Documentation/included/special-characters.ly:13: #:override
'(replacement-alist . ()) (car pair)
indentation is artificially compressed (aligns with the dangling
parenthesis)

http://codereview.appspot.com/4553056/diff/106003/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4553056/diff/106003/Documentation/notation/input.itely#newcode1762
Documentation/notation/input.itely:1762: \new Staff { \repeat unfold 9
a' }
a'4

http://codereview.appspot.com/4553056/diff/106003/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):

http://codereview.appspot.com/4553056/diff/106003/Documentation/notation/notation-appendices.itely#newcode912
Documentation/notation/notation-appendices.itely:912: The rest of them
are inspired of LaTeX.
inspired by @LaTeX{}

http://codereview.appspot.com/4553056/diff/106003/input/regression/markup-special-characters.ly
File input/regression/markup-special-characters.ly (right):

http://codereview.appspot.com/4553056/diff/106003/input/regression/markup-special-characters.ly#newcode1
input/regression/markup-special-characters.ly:1: \version 2.15.12
2.15.13

http://codereview.appspot.com/4553056/diff/106003/input/regression/markup-special-characters.ly#newcode4
input/regression/markup-special-characters.ly:4: A list of special
characters ASCII aliases can be easily included.
character

http://codereview.appspot.com/4553056/diff/106003/input/regression/markup-special-characters.ly#newcode5
input/regression/markup-special-characters.ly:5: This works for markups
and lyrics.
remove leading spaces

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc
File lily/text-interface.cc (right):

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode43
lily/text-interface.cc:43: if (!to_boolean (scm_list_p
(replacement_alist))
!ly_is_list

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode44
lily/text-interface.cc:44: || to_boolean (scm_null_p
(replacement_alist)))
scm_is_null

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode51
lily/text-interface.cc:51: (scm_string_length (scm_caar (s;
fix indent (run through fixcc.py)

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode56
lily/text-interface.cc:56: for (int j = max_length; j  0; j--)
(vsize j = max_length; j--;)

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode60
lily/text-interface.cc:60: (ly_assoc_get (ly_string2scm (dummy),
fix indent

http://codereview.appspot.com/4553056/diff/106003/lily/text-interface.cc#newcode61
lily/text-interface.cc:61: replacement_alist, SCM_BOOL_F), );
fix indent

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly
File ly/text-replacements.ly (right):

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode20
ly/text-replacements.ly:20: #(define (add-text-replacements! alist)
fix indentation

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode26
ly/text-replacements.ly:26: (add-text-replacements!
fix indentation

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode27
ly/text-replacements.ly:27: '(; Punctuation
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode36
ly/text-replacements.ly:36: ; French, German and English quotes
open/close
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode50
ly/text-replacements.ly:50: ; Word dividers
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode60
ly/text-replacements.ly:60: ; General typography
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode77
ly/text-replacements.ly:77: ; Diacritics
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode88
ly/text-replacements.ly:88: ; Non-ASCII Letters (Excluding Accented
Letters)
;;

http://codereview.appspot.com/4553056/diff/106003/ly/text-replacements.ly#newcode110
ly/text-replacements.ly:110: ; Mathematical symbols
;;

Re: New alist to replace special characters. (issue 4553056)

2011-09-21 Thread bordage . bertrand 

Thanks a lot, Neil.
Could you have a last look at the Scheme files?
I'm not sure of the indentation.

I created a new scm/text.scm file for the definitions I couldn't put
elsewhere.

Bertrand

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread bordage . bertrand 

Hey!

I'm currently writing a doc entry that explains how to use replacements.
I have a few questions:

Where do you think I should put it? In NR 1.8.1 or 1.8.2?

Do you think I have to move the table from the regtest to the Appendix A
(and keep the rest of the regtest as a regtest)?

Bertrand

PS: I'm also writing a changelog entry.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread pkx166h 

On 2011/09/20 10:18:41, Bertrand Bordage wrote:

Hey!



I'm currently writing a doc entry that explains how to use

replacements. I have

a few questions:



Where do you think I should put it? In NR 1.8.1 or 1.8.2?


Hmm.. I'd say 3.3.3 actually

http://lilypond.org/doc/v2.14/Documentation/notation/text-encoding

1.8.x are how to format text (bold italic etc) not to use special chars
which this seems to be and which NR 3.3.3 is all about.



Do you think I have to move the table from the regtest to the Appendix

A (and

keep the rest of the regtest as a regtest)?


I am not experienced enough to answer this, but which Appendix A did you
intend? A new one or add to an existing as I cannot see where this would
be appropriate.


Bertrand



PS: I'm also writing a changelog entry.




http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread bordage . bertrand 

On 2011/09/20 12:07:31, J_lowe wrote:

 Where do you think I should put it? In NR 1.8.1 or 1.8.2?



Hmm.. I'd say 3.3.3 actually


Oh, yes! This is better.


 Do you think I have to move the table from the regtest to the

Appendix A (and

 keep the rest of the regtest as a regtest)?



I am not experienced enough to answer this, but which Appendix A did

you intend?

A new one or add to an existing as I cannot see where this would be

appropriate.

In a new one called Special characters, just after Text markup list
commands.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread bordage . bertrand 

New patch set including some documentation work.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread tdanielsmusic 

A few comments following a quick look at the doc changes

Trevor


http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1591
Documentation/notation/input.itely:1591: @cindex UTF-8
Better to index these under the appropriate subsubsec

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1597
Documentation/notation/input.itely:1597: @end menu
I think I'd prefer the order to be:

* Text encoding::
* Unicode::
* ASCII aliases::

That way we work from the general to the more specific,
rather than the other way round.

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1625
Documentation/notation/input.itely:1625: See the complete @ref{List of
special characters}.
Should also have a See also:

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1636
Documentation/notation/input.itely:1636: @end lilypond
Didn't we discuss earlier using \include?
If this works it should be mentioned too.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread bordage . bertrand 

Hmm, I don't understand one comment, but I agree with the others.

Thanks,
Bertrand


http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1636
Documentation/notation/input.itely:1636: @end lilypond
What do you mean?

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread tdanielsmusic 


http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1636
Documentation/notation/input.itely:1636: @end lilypond
On 2011/09/20 17:09:48, Bertrand Bordage wrote:

What do you mean?


See comments 25 and 26.

If this works (I presume it does):

germanHTML = #(add-text-replacements! '((ss; . ß)
[...]))
frenchLigatures = [...]

\paper {
  \germanHTML
  \frenchLigatures
}

it would be good to use this form in the snippet and
comment that the definitions can be placed in ly files
which can be \included.

http://codereview.appspot.com/4553056/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread Trevor Daniels 


bordage.bertr...@gmail.com
Tuesday, September 20, 2011 11:18 AM

Do you think I have to move the table from the regtest to the 
Appendix A

(and keep the rest of the regtest as a regtest)?


Yes.  Between the current A10 and A11 looks a good place.

Trevor



-
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1410 / Virus Database: 1520/3908 - Release Date: 09/20/11


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread bordage . bertrand 


http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/input.itely#newcode1636
Documentation/notation/input.itely:1636: @end lilypond
Yes, unfortunately, this isn't simple. I didn't find any technical way
to achieve this.

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-20 Thread percival . music . ca 


http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/notation-appendices.itely
File Documentation/notation/notation-appendices.itely (right):

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/notation-appendices.itely#newcode909
Documentation/notation/notation-appendices.itely:909: @example
blank line before @example and after @end example

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/notation-appendices.itely#newcode912
Documentation/notation/notation-appendices.itely:912: to a @code{\paper}
block. See @ref{ASCII aliases} for more details.
We're not allowed to write
  see @ref{} for more details
according to the texinfo spec.  Please change to:
  For more details, see @ref{}.

Come to think of it, rewrite the whole paragraph to keep the @example
after the text:

The following special characters references can be used; for more
details, see @ref{ASCII aliases}.

@example
...
@end example

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-19 Thread mtsolo 

Hey Bertrand,

Could you show an example, in the regtest, of how one would write:

ndash;

(or whatever) such that ndash; appeared (meaning the string ndash; -
not the replacement n-dash).

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-16 Thread pkx166h 

Hello, passes make but fails make check

please see

http://code.google.com/p/lilypond/issues/detail?id=1891#c1

James

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-16 Thread pkx166h 

On 2011/09/16 21:31:25, J_lowe wrote:

Hello, passes make but fails make check


Sorry ignore this, I just realised I made a mistake in my make check.
I'll redo now.

James

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-16 Thread pkx166h 

passes make and reg tests

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

2011-09-15 Thread bordage . bertrand 

New patch set.
'' and '@' have been added to the lexer.
'' is therefore a perfectly working escape character in lyrics.

Bertrand

http://codereview.appspot.com/4553056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel