New instrument name posititioning in scheme displays instr. name for haraiki'ed staves

2009-08-10 Thread Reinhold Kainhofer
Since the patch b8a1b9b174a3b68f05bb3e08fb5f754649b92574, short instrument 
names for harakiried staves are still printed (above each other, at the top of 
the system).

Example attached.

Cheers,
Reinhold
-- 
--
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial  Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org
\version 2.13.4
\pointAndClickOff
\score {
  \new StaffGroup 
\new Staff {
  \set Staff.shortInstrumentName = A 1
  c''1 \break c''1
}
\new Staff {
  \set Staff.shortInstrumentName = B 2
  R1*2
}
\new Staff {
  \set Staff.shortInstrumentName = C 3
  R1*2
}
  
 \layout {
  \context { \RemoveEmptyStaffContext }
 }
}

iname.pdf
Description: Adobe PDF document
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: New instrument name posititioning in scheme displays instr. name for haraiki'ed staves

2009-08-10 Thread Neil Puttock
2009/8/10 Reinhold Kainhofer reinh...@kainhofer.com:
 Since the patch b8a1b9b174a3b68f05bb3e08fb5f754649b92574, short instrument
 names for harakiried staves are still printed (above each other, at the top of
 the system).

Oh dear, that's not good. :)

It looks like I should have paid more attention to
`instrument-name-hara-kirk.ly' (and to Joe's comment about applying
interval-center to an empty interval, since this would only occur if
the elements list is empty, i.e., hara-kiried); unfortunately, this
regression didn't show up with `make check'.

I'll push a fix once I've double checked the regression tests.

Cheers,
Neil


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: New instrument name posititioning in scheme displays instr. name for haraiki'ed staves

2009-08-10 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am Montag, 10. August 2009 22:56:09 schrieb Neil Puttock:
 2009/8/10 Reinhold Kainhofer reinh...@kainhofer.com:
  Since the patch b8a1b9b174a3b68f05bb3e08fb5f754649b92574, short
  instrument names for harakiried staves are still printed (above each
  other, at the top of the system).

 Oh dear, that's not good. :)
[...]
 I'll push a fix once I've double checked the regression tests.

... and added a new regression test for this bug, right? ;-)

Cheers,
Reinhold

- -- 
- --
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial  Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFKgI0/TqjEwhXvPN0RAnkyAJ91QPKZ4VVYx4HJDq9h7XJtpzGRCwCfYJ+u
o9nsA5RNe/y26Fuy1xsVlGs=
=QzYC
-END PGP SIGNATURE-


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: New instrument name posititioning in scheme displays instr. name for haraiki'ed staves

2009-08-10 Thread Neil Puttock
2009/8/10 Reinhold Kainhofer reinh...@kainhofer.com:

 ... and added a new regression test for this bug, right? ;-)

Heheh, I'm hoping it won't come to that if I can get the existing test
to work properly (I'm hopeful making the name longer will work).

Regards,
Neil


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: New instrument name posititioning in scheme displays instr. name for haraiki'ed staves

2009-08-10 Thread Neil Puttock
2009/8/10 Neil Puttock n.putt...@gmail.com:

 Heheh, I'm hoping it won't come to that if I can get the existing test
 to work properly (I'm hopeful making the name longer will work).

Well this is rather puzzling: if I fix the bug, `make check' shows the
correction with a distance of 1.00 (even without changing
shortInstrumentName), whereas testing current master against a
baseline of 1ac472 (just before the instrument name patch) doesn't
reveal the regression.

Can anybody explain what's going on?

Regards,
Neil


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel