Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)
Pushed as 8adeb99e344bf047b9b3b9b48a9e97e59e8fc4d3 and 71aa438bce0f68b0e8ab8c633b4902c971ede48b. http://codereview.appspot.com/5233042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)
Thanks Neil, I'll make two commits. Do you want to see them both on codereview? Comment in lily-guile restored. http://codereview.appspot.com/5233042/diff/12001/lily/lily-guile.cc File lily/lily-guile.cc (left): http://codereview.appspot.com/5233042/diff/12001/lily/lily-guile.cc#oldcode72 lily/lily-guile.cc:72: Ugh. this is not very efficient. This was a mistake, sorry. http://codereview.appspot.com/5233042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)
Hi Betrand, This should be split into two patches: one for the optimization and another for adding robust_symbol2string lookups outside note-head.cc. Cheers, Neil http://codereview.appspot.com/5233042/diff/12001/lily/lily-guile.cc File lily/lily-guile.cc (left): http://codereview.appspot.com/5233042/diff/12001/lily/lily-guile.cc#oldcode72 lily/lily-guile.cc:72: Ugh. this is not very efficient. why have you removed this comment? http://codereview.appspot.com/5233042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)
Passes make and make check throws up no reg tests except graphviz.log: --snip-- @@ -14,9 +14,9 @@ Writing graph `#f'...digraph G { rankdir="LR" node [shape=rectangle] -41 [label="caching Stem.stencil\n# -> #"] +41 [label="caching LedgerLineSpanner.stencil\n# -> #"] 40 [label="caching VerticalAxisGroup.stencil\n# -> #f"] -39 [label="caching LedgerLineSpanner.stencil\n# -> #"] +39 [label="caching Stem.stencil\n# -> #"] 38 [label="caching StaffSymbol.stencil\n# -> #"] 37 [label="caching Stem.Y-extent\n# -> (-2.812186 . 0.5)"] 36 [label="caching Stem.length\n# -> 6.624372"] @@ -56,7 +56,7 @@ 2 [label="NoteHead\n/home/jlowe/lilypond-git/lily/engraver.cc:60\ncause <- # 41 +37 -> 39 36 -> 37 35 -> 36 34 -> 35 --snip-- James http://codereview.appspot.com/5233042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)
http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc#newcode79 lily/note-head.cc:79: out = fm->find_by_name (idx_either); Unfortunately, this doesn't work. If the condition line 73 is false, then out will be an empty stencil. But this gave me an idea: use two stencils instead of one. Instead of overwriting the working stencil 'out' to check if the new one is empty, we can use another 'test' stencil. I test that now and upload it. http://codereview.appspot.com/5233042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)
http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/5233042/diff/1/lily/note-head.cc#newcode79 lily/note-head.cc:79: out = fm->find_by_name (idx_either); This performs a second lookup for every note-head. Move this call to line 61, so you only perform the second lookup if there is a possibility that it will give a new result. http://codereview.appspot.com/5233042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)
Reviewers: , Message: Hi, This is a try to increase performance, especially under Windows (see http://code.google.com/p/lilypond/issues/detail?id=1926). As I don't use Windows to compile LilyPond, can someone test it? Regards, Bertrand Description: Optimizes note-heads.cc and introduces robust_symbol2string. Potential fix to issue 1926. Please review this at http://codereview.appspot.com/5233042/ Affected files: M lily/include/lily-guile.hh M lily/lily-guile.cc M lily/lily-parser-scheme.cc M lily/note-head.cc M lily/page-turn-engraver.cc M lily/paper-column-engraver.cc M lily/program-option-scheme.cc M lily/rest.cc M lily/stem.cc M lily/time-signature.cc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel