Re: PATCH: 48-hour countdown to 20110914
2011/9/13 Peekay Ex pkx1...@gmail.com: 2011/9/13 Janek Warchoł janek.lilyp...@gmail.com: 2011/9/13 Peekay Ex pkx1...@gmail.com: On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: countdown for 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review after some comments today. you mean needs_work? I do. I still don't get it... I don't see any new comments either in tracker http://code.google.com/p/lilypond/issues/detail?id=1873 or on Rietveld http://codereview.appspot.com/4951062/ All comments there are at least 3 days old. Also, the patch status of the tracker issue is patch-review. ?? cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
Janek, 2011/9/14 Janek Warchoł janek.lilyp...@gmail.com: 2011/9/13 Peekay Ex pkx1...@gmail.com: 2011/9/13 Janek Warchoł janek.lilyp...@gmail.com: 2011/9/13 Peekay Ex pkx1...@gmail.com: On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: countdown for 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review after some comments today. you mean needs_work? I do. I still don't get it... I don't see any new comments either in tracker http://code.google.com/p/lilypond/issues/detail?id=1873 or on Rietveld http://codereview.appspot.com/4951062/ All comments there are at least 3 days old. Also, the patch status of the tracker issue is patch-review. ?? I have gone back over again. I think somewhere I confused two tracker issues (this and the change to parmesan noteheads issue). You are right sorry. But I have gone back over the the correct tracker and the correct Reitveld and it is fine. :) Patch-review and I did my reg tests ok. Sorry but thanks for catching this. James -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
Hello, On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: For 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review after some comments today. Regards -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
2011/9/13 Peekay Ex pkx1...@gmail.com: Hello, On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: For 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review you mean needs_work? after some comments today. I don't see any, are you perhaps referring to another patch? cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: 48-hour countdown to 20110914
Hello, 2011/9/13 Janek Warchoł janek.lilyp...@gmail.com: 2011/9/13 Peekay Ex pkx1...@gmail.com: Hello, On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell c...@shaw.ca wrote: For 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 This has been set back to review you mean needs_work? I do. Sorry. -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: 48-hour countdown to 20110914
For 22:00 MDT Wednesday, September 14 Issue 456 http://code.google.com/p/lilypond/issues/detail?id=456: \laissezVibrer in chords - R 4969069 http://codereview.appspot.com/4969069/ Issue 1876 http://code.google.com/p/lilypond/issues/detail?id=1876: MusicXML: fix case when some elements have a staff number, while others don't - R 4991044 http://codereview.appspot.com/4991044/ Issue 1193 http://code.google.com/p/lilypond/issues/detail?id=1193: Enhancement: internal ledger lines, and Issue 1292 http://code.google.com/p/lilypond/issues/detail?id=1292: Enhancement: twelve-notation support, and Issue 1878 http://code.google.com/p/lilypond/issues/detail?id=1878: Add support for custom ledger positions All 3 above connected to R 4974075 http://codereview.appspot.com/4974075/ Issue 380 http://code.google.com/p/lilypond/issues/detail?id=380: cycling markup reference segfaults - R 4951073 http://codereview.appspot.com/4951073/ Issue 1852 http://code.google.com/p/lilypond/issues/detail?id=1852: manuals needs more explicit dependencies - R 4996044 http://codereview.appspot.com/4996044/ Issue 1873 http://code.google.com/p/lilypond/issues/detail?id=1873: Added glyphs for Kievan Notation - R 4951062 http://codereview.appspot.com/4951062/ Issue 1776 http://code.google.com/p/lilypond/issues/detail?id=1776: Doc: NR - Polymetric Notation \compoundMeter isn't documented - R 4837050 http://codereview.appspot.com/4837050/ A goodly batch today, devels. Nice work! Cheers Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel