Re: PATCH: Use same fret-assignment code for FretBoards and TabStaff

2010-01-23 Thread Neil Puttock
Hi Carl,

On 22 January 2010 03:14, Carl Sorensen  wrote:

> Please review the patch at
>
> http://codereview.appspot.com/186268/show

I'll post some comments on Rietveld soon.

Cheers,
Neil


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


PATCH: Use same fret-assignment code for FretBoards and TabStaff

2010-01-21 Thread Carl Sorensen
In response to a request from Patrick Schmidt on the tablatures list, I
became aware of the fact that we have two separate methods of finding
strings and frets given notes -- one for the tab-note-heads-engraver and one
for the fretboards-engraver.

This didn't seem to me to be a very good situation, so I rewrote the code so
that both engravers call the procedure specified in the context property
noteToFretFunction to get frets and strings from notes.

Please review the patch at

http://codereview.appspot.com/186268/show


Thanks,

Carl



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel