Re: Patch: Delete intermediate ps files
On Tue, Jul 14, 2009 at 09:34:34PM +0100, Neil Puttock wrote: 2009/7/13 Maximilian Albert maximilian.alb...@googlemail.com: Thanks a lot! So does this close issue 685? Yes. Not until somebody changes the status! Remember, whenever you push a fix to master, alter the status on the tracker. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/13 Maximilian Albert maximilian.alb...@googlemail.com: Thanks a lot! So does this close issue 685? Yes. What's the status about .log files being created on Windows mentioned there? Assuming this is a feature Windows users would like, it should be logged as a new issue (low priority enhancement I'd imagine). Regards, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
Neil Puttock wrote Tuesday, July 14, 2009 9:34 PM 2009/7/13 Maximilian Albert maximilian.alb...@googlemail.com: Thanks a lot! So does this close issue 685? Yes. What's the status about .log files being created on Windows mentioned there? Assuming this is a feature Windows users would like, it should be logged as a new issue (low priority enhancement I'd imagine). If the Windows user is invoking LP by double-clicking a .ly file the only way to see the console output is via the log file. It is essential for this mode of working. Most Windows users would do this, at least at the start, when it is essential that they see the error messages. The alternative is to use an editor which can launch a compilation and capture the console output (that's what I do), or to invoke LP from the command line DOS box (not natural for most Windows users) Regards, Neil Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/10 Maximilian Albert maximilian.alb...@googlemail.com: OK, thanks. Now the docs compiled fine and I could check that the result of my patch is as intended. Any further comments or are they ready to be applied? Thanks, they're both applied. Regards, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/13 Neil Puttock n.putt...@gmail.com: Thanks, they're both applied. Thanks a lot! So does this close issue 685? What's the status about .log files being created on Windows mentioned there? Max ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/10 Graham Percival gra...@percival-music.ca: I've just got the same error. It's caused by Graham's essay makefile hacking. Sorry, I'll branch a dev/graham and then revert it. OK, thanks. Now the docs compiled fine and I could check that the result of my patch is as intended. Any further comments or are they ready to be applied? Max ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/9 Graham Percival gra...@percival-music.ca: Yes, that patch is the only thing needed to fix it. However, does this patch apply cleanly, without disrupting any regtests? Hmm, I tried to run the regression tests via 'make check' (is that the right way to do it?) with the current git version first (i.e., before applying my patch) and got the following error: == make[2]: Entering directory `/home/cilix/code/lilypond/input/regression' /home/cilix/code/lilypond/scripts/build/out/extract_texi_filenames -o /home/cilix/code/lilypond/out/xref-maps out-test/collated-files.texi extract_texi_filenames.py: Processing out-test/collated-files.texi texi2html --I=/home/cilix/code/lilypond/out/xref-maps --I=. --I=./out-test --output=out-test/collated-files.html --init-file=/home/cilix/code/lilypond/lilypond-texi2html.init out-test/collated-files.texi WARNING: Unable to load the map file Undefined subroutine main:: called at /home/cilix/code/lilypond/lilypond-texi2html.init line 743. make[2]: *** [out-test/collated-files.html] Error 25 rm /home/cilix/code/lilypond/out/xref-maps/collated-files.xref-map make[2]: Leaving directory `/home/cilix/code/lilypond/input/regression' make[1]: *** [local-test] Error 2 make[1]: Leaving directory `/home/cilix/code/lilypond/input/regression' make: *** [test] Error 2 == What's going wrong? Thanks for any hints, Max ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/9 Maximilian Albert maximilian.alb...@googlemail.com Hmm, I tried to run the regression tests via 'make check' (is that the right way to do it?) No, see Testing LilyPond in the Contrib Guide or in Application usage, section Install/build from source/compile (don't remember the exact name). with the current git version first (i.e., before applying my patch) Building without GUB only depend on the source working tree and not on git status at all. However, make test-baseline requires you to have a clean Git working tree. So commit your patch, run git checkout HEAD^ make test-baseline git checkout master # or whatever the head where you committed was make check and a final isntruction to see comparison results I don't remember, see the docs. HTH, John ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/9 John Mandereau john.mander...@gmail.com: 2009/7/9 Maximilian Albert maximilian.alb...@googlemail.com Hmm, I tried to run the regression tests via 'make check' (is that the right way to do it?) No, see Testing LilyPond in the Contrib Guide or in Application usage, section Install/build from source/compile (don't remember the exact name). Aha! Thanks for pointing me there. I performed the instructions given there and got three differences reported (one of which is in the file tree.gittxt and is due to the new git commit) but I don't see how any of the other two can be related to the deletion of the intermediate ps file. Do you want to take a look at the test output or is it fine to apply the patch since there was no error? I also attached a second patch for the NEWS entry. I couldn't test it, though, since 'make doc' (which I initially thought generates the documentation) produces an error and 'make web' only says make: *** No rule to make target `web'. Stop. :-( Let me know if I can do anything else. Cheers, Max From 2a0adf68f4519678f0bf5f902acb7044dbd2a43e Mon Sep 17 00:00:00 2001 From: Maximilian Albert maximilian.alb...@gmail.com Date: Wed, 8 Jul 2009 13:55:49 +0900 Subject: [PATCH] Delete intermediate ps files by default --- scm/lily.scm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scm/lily.scm b/scm/lily.scm index 270ed42..53dd685 100644 --- a/scm/lily.scm +++ b/scm/lily.scm @@ -65,7 +65,7 @@ configurations.) Debug cyclic callback chains.) (debug-skylines #f Debug skylines.) -(delete-intermediate-files #f +(delete-intermediate-files #t Delete unusable, intermediate PostScript files.) (dump-profile #f Dump memory and time information for each file.) -- 1.6.0.4 From 88a9943dce2d23c95ff67a8fe383b2a5a7601f27 Mon Sep 17 00:00:00 2001 From: Maximilian Albert maximilian.alb...@gmail.com Date: Thu, 9 Jul 2009 18:04:11 +0900 Subject: [PATCH] Add NEWS entry about automatic deletion of intermediate files --- Documentation/topdocs/NEWS.tely |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/Documentation/topdocs/NEWS.tely b/Documentation/topdocs/NEWS.tely index 0b4bbd4..62d2021 100644 --- a/Documentation/topdocs/NEWS.tely +++ b/Documentation/topdocs/NEWS.tely @@ -62,6 +62,14 @@ which scares away people. @end ignore +...@item Intermediate .ps files which are created by Lilypond +during compilation are now deleted by default. To keep them, +add the line +...@example +#(ly:set-option 'delete-intermediate-files #f) +...@end example +to your input files. + @item Dashed and dotted slurs, phrasing slurs, and ties have been made variable thickness, and partially dashed slurs are now available: -- 1.6.0.4 ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/9 Maximilian Albert maximilian.alb...@googlemail.com: I performed the instructions given there and got three differences reported (one of which is in the file Addendum: After re-running the tests with the additional NEWS entry, there are only two differences, one of which is test-output-distance.ly (which is supposed to always show up, IIUC) and the other one is due to the additional git commit as mentioned. So I guess the new patches pass the test. ;-) Cheers, Max ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/9 Maximilian Albert maximilian.alb...@googlemail.com: 'make doc' (which I initially thought generates the documentation) produces an error Which error? If you can't fix it yourself, please report, including the last 100 lines of make output and other log files as appropriate. and 'make web' only says make: *** No rule to make target `web'. Stop. :-( 'web' target has been renamed to 'doc'. Cheers, John ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch: Delete intermediate ps files
2009/7/10 John Mandereau john.mander...@gmail.com: 2009/7/9 Maximilian Albert maximilian.alb...@googlemail.com: 'make doc' (which I initially thought generates the documentation) produces an error Which error? If you can't fix it yourself, please report, including the last 100 lines of make output and other log files as appropriate. You can find them here, along with the error message (at the bottom): http://pastebin.com/m2bcb5c37 Thanks for your help, Max ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
2009/7/9 Maximilian Albert maximilian.alb...@googlemail.com: You can find them here, along with the error message (at the bottom): http://pastebin.com/m2bcb5c37 I've just got the same error. It's caused by Graham's essay makefile hacking. Unfortunately I don't know how to fix it apart from reverting the whole patch. Regards, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
On Thu, Jul 09, 2009 at 08:01:46PM +0100, Neil Puttock wrote: 2009/7/9 Maximilian Albert maximilian.alb...@googlemail.com: You can find them here, along with the error message (at the bottom): http://pastebin.com/m2bcb5c37 I've just got the same error. It's caused by Graham's essay makefile hacking. Sorry, I'll branch a dev/graham and then revert it. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Patch: Delete intermediate ps files
Yes, that patch is the only thing needed to fix it. However, does this patch apply cleanly, without disrupting any regtests? It's possible that some (badly written) regtests require the intermediate files to be built. If so, we'd need to add a build rule to add the -d option to enable intermediate files. If you can check this, and add a NEWS item about this change, then we can apply the patch. Cheers, - Graham On Wed, Jul 08, 2009 at 01:57:00PM +0900, Maximilian Albert wrote: Hi, am I missing something or is the only thing that is needed to solve the first part of issue #685 (see http://code.google.com/p/lilypond/issues/detail?id=685 ) a one-line change as in the attached patch? As for the second part, are log files still created by default? This doesn't seem to be the case with the latest version 2.13.4. Cheers, Max From e7c2bc32829c1e6a9197c893497019a7b2904ded Mon Sep 17 00:00:00 2001 From: Maximilian Albert maximilian.alb...@gmail.com Date: Wed, 8 Jul 2009 13:55:49 +0900 Subject: [PATCH] Delete intermediate ps files by default --- scm/lily.scm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scm/lily.scm b/scm/lily.scm index 270ed42..53dd685 100644 --- a/scm/lily.scm +++ b/scm/lily.scm @@ -65,7 +65,7 @@ configurations.) Debug cyclic callback chains.) (debug-skylines #f Debug skylines.) -(delete-intermediate-files #f +(delete-intermediate-files #t Delete unusable, intermediate PostScript files.) (dump-profile #f Dump memory and time information for each file.) -- 1.6.0.4 ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch: Delete intermediate ps files
Hi, am I missing something or is the only thing that is needed to solve the first part of issue #685 (see http://code.google.com/p/lilypond/issues/detail?id=685 ) a one-line change as in the attached patch? As for the second part, are log files still created by default? This doesn't seem to be the case with the latest version 2.13.4. Cheers, Max From e7c2bc32829c1e6a9197c893497019a7b2904ded Mon Sep 17 00:00:00 2001 From: Maximilian Albert maximilian.alb...@gmail.com Date: Wed, 8 Jul 2009 13:55:49 +0900 Subject: [PATCH] Delete intermediate ps files by default --- scm/lily.scm |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scm/lily.scm b/scm/lily.scm index 270ed42..53dd685 100644 --- a/scm/lily.scm +++ b/scm/lily.scm @@ -65,7 +65,7 @@ configurations.) Debug cyclic callback chains.) (debug-skylines #f Debug skylines.) -(delete-intermediate-files #f +(delete-intermediate-files #t Delete unusable, intermediate PostScript files.) (dump-profile #f Dump memory and time information for each file.) -- 1.6.0.4 ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
