Re: Patch for new harmonic glyph

2007-01-27 Thread Maximilian Albert 
>> If you feel comfortable with it this way
>> it might be good to update the docs, too (probably adding two sample
>> bars to note-head-style.ly in the regression tests would suffice). If
>> you wish I can try to do that later on.
> 
> please do.

Here it is. Sorry that it took me so long to submit only a few
additional lines of code. I just wanted to make sure not to miss any
other locations in the docs where a reference to the new styles would
make sense.

In addition, I had a problem with "make web" when trying to verify the
changes (the file input/typography.ly fails to compile). I am now even
tempted to think that it is a bug in the latest git version because even
the most simple file containing only a few notes fails to be processed
with the freshly compiled v2.11.15 from git (it took me some time to
find that out). But I haven't had time to figure out yet what exactly
causes the error.

Cheers
Max
From f35db04c340cdc55eacf613cbcdc0ffe86a9d0ee Mon Sep 17 00:00:00 2001
From: Maximilian Albert <[EMAIL PROTECTED]>
Date: Sat, 27 Jan 2007 18:34:26 +0100
Subject: [PATCH] add new notehead styles 'harmonic-black' and 'harmonic-mixed' 
to docs (in regression tests)

---
 input/regression/note-head-style.ly |   10 ++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/input/regression/note-head-style.ly 
b/input/regression/note-head-style.ly
index b5164e9..c561eec 100644
--- a/input/regression/note-head-style.ly
+++ b/input/regression/note-head-style.ly
@@ -61,6 +61,16 @@ pattern = <<
 
   \break
 
+  \override Staff.NoteHead  #'style = #'harmonic-black
+  s1*0^\markup { "harmonic-black" }
+  \pattern
+
+  \override Staff.NoteHead  #'style = #'harmonic-mixed
+  s1*0^\markup { "harmonic-mixed" }
+  \pattern
+
+  \break
+
   \override Staff.NoteHead  #'style = #'diamond
   s1*0^\markup { "diamond" }
   \pattern
-- 
1.4.4.4

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patch for new harmonic glyph

2007-01-26 Thread Han-Wen Nienhuys 
Maximilian Albert escreveu:
> Han-Wen Nienhuys wrote:
> 
>>> I also added a glyph called "s1harmonic" which [...] in a way "closes
>>> the gap" between "s0" and "s2". [...] Agree?
>> No, this should be handled by the code in output-lib. That code's sole 
>> purpose
>> is to fill all the gaps in the different styles.
> 
> Alright, so I removed "s1harmonic" from mf/parmesan-heads.mf again but
> left the two new styles as they are. If you feel comfortable with it
> this way (otherwise please do not hesitate to make further suggestions)
> it might be good to update the docs, too (probably adding two sample
> bars to note-head-style.ly in the regression tests would suffice). If
> you wish I can try to do that later on.

please do.
-- 

Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen

LilyPond Software Design
 -- Code for Music Notation
http://www.lilypond-design.com



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Patch for new harmonic glyph

2007-01-25 Thread Maximilian Albert 
Han-Wen Nienhuys wrote:

>> I also added a glyph called "s1harmonic" which [...] in a way "closes
>> the gap" between "s0" and "s2". [...] Agree?
> 
> No, this should be handled by the code in output-lib. That code's sole purpose
> is to fill all the gaps in the different styles.

Alright, so I removed "s1harmonic" from mf/parmesan-heads.mf again but
left the two new styles as they are. If you feel comfortable with it
this way (otherwise please do not hesitate to make further suggestions)
it might be good to update the docs, too (probably adding two sample
bars to note-head-style.ly in the regression tests would suffice). If
you wish I can try to do that later on.


> I'd like to integrate your patch. However, could you post a patch made with
> GIT to the list, so I can apply without having to invent a commit  message
> and C&P-ing your name & email? 

Sure. And sorry, I could have thought of that in advance. Please find
the git patch attached.

Thanks and cheers
Max
From 0c7eb62cca9c20cb8406fe454b4ec74e08043143 Mon Sep 17 00:00:00 2001
From: Maximilian Albert <[EMAIL PROTECTED]>
Date: Thu, 25 Jan 2007 14:57:56 +0100
Subject: [PATCH] New glyph (black diamond) and two harmonic-like notehead 
styles using it.

---
 mf/parmesan-heads.mf |7 +++
 scm/output-lib.scm   |3 +++
 2 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/mf/parmesan-heads.mf b/mf/parmesan-heads.mf
index da64dbe..551e3e3 100644
--- a/mf/parmesan-heads.mf
+++ b/mf/parmesan-heads.mf
@@ -192,6 +192,13 @@ fet_beginchar("Harmonic notehead (Neo-mensural open)",
charwy := 0;
 fet_endchar;
 
+fet_beginchar("Harmonic notehead (Neo-mensural black)",
+ "s2harmonic")
+   draw_neomensural_black_head (1.3 staff_space#, 1.3 noteheight#);
+   charwx := head_width#;
+   charwy := 0;
+fet_endchar;
+
 fet_beginchar("Neo-mensural semibrevis head","s0neomensural")
   draw_neomensural_open_head (staff_space#, noteheight#);
 fet_endchar;
diff --git a/scm/output-lib.scm b/scm/output-lib.scm
index f66a78b..11f427b 100644
--- a/scm/output-lib.scm
+++ b/scm/output-lib.scm
@@ -168,6 +168,9 @@
   ;; statement.  -- jr
   ((xcircle) "2xcircle")
   ((harmonic) "0harmonic")
+  ((harmonic-black) "2harmonic")
+  ((harmonic-mixed) (if (<= log 1) "0harmonic"
+   "2harmonic"))
   ((baroque) 
;; Oops, I actually would not call this "baroque", but, for
;; backwards compatibility to 1.4, this is supposed to take
-- 
1.4.4.4

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel