Re: Anything missing for 2.21.0?
On 3/29/20, Dan Eble wrote: >str = re.sub (r"\\(compress|expand)FullBarRests)", r"\\\1EmptyMeasures", That’s on me; sorry about that. https://codereview.appspot.com/553750044/diff/561590043/python/convertrules.py I was convinced it had successfully gone through the docs and regtests, which is why I didn’t look twice. Sh*t. Cheers, V.
Re: Anything missing for 2.21.0?
>> No holdup, but I would like to see an LSR import to synchronize >> documentation with snippets. > > I think that's standard as part of the release procedure? Ah, ok, excellent. Werner
Re: Anything missing for 2.21.0?
- Original Message - From: "David Kastrup" To: "Werner LEMBERG" Cc: Sent: Sunday, March 29, 2020 6:10 PM Subject: Re: Anything missing for 2.21.0? Werner LEMBERG writes: Anybody can think of a holdup? No holdup, but I would like to see an LSR import to synchronize documentation with snippets. I think that's standard as part of the release procedure? -- David Kastrup Probably should be, but isn't. I'll try to remember when we have the go ahead. -- Phil Holmes
Re: Anything missing for 2.21.0?
Dan Eble writes: > On Mar 29, 2020, at 14:46, David Kastrup wrote: >> >> Dan Eble writes: >> >>> On Mar 29, 2020, at 11:54, David Kastrup wrote: Anybody can think of a holdup? >>> >>> convert-ly is broken: > ... >> Oh wow, how did that happen? >> >> Oh, and now I remember that there was a convert-ly thing about some >> spacing properties that I also needed to get done. More important for >> 2.20.1 than 2.21.0 probably, but I need to get it done either way. > > The log levels in the --help text are also wrong. If you try to use > NONE or WARNING, it complains, > > convert-ly: error: Unknown or invalid loglevel 'NONE' > > It does accept WARN rather than WARNING, and in that mode it doesn't > print progress messages, though I haven't verified that it actually > prints warnings. > > Obviously, this isn't a show-stopper, and should probably be fixed in > 2.20 if there are any more patches released, but if you're touching > the script anyway... This one is a _humongous_ can of worms coming from python/lilylib.py with translations and help strings for several utilities centering on "WARNING" while Documentation is part/part and there is a parallel naming issue with LilyPond itself which also has warning levels, as well as several build scripts. Not really a matter for a quick patchup. -- David Kastrup
Re: Anything missing for 2.21.0?
Dan Eble writes: > On Mar 29, 2020, at 11:54, David Kastrup wrote: >> >> Anybody can think of a holdup? > > convert-ly is broken: > > find . -name '*.ly' -print0 | xargs -0 convert-ly -d -e -l WARN > Traceback (most recent call last): > File "/home/user/lilypond-build/out/bin/convert-ly", line 236, in > do_conversion >newstr = x[1] (str) > File > "/home/user/lilypond-build/out/lib/lilypond/current/python/convertrules.py", > line 3980, in conv >str = re.sub (r"\\(compress|expand)FullBarRests)", r"\\\1EmptyMeasures", > >HERE? More like 13 characters later. -- David Kastrup
Re: Anything missing for 2.21.0?
On Mar 29, 2020, at 15:31, David Kastrup wrote: > I was actually only planning to touch convertrules.py . Sigh. Sure, don't let it bother you. — Dan
Re: Anything missing for 2.21.0?
Dan Eble writes: > On Mar 29, 2020, at 14:46, David Kastrup wrote: >> >> Dan Eble writes: >> >>> On Mar 29, 2020, at 11:54, David Kastrup wrote: Anybody can think of a holdup? >>> >>> convert-ly is broken: > ... >> Oh wow, how did that happen? >> >> Oh, and now I remember that there was a convert-ly thing about some >> spacing properties that I also needed to get done. More important for >> 2.20.1 than 2.21.0 probably, but I need to get it done either way. > > The log levels in the --help text are also wrong. If you try to use > NONE or WARNING, it complains, > > convert-ly: error: Unknown or invalid loglevel 'NONE' > > It does accept WARN rather than WARNING, and in that mode it doesn't > print progress messages, though I haven't verified that it actually > prints warnings. > > Obviously, this isn't a show-stopper, and should probably be fixed in > 2.20 if there are any more patches released, but if you're touching > the script anyway... I was actually only planning to touch convertrules.py . Sigh. -- David Kastrup
Re: Anything missing for 2.21.0?
On Mar 29, 2020, at 14:46, David Kastrup wrote: > > Dan Eble writes: > >> On Mar 29, 2020, at 11:54, David Kastrup wrote: >>> >>> Anybody can think of a holdup? >> >> convert-ly is broken: ... > Oh wow, how did that happen? > > Oh, and now I remember that there was a convert-ly thing about some > spacing properties that I also needed to get done. More important for > 2.20.1 than 2.21.0 probably, but I need to get it done either way. The log levels in the --help text are also wrong. If you try to use NONE or WARNING, it complains, convert-ly: error: Unknown or invalid loglevel 'NONE' It does accept WARN rather than WARNING, and in that mode it doesn't print progress messages, though I haven't verified that it actually prints warnings. Obviously, this isn't a show-stopper, and should probably be fixed in 2.20 if there are any more patches released, but if you're touching the script anyway... — Dan
Re: Anything missing for 2.21.0?
Dan Eble writes: > On Mar 29, 2020, at 11:54, David Kastrup wrote: >> >> Anybody can think of a holdup? > > convert-ly is broken: > > find . -name '*.ly' -print0 | xargs -0 convert-ly -d -e -l WARN > Traceback (most recent call last): > File "/home/user/lilypond-build/out/bin/convert-ly", line 236, in > do_conversion >newstr = x[1] (str) > File > "/home/user/lilypond-build/out/lib/lilypond/current/python/convertrules.py", > line 3980, in conv >str = re.sub (r"\\(compress|expand)FullBarRests)", r"\\\1EmptyMeasures", > >HERE? Oh wow, how did that happen? Oh, and now I remember that there was a convert-ly thing about some spacing properties that I also needed to get done. More important for 2.20.1 than 2.21.0 probably, but I need to get it done either way. -- David Kastrup
Re: Anything missing for 2.21.0?
On Mar 29, 2020, at 11:54, David Kastrup wrote: > > Anybody can think of a holdup? convert-ly is broken: find . -name '*.ly' -print0 | xargs -0 convert-ly -d -e -l WARN Traceback (most recent call last): File "/home/user/lilypond-build/out/bin/convert-ly", line 236, in do_conversion newstr = x[1] (str) File "/home/user/lilypond-build/out/lib/lilypond/current/python/convertrules.py", line 3980, in conv str = re.sub (r"\\(compress|expand)FullBarRests)", r"\\\1EmptyMeasures", HERE? — Dan
Re: Anything missing for 2.21.0?
Werner LEMBERG writes: >> Anybody can think of a holdup? > > No holdup, but I would like to see an LSR import to synchronize > documentation with snippets. I think that's standard as part of the release procedure? -- David Kastrup
Re: Anything missing for 2.21.0?
> Anybody can think of a holdup? No holdup, but I would like to see an LSR import to synchronize documentation with snippets. Werner
Re: Anything missing for 2.21.0?
Am Sonntag, den 29.03.2020, 17:54 +0200 schrieb David Kastrup: > [Repeat message since I got the address of translations wrong] > > I see that translation-status is in master. The web site is still > getting fixed (including MacOSX download links), so we'd probably better > wait with the big announcements until that is there. > > But roll the release? It's just the first unstable in a series anyway. > > Anybody can think of a holdup? I'm all for doing this, website and announcement should be independent of tagging the release and building the binaries. And there is a growing pile of things that wait for 2.21.0 to happen. Jonas signature.asc Description: This is a digitally signed message part
