Re: Current state of automatic footnotes. (issue4580041)
On 28 July 2011 15:57, mts...@gmail.com wrote: Many thanks to everyone for their help on this. Pushed as 233aad0ba9781e43424c4e77a859e42b660210e6. Hi Mike, can you look at my comments from a month ago please? I believe some of them are still relevant. Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
Many thanks to everyone for their help on this. Pushed as 233aad0ba9781e43424c4e77a859e42b660210e6. Cheers, MS http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
On 2011/06/26 10:03:16, mike_apollinemike.com wrote: On Jun 26, 2011, at 11:26 AM, mailto:m...@apollinemike.com wrote: On Jun 25, 2011, at 6:38 PM, mailto:percival.music...@gmail.com wrote: On 2011/06/25 07:15:39, J_lowe wrote: I get an error/seg fault when I try to make: I can confirm this. Fixed. I had accidentally kept annotation-whiteout in balloon.cc whereas I had scrubbed it in all the other files. One problem is that, after internals.texi is built, I get: programming error: Parsed object should be dead: static scm_unused_struct* Prob::mark_smob(scm_unused_struct*) continuing, cross fingers I'm not sure what I did to make this happen. It doesn't interfere w/ the compilation process, so the patch is still reviewable, but it'd need to be found and scrubbed before being pushed. I'm guessing that I'm forgetting to unprotect something that I'm creating. If anyone runs across something in my code that creates new events/probs in an unusual way (i.e. a clone) or anything else that'd cause this, please let me know! Just a follow-up: I ran all of the footnote related regtests and this error did not come up. So it may arise from something else. Cheers, MS Passes regtests. http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
On Jun 25, 2011, at 6:38 PM, percival.music...@gmail.com wrote: On 2011/06/25 07:15:39, J_lowe wrote: I get an error/seg fault when I try to make: I can confirm this. Fixed. I had accidentally kept annotation-whiteout in balloon.cc whereas I had scrubbed it in all the other files. One problem is that, after internals.texi is built, I get: programming error: Parsed object should be dead: static scm_unused_struct* Prob::mark_smob(scm_unused_struct*) continuing, cross fingers I'm not sure what I did to make this happen. It doesn't interfere w/ the compilation process, so the patch is still reviewable, but it'd need to be found and scrubbed before being pushed. I'm guessing that I'm forgetting to unprotect something that I'm creating. If anyone runs across something in my code that creates new events/probs in an unusual way (i.e. a clone) or anything else that'd cause this, please let me know! Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
On Jun 26, 2011, at 11:26 AM, m...@apollinemike.com wrote: On Jun 25, 2011, at 6:38 PM, percival.music...@gmail.com wrote: On 2011/06/25 07:15:39, J_lowe wrote: I get an error/seg fault when I try to make: I can confirm this. Fixed. I had accidentally kept annotation-whiteout in balloon.cc whereas I had scrubbed it in all the other files. One problem is that, after internals.texi is built, I get: programming error: Parsed object should be dead: static scm_unused_struct* Prob::mark_smob(scm_unused_struct*) continuing, cross fingers I'm not sure what I did to make this happen. It doesn't interfere w/ the compilation process, so the patch is still reviewable, but it'd need to be found and scrubbed before being pushed. I'm guessing that I'm forgetting to unprotect something that I'm creating. If anyone runs across something in my code that creates new events/probs in an unusual way (i.e. a clone) or anything else that'd cause this, please let me know! Just a follow-up: I ran all of the footnote related regtests and this error did not come up. So it may arise from something else. Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
Hello, I get an error/seg fault when I try to make: (sorry of this a bit verbose) make runs 'for a bit' then I get --snip-- ezh --header=texidoc --header=texidoccs --header=texidocde --header=texidoces --header=texidocfr --header=texidochu --header=texidocit --header=texidocja --header=texidocnl --header=texidoczh -dcheck-internal-types -ddump-signatures -danti-alias-factor=2' --output=./out --format=texi --verbose --skip-lily-check --lily-output-dir /home/james/lilypond-git/out/lybook-db --redirect-lilypond-output snippets.tely cp -p contributor.texi out/contributor.texi cp -p web.texi out/web.texi LANG= makeinfo --enable-encoding -I /home/james/lilypond-git/Documentation -I. -I./out --output=out/lilypond-usage.info out/usage.texi LANG= makeinfo --enable-encoding -I /home/james/lilypond-git/Documentation -I. -I./out --output=out/lilypond-contributor.info out/contributor.texi LANG= makeinfo --enable-encoding -I /home/james/lilypond-git/Documentation -I. -I./out --output=out/lilypond-internals.info out/internals.texi LANG= makeinfo --enable-encoding -I /home/james/lilypond-git/Documentation -I. -I./out --output=out/lilypond-web.info out/web.texi Segmentation fault make[1]: *** [out/lilypond-internals.info] Error 139 make[1]: *** Waiting for unfinished jobs lilypond-book.py (GNU LilyPond) 2.15.3 Reading snippets.tely... Dissecting... Writing snippets... --snip-- then it carries on 'as normal' and ends in --snip-- Compiling /home/james/lilypond-git/Documentation/out/template.texi... /home/james/lilypond-git/Documentation/out/template.texi is up to date. rm out/weblinks.itexi make[1]: Leaving directory `/home/james/lilypond-git/Documentation' make: *** [all] Error 2 --snip-- Hopefully Neil will verify this (in case I have not done something right). James http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
On 2011/06/25 07:15:39, J_lowe wrote: I get an error/seg fault when I try to make: I can confirm this. http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
On 2011/06/21 09:17:25, Graham Percival wrote: I can confirm the cannot compile with this patch applied. Should apply cleanly - please confirm leave your comments! Cheers, MS http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
Hi Mike,
I'll take a closer look at this at the weekend.
Cheers,
Neil
http://codereview.appspot.com/4580041/diff/10001/input/regression/footnote-auto-numbering-page-reset.ly
File input/regression/footnote-auto-numbering-page-reset.ly (right):
http://codereview.appspot.com/4580041/diff/10001/input/regression/footnote-auto-numbering-page-reset.ly#newcode3
input/regression/footnote-auto-numbering-page-reset.ly:3: texidoc =
Lilypond does footnotes.
needs a more descriptive texidoc (same applies to other tests)
http://codereview.appspot.com/4580041/diff/10001/lily/balloon.cc
File lily/balloon.cc (right):
http://codereview.appspot.com/4580041/diff/10001/lily/balloon.cc#newcode136
lily/balloon.cc:136: annotation-whiteout
needs adding to scm/define-grob-properties.scm
http://codereview.appspot.com/4580041/diff/10001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/4580041/diff/10001/ly/music-functions-init.ly#newcode364
ly/music-functions-init.ly:364: \footnoteGrob $grob-name $offset \markup
{ } $footnote
I haven't tested this, but could you use \markup \null instead?
http://codereview.appspot.com/4580041/diff/10001/ly/music-functions-init.ly#newcode392
ly/music-functions-init.ly:392: 'text (markup )
'text (make-null-markup) ?
http://codereview.appspot.com/4580041/diff/10001/scm/lily-library.scm
File scm/lily-library.scm (right):
http://codereview.appspot.com/4580041/diff/10001/scm/lily-library.scm#newcode749
scm/lily-library.scm:749: (define-public (random-string pool n)
remove (since you're now using gensym)
http://codereview.appspot.com/4580041/diff/10001/scm/lily-library.scm#newcode763
scm/lily-library.scm:763: (define-public (random-lowercase-string n)
remove
http://codereview.appspot.com/4580041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
I can confirm the cannot compile with this patch applied. http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Current state of automatic footnotes. (issue4580041)
Hi Mike! There is a problem with your patch, I can not compile until the end, even after git clean -fxd. This crashes when building internals.texi And there is still the same spacing issues with number_raise and notes higher than 9... Thanks, Bertrand http://codereview.appspot.com/4580041/diff/2001/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): http://codereview.appspot.com/4580041/diff/2001/lily/page-layout-problem.cc#newcode209 lily/page-layout-problem.cc:209: annotation-translate_axis (footnote_stencil-extent (Y_AXIS)[UP] + number_raise - annotation-extent(Y_AXIS)[UP], Y_AXIS); Looks like the vertical spacing problem comes from here. Why not just : annotation-translate_axis (number_raise, Y_AXIS); ? Or with a Scheme interface that allows users to chose between fixed and variable height ? Same comment for line 239. http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
