Re: NR: 1.4.1 Replaced deprecated snippet w\ @lilypond (issue 60840048)

2014-02-14 Thread graham

LGTM

https://codereview.appspot.com/60840048/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: NR: 1.4.1 Replaced deprecated snippet w\ @lilypond (issue 60840048)

2014-02-09 Thread lilyfan

On 2014/02/08 21:55:15, dak wrote:

Is there any way in which one can actually delete this snippet file

without

getting it carried back in via LSR?


According to CG 7.4:
Snippets used in the documentation are in
'$LILYPOND_GIT/Documentation/snippets'.
This directory contains a complete set of the snippets in the LSR which
are tagged with 'docs'.

So, you would just need to remove the docs tag?

My 2 cents?

Jean-Charles

https://codereview.appspot.com/60840048/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: NR: 1.4.1 Replaced deprecated snippet w\ @lilypond (issue 60840048)

2014-02-08 Thread pkx166h

Reviewers: dak,

Message:
On 2014/02/08 21:55:15, dak wrote:

https://codereview.appspot.com/60840048/diff/1/Documentation/notation/repeats.itely

File Documentation/notation/repeats.itely (left):



https://codereview.appspot.com/60840048/diff/1/Documentation/notation/repeats.itely#oldcode526

Documentation/notation/repeats.itely:526:
{printing-a-repeat-sign-at-the-beginning-of-a-piece.ly}
Is there any way in which one can actually delete this snippet file

without

getting it carried back in via LSR?


I did wonder.

Can we just remove it from ../snippets/new/.. as it resides in
snippets/.. anyway, I assumed that anything in snippets/new/.. gets
re-introduced to the doc (not sure about LSR) with makelsr.py?

James

Description:
NR: 1.4.1 Replaced deprecated snippet w\ @lilypond

Issue 3801

Removed reference to snippet and added a suitable
@lilypond example.

Please review this at https://codereview.appspot.com/60840048/

Affected files (+10, -6 lines):
  M Documentation/notation/repeats.itely


Index: Documentation/notation/repeats.itely
diff --git a/Documentation/notation/repeats.itely  
b/Documentation/notation/repeats.itely
index  
ba57fe22b02d856a08b4e794472287b661ba982b..77defacb7879ad6885d605883da6beedde68574c  
100644

--- a/Documentation/notation/repeats.itely
+++ b/Documentation/notation/repeats.itely
@@ -94,6 +94,16 @@ c2 d
 \repeat volta 2 { d4 e f g }
 @end lilypond

+An @q{opening} repeat mark is not, by default, printed in the first full
+measure.  However it is possible to add one by using @code{\bar .|:}
+before the first note.
+
+@lilypond[verbatim,fragment,quote,relative=2]
+\repeat volta 2 { \bar .|: c4 d e f }
+c2 d
+\repeat volta 2 { d4 e f g }
+@end lilypond
+
 Alternative endings can be produced using @code{\alternative}.  Each
 group of alternatives must be themselves, enclosed in a set of braces.

@@ -519,12 +529,6 @@ voltaAdLib = \markup { 1. 2. 3... \text \italic { ad  
lib. } }

 }
 @end lilypond

-
-@snippets
-
-@lilypondfile[verbatim,quote,texidoc,doctitle]
-{printing-a-repeat-sign-at-the-beginning-of-a-piece.ly}
-
 @seealso
 Notation Reference:
 @ref{Bar lines},



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel