Re: experimental code on Gitlab (bend-spanner repository)
Il giorno gio 22 ott 2020 alle 10:19, Thomas Morley ha scritto: Hi Federico, see: https://gitlab.com/lilypond/lilypond/-/merge_requests/473 Great! I'll check it out in the next days. There are some changes in usage. - A BendSpanner is now started with \^ and ends automatically at the next suitable note or chord (the \startBend ... \stopBend pair is gone). I like this change a lot! [...] Known limitations: - The engraver is not part of the default TabVoice. The interplay with context-property defaultStrings (usually unset, though) causes warnings. - There's still no convincing functionality for Voice-context. No time left in my autumn-break ... Please let me know what you think. I will give more comments here or directly in the MR as soon as I can test it. Many thanks Federico
Re: experimental code on Gitlab (bend-spanner repository)
Am Mi., 23. Sept. 2020 um 23:46 Uhr schrieb Federico Bruni : > > Il giorno mer 23 set 2020 alle 20:57, Thomas Morley > ha scritto: > > Ok, ok, I will revise the code and probably extend functionality to > > cover bends in Voice-contexts. > > If I'm satisfied I'll put up a MR. > > Though, I doubt I can start before mid-octobre... > > Wow, this is the news I've been waiting for years. > I look forward to testing your code. > > Thanks > Federico Hi Federico, see: https://gitlab.com/lilypond/lilypond/-/merge_requests/473 There are some changes in usage. - A BendSpanner is now started with \^ and ends automatically at the next suitable note or chord (the \startBend ... \stopBend pair is gone). - For skipping a NoteColumn use \override NoteColumn.bend-me = ##f or use the provided shortcuts: \skipNC, \skipNCs, \endSkipNCs. - Tied notes are no longer special cased, you'll need to manually skip them. This is a little loss, I didn't manage to stop the bend automatically, implement skipping NoteColumns _and_ respect tied notes in a satisfying way. - \bendStencilTweak is gone, instead use \bendStartLevel with an integer argument, if needed. As the name suggests you'll need to use it only for the first of multiple consecutive bends (in some cases), for follow up bends this value (setting details.successive-level) is maintained by the engraver. - The BendMeEngraver is joined with the BendSpannerEngraver in Bend_spanner_engraver Known limitations: - The engraver is not part of the default TabVoice. The interplay with context-property defaultStrings (usually unset, though) causes warnings. - There's still no convincing functionality for Voice-context. No time left in my autumn-break ... Please let me know what you think. Cheers, Harm
Re: experimental code on Gitlab (bend-spanner repository)
Il giorno mer 23 set 2020 alle 20:57, Thomas Morley ha scritto: Ok, ok, I will revise the code and probably extend functionality to cover bends in Voice-contexts. If I'm satisfied I'll put up a MR. Though, I doubt I can start before mid-octobre... Wow, this is the news I've been waiting for years. I look forward to testing your code. Thanks Federico
Re: experimental code on Gitlab (bend-spanner repository)
Am Mi., 23. Sept. 2020 um 12:36 Uhr schrieb Federico Bruni : > > Il giorno mer 23 set 2020 alle 09:33, Jonas Hahnfeld > ha scritto: > >> Why moving it to Gitlab? > >> > >> - It would have more visibility for users as well as developers. > >> - Perhaps Harm may start working on that repository instead of > >> posting > >> files on the mailing list :-) as he has an account on Gitlab. Well, > >> if > >> he doesn't, I'll keep up my git maintainer role. > > > > My 2 cents: With that motivation, I'm against moving it to GitLab. You > > wrote it's still work in progress and that you're not willing to adapt > > the code for OLL or LilyPond proper. I don't see a reason to give this > > a more official flavor by putting it into the organization. > > I think that Harm will adapt to LilyPond proper when he thinks it's > mature enough. > > Harm always says it's a work in progress, but from a user point of view > it's already powerful and feature rich. I wish it could be already in > LilyPond core. > > Anyway, I can put it on my account on Gitlab and turn the version on > Pagure into a mirror. Ok, ok, I will revise the code and probably extend functionality to cover bends in Voice-contexts. If I'm satisfied I'll put up a MR. Though, I doubt I can start before mid-octobre... Cheers, Harm
Re: experimental code on Gitlab (bend-spanner repository)
Il giorno mer 23 set 2020 alle 09:33, Jonas Hahnfeld ha scritto: Why moving it to Gitlab? - It would have more visibility for users as well as developers. - Perhaps Harm may start working on that repository instead of posting files on the mailing list :-) as he has an account on Gitlab. Well, if he doesn't, I'll keep up my git maintainer role. My 2 cents: With that motivation, I'm against moving it to GitLab. You wrote it's still work in progress and that you're not willing to adapt the code for OLL or LilyPond proper. I don't see a reason to give this a more official flavor by putting it into the organization. I think that Harm will adapt to LilyPond proper when he thinks it's mature enough. Harm always says it's a work in progress, but from a user point of view it's already powerful and feature rich. I wish it could be already in LilyPond core. Anyway, I can put it on my account on Gitlab and turn the version on Pagure into a mirror.
Re: experimental code on Gitlab (bend-spanner repository)
Am Mittwoch, den 23.09.2020, 00:07 +0200 schrieb Federico Bruni: > Hi > > I'm writing to ask the permission to place some "experimental" code in > a repository within the LilyPond group. > The project would be called bend-spanner, so the link would be: > https://gitlab.com/lilypond/bend-spanner > > Of course the description would highlight that it's a work in progress > of a new feature which may be included in LilyPond eventually, when > it's mature enough. > > The author of the code is Harm. which is mentioned nowhere in the code, at least not in the comments I scanned. > I'm only the "git maintainer", as Harm > posted the files on lilypond-user mailing list but never in a > repository. > I decided to put it in a git repository to make things easier for any > potential user. > > It's currently hosted here: > https://pagure.io/lilypond-bend-spanner > > Why moving it to Gitlab? > > - It would have more visibility for users as well as developers. > - Perhaps Harm may start working on that repository instead of posting > files on the mailing list :-) as he has an account on Gitlab. Well, if > he doesn't, I'll keep up my git maintainer role. My 2 cents: With that motivation, I'm against moving it to GitLab. You wrote it's still work in progress and that you're not willing to adapt the code for OLL or LilyPond proper. I don't see a reason to give this a more official flavor by putting it into the organization. Jonas signature.asc Description: This is a digitally signed message part
