Re: Remove deprecated context properties (issue 560030044 by v.villen...@gmail.com)

2021-01-07 Thread Werner LEMBERG 


> https://codereview.appspot.com/560030044/

Thanks for the reminder; apparently it has been forgotten to be
applied.  Valentin, could you submit a Merge Request?


Werner

Re: Remove deprecated context properties (issue 560030044 by v.villen...@gmail.com)

2020-05-10 Thread v . villenave 
On 2020/05/09 18:25:03, lemzwerg wrote:
>
https://codereview.appspot.com/560030044/diff/557800043/scm/define-context-properties.scm#newcode609
> scm/define-context-properties.scm:609: merge rests when this is set to
true.")
> While you are at it, please fix indentation (i.e., no indentation for
the
> continuation line).

Acknowledged.

> LGTM.  This issue also adds some scheme code and a conversion rule –
they are
> different commits, right?

Should they really be? The scheme code (largely inspired by Harm BTW :-)
is only needed for the snippet (which will get updated through next
makelsr anyway).

As for define-context-properties.scm, it’s used in the doc so I thought
it’d make sense to have that in the same commit that the @funindex
cleanup.

V.

https://codereview.appspot.com/560030044/

Re: Remove deprecated context properties (issue 560030044 by v.villen...@gmail.com)

2020-05-10 Thread v . villenave 
Reviewers: lemzwerg, thomasmorley651,

Message:
On 2020/05/09 20:17:09, thomasmorley651 wrote:
> Not sure about chordNameExceptionsFull and chordNameExceptionsPartial.
> I thought our deprecating policy would be to wait for 1 or even 2
stable
> versions before deleting from source.

Actually, all that was deprecated _long_ ago, much longer than 1 or 2
stable releases:
https://lists.gnu.org/archive/html/lilypond-user/2008-08/msg00389.html

I just made that clearer (and even added a convert-rule for
banter-style) :
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=78225bc1b386e12dc1d03a5d2c7a017c0a52a22d

V.

Description:
Remove deprecated context properties

- bassFigureFormatFunction was dropped in 2.7.18 in favor of
figuredBassFormatter.  Removed throughout the doc, with a
convert rule.

- alignBassFigureAccidentals was deprecated even earlier, in 2.7.13.
Added to the aforementioned convert-rule.

- chordNameExceptionsFull and chordNameExceptionsPartial have been
deprecated at least since I rewrote the chord naming functions in
2.21.0; the only trace left is in the chord-names-alternative snippet.

Please review this at https://codereview.appspot.com/560030044/

Affected files (+36, -20 lines):
  M Documentation/ca/notation/rhythms.itely
  M Documentation/de/notation/rhythms.itely
  M Documentation/es/notation/rhythms.itely
  M Documentation/fr/notation/rhythms.itely
  M Documentation/it/notation/rhythms.itely
  M Documentation/ja/notation/rhythms.itely
  M Documentation/notation/rhythms.itely
  M Documentation/snippets/chord-names-alternative.ly
  M python/convertrules.py
  M scm/define-context-properties.scm


Index: Documentation/ca/notation/rhythms.itely
diff --git a/Documentation/ca/notation/rhythms.itely 
b/Documentation/ca/notation/rhythms.itely
index 
544ce11fcb914df5f53c06326b3603c8d0616afe..9f06b390463d9dd32df8d24225260ab6bb278899
 100644
--- a/Documentation/ca/notation/rhythms.itely
+++ b/Documentation/ca/notation/rhythms.itely
@@ -291,8 +291,8 @@ de grup especial, vegeu
 @cindex grups especials, format de
 @cindex tresets, format de
 
-@funindex tupletNumberFormatFunction
 @funindex tupletSpannerDuration
+@funindex \tupletSpan
 
 @lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
 {entering-several-tuplets-using-only-one--tuplet-command.ly}
Index: Documentation/de/notation/rhythms.itely
diff --git a/Documentation/de/notation/rhythms.itely 
b/Documentation/de/notation/rhythms.itely
index 
39ff710c89728d3fa485363a35da74d62884ca0e..a26eefea736d3ad48ecfe86ce4ccd1c91e360804
 100644
--- a/Documentation/de/notation/rhythms.itely
+++ b/Documentation/de/notation/rhythms.itely
@@ -269,8 +269,8 @@ zu setzen, siehe @ref{Tondauern skalieren}.
 @cindex Triole, Formatierung
 @cindex Formatierung von Triolen
 
-@funindex tupletNumberFormatFunction
 @funindex tupletSpannerDuration
+@funindex \tupletSpan
 
 @lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
 {entering-several-tuplets-using-only-one--tuplet-command.ly}
Index: Documentation/es/notation/rhythms.itely
diff --git a/Documentation/es/notation/rhythms.itely 
b/Documentation/es/notation/rhythms.itely
index 
8e827da1e73d277c3b5b6fb144f9fad167e9a4a9..a20b9d606138d6a0adb463b8aefc3215b6f1a8c3
 100644
--- a/Documentation/es/notation/rhythms.itely
+++ b/Documentation/es/notation/rhythms.itely
@@ -310,7 +310,6 @@ de grupo especial, véase @ref{Escalar las duraciones}.
 @cindex tresillo, formato de
 
 @cindex grupo especial, introducir muchos
-@funindex tupletNumberFormatFunction
 @funindex tupletSpannerDuration
 @funindex \tupletSpan
 @lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
Index: Documentation/fr/notation/rhythms.itely
diff --git a/Documentation/fr/notation/rhythms.itely 
b/Documentation/fr/notation/rhythms.itely
index 
8ac60ba8edd728e7a9f2341c89d528c3e0d86da1..dcf62e46c1e244af94e99bbf447bc6b12394f17c
 100644
--- a/Documentation/fr/notation/rhythms.itely
+++ b/Documentation/fr/notation/rhythms.itely
@@ -307,7 +307,6 @@ comme indiqué au chapitre @ref{Changement d'échelle des 
durées}.
 @cindex n-olet, formatage
 @cindex triolet, formatage
 @cindex n-olets successifs
-@funindex tupletNumberFormatFunction
 @funindex tupletSpannerDuration
 @funindex \tupletSpan
 @lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
Index: Documentation/it/notation/rhythms.itely
diff --git a/Documentation/it/notation/rhythms.itely 
b/Documentation/it/notation/rhythms.itely
index 
294dc2d34dc64078dd1ac2a51d429162114858db..7d6d7124d71560b36fe78deb3a3760362844c5b2
 100644
--- a/Documentation/it/notation/rhythms.itely
+++ b/Documentation/it/notation/rhythms.itely
@@ -308,7 +308,6 @@ quadra del gruppo irregolare, si veda @ref{Scalare le 
durate}.
 
 @cindex inserimento di gruppi irregolari multipli
 @cindex gruppo irregolare, inserirne multipli
-@funindex tupletNumberFormatFunction
 @funindex tupletSpannerDuration
 @funindex \tupletSpan
 @lilypondfile[verbatim,quote,ragged-right,texidoc,doctitle]
Index:

Re: Remove deprecated context properties (issue 560030044 by v.villen...@gmail.com)

2020-05-09 Thread thomasmorley65 
Not sure about chordNameExceptionsFull and chordNameExceptionsPartial.
I thought our deprecating policy would be to wait for 1 or even 2 stable
versions before deleting from source.
Well, the snippet demonstrates a user-level reimplementation, but this
makes little sense to me. Also, banter-style is gone as well, afaik.


https://codereview.appspot.com/560030044/

Remove deprecated context properties (issue 560030044 by v.villen...@gmail.com)

2020-05-09 Thread lemzwerg--- via Discussions on LilyPond development 
LGTM.  This issue also adds some scheme code and a conversion rule –
they are different commits, right?


https://codereview.appspot.com/560030044/diff/557800043/scm/define-context-properties.scm
File scm/define-context-properties.scm (right):

https://codereview.appspot.com/560030044/diff/557800043/scm/define-context-properties.scm#newcode609
scm/define-context-properties.scm:609: merge rests when this is set to
true.")
While you are at it, please fix indentation (i.e., no indentation for
the continuation line).

https://codereview.appspot.com/560030044/