Re: Report unterminated ties hanging at end of input (issue 7019044)
Comment by project member d...@gnu.org, Dec 26, 2012 The regtest tie-whole.ly is written badly, a warning is appropriate. There is no point in warning three times, though: once for every note in the chord. The warnings in quote-tie.log and quote-cue-during.log, however, are inappropriate. If one puts slurs where the ties are, this does not generate a warning without the patch (I have not checked with slurs and this patch), so the wrong warning for ties by this patch has no previous parallel in slurs, either. https://codereview.appspot.com/7019044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Report unterminated ties hanging at end of input (issue 7019044)
Reviewers: zefram_fysh.org, Message: Issue 3062 - patch created by 'Zefram', but submitted by James Description: Report unterminated ties hanging at end of input Issue 3062 LP doesn't report unterminated ties that are left hanging at the end of input. Compare { a2~ r2 } (which warns) with { a2~ } (which doesn't). Contrast against the handling of slurs, where both { a2( r2 } and { a2( } warn. Please review this at https://codereview.appspot.com/7019044/ Affected files: M lily/tie-engraver.cc Index: lily/tie-engraver.cc diff --git a/lily/tie-engraver.cc b/lily/tie-engraver.cc index 07eb9196c78101a2c58ca5d4b1dabbc77cef9ad8..aa8544bcca0a05fc5a13090f82f6619f09678134 100644 --- a/lily/tie-engraver.cc +++ b/lily/tie-engraver.cc @@ -88,6 +88,7 @@ protected: void typeset_tie (Grob *); void report_unterminated_tie (Head_event_tuple const ); bool has_autosplit_end (Stream_event *event); + virtual void finalize (); public: TRANSLATOR_DECLARATIONS (Tie_engraver); }; @@ -131,6 +132,14 @@ Tie_engraver::has_autosplit_end (Stream_event *event) } void +Tie_engraver::finalize () +{ + vectorHead_event_tuple::iterator it = heads_to_tie_.begin (); + for (; it heads_to_tie_.end (); it++) +report_unterminated_tie (*it); +} + +void Tie_engraver::process_music () { bool busy = event_; ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel