Re: Separate flags into their own sub-font. (issue4654084)
Carl, are there any problems? The countdown is over but i don't see it pushed. cheers, Janek http://codereview.appspot.com/4654084/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Separate flags into their own sub-font. (issue4654084)
No problem. I was waiting for a notification that the countdown is over. pushed with 15f4f4c7c1d0e8c2f904981586145f478a31b65 Issue 1709 marked fixed Rietveld issue http://codereview.appspot.com/4654084/ closed Thanks, Carl On 7/9/11 1:02 PM, lemniskata.bernoull...@gmail.com lemniskata.bernoull...@gmail.com wrote: Carl, are there any problems? The countdown is over but i don't see it pushed. cheers, Janek http://codereview.appspot.com/4654084/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Separate flags into their own sub-font. (issue4654084)
On 11-07-09 03:10 PM, Carl Sorensen wrote: No problem. I was waiting for a notification that the countdown is over. pushed with 15f4f4c7c1d0e8c2f904981586145f478a31b65 Issue 1709 marked fixed Rietveld issue http://codereview.appspot.com/4654084/ closed Thanks, Carl On 7/9/11 1:02 PM, lemniskata.bernoull...@gmail.com lemniskata.bernoull...@gmail.com wrote: Carl, are there any problems? The countdown is over but i don't see it pushed. cheers, Janek http://codereview.appspot.com/4654084/ Thanks to you both, Carl and Janek! Colin -- The human race has one really effective weapon, and that is laughter. -- Mark Twain ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Separate flags into their own sub-font. (issue4654084)
LGTM! Thank you, Carl! http://codereview.appspot.com/4654084/diff/42/mf/feta-flags-generic.mf File mf/feta-flags-generic.mf (right): http://codereview.appspot.com/4654084/diff/42/mf/feta-flags-generic.mf#newcode4 mf/feta-flags-generic.mf:4: % Copyright (C) 1997--2011 Han-Wen Nienhuys han...@xs4all.nl Shouldn't your name be here, Carl? http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf File mf/feta-scripts.mf (right): http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf#newcode1450 mf/feta-scripts.mf:1450: begingroup; You added this because every glyph should be in some group now? http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf#newcode1452 mf/feta-scripts.mf:1452: height# := staff_space#; are the colons only a matter of style? http://codereview.appspot.com/4654084/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Separate flags into their own sub-font. (issue4654084)
I've almost forgotten: i checked that Carl's patch set passes regtests. http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf File mf/feta-scripts.mf (right): http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf#newcode1450 mf/feta-scripts.mf:1450: begingroup; On 2011/07/04 20:48:45, Carl wrote: On 2011/07/04 20:19:31, Janek Warchol wrote: You added this because every glyph should be in some group now? No, the begingroup and endgroup define the scope over which the save functions. and the height, overshoot, and width that are used in this glyph should be limited to this glyph. Ah, ok. http://codereview.appspot.com/4654084/diff/42/mf/feta-scripts.mf#newcode1452 mf/feta-scripts.mf:1452: height# := staff_space#; On 2011/07/04 20:48:45, Carl wrote: On 2011/07/04 20:19:31, Janek Warchol wrote: are the colons only a matter of style? No. The colon makes it an assignment. Without the colon, it's an equation that becomes a constraint; eventually the equation is solved. The intention here, AFAICS, is to have it be an assignment, so I made it explicit. Yes, i'd say that too. http://codereview.appspot.com/4654084/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Separate flags into their own sub-font. (issue4654084)
Reviewers: Janek Warchol, Message: I have made another stab at separating flags and noteheads. This time, I believe that it is right -- both noteheads and flags start at codepoint 32. Again, to test you will need to do rm mf/out/* make Please review. Thanks, Carl Description: Separate flags into their own sub-font. When we have lots of flag sizes, there will be lots of glyphs. With a maximum of 256-32 = 234 glyphs per sub font, we wanted to have flags in their own sub font. But flags depend on notehead widths, so they needed to be in the same subfont as the noteheads. This patch moves the notehead parameters from feta-noteheads.mf to feta-params.mf, so the basic notehead parameters are available to all subfonts. Also, AFAICS, bigcheese.pe.in is no longer used -- it doesn't show up anywhere in a git grep, except as having been renamed. It doesn't show up in GNUmakefile. So I deleted it. Please review this at http://codereview.appspot.com/4654084/ Affected files: M mf/GNUmakefile M mf/bigcheese.pe.in A mf/feta-flags-generic.mf A mf/feta-flags11.mf A mf/feta-flags13.mf A mf/feta-flags14.mf A mf/feta-flags16.mf A mf/feta-flags18.mf A mf/feta-flags20.mf A mf/feta-flags23.mf A mf/feta-flags26.mf M mf/feta-generic.mf M mf/feta-noteheads-generic.mf M mf/feta-noteheads-test-generic.mf M mf/feta-noteheads.mf M mf/feta-params.mf M mf/feta-scripts.mf M mf/parmesan-noteheads.mf M scripts/build/gen-emmentaler-scripts.py M scripts/build/mf-to-table.py ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
