Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-06 Thread Mark Polesky

Andrew Hawryluk wrote:

> I think even this simple case might fail if the dots were placed in
> the Voice context:
> << c''4. \\ b'4. >>

Yes, but I would consider this a "mesh". If there is a way to test
for that, this situation would not qualify for moving the engraver
to the Voice context.

- Mark



  


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-06 Thread David Kastrup
Andrew Hawryluk  writes:

> 2009/8/5 John Mandereau :
>> dots.ly before
>> dots.ly after
>>
>> collision-mesh.ly before
>> collision-mesh.ly after
>
> I think even this simple case might fail if the dots were placed in
> the Voice context:
> << c''4. \\ b'4. >>
>
> In the example that Mark found, the non-aligned notes are certainly
> superior, but I'm not sure what rule would determine whether the
> alignment is desired for every case. Would it be as simple as 'keep
> the dots unaligned unless collisions result' ? I guess this would
> require significant surgery to the Dot_column_engraver, no?

Likely two engravers, one that does the work per voice, and one that
retries and cleans up if the per-voice engraving sucks.

-- 
David Kastrup


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Andrew Hawryluk
2009/8/5 John Mandereau :
> dots.ly before
> dots.ly after
>
> collision-mesh.ly before
> collision-mesh.ly after

I think even this simple case might fail if the dots were placed in
the Voice context:
<< c''4. \\ b'4. >>

In the example that Mark found, the non-aligned notes are certainly
superior, but I'm not sure what rule would determine whether the
alignment is desired for every case. Would it be as simple as 'keep
the dots unaligned unless collisions result' ? I guess this would
require significant surgery to the Dot_column_engraver, no?

Andrew
<>___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Mark Polesky

Neil Puttock wrote:
> Try running `collision-mesh.ly' to see what happens. :)

Okay, so dots.ly looks better and collision-mesh.ly looks worse.
So what's the solution? This is probably ridiculous, but if there
were some way to test for meshing, so that the Dot_column_engraver
would stay in Staff... and in the absence of meshing, the engraver
would be moved into Voice?

Is there a better way to fix the dots in dots.ly?

- Mark



  


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread John Mandereau
Le mercredi 05 août 2009 à 22:13 +0100, Neil Puttock a écrit :

> Try running `collision-mesh.ly' to see what happens. :)


Indeed :-P

dots.ly before 

dots.ly after


collision-mesh.ly before

collision-mesh.ly after



John
<><><><>

signature.asc
Description: Ceci est une partie de message numériquement signée
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Mark Polesky

Mark Polesky wrote: 
> > > Try running `collision-mesh.ly' to see what happens. :)> 
> > Where's that?
> 
> Oh, I see, it's a regression test. How do I run a regression test?

Oh, right.
I think I'm going to stop now, since I'm clearly just being stupid.

Sorry.
- Mark



  


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Mark Polesky

Mark Polesky wrote:

> > Try running `collision-mesh.ly' to see what happens. :)> 
> Where's that?

Oh, I see, it's a regression test. How do I run a regression test?
- Mark



  


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Neil Puttock
2009/8/5 Mark Polesky :

> Where's that?

http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=blob;f=input/regression/collision-mesh.ly;h=53b02aa4cbda8e1c8834a72046b980d500a5a975;hb=HEAD


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Mark Polesky

Neil Puttock wrote:

> Try running `collision-mesh.ly' to see what happens. :)

Where's that?
- Mark



  


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Neil Puttock
2009/8/5 Mark Polesky :

> I didn't, but unfortunately my system can hardly do anything these
> days... If someone else would like to run the regtests with this
> change, that would be great.

Try running `collision-mesh.ly' to see what happens. :)

Regards,
Neil


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Mark Polesky

Han-Wen Nienhuys wrote:

> > I'm
> > thinking that Dot_column_engraver may be better suited in the
> > Voice context than in the Staff context.
> 
> I suspect that this will give many collisions (dots on top of
> noteheads) when this is combined with polyphonic chords.  Did you
> runthis through the regtets to see if it breaks things?

I didn't, but unfortunately my system can hardly do anything these
days... If someone else would like to run the regtests with this
change, that would be great.

- Mark



  


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Han-Wen Nienhuys
On Wed, Aug 5, 2009 at 12:46 PM, Mark Polesky wrote:
> On the user list, Nick Payne shed light on a potential problem
> with the Dot_column_engraver.
> http://lists.gnu.org/archive/html/lilypond-user/2009-08/msg00132.html
>
> Looking at an example from Ted Ross (see attached png), I'm
> thinking that Dot_column_engraver may be better suited in the
> Voice context than in the Staff context.
>
> Thoughts?

I suspect that this will give many collisions (dots on top of
noteheads) when this is combined with polyphonic chords.  Did you run
this through the regtets to see if it breaks things?



-- 
Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Mark Polesky

Valentin Villenave wrote:

> Mark, can you make this change on your own, modify the documentation
> accordingly (don't forget NEWS), and make sure it doesn't break
> anything (esp. wrt regtests)? If you do all of this, I think it should
> be safe for you to push the change (if any problem occurs later, it
> will be trivial to revert the commit).

I've not been able to connect to git via SSH since Saturday,
and nothing I've tried 
has worked. I'd like to take care of
that first, but I'm out of ideas.

http://lists.gnu.org/archive/html/lilypond-devel/2009-08/msg00061.html

- Mark



  


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Valentin Villenave
2009/8/5 Mark Polesky :
> Looking at an example from Ted Ross (see attached png), I'm
> thinking that Dot_column_engraver may be better suited in the
> Voice context than in the Staff context.

Mark, can you make this change on your own, modify the documentation
accordingly (don't forget NEWS), and make sure it doesn't break
anything (esp. wrt regtests)? If you do all of this, I think it should
be safe for you to push the change (if any problem occurs later, it
will be trivial to revert the commit).

Regards,
Valentin


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Werner LEMBERG

> Looking at an example from Ted Ross (see attached png), I'm
> thinking that Dot_column_engraver may be better suited in the
> Voice context than in the Staff context.

Good idea.


Werner


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread David Kastrup
Mark Polesky  writes:

> On the user list, Nick Payne shed light on a potential problem
> with the Dot_column_engraver. 
> http://lists.gnu.org/archive/html/lilypond-user/2009-08/msg00132.html
>
> Looking at an example from Ted Ross (see attached png), I'm
> thinking that Dot_column_engraver may be better suited in the
> Voice context than in the Staff context.
>
> Thoughts?

Agree.

-- 
David Kastrup



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Should Dot_column_engraver be in Voice instead of Staff?

2009-08-05 Thread Mark Polesky
On the user list, Nick Payne shed light on a potential problem
with the Dot_column_engraver. 
http://lists.gnu.org/archive/html/lilypond-user/2009-08/msg00132.html

Looking at an example from Ted Ross (see attached png), I'm
thinking that Dot_column_engraver may be better suited in the
Voice context than in the Staff context.

Thoughts?
- Mark



  <>___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel