Re: T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)
This patch no longer applies to current tree (as of 24th Sept) http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)
Thanks for applying these! Sorry to bother you again with indentation, but you don't have to replace spaces with tabulators in scripts/musicxml2ly.ly . We decided that the rule for Python is 4 spaces per indentation level. For more infos, see: http://lilypond.org/~graham/gop/gop_1.html#GOP-1-_002d-python-formatting Thanks, Bertrand http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)
On 2011/09/20 10:49:28, Bertrand Bordage wrote: Thanks for applying these! Sorry to bother you again with indentation, but you don't have to replace spaces don't have to == don't need to, I assume you mean you shouldn't with tabulators in scripts/musicxml2ly.ly . We decided that the rule for Python is 4 spaces per indentation level. For more infos, see: http://lilypond.org/%7Egraham/gop/gop_1.html#GOP-1-_002d-python-formatting Thanks, Bertrand New patch-set uploaded with tabs in musicxml2ly.py converted to spaces. Ian http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)
LGTM. On 2011/09/20 14:15:53, Ian Hulin (gmail) wrote: don't have to == don't need to, I assume you mean you shouldn't with tabulators in scripts/musicxml2ly.ly . Yes, this was a subtle DON'T DO IT! :) http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)
http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm File scm/document-identifiers.scm (right): http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm#newcode31 scm/document-identifiers.scm:31: On 2011/09/18 22:57:39, Bertrand Bordage wrote: Why a new line? Done. http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm#newcode353 scm/lily.scm:353: (ly:format On 2011/09/18 22:57:39, Bertrand Bordage wrote: Err... Why is this required? Be careful with the indentation: there shouldn't be tabulators. ly:format call removed, tabs converted to spaces. http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)
New patch-set uploaded. Ian http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)
Hi Ian, I have some comments. The rest of the patch LGTM. Regards, Bertrand http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm File scm/document-identifiers.scm (right): http://codereview.appspot.com/4974078/diff/3001/scm/document-identifiers.scm#newcode31 scm/document-identifiers.scm:31: Why a new line? http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/4974078/diff/3001/scm/lily.scm#newcode353 scm/lily.scm:353: (ly:format Err... Why is this required? Be careful with the indentation: there shouldn't be tabulators. http://codereview.appspot.com/4974078/diff/3001/scripts/musicxml2ly.py File scripts/musicxml2ly.py (right): http://codereview.appspot.com/4974078/diff/3001/scripts/musicxml2ly.py#newcode71 scripts/musicxml2ly.py:71: (ly:format #f ~a:~a den num))) #f? http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
T1780 remove scheme format calls with no destination parameter - deprecated in Guile V2 (issue 4974078)
Passes make. There is one reg test that shows up that I don't understand the significance of but it looks ok. Attached in http://code.google.com/p/lilypond/issues/detail?id=1780#c14 http://codereview.appspot.com/4974078/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
