Re: ly: Updates to predefined Ukulele fretboards (issue 367880043 by pkxgnugi...@runbox.com)

2019-01-18 Thread pkxgnugitcl

This has now been pushed

ly: Updates to predefined Ukulele fretboards master staging
author  Davide Bonetti 
Fri, 18 Jan 2019 11:34:37 + (11:34 +)
committer   James Lowe
Fri, 18 Jan 2019 11:36:47 + (11:36 +)
commit  17c0c74440f5a9b26617b274d927e8e4db1a1d4e

--

Thank you Davide.

https://codereview.appspot.com/367880043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: ly: Updates to predefined Ukulele fretboards (issue 367880043 by pkxgnugi...@runbox.com)

2019-01-14 Thread pkxgnugitcl

Patch on countdown for January 17th

https://codereview.appspot.com/367880043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: ly: Updates to predefined Ukulele fretboards (issue 367880043 by pkxgnugi...@runbox.com)

2019-01-11 Thread pkxgnugitcl

Passes make, make check and a full make doc.

Please review

https://codereview.appspot.com/367880043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Ukulele fretboards

2019-01-08 Thread James Lowe

Hello Davide,

On 06/01/2019 5:02 pm, Davide Bonetti wrote:

Hello everyone.
I worked on ukulele fretboards, fixing errors and adding new 
predefined fretboards.

Here the result of my work.
Regards
Davide


Thank you for your time on this.

I will submit a patch on your behalf and it will go through the review 
process.


I will also add you as a CC to the Rietveld (which we use for 
comments/questions) so that you can see and answer anyone who may have 
any problems or questions about your changes.


--
Regards

James


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Ukulele fretboards

2019-01-06 Thread Davide Bonetti

Hello everyone.
I worked on ukulele fretboards, fixing errors and adding new predefined
fretboards.
Here the result of my work.
Regards
Davide



---
Questa e-mail รจ stata controllata per individuare virus con Avast antivirus.
https://www.avast.com/antivirus
\version "2.18.0"
\include "predefined-ukulele-fretboards.ly"


mychords = \chordmode {
  c1 c:m c:aug c:dim c:7 c:maj7 c:m7 c:6 c:m6 \break
  c:m6- c:m7+ c:m7.5- c:dim7 c:sus2 c:sus4 c:7sus4 c:9 c:7.9- \break
}

chordsline = {
  \mychords
  \transpose c cis {
\mychords
  }
  \transpose c des {
\mychords
  }
  \transpose c d {
\mychords
  }
  \transpose c dis {
\mychords
  }
  \transpose c ees {
\mychords
  }
  \transpose c e {
\mychords
  }
  \transpose c f {
\mychords
  }
  \transpose c fis {
\mychords
  }
  \transpose c ges {
\mychords
  }
  \transpose c g {
\mychords
  }
  \transpose c gis {
\mychords
  }
  \transpose c aes {
\mychords
  }
  \transpose c a {
\mychords
  }
  \transpose c ais {
\mychords
  }
  \transpose c bes {
\mychords
  }
  \transpose c b {
\mychords
  }
}

\score {
  <<
\new ChordNames {
  \chordsline
}
\new FretBoards {
  \set Staff.stringTunings = #ukulele-tuning
  \chordsline
}
  >>
  \layout {
indent = 0
\context {
  \Score
  \remove "Bar_number_engraver"
}
  }
} This file is part of LilyPond, the GNU music typesetter.

 Copyright (C) 2009--2015 Matt Corks 

 LilyPond is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
 the Free Software Foundation, either version 3 of the License, or
 (at your option) any later version.

 LilyPond is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 GNU General Public License for more details.

 You should have received a copy of the GNU General Public License
 along with LilyPond.  If not, see <http://www.gnu.org/licenses/>.

\version "2.18.0"

 sources:
   ukulele hall of fame museum website (http://www.ukulele.org/),
   kiwi ukulele website (http://www.kiwiukulele.co.nz/)

% chord definitions require default pitchnames
\languageSaveAndChange #default-language

%%% a chords

\storePredefinedDiagram #default-fret-table \chordmode {a}
#ukulele-tuning
#"2-2;1-1;o;o;"

\storePredefinedDiagram #default-fret-table \chordmode {a:m}
#ukulele-tuning
#"2-2;o;o;o;"

\storePredefinedDiagram #default-fret-table \chordmode {a:7}
#ukulele-tuning
#"o;1-1;o;o;"

\storePredefinedDiagram #default-fret-table \chordmode {a:m7}
#ukulele-tuning
#"o;o;o;o;"

\storePredefinedDiagram #default-fret-table \chordmode {a:dim7}
#ukulele-tuning
#"2-1;3-3;2-2;3-4;"

\storePredefinedDiagram #default-fret-table \chordmode {a:maj7}
#ukulele-tuning
#"1-1;1-2;o;o;"

\storePredefinedDiagram #default-fret-table \chordmode {a:6}
#ukulele-tuning
#"2-1;4-3;2-2;4-4;"

\storePredefinedDiagram #default-fret-table \chordmode {a:sus2}
#ukulele-tuning
#"2-1;4-3;o;2-2;"

\storePredefinedDiagram #default-fret-table \chordmode {a:sus4}
#ukulele-tuning
#"2-1;2-2;o;o;"

\storePredefinedDiagram #default-fret-table \chordmode {a:aug}
#ukulele-tuning
#"2-3;1-1;1-2;O;"

\storePredefinedDiagram #default-fret-table \chordmode {a:9}
#ukulele-tuning
#"o;1-1;o;2-2;"

\storePredefinedDiagram #default-fret-table \chordmode {a:dim}
#ukulele-tuning
#"2-1;3-2;5-4;3-4;"

\storePredefinedDiagram #default-fret-table \chordmode {a:m6}
#ukulele-tuning
#"2-1-(;4-3;2-1-);3-2;"

\storePredefinedDiagram #default-fret-table \chordmode {a:m6-}
#ukulele-tuning
#"2-2;4-4;1-1;3-3;"

\storePredefinedDiagram #default-fret-table \chordmode {a:m7.5-}
#ukulele-tuning
#"2-1;3-2-(;3-2;3-2-);"

\storePredefinedDiagram #default-fret-table \chordmode {a:m7+}
#ukulele-tuning
#"1-1;o;o;o;"

\storePredefinedDiagram #defa