Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-10 Thread dak 


http://codereview.appspot.com/5503093/diff/4003/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5503093/diff/4003/Documentation/contributor/source-code.itexi#newcode926
Documentation/contributor/source-code.itexi:926:
PATH=~/type-here-directory-containing-git-cl:"${PATH}"
$@{PATH@}

http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-10 Thread graham 

this fails to compile.  Removed from staging.

http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-10 Thread janek . lilypond 

pushed to staging and closed.

http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-08 Thread graham 

LGTM

http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-06 Thread janek . lilypond 

On 2012/01/06 11:07:29, J_lowe wrote:

Sorry, an English Idiom.
"lift this section" = "Copy and Paste this section"


No problem.  So it's ok now?

PS sorry for previous mail, i had to check something about git-cl



http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-06 Thread pkx166h 

On 2012/01/06 10:15:47, janek wrote:

third draft.



http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi

File Documentation/contributor/source-code.itexi (right):



http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi#newcode921

Documentation/contributor/source-code.itexi:921: @example
On 2012/01/05 06:05:23, J_lowe wrote:
> Were this me making this edit, I'd lift this section



"lift this section" = ?


Sorry, an English Idiom. "lift this section" = "Copy and Paste this
section"


http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-06 Thread janek . lilypond 

third draft.


http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi#newcode921
Documentation/contributor/source-code.itexi:921: @example
On 2012/01/05 06:05:23, J_lowe wrote:

Were this me making this edit, I'd lift this section


"lift this section" = ?


and just reword the bits for LilyDev.


http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-04 Thread pkx166h 


http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi#newcode921
Documentation/contributor/source-code.itexi:921: @example
On 2012/01/05 01:08:01, janek wrote:

should all this be in a Note?


I think you could make this much simpler.

See the section

http://lilypond.org/doc/v2.15/Documentation/contributor-big-page#problems

Compiling on Mac OS X

Follow that style. Were this me making this edit, I'd lift this section
and just reword the bits for LilyDev.

There is some assumption that if you've managed to install and get this
far with LilyDev that you can handle cut-down instructions.

Otherwise generally:

use @example for just the stuff you'd type in the terminal, not any
additional instructions. This makes it much clearer especially on the
web pages.

http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-04 Thread janek . lilypond 

second draft


http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5503093/diff/4001/Documentation/contributor/source-code.itexi#newcode921
Documentation/contributor/source-code.itexi:921: @example
should all this be in a Note?

http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-03 Thread graham 

Most linux distributions use bash, so this isn't a terrible idea.  But
you need to log out and log back in for the change to take effect.


http://codereview.appspot.com/5503093/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5503093/diff/1/Documentation/contributor/source-code.itexi#newcode917
Documentation/contributor/source-code.itexi:917:
@command{PATH=~/type-here-directory-containing-git-cl:"${PATH}"}
On 2012/01/03 21:55:09, Carl wrote:

If we are going to do this, we should probably have the line be in an

@example

+1

http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: explain how to add git-cl to PATH (issue 5503093)

2012-01-03 Thread Carl . D . Sorensen 

I hesitate to do this because is it OS-specific.

I think if we are going to do it, we should clearly mark this line as
applying to lilydev and similar systems.

When we do this, we are diving development towards only occuring on
lilydev.  Maybe that's OK, but it seems unnecessary to me.

Thanks,

Carl



http://codereview.appspot.com/5503093/diff/1/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):

http://codereview.appspot.com/5503093/diff/1/Documentation/contributor/source-code.itexi#newcode917
Documentation/contributor/source-code.itexi:917:
@command{PATH=~/type-here-directory-containing-git-cl:"${PATH}"}
If we are going to do this, we should probably have the line be in an
@example

http://codereview.appspot.com/5503093/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

explain how to add git-cl to PATH (issue 5503093)

2012-01-03 Thread janek . lilypond 

Reviewers: ,

Description:
explain how to add git-cl to PATH

i know modifying PATH is basic knowledge,
but i'm windows man and figuring this out
took me 15 minutes... too long.

Please review this at http://codereview.appspot.com/5503093/

Affected files:
  M Documentation/contributor/source-code.itexi


Index: Documentation/contributor/source-code.itexi
diff --git a/Documentation/contributor/source-code.itexi  
b/Documentation/contributor/source-code.itexi
index  
3f964f93a41f65b321b586feedab8e9962adf2b6..449e8c83fe4b24eead0b7297463c02d2c4a7be51  
100644

--- a/Documentation/contributor/source-code.itexi
+++ b/Documentation/contributor/source-code.itexi
@@ -913,10 +913,12 @@ git clone git://github.com/gperciva/git-cl.git
 @end example

 @item
-Add the @file{git-cl/} directory to your PATH, or create a
-symbolic link to the @command{git-cl} and @command{upload.py}
-scripts in one of your PATH directories (such as
-@file{$HOME/bin}).
+Add the @file{git-cl/} directory to your PATH (add line
+@command{PATH=~/type-here-directory-containing-git-cl:"${PATH}"}
+at the end of a hidden file @file{.bashrc} in your home directory),
+or create a symbolic link to the @command{git-cl}
+and @command{upload.py} scripts in one of your PATH
+directories (such as @file{$HOME/bin}).

 @end enumerate




___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel